@atlaskit/editor-plugin-tasks-and-decisions 19.1.2 → 19.2.0

package/CHANGELOG.md

@@ -1,5 +1,22 @@
 # @atlaskit/editor-plugin-tasks-and-decisions
 
+## 19.2.0
+
+### Minor Changes
+
+- [`18d27cec35407`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/18d27cec35407) -
+  [ux] FFCLEANUP-81253 Cleanup of experiment platform_editor_blocktaskitem_patch_1
+
+### Patch Changes
+
+- Updated dependencies
+
+## 19.1.3
+
+### Patch Changes
+
+- Updated dependencies
+
 ## 19.1.2
 
 ### Patch Changes

package/dist/cjs/pm-plugins/helpers.js

@@ -22,7 +22,6 @@ var _model = require("@atlaskit/editor-prosemirror/model");
 var _state = require("@atlaskit/editor-prosemirror/state");
 var _transform = require("@atlaskit/editor-prosemirror/transform");
 var _utils2 = require("@atlaskit/editor-prosemirror/utils");
-var _expValEquals = require("@atlaskit/tmp-editor-statsig/exp-val-equals");
 var _pluginKey = require("./plugin-key");
 var _types = require("./types");
 var _utils3 = require("./utils");
@@ -320,39 +319,26 @@ function getTaskItemDataAtPos(view) {
   var selection = state.selection,
     schema = state.schema;
   var $from = selection.$from;
-  if ((0, _expValEquals.expValEquals)('platform_editor_blocktaskitem_patch_1', 'isEnabled', true)) {
-    var _schema$nodes2 = schema.nodes,
-      taskItem = _schema$nodes2.taskItem,
-      blockTaskItem = _schema$nodes2.blockTaskItem;
-    var maybeTask = (0, _utils2.findParentNodeOfTypeClosestToPos)($from, [taskItem, blockTaskItem]);
+  var _schema$nodes2 = schema.nodes,
+    taskItem = _schema$nodes2.taskItem,
+    blockTaskItem = _schema$nodes2.blockTaskItem;
+  var maybeTask = (0, _utils2.findParentNodeOfTypeClosestToPos)($from, [taskItem, blockTaskItem]);
 
-    // current selection has to be inside taskitem
-    if (maybeTask) {
-      return {
-        pos: maybeTask === null || maybeTask === void 0 ? void 0 : maybeTask.pos,
-        localId: maybeTask === null || maybeTask === void 0 ? void 0 : maybeTask.node.attrs.localId
-      };
-    }
-  } else {
-    var isInTaskItem = $from.node().type === schema.nodes.taskItem;
-
-    // current selection has to be inside taskitem
-    if (isInTaskItem) {
-      var taskItemPos = $from.before();
-      return {
-        pos: taskItemPos,
-        localId: $from.node().attrs.localId
-      };
-    }
+  // current selection has to be inside taskitem
+  if (maybeTask) {
+    return {
+      pos: maybeTask === null || maybeTask === void 0 ? void 0 : maybeTask.pos,
+      localId: maybeTask === null || maybeTask === void 0 ? void 0 : maybeTask.node.attrs.localId
+    };
   }
 }
 function getAllTaskItemsDataInRootTaskList(view) {
   var state = view.state;
   var schema = state.schema;
   var $fromPos = state.selection.$from;
-  var isInTaskItem = (0, _expValEquals.expValEquals)('platform_editor_blocktaskitem_patch_1', 'isEnabled', true) ? isInsideTask(state) : $fromPos.node().type === schema.nodes.taskItem;
+
   // if not inside task item then return undefined;
-  if (!isInTaskItem) {
+  if (!isInsideTask(state)) {
     return;
   }
   var _schema$nodes3 = schema.nodes,
@@ -367,7 +353,7 @@ function getAllTaskItemsDataInRootTaskList(view) {
     var rootTaskListStartPos = rootTaskListData.start;
     var allTaskItems = [];
     rootTaskList.descendants(function (node, pos, parent, index) {
-      if (node.type === taskItem || (0, _expValEquals.expValEquals)('platform_editor_blocktaskitem_patch_1', 'isEnabled', true) && blockTaskItem && node.type === blockTaskItem) {
+      if (node.type === taskItem || blockTaskItem && node.type === blockTaskItem) {
         allTaskItems.push({
           node: node,
           pos: pos + rootTaskListStartPos,
@@ -389,7 +375,7 @@ function getCurrentTaskItemIndex(view, allTaskItems) {
   var allTaskItemNodes = allTaskItems.map(function (nodeData) {
     return nodeData.node;
   });
-  var currentTaskItem = (0, _expValEquals.expValEquals)('platform_editor_blocktaskitem_patch_1', 'isEnabled', true) ? (_findParentNodeOfType = (0, _utils2.findParentNodeOfTypeClosestToPos)($fromPos, [taskItem, blockTaskItem])) === null || _findParentNodeOfType === void 0 ? void 0 : _findParentNodeOfType.node : $fromPos.node($fromPos.depth);
+  var currentTaskItem = (_findParentNodeOfType = (0, _utils2.findParentNodeOfTypeClosestToPos)($fromPos, [taskItem, blockTaskItem])) === null || _findParentNodeOfType === void 0 ? void 0 : _findParentNodeOfType.node;
   if (currentTaskItem) {
     var currentTaskItemIndex = allTaskItemNodes.indexOf(currentTaskItem);
     return currentTaskItemIndex;
@@ -440,10 +426,10 @@ function focusCheckboxAndUpdateSelection(view, taskItemData) {
   var tr = state.tr;
 
   // if there's an extension at this position, we're in a blockTaskItem, set a gapCursor
-  if ((0, _expValEquals.expValEquals)('platform_editor_blocktaskitem_patch_1', 'isEnabled', true) && extension && ((_doc$resolve$nodeAfte = doc.resolve(pos + 1).nodeAfter) === null || _doc$resolve$nodeAfte === void 0 ? void 0 : _doc$resolve$nodeAfte.type) === extension) {
+  if (extension && ((_doc$resolve$nodeAfte = doc.resolve(pos + 1).nodeAfter) === null || _doc$resolve$nodeAfte === void 0 ? void 0 : _doc$resolve$nodeAfte.type) === extension) {
     tr.setSelection(new _selection.GapCursorSelection(doc.resolve(pos + 1)));
     // if there's a textblock at this position, we're in a blockTaskItem, add an extra hop into the content
-  } else if ((0, _expValEquals.expValEquals)('platform_editor_blocktaskitem_patch_1', 'isEnabled', true) && (_doc$resolve$nodeAfte2 = doc.resolve(pos + 1).nodeAfter) !== null && _doc$resolve$nodeAfte2 !== void 0 && _doc$resolve$nodeAfte2.isTextblock) {
+  } else if ((_doc$resolve$nodeAfte2 = doc.resolve(pos + 1).nodeAfter) !== null && _doc$resolve$nodeAfte2 !== void 0 && _doc$resolve$nodeAfte2.isTextblock) {
     tr.setSelection(new _state.TextSelection(doc.resolve(pos + 2)));
     // else, this is an ordinary task item with inline content
   } else {

package/dist/cjs/pm-plugins/main.js

@@ -95,7 +95,7 @@ function createPlugin(portalProviderAPI, eventDispatcher, dispatch, api, getIntl
         var $from = selection.$from,
           $to = selection.$to;
         var parentOffset = $from.parentOffset;
-        var isInTaskItem = (0, _expValEquals.expValEquals)('platform_editor_blocktaskitem_patch_1', 'isEnabled', true) ? (0, _helpers.isInsideTask)(state) : $from.node().type === schema.nodes.taskItem;
+        var isInTaskItem = (0, _helpers.isInsideTask)(state);
         var focusedTaskItemLocalId = _pluginKey.stateKey.getState(state).focusedTaskItemLocalId;
         var currentTaskItemData = (0, _helpers.getTaskItemDataAtPos)(view);
         var currentTaskItemFocused = focusedTaskItemLocalId === (currentTaskItemData === null || currentTaskItemData === void 0 ? void 0 : currentTaskItemData.localId);

package/dist/es2019/pm-plugins/helpers.js

@@ -4,7 +4,6 @@ import { NodeRange } from '@atlaskit/editor-prosemirror/model';
 import { TextSelection } from '@atlaskit/editor-prosemirror/state';
 import { liftTarget } from '@atlaskit/editor-prosemirror/transform';
 import { findParentNodeClosestToPos, findParentNodeOfTypeClosestToPos, hasParentNodeOfType } from '@atlaskit/editor-prosemirror/utils';
-import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 import { stateKey } from './plugin-key';
 import { ACTIONS } from './types';
 import { findBlockTaskItem } from './utils';
@@ -319,31 +318,18 @@ export function getTaskItemDataAtPos(view) {
   const {
     $from
   } = selection;
-  if (expValEquals('platform_editor_blocktaskitem_patch_1', 'isEnabled', true)) {
-    const {
-      taskItem,
-      blockTaskItem
-    } = schema.nodes;
-    const maybeTask = findParentNodeOfTypeClosestToPos($from, [taskItem, blockTaskItem]);
-
-    // current selection has to be inside taskitem
-    if (maybeTask) {
-      return {
-        pos: maybeTask === null || maybeTask === void 0 ? void 0 : maybeTask.pos,
-        localId: maybeTask === null || maybeTask === void 0 ? void 0 : maybeTask.node.attrs.localId
-      };
-    }
-  } else {
-    const isInTaskItem = $from.node().type === schema.nodes.taskItem;
+  const {
+    taskItem,
+    blockTaskItem
+  } = schema.nodes;
+  const maybeTask = findParentNodeOfTypeClosestToPos($from, [taskItem, blockTaskItem]);
 
-    // current selection has to be inside taskitem
-    if (isInTaskItem) {
-      const taskItemPos = $from.before();
-      return {
-        pos: taskItemPos,
-        localId: $from.node().attrs.localId
-      };
-    }
+  // current selection has to be inside taskitem
+  if (maybeTask) {
+    return {
+      pos: maybeTask === null || maybeTask === void 0 ? void 0 : maybeTask.pos,
+      localId: maybeTask === null || maybeTask === void 0 ? void 0 : maybeTask.node.attrs.localId
+    };
   }
 }
 export function getAllTaskItemsDataInRootTaskList(view) {
@@ -354,9 +340,9 @@ export function getAllTaskItemsDataInRootTaskList(view) {
     schema
   } = state;
   const $fromPos = state.selection.$from;
-  const isInTaskItem = expValEquals('platform_editor_blocktaskitem_patch_1', 'isEnabled', true) ? isInsideTask(state) : $fromPos.node().type === schema.nodes.taskItem;
+
   // if not inside task item then return undefined;
-  if (!isInTaskItem) {
+  if (!isInsideTask(state)) {
     return;
   }
   const {
@@ -370,7 +356,7 @@ export function getAllTaskItemsDataInRootTaskList(view) {
     const rootTaskListStartPos = rootTaskListData.start;
     const allTaskItems = [];
     rootTaskList.descendants((node, pos, parent, index) => {
-      if (node.type === taskItem || expValEquals('platform_editor_blocktaskitem_patch_1', 'isEnabled', true) && blockTaskItem && node.type === blockTaskItem) {
+      if (node.type === taskItem || blockTaskItem && node.type === blockTaskItem) {
         allTaskItems.push({
           node,
           pos: pos + rootTaskListStartPos,
@@ -395,7 +381,7 @@ export function getCurrentTaskItemIndex(view, allTaskItems) {
   } = schema.nodes;
   const $fromPos = state.selection.$from;
   const allTaskItemNodes = allTaskItems.map(nodeData => nodeData.node);
-  const currentTaskItem = expValEquals('platform_editor_blocktaskitem_patch_1', 'isEnabled', true) ? (_findParentNodeOfType = findParentNodeOfTypeClosestToPos($fromPos, [taskItem, blockTaskItem])) === null || _findParentNodeOfType === void 0 ? void 0 : _findParentNodeOfType.node : $fromPos.node($fromPos.depth);
+  const currentTaskItem = (_findParentNodeOfType = findParentNodeOfTypeClosestToPos($fromPos, [taskItem, blockTaskItem])) === null || _findParentNodeOfType === void 0 ? void 0 : _findParentNodeOfType.node;
   if (currentTaskItem) {
     const currentTaskItemIndex = allTaskItemNodes.indexOf(currentTaskItem);
     return currentTaskItemIndex;
@@ -460,10 +446,10 @@ export function focusCheckboxAndUpdateSelection(view, taskItemData) {
   const tr = state.tr;
 
   // if there's an extension at this position, we're in a blockTaskItem, set a gapCursor
-  if (expValEquals('platform_editor_blocktaskitem_patch_1', 'isEnabled', true) && extension && ((_doc$resolve$nodeAfte = doc.resolve(pos + 1).nodeAfter) === null || _doc$resolve$nodeAfte === void 0 ? void 0 : _doc$resolve$nodeAfte.type) === extension) {
+  if (extension && ((_doc$resolve$nodeAfte = doc.resolve(pos + 1).nodeAfter) === null || _doc$resolve$nodeAfte === void 0 ? void 0 : _doc$resolve$nodeAfte.type) === extension) {
     tr.setSelection(new GapCursorSelection(doc.resolve(pos + 1)));
     // if there's a textblock at this position, we're in a blockTaskItem, add an extra hop into the content
-  } else if (expValEquals('platform_editor_blocktaskitem_patch_1', 'isEnabled', true) && (_doc$resolve$nodeAfte2 = doc.resolve(pos + 1).nodeAfter) !== null && _doc$resolve$nodeAfte2 !== void 0 && _doc$resolve$nodeAfte2.isTextblock) {
+  } else if ((_doc$resolve$nodeAfte2 = doc.resolve(pos + 1).nodeAfter) !== null && _doc$resolve$nodeAfte2 !== void 0 && _doc$resolve$nodeAfte2.isTextblock) {
     tr.setSelection(new TextSelection(doc.resolve(pos + 2)));
     // else, this is an ordinary task item with inline content
   } else {

package/dist/es2019/pm-plugins/main.js

@@ -87,7 +87,7 @@ export function createPlugin(portalProviderAPI, eventDispatcher, dispatch, api,
           $to
         } = selection;
         const parentOffset = $from.parentOffset;
-        const isInTaskItem = expValEquals('platform_editor_blocktaskitem_patch_1', 'isEnabled', true) ? isInsideTask(state) : $from.node().type === schema.nodes.taskItem;
+        const isInTaskItem = isInsideTask(state);
         const focusedTaskItemLocalId = stateKey.getState(state).focusedTaskItemLocalId;
         const currentTaskItemData = getTaskItemDataAtPos(view);
         const currentTaskItemFocused = focusedTaskItemLocalId === (currentTaskItemData === null || currentTaskItemData === void 0 ? void 0 : currentTaskItemData.localId);

package/dist/esm/pm-plugins/helpers.js

@@ -4,7 +4,6 @@ import { NodeRange } from '@atlaskit/editor-prosemirror/model';
 import { TextSelection } from '@atlaskit/editor-prosemirror/state';
 import { liftTarget } from '@atlaskit/editor-prosemirror/transform';
 import { findParentNodeClosestToPos, findParentNodeOfTypeClosestToPos, hasParentNodeOfType } from '@atlaskit/editor-prosemirror/utils';
-import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 import { stateKey } from './plugin-key';
 import { ACTIONS } from './types';
 import { findBlockTaskItem } from './utils';
@@ -302,39 +301,26 @@ export function getTaskItemDataAtPos(view) {
   var selection = state.selection,
     schema = state.schema;
   var $from = selection.$from;
-  if (expValEquals('platform_editor_blocktaskitem_patch_1', 'isEnabled', true)) {
-    var _schema$nodes2 = schema.nodes,
-      taskItem = _schema$nodes2.taskItem,
-      blockTaskItem = _schema$nodes2.blockTaskItem;
-    var maybeTask = findParentNodeOfTypeClosestToPos($from, [taskItem, blockTaskItem]);
+  var _schema$nodes2 = schema.nodes,
+    taskItem = _schema$nodes2.taskItem,
+    blockTaskItem = _schema$nodes2.blockTaskItem;
+  var maybeTask = findParentNodeOfTypeClosestToPos($from, [taskItem, blockTaskItem]);
 
-    // current selection has to be inside taskitem
-    if (maybeTask) {
-      return {
-        pos: maybeTask === null || maybeTask === void 0 ? void 0 : maybeTask.pos,
-        localId: maybeTask === null || maybeTask === void 0 ? void 0 : maybeTask.node.attrs.localId
-      };
-    }
-  } else {
-    var isInTaskItem = $from.node().type === schema.nodes.taskItem;
-
-    // current selection has to be inside taskitem
-    if (isInTaskItem) {
-      var taskItemPos = $from.before();
-      return {
-        pos: taskItemPos,
-        localId: $from.node().attrs.localId
-      };
-    }
+  // current selection has to be inside taskitem
+  if (maybeTask) {
+    return {
+      pos: maybeTask === null || maybeTask === void 0 ? void 0 : maybeTask.pos,
+      localId: maybeTask === null || maybeTask === void 0 ? void 0 : maybeTask.node.attrs.localId
+    };
   }
 }
 export function getAllTaskItemsDataInRootTaskList(view) {
   var state = view.state;
   var schema = state.schema;
   var $fromPos = state.selection.$from;
-  var isInTaskItem = expValEquals('platform_editor_blocktaskitem_patch_1', 'isEnabled', true) ? isInsideTask(state) : $fromPos.node().type === schema.nodes.taskItem;
+
   // if not inside task item then return undefined;
-  if (!isInTaskItem) {
+  if (!isInsideTask(state)) {
     return;
   }
   var _schema$nodes3 = schema.nodes,
@@ -349,7 +335,7 @@ export function getAllTaskItemsDataInRootTaskList(view) {
     var rootTaskListStartPos = rootTaskListData.start;
     var allTaskItems = [];
     rootTaskList.descendants(function (node, pos, parent, index) {
-      if (node.type === taskItem || expValEquals('platform_editor_blocktaskitem_patch_1', 'isEnabled', true) && blockTaskItem && node.type === blockTaskItem) {
+      if (node.type === taskItem || blockTaskItem && node.type === blockTaskItem) {
         allTaskItems.push({
           node: node,
           pos: pos + rootTaskListStartPos,
@@ -371,7 +357,7 @@ export function getCurrentTaskItemIndex(view, allTaskItems) {
   var allTaskItemNodes = allTaskItems.map(function (nodeData) {
     return nodeData.node;
   });
-  var currentTaskItem = expValEquals('platform_editor_blocktaskitem_patch_1', 'isEnabled', true) ? (_findParentNodeOfType = findParentNodeOfTypeClosestToPos($fromPos, [taskItem, blockTaskItem])) === null || _findParentNodeOfType === void 0 ? void 0 : _findParentNodeOfType.node : $fromPos.node($fromPos.depth);
+  var currentTaskItem = (_findParentNodeOfType = findParentNodeOfTypeClosestToPos($fromPos, [taskItem, blockTaskItem])) === null || _findParentNodeOfType === void 0 ? void 0 : _findParentNodeOfType.node;
   if (currentTaskItem) {
     var currentTaskItemIndex = allTaskItemNodes.indexOf(currentTaskItem);
     return currentTaskItemIndex;
@@ -422,10 +408,10 @@ export function focusCheckboxAndUpdateSelection(view, taskItemData) {
   var tr = state.tr;
 
   // if there's an extension at this position, we're in a blockTaskItem, set a gapCursor
-  if (expValEquals('platform_editor_blocktaskitem_patch_1', 'isEnabled', true) && extension && ((_doc$resolve$nodeAfte = doc.resolve(pos + 1).nodeAfter) === null || _doc$resolve$nodeAfte === void 0 ? void 0 : _doc$resolve$nodeAfte.type) === extension) {
+  if (extension && ((_doc$resolve$nodeAfte = doc.resolve(pos + 1).nodeAfter) === null || _doc$resolve$nodeAfte === void 0 ? void 0 : _doc$resolve$nodeAfte.type) === extension) {
     tr.setSelection(new GapCursorSelection(doc.resolve(pos + 1)));
     // if there's a textblock at this position, we're in a blockTaskItem, add an extra hop into the content
-  } else if (expValEquals('platform_editor_blocktaskitem_patch_1', 'isEnabled', true) && (_doc$resolve$nodeAfte2 = doc.resolve(pos + 1).nodeAfter) !== null && _doc$resolve$nodeAfte2 !== void 0 && _doc$resolve$nodeAfte2.isTextblock) {
+  } else if ((_doc$resolve$nodeAfte2 = doc.resolve(pos + 1).nodeAfter) !== null && _doc$resolve$nodeAfte2 !== void 0 && _doc$resolve$nodeAfte2.isTextblock) {
     tr.setSelection(new TextSelection(doc.resolve(pos + 2)));
     // else, this is an ordinary task item with inline content
   } else {

package/dist/esm/pm-plugins/main.js

@@ -88,7 +88,7 @@ export function createPlugin(portalProviderAPI, eventDispatcher, dispatch, api,
         var $from = selection.$from,
           $to = selection.$to;
         var parentOffset = $from.parentOffset;
-        var isInTaskItem = expValEquals('platform_editor_blocktaskitem_patch_1', 'isEnabled', true) ? isInsideTask(state) : $from.node().type === schema.nodes.taskItem;
+        var isInTaskItem = isInsideTask(state);
         var focusedTaskItemLocalId = stateKey.getState(state).focusedTaskItemLocalId;
         var currentTaskItemData = getTaskItemDataAtPos(view);
         var currentTaskItemFocused = focusedTaskItemLocalId === (currentTaskItemData === null || currentTaskItemData === void 0 ? void 0 : currentTaskItemData.localId);

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-plugin-tasks-and-decisions",
-	"version": "19.1.2",
+	"version": "19.2.0",
 	"description": "Tasks and decisions plugin for @atlaskit/editor-core",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",
@@ -42,14 +42,14 @@
 		"@atlaskit/primitives": "^22.5.0",
 		"@atlaskit/prosemirror-input-rules": "^4.1.0",
 		"@atlaskit/task-decision": "^21.9.0",
-		"@atlaskit/tmp-editor-statsig": "^170.0.0",
+		"@atlaskit/tmp-editor-statsig": "^172.0.0",
 		"@atlaskit/tokens": "^16.11.0",
 		"@babel/runtime": "^7.0.0",
 		"@compiled/react": "^1.0.2",
 		"bind-event-listener": "^3.0.0"
 	},
 	"peerDependencies": {
-		"@atlaskit/editor-common": "^120.10.0",
+		"@atlaskit/editor-common": "^120.11.0",
 		"react": "^18.2.0 || ^19.2.0",
 		"react-dom": "^18.2.0 || ^19.2.0",
 		"react-intl": "^5.25.1 || ^6.0.0 || ^7.0.0"
@@ -62,41 +62,6 @@
 		"react-intl": "^7.0.0",
 		"wait-for-expect": "^1.2.0"
 	},
-	"techstack": {
-		"@atlassian/frontend": {
-			"code-structure": [
-				"editor-plugin"
-			],
-			"import-structure": [
-				"atlassian-conventions"
-			],
-			"circular-dependencies": [
-				"file-and-folder-level"
-			]
-		},
-		"@repo/internal": {
-			"dom-events": "use-bind-event-listener",
-			"analytics": [
-				"analytics-next"
-			],
-			"design-tokens": [
-				"color"
-			],
-			"theming": [
-				"react-context"
-			],
-			"ui-components": [
-				"lite-mode"
-			],
-			"deprecation": "no-deprecated-imports",
-			"styling": [
-				"compiled"
-			],
-			"imports": [
-				"import-no-extraneous-disable-for-examples-and-docs"
-			]
-		}
-	},
 	"platform-feature-flags": {
 		"platform-dst-motion-uplift-custom-button": {
 			"type": "boolean",