@atlaskit/editor-plugin-table 9.2.0 → 9.3.0

package/src/pm-plugins/utils/row-controls.ts

@@ -92,8 +92,6 @@ export const getRowClassNames = (
 	hoveredRows: number[] = [],
 	isInDanger?: boolean,
 	isResizing?: boolean,
-	// Ignored via go/ees005
-	// eslint-disable-next-line @typescript-eslint/max-params
 ): string => {
 	const classNames: string[] = [];
 	if (isRowSelected(index)(selection) || (hoveredRows.indexOf(index) > -1 && !isResizing)) {

package/src/pm-plugins/utils/snapping.ts

@@ -91,8 +91,6 @@ export const findClosestSnap = (
 	guidelines: GuidelineConfig[],
 	snapGap: number = 0,
 	tolerance: number = 0,
-	// Ignored via go/ees005
-	// eslint-disable-next-line @typescript-eslint/max-params
 ) => {
 	const closestGapIndex = snapWidths.reduce(
 		(prev, curr, index) =>

package/src/tablePlugin.tsx

@@ -148,7 +148,10 @@ const tablesPlugin: TablePlugin = ({ config: options, api }) => {
 			insertTable:
 				(analyticsPayload): Command =>
 				(state, dispatch) => {
-					if (fg('platform_editor_use_nested_table_pm_nodes')) {
+					if (
+						options?.tableOptions?.allowNestedTables &&
+						fg('platform_editor_use_nested_table_pm_nodes')
+					) {
 						return editorCommandToPMCommand(
 							insertTableWithNestingSupport(
 								{
@@ -235,7 +238,8 @@ const tablesPlugin: TablePlugin = ({ config: options, api }) => {
 		nodes() {
 			const { allowColumnResizing } = pluginConfig(options?.tableOptions);
 			// TODO: ED-25901 - We need to move this into a plugin config option so we don't accidentally enable nested nodes in Jira
-			const isNestingSupported = fg('platform_editor_use_nested_table_pm_nodes');
+			const isNestingSupported =
+				options?.tableOptions?.allowNestedTables && fg('platform_editor_use_nested_table_pm_nodes');
 
 			return isNestingSupported
 				? [
@@ -716,6 +720,7 @@ const tablesPlugin: TablePlugin = ({ config: options, api }) => {
 						// If the cursor is inside a table
 						if (
 							hasParentNodeOfType(state.schema.nodes.table)(state.selection) &&
+							options?.tableOptions?.allowNestedTables &&
 							fg('platform_editor_use_nested_table_pm_nodes')
 						) {
 							// If the experiment is disabled, or we're trying to nest deeper than one level, we insert the table after the top table

package/src/ui/FloatingInsertButton/getPopupOptions.ts

@@ -54,8 +54,6 @@ function getRowOptions(index: number, isDragAndDropEnabled: boolean): Partial<Po
 	};
 }
 
-// Ignored via go/ees005
-// eslint-disable-next-line @typescript-eslint/max-params
 function getColumnOptions(
 	index: number,
 	tableContainer: HTMLElement | null,
@@ -113,8 +111,6 @@ function getColumnOptions(
 	return options;
 }
 
-// Ignored via go/ees005
-// eslint-disable-next-line @typescript-eslint/max-params
 function getPopupOptions(
 	direction: TableDirection,
 	index: number,

package/src/ui/TableFloatingColumnControls/ColumnControls/index.tsx

@@ -97,7 +97,7 @@ export const ColumnControls = ({
 	const hasHeaderRow = firstRow ? firstRow.getAttribute('data-header-row') : false;
 
 	const rowControlStickyTop = fg('platform_editor_breakout_use_css') ? 45 : rowHeights?.[0];
-	const marginTop = hasHeaderRow && stickyTop !== undefined ? (rowControlStickyTop ?? 0) : 0;
+	const marginTop = hasHeaderRow && stickyTop !== undefined ? rowControlStickyTop ?? 0 : 0;
 
 	const handleClick = useCallback(
 		(event: MouseEvent) => {
@@ -195,8 +195,6 @@ export const ColumnControls = ({
 		appearance: DragHandleAppearance,
 		gridColumn: string,
 		indexes: number[],
-		// Ignored via go/ees005
-		// eslint-disable-next-line @typescript-eslint/max-params
 	) => {
 		const isHover = type === 'hover';
 		const isPlaceholder = appearance === 'placeholder';

package/src/ui/TableFloatingColumnControls/index.tsx

@@ -101,7 +101,7 @@ const TableFloatingColumnControls = ({
 
 	if (stickyTop) {
 		const columnControlTopOffsetFromParent = '-12px';
-		const headerRowHeight = hasHeaderRow && stickyTop !== undefined ? (rowHeights?.[0] ?? 0) : 0;
+		const headerRowHeight = hasHeaderRow && stickyTop !== undefined ? rowHeights?.[0] ?? 0 : 0;
 		containerRef?.current?.style.setProperty(
 			'top',
 			fg('platform_editor_breakout_use_css')

package/src/ui/TableFloatingControls/RowControls/DragControls.tsx

@@ -184,8 +184,6 @@ export const DragControls = ({
 		appearance: DragHandleAppearance,
 		gridRow: string,
 		indexes: number[],
-		// Ignored via go/ees005
-		// eslint-disable-next-line @typescript-eslint/max-params
 	) => {
 		const isHover = type === 'hover';
 

package/src/ui/TableFloatingControls/index.tsx

@@ -2,7 +2,6 @@ import React, { useCallback } from 'react';
 
 import type { TableColumnOrdering } from '@atlaskit/custom-steps';
 import { browser } from '@atlaskit/editor-common/browser';
-import { useSharedPluginState } from '@atlaskit/editor-common/hooks';
 import type { ExtractInjectionAPI } from '@atlaskit/editor-common/types';
 import type { Node as PmNode } from '@atlaskit/editor-prosemirror/model';
 import type { Selection } from '@atlaskit/editor-prosemirror/state';
@@ -125,8 +124,6 @@ export const TableFloatingControls = ({
 		[editorView, tableActive],
 	);
 
-	const { featureFlagsState } = useSharedPluginState(api, ['featureFlags']);
-
 	if (!tableRef) {
 		return null;
 	}
@@ -144,8 +141,7 @@ export const TableFloatingControls = ({
 	// Ignored via go/ees005
 	// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
 	const isNested = tablePos !== undefined && isTableNested(editorView.state, tablePos!);
-	const shouldShowCornerControls =
-		!featureFlagsState?.elementDragAndDrop || (isNested && !editorExperiment('nested-dnd', true));
+	const shouldShowCornerControls = isNested && !editorExperiment('nested-dnd', true);
 
 	return (
 		// eslint-disable-next-line @atlaskit/ui-styling-standard/no-classname-prop -- Ignored via go/DSP-18766

package/src/ui/event-handlers.ts

@@ -507,8 +507,6 @@ export const handleCut = (
 	isTableScalingEnabled = false,
 	isTableFixedColumnWidthsOptionEnabled = false,
 	shouldUseIncreasedScalingPercent = false,
-	// Ignored via go/ees005
-	// eslint-disable-next-line @typescript-eslint/max-params
 ): Transaction => {
 	const oldSelection = oldState.tr.selection;
 	let { tr } = newState;

package/src/ui/toolbar.tsx

@@ -115,8 +115,6 @@ export const getToolbarMenuConfig = (
 	editorAnalyticsAPI: EditorAnalyticsAPI | undefined | null,
 	isTableScalingWithFixedColumnWidthsOptionShown = false,
 	areTableColumnWidthsFixed = false,
-	// Ignored via go/ees005
-	// eslint-disable-next-line @typescript-eslint/max-params
 ): FloatingToolbarItem<Command> => {
 	const optionItem: typeOption = 'item-checkbox';
 
@@ -209,8 +207,6 @@ export const getToolbarCellOptionsConfig = (
 	isTableFixedColumnWidthsOptionEnabled = false,
 	shouldUseIncreasedScalingPercent = false,
 	isCommentEditor = false,
-	// Ignored via go/ees005
-	// eslint-disable-next-line @typescript-eslint/max-params
 ): FloatingToolbarDropdown<Command> => {
 	const { top, bottom, right, left } = initialSelectionRect;
 	const numberOfColumns = right - left;
@@ -487,8 +483,6 @@ export const getToolbarConfig =
 		options?: TablePluginOptions,
 		isTableFixedColumnWidthsOptionEnabled = false,
 		shouldUseIncreasedScalingPercent = false,
-		// Ignored via go/ees005
-		// eslint-disable-next-line @typescript-eslint/max-params
 	) =>
 	(config: PluginConfig): FloatingToolbarHandler =>
 	(state, intl) => {
@@ -678,8 +672,6 @@ const getCellItems = (
 	isTableFixedColumnWidthsOptionEnabled = false,
 	shouldUseIncreasedScalingPercent = false,
 	isCommentEditor = false,
-	// Ignored via go/ees005
-	// eslint-disable-next-line @typescript-eslint/max-params
 ): Array<FloatingToolbarItem<Command>> => {
 	const initialSelectionRect = getClosestSelectionRect(state);
 	if (initialSelectionRect) {
@@ -711,8 +703,6 @@ const getDistributeConfig =
 		isTableScalingEnabled = false,
 		isTableFixedColumnWidthsOptionEnabled = false,
 		isCommentEditor = false,
-		// Ignored via go/ees005
-		// eslint-disable-next-line @typescript-eslint/max-params
 	): Command =>
 	(state, dispatch, editorView) => {
 		const selectionOrTableRect = getClosestSelectionOrTableRect(state);
@@ -752,8 +742,6 @@ const getColumnSettingItems = (
 	isTableScalingEnabled = false,
 	isTableFixedColumnWidthsOptionEnabled = false,
 	isCommentEditor = false,
-	// Ignored via go/ees005
-	// eslint-disable-next-line @typescript-eslint/max-params
 ): Array<FloatingToolbarItem<Command>> => {
 	const pluginState = getPluginState(editorState);
 	const selectionOrTableRect = getClosestSelectionOrTableRect(editorState);
@@ -809,8 +797,6 @@ const getColorPicker = (
 	{ formatMessage }: ToolbarMenuContext,
 	editorAnalyticsAPI: EditorAnalyticsAPI | null | undefined,
 	getEditorView: () => EditorView | null,
-	// Ignored via go/ees005
-	// eslint-disable-next-line @typescript-eslint/max-params
 ): Array<FloatingToolbarItem<Command>> => {
 	const { targetCellPosition, pluginConfig } = getPluginState(state);
 	if (!pluginConfig.allowBackgroundColor) {
@@ -902,8 +888,6 @@ const getAlignmentOptionsConfig = (
 	shouldUseIncreasedScalingPercent: boolean,
 	isFullWidthEditor?: boolean,
 	isCommentEditor?: boolean,
-	// Ignored via go/ees005
-	// eslint-disable-next-line @typescript-eslint/max-params
 ): Array<FloatingToolbarDropdown<Command>> => {
 	const tableObject = findTable(editorState.selection);
 
@@ -1017,8 +1001,6 @@ const isLayoutOptionDisabled = (
 	editorView: EditorView | null,
 	shouldUseIncreasedScalingPercent: boolean,
 	isFullWidthEditor: boolean | undefined,
-	// Ignored via go/ees005
-	// eslint-disable-next-line @typescript-eslint/max-params
 ) => {
 	const { lineLength } = getEditorContainerWidth();
 	let tableContainerWidth = getTableContainerWidth(selectedNode);