@atlaskit/editor-plugin-table 7.5.1 → 7.5.3

package/src/pm-plugins/table-resizing/event-handlers.ts

@@ -2,6 +2,7 @@ import type { CellAttributes, TableLayout } from '@atlaskit/adf-schema';
 import {
   ACTION_SUBJECT,
   EVENT_TYPE,
+  INPUT_METHOD,
   TABLE_ACTION,
   TABLE_OVERFLOW_CHANGE_TRIGGER,
 } from '@atlaskit/editor-common/analytics';
@@ -211,6 +212,9 @@ export const handleMouseDown = (
           resizingSelectedColumns ? selectedColumns : undefined,
           tablePreserveWidth,
         );
+
+        const resizedDelta = clientX - startX;
+
         tr = updateColumnWidths(newResizeState, table, start)(tr);
         if (colIndex === map.width - 1) {
           const mouseUpTime = event.timeStamp;
@@ -223,11 +227,26 @@ export const handleMouseDown = (
               type: 'table-border',
               position: 'right',
               duration: mouseUpTime - mouseDownTime,
-              delta: Math.abs(clientX - dragging.startX),
+              delta: Math.abs(resizedDelta),
             },
             eventType: EVENT_TYPE.UI,
           })(tr);
         }
+
+        editorAnalyticsAPI?.attachAnalyticsEvent({
+          action: TABLE_ACTION.COLUMN_RESIZED,
+          actionSubject: ACTION_SUBJECT.TABLE,
+          eventType: EVENT_TYPE.TRACK,
+          attributes: {
+            colIndex: colIndex,
+            resizedDelta,
+            isLastColumn: colIndex === map.width - 1,
+            tableWidth: table.attrs.width,
+            inputMethod: INPUT_METHOD.MOUSE,
+            totalRowCount: map.height,
+            totalColumnCount: map.width,
+          },
+        })(tr);
       }
       if (getBooleanFF('platform.editor.a11y-column-resizing_emcvz')) {
         if (isKeyboardResize || !isTableHovered) {

package/src/utils/merged-cells.ts

@@ -259,13 +259,17 @@ export const checkEdgeHasMergedCells = (
   const { mapByRow, mapByColumn } = tableMap;
   const map = 'row' === direction ? mapByRow : mapByColumn;
   const lengthLimiter = direction === 'row' ? tableMap.width : tableMap.height;
-
   let minIndex = Math.min(...indexes);
   let maxIndex = Math.max(...indexes);
   let isTopSideHaveMergedCells = false;
   let isBottomSideHaveMergedCells = false;
-  let isOldMinIndex = !map[minIndex - 1] && !map[minIndex];
-  let isOldMaxIndex = !map[maxIndex + 1] && !map[maxIndex];
+
+  /**
+   * this is to check if the cell position from last focused table is overflow. since if you selection from a cell in 6th row and 7th column cell in a 7x8 table to 3x3 table, the cell position will be overflow because new table dont have this cell at all.
+   TODO: ED-22335 this should better called only when hover over the drag handle.
+  */
+  let isOldMinIndex = !map[minIndex - 1] || !map[minIndex];
+  let isOldMaxIndex = !map[maxIndex + 1] || !map[maxIndex];
 
   if (minIndex > 0 && !isOldMinIndex) {
     const prevSelectionSet = map[minIndex - 1];