@atlaskit/editor-plugin-table 7.1.4 → 7.2.1

package/dist/types-ts4.5/pm-plugins/drag-and-drop/actions.d.ts

@@ -1,7 +1,6 @@
 import type { DecorationSet } from '@atlaskit/editor-prosemirror/view';
 import type { TableDirection } from '../../types';
 import type { DropTargetType } from './consts';
-import type { DragAndDropPluginState } from './types';
 export interface DragAndDropAction<T, D> {
     type: T;
     data: D;
@@ -10,7 +9,6 @@ export declare const DragAndDropActionType: {
     readonly SET_DROP_TARGET: "SET_DROP_TARGET";
     readonly CLEAR_DROP_TARGET: "CLEAR_DROP_TARGET";
     readonly TOGGLE_DRAG_MENU: "TOGGLE_DRAG_MENU";
-    readonly UPDATE: "UPDATE";
 };
 export type DragAndDropSetDropTargetAction = DragAndDropAction<typeof DragAndDropActionType.SET_DROP_TARGET, {
     type: DropTargetType;
@@ -25,5 +23,4 @@ export type DragAndDropToggleDragMenuAction = DragAndDropAction<typeof DragAndDr
     direction: TableDirection;
     index: number;
 }>;
-export type DragAndDropUpdateAction = DragAndDropAction<typeof DragAndDropActionType.UPDATE, Partial<DragAndDropPluginState>>;
-export type DragAndDropPluginAction = DragAndDropSetDropTargetAction | DragAndDropClearDropTargetAction | DragAndDropToggleDragMenuAction | DragAndDropUpdateAction;
+export type DragAndDropPluginAction = DragAndDropSetDropTargetAction | DragAndDropClearDropTargetAction | DragAndDropToggleDragMenuAction;

package/dist/types-ts4.5/pm-plugins/drag-and-drop/consts.d.ts

@@ -4,4 +4,3 @@ export declare const DropTargetType: {
     readonly COLUMN: "column";
 };
 export type DropTargetType = (typeof DropTargetType)[keyof typeof DropTargetType];
-export declare const DRAGGABLE_TABLE_NODE_SIZE_LIMIT = 20000;

package/dist/types-ts4.5/pm-plugins/drag-and-drop/plugin.d.ts

@@ -1,5 +1,4 @@
 import type { EditorAnalyticsAPI } from '@atlaskit/editor-common/analytics';
 import type { Dispatch, EventDispatcher } from '@atlaskit/editor-common/event-dispatcher';
 import { SafePlugin } from '@atlaskit/editor-common/safe-plugin';
-import type { DragAndDropPluginState } from './types';
-export declare const createPlugin: (dispatch: Dispatch, eventDispatcher: EventDispatcher, editorAnalyticsAPI?: EditorAnalyticsAPI) => SafePlugin<DragAndDropPluginState>;
+export declare const createPlugin: (dispatch: Dispatch, eventDispatcher: EventDispatcher, editorAnalyticsAPI?: EditorAnalyticsAPI) => SafePlugin<import("./types").DragAndDropPluginState>;

package/dist/types-ts4.5/pm-plugins/drag-and-drop/types.d.ts

@@ -9,5 +9,4 @@ export interface DragAndDropPluginState {
     dragMenuDirection?: TableDirection;
     dragMenuIndex: number;
     isDragging: boolean;
-    canDrag: boolean;
 }

package/dist/types-ts4.5/ui/DragHandle/index.d.ts

@@ -17,7 +17,6 @@ type DragHandleProps = {
     onMouseOut?: MouseEventHandler;
     onMouseUp?: MouseEventHandler;
     editorView: EditorView;
-    canDrag?: boolean;
     isDragMenuTarget: boolean;
 };
 export declare const DragHandle: React.FC<import("react-intl-next").WithIntlProps<DragHandleProps & WrappedComponentProps<"intl">>> & {

package/dist/types-ts4.5/ui/FloatingDragMenu/DragMenu.d.ts

@@ -19,10 +19,9 @@ type DragMenuProps = {
     scrollableElement?: HTMLElement;
     pluginConfig?: PluginConfig;
     getEditorContainerWidth: GetEditorContainerWidth;
-    canDrag?: boolean;
     editorAnalyticsAPI?: EditorAnalyticsAPI;
 };
-export declare const DragMenu: ({ direction, index, isOpen, editorView, tableNode, mountPoint, boundariesElement, scrollableElement, targetCellPosition, getEditorContainerWidth, canDrag, editorAnalyticsAPI, pluginConfig, intl: { formatMessage }, }: DragMenuProps & WrappedComponentProps) => jsx.JSX.Element | null;
+export declare const DragMenu: ({ direction, index, isOpen, editorView, tableNode, mountPoint, boundariesElement, scrollableElement, targetCellPosition, getEditorContainerWidth, editorAnalyticsAPI, pluginConfig, intl: { formatMessage }, }: DragMenuProps & WrappedComponentProps) => jsx.JSX.Element | null;
 declare const _default: import("react").FC<import("react-intl-next").WithIntlProps<DragMenuProps & WrappedComponentProps<"intl">>> & {
     WrappedComponent: import("react").ComponentType<DragMenuProps & WrappedComponentProps<"intl">>;
 };

package/dist/types-ts4.5/ui/FloatingDragMenu/index.d.ts

@@ -17,13 +17,12 @@ export interface Props {
     index?: number;
     targetCellPosition?: number;
     getEditorContainerWidth: GetEditorContainerWidth;
-    canDrag?: boolean;
     editorAnalyticsAPI?: EditorAnalyticsAPI;
     stickyHeaders?: RowStickyState;
     pluginConfig?: PluginConfig;
 }
 declare const FloatingDragMenu: {
-    ({ mountPoint, boundariesElement, scrollableElement, editorView, isOpen, tableNode, direction, index, targetCellPosition, getEditorContainerWidth, canDrag, editorAnalyticsAPI, stickyHeaders, pluginConfig, }: Props): JSX.Element | null;
+    ({ mountPoint, boundariesElement, scrollableElement, editorView, isOpen, tableNode, direction, index, targetCellPosition, getEditorContainerWidth, editorAnalyticsAPI, stickyHeaders, pluginConfig, }: Props): JSX.Element | null;
     displayName: string;
 };
 export default FloatingDragMenu;

package/dist/types-ts4.5/ui/TableFloatingColumnControls/ColumnControls/index.d.ts

@@ -14,10 +14,9 @@ export interface ColumnControlsProps {
     colWidths?: (number | undefined)[];
     hasHeaderColumn?: boolean;
     isTableHovered?: boolean;
-    canDrag?: boolean;
     tableContainerWidth?: number;
     isNumberColumnEnabled?: boolean;
     isDragging?: boolean;
 }
-export declare const ColumnControls: ({ editorView, tableActive, tableRef, hoveredCell, isResizing, stickyTop, localId, isInDanger, rowHeights, colWidths, hasHeaderColumn, isTableHovered, canDrag, tableContainerWidth, isNumberColumnEnabled, isDragging, }: ColumnControlsProps) => JSX.Element;
+export declare const ColumnControls: ({ editorView, tableActive, tableRef, hoveredCell, isResizing, stickyTop, localId, isInDanger, rowHeights, colWidths, hasHeaderColumn, isTableHovered, tableContainerWidth, isNumberColumnEnabled, isDragging, }: ColumnControlsProps) => JSX.Element;
 export default ColumnControls;

package/dist/types-ts4.5/ui/TableFloatingColumnControls/index.d.ts

@@ -22,7 +22,6 @@ export interface Props {
     ordering?: TableColumnOrdering;
     stickyHeader?: RowStickyState;
     isTableHovered?: boolean;
-    canDrag?: boolean;
     tableContainerWidth?: number;
     isNumberColumnEnabled?: boolean;
 }

package/dist/types-ts4.5/ui/TableFloatingControls/RowControls/DragControls.d.ts

@@ -13,7 +13,6 @@ type DragControlsProps = {
     isInDanger?: boolean;
     isResizing?: boolean;
     isTableHovered?: boolean;
-    canDrag?: boolean;
     hoverRows: (rows: number[], danger?: boolean) => void;
     selectRow: (row: number, expand: boolean) => void;
     selectRows: (rowIndexes: number[]) => void;

package/dist/types-ts4.5/ui/TableFloatingControls/index.d.ts

@@ -18,7 +18,6 @@ export interface Props {
     isHeaderColumnEnabled?: boolean;
     isNumberColumnEnabled?: boolean;
     isDragAndDropEnabled?: boolean;
-    canDrag?: boolean;
     hasHeaderRow?: boolean;
     headerRowHeight?: number;
     hoveredRows?: number[];

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaskit/editor-plugin-table",
-  "version": "7.1.4",
+  "version": "7.2.1",
   "description": "Table plugin for the @atlaskit/editor",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/"
@@ -28,8 +28,8 @@
     "runReact18": false
   },
   "dependencies": {
-    "@atlaskit/adf-schema": "^35.3.0",
-    "@atlaskit/custom-steps": "^0.0.11",
+    "@atlaskit/adf-schema": "^35.5.1",
+    "@atlaskit/custom-steps": "^0.0.12",
     "@atlaskit/editor-common": "^77.2.0",
     "@atlaskit/editor-palette": "1.5.2",
     "@atlaskit/editor-plugin-analytics": "^0.4.0",
@@ -64,7 +64,7 @@
     "react-intl-next": "npm:react-intl@^5.18.1"
   },
   "devDependencies": {
-    "@atlaskit/analytics-next": "^9.1.0",
+    "@atlaskit/analytics-next": "^9.2.0",
     "@atlaskit/editor-plugin-decorations": "^0.2.0",
     "@atlaskit/editor-plugin-feature-flags": "^1.0.0",
     "@atlaskit/editor-plugin-grid": "^0.3.0",
@@ -72,7 +72,7 @@
     "@atlaskit/editor-test-helpers": "^18.15.0",
     "@atlaskit/visual-regression": "*",
     "@atlassian/atlassian-frontend-prettier-config-1.0.1": "npm:@atlassian/atlassian-frontend-prettier-config@1.0.1",
-    "@atlassian/feature-flags-test-utils": "^0.1.2",
+    "@atlassian/feature-flags-test-utils": "^0.2.0",
     "@testing-library/dom": "^8.17.1",
     "@testing-library/react": "^12.1.5",
     "@testing-library/react-hooks": "^8.0.1",

package/src/nodeviews/TableComponent.tsx

@@ -95,7 +95,6 @@ export interface ComponentProps {
   isHeaderColumnEnabled: boolean;
   isMediaFullscreen?: boolean;
   isDragAndDropEnabled?: boolean;
-  canDrag?: boolean;
   tableActive: boolean;
   ordering: TableColumnOrdering;
   isResizing?: boolean;
@@ -442,7 +441,6 @@ class TableComponent extends React.Component<ComponentProps, TableState> {
       getPos,
       pluginInjectionApi,
       isDragAndDropEnabled,
-      canDrag,
       getEditorFeatureFlags,
     } = this.props;
 
@@ -472,7 +470,6 @@ class TableComponent extends React.Component<ComponentProps, TableState> {
         isNumberColumnEnabled={node.attrs.isNumberColumnEnabled}
         isHeaderRowEnabled={isHeaderRowEnabled}
         isDragAndDropEnabled={isDragAndDropEnabled}
-        canDrag={canDrag}
         ordering={ordering}
         isHeaderColumnEnabled={isHeaderColumnEnabled}
         hasHeaderRow={hasHeaderRow}
@@ -500,7 +497,6 @@ class TableComponent extends React.Component<ComponentProps, TableState> {
         selection={view.state.selection}
         headerRowHeight={headerRow ? headerRow.offsetHeight : undefined}
         stickyHeader={this.state.stickyHeader}
-        canDrag={canDrag}
         getEditorFeatureFlags={getEditorFeatureFlags}
         tableContainerWidth={tableContainerWidth}
         isNumberColumnEnabled={node.attrs.isNumberColumnEnabled}

package/src/nodeviews/table.tsx

@@ -215,9 +215,7 @@ export default class TableView extends ReactNodeView<Props> {
             tableResizingPluginState,
             tableWidthPluginState,
             pluginState,
-            // containerWidth,
             mediaState,
-            tableDragAndDropState,
           } = pluginStates;
           const containerWidth = props.getEditorContainerWidth();
 
@@ -253,7 +251,6 @@ export default class TableView extends ReactNodeView<Props> {
               isHeaderRowEnabled={pluginState!.isHeaderRowEnabled}
               isHeaderColumnEnabled={pluginState!.isHeaderColumnEnabled}
               isDragAndDropEnabled={pluginState!.isDragAndDropEnabled}
-              canDrag={tableDragAndDropState?.canDrag ?? false}
               tableActive={tableActive}
               ordering={pluginState!.ordering as TableColumnOrdering}
               isResizing={isResizing}

package/src/plugin.tsx

@@ -517,7 +517,6 @@ const tablesPlugin: TablePlugin = ({ config: options, api }) => {
                       direction={dragAndDropState?.dragMenuDirection}
                       index={dragAndDropState?.dragMenuIndex}
                       isOpen={!!dragAndDropState?.isDragMenuOpen && !isResizing}
-                      canDrag={dragAndDropState?.canDrag}
                       getEditorContainerWidth={defaultGetEditorContainerWidth}
                       editorAnalyticsAPI={editorAnalyticsAPI}
                       stickyHeaders={stickyHeader}

package/src/pm-plugins/drag-and-drop/actions.ts

@@ -3,7 +3,6 @@ import type { DecorationSet } from '@atlaskit/editor-prosemirror/view';
 import type { TableDirection } from '../../types';
 
 import type { DropTargetType } from './consts';
-import type { DragAndDropPluginState } from './types';
 
 export interface DragAndDropAction<T, D> {
   type: T;
@@ -14,7 +13,6 @@ export const DragAndDropActionType = {
   SET_DROP_TARGET: 'SET_DROP_TARGET',
   CLEAR_DROP_TARGET: 'CLEAR_DROP_TARGET',
   TOGGLE_DRAG_MENU: 'TOGGLE_DRAG_MENU',
-  UPDATE: 'UPDATE',
 } as const;
 
 export type DragAndDropSetDropTargetAction = DragAndDropAction<
@@ -42,14 +40,8 @@ export type DragAndDropToggleDragMenuAction = DragAndDropAction<
   }
 >;
 
-export type DragAndDropUpdateAction = DragAndDropAction<
-  typeof DragAndDropActionType.UPDATE,
-  Partial<DragAndDropPluginState>
->;
-
 // NOTE: This should be a Union of all possible actions
 export type DragAndDropPluginAction =
   | DragAndDropSetDropTargetAction
   | DragAndDropClearDropTargetAction
-  | DragAndDropToggleDragMenuAction
-  | DragAndDropUpdateAction;
+  | DragAndDropToggleDragMenuAction;

package/src/pm-plugins/drag-and-drop/consts.ts

@@ -6,5 +6,3 @@ export const DropTargetType = {
 
 export type DropTargetType =
   (typeof DropTargetType)[keyof typeof DropTargetType];
-
-export const DRAGGABLE_TABLE_NODE_SIZE_LIMIT = 20000;

package/src/pm-plugins/drag-and-drop/plugin.ts

@@ -28,10 +28,9 @@ import {
   clearDropTargetWithAnalytics,
   moveSourceWithAnalytics,
 } from './commands-with-analytics';
-import { DRAGGABLE_TABLE_NODE_SIZE_LIMIT, DropTargetType } from './consts';
+import { DropTargetType } from './consts';
 import { createPluginState, getPluginState } from './plugin-factory';
 import { pluginKey } from './plugin-key';
-import type { DragAndDropPluginState } from './types';
 import { getDraggableDataFromEvent } from './utils/monitor';
 
 const destroyFn = (editorView: EditorView, editorAnalyticsAPI: any) => {
@@ -243,23 +242,14 @@ export const createPlugin = (
       isDragMenuOpen: false,
       dragMenuIndex: 0,
       isDragging: false,
-      canDrag: false,
     })),
     key: pluginKey,
     appendTransaction: (transactions, oldState, newState) => {
-      const {
-        targetCellPosition: oldTargetCellPosition,
-        tableNode: oldTableNode,
-      } = getTablePluginState(oldState);
-      const {
-        targetCellPosition: newTargetCellPosition,
-        tableNode: newTableNode,
-      } = getTablePluginState(newState);
-      const { isDragMenuOpen, dragMenuIndex, canDrag } =
-        getPluginState(newState);
-
-      const stateChanges: Array<Partial<DragAndDropPluginState>> = [];
-      const tr = newState.tr;
+      const { targetCellPosition: oldTargetCellPosition } =
+        getTablePluginState(oldState);
+      const { targetCellPosition: newTargetCellPosition } =
+        getTablePluginState(newState);
+      const { isDragMenuOpen, dragMenuIndex } = getPluginState(newState);
 
       // What's happening here? you asked... In a nutshell;
       // If the target cell position changes while the drag menu is open then we want to close the drag menu if it has been opened.
@@ -267,6 +257,15 @@ export const createPlugin = (
       // to check if the new target cell position is pointed at a different cell than what the drag menu was opened on.
       if (oldTargetCellPosition !== newTargetCellPosition) {
         if (isDragMenuOpen) {
+          const tr = newState.tr;
+          const action = {
+            type: DragAndDropActionType.TOGGLE_DRAG_MENU,
+            data: {
+              isDragMenuOpen: false,
+              direction: undefined,
+            },
+          };
+
           if (newTargetCellPosition !== undefined) {
             const cells = getCellsInRow(dragMenuIndex)(tr.selection);
             // ED-20673 check if it is a cell selection,
@@ -279,44 +278,13 @@ export const createPlugin = (
               cells[0].node !== tr.doc.nodeAt(newTargetCellPosition) &&
               !isCellSelection
             ) {
-              stateChanges.push({
-                isDragMenuOpen: false,
-                dragMenuDirection: undefined,
-              });
+              return tr.setMeta(pluginKey, action);
             } // else NOP
           } else {
-            stateChanges.push({
-              isDragMenuOpen: false,
-              dragMenuDirection: undefined,
-            });
+            return tr.setMeta(pluginKey, action);
           }
         }
       }
-
-      if (oldTableNode?.nodeSize !== newTableNode?.nodeSize) {
-        const nextCanDrag =
-          (newTableNode?.nodeSize ?? 0) < DRAGGABLE_TABLE_NODE_SIZE_LIMIT;
-
-        if (canDrag !== nextCanDrag) {
-          stateChanges.push({
-            canDrag: nextCanDrag,
-          });
-        }
-      }
-
-      if (stateChanges.length) {
-        return tr
-          .setMeta(pluginKey, {
-            type: DragAndDropActionType.UPDATE,
-            data: {
-              ...stateChanges.reduce(
-                (state, cur) => ({ ...state, ...cur }),
-                {},
-              ),
-            },
-          })
-          .setMeta('addToHistory', false);
-      }
     },
     view: (editorView: EditorView) => {
       return {

package/src/pm-plugins/drag-and-drop/reducer.ts

@@ -31,11 +31,6 @@ export default (
         dragMenuDirection: action.data.direction,
         dragMenuIndex: action.data.index,
       };
-    case DragAndDropActionType.UPDATE:
-      return {
-        ...pluginState,
-        ...action.data,
-      };
     default:
       return pluginState;
   }

package/src/pm-plugins/drag-and-drop/types.ts

@@ -12,5 +12,4 @@ export interface DragAndDropPluginState {
   dragMenuDirection?: TableDirection;
   dragMenuIndex: number;
   isDragging: boolean;
-  canDrag: boolean;
 }

package/src/pm-plugins/main.ts

@@ -21,6 +21,7 @@ import {
   transformSliceToRemoveOpenBodiedExtension,
   transformSliceToRemoveOpenExpand,
   transformSliceToRemoveOpenLayoutNodes,
+  transformSliceToRemoveOpenMultiBodiedExtension,
 } from '@atlaskit/editor-common/transforms';
 import type {
   GetEditorContainerWidth,
@@ -281,6 +282,9 @@ export const createPlugin = (
         /** If a partial paste of bodied extension, paste only text */
         slice = transformSliceToRemoveOpenBodiedExtension(slice, schema);
 
+        /** If a partial paste of multi bodied extension, paste only children */
+        slice = transformSliceToRemoveOpenMultiBodiedExtension(slice, schema);
+
         slice = transformSliceToCorrectEmptyTableCells(slice, schema);
 
         if (!pluginConfig.allowColumnResizing) {

package/src/ui/DragHandle/index.tsx

@@ -37,7 +37,6 @@ type DragHandleProps = {
   onMouseOut?: MouseEventHandler;
   onMouseUp?: MouseEventHandler;
   editorView: EditorView;
-  canDrag?: boolean;
   isDragMenuTarget: boolean; // this is identify which current handle component is
 };
 
@@ -55,7 +54,6 @@ const DragHandleComponent = ({
   onMouseUp,
   onClick,
   editorView,
-  canDrag = false,
   intl: { formatMessage },
 }: DragHandleProps & WrappedComponentProps) => {
   const dragHandleDivRef = useRef<HTMLButtonElement>(null);
@@ -94,7 +92,7 @@ const DragHandleComponent = ({
       return draggable({
         element: dragHandleDivRefCurrent,
         canDrag: () => {
-          return canDrag && !hasMergedCells;
+          return !hasMergedCells;
         },
         getInitialData() {
           return {
@@ -138,7 +136,6 @@ const DragHandleComponent = ({
     isRow,
     editorView.state.selection,
     hasMergedCells,
-    canDrag,
   ]);
 
   const showDragMenuAnchorId = isRow
@@ -170,7 +167,7 @@ const DragHandleComponent = ({
           ClassName.DRAG_HANDLE_BUTTON_CONTAINER,
           appearance,
           {
-            [ClassName.DRAG_HANDLE_DISABLED]: !canDrag || hasMergedCells,
+            [ClassName.DRAG_HANDLE_DISABLED]: hasMergedCells,
           },
         )}
         ref={dragHandleDivRef}

package/src/ui/FloatingDragMenu/DragMenu.tsx

@@ -94,7 +94,6 @@ type DragMenuProps = {
   scrollableElement?: HTMLElement;
   pluginConfig?: PluginConfig;
   getEditorContainerWidth: GetEditorContainerWidth;
-  canDrag?: boolean;
   editorAnalyticsAPI?: EditorAnalyticsAPI;
 };
 
@@ -265,7 +264,6 @@ export const DragMenu = ({
   scrollableElement,
   targetCellPosition,
   getEditorContainerWidth,
-  canDrag,
   editorAnalyticsAPI,
   pluginConfig,
   intl: { formatMessage },
@@ -291,7 +289,7 @@ export const DragMenu = ({
   const dragMenuConfig = getDragMenuConfig(
     direction,
     getEditorContainerWidth,
-    !!canDrag && !shouldMoveDisabled,
+    !shouldMoveDisabled,
     hasMergedCellsInTable,
     editorView,
     tableMap,

package/src/ui/FloatingDragMenu/index.tsx

@@ -29,7 +29,6 @@ export interface Props {
   index?: number;
   targetCellPosition?: number;
   getEditorContainerWidth: GetEditorContainerWidth;
-  canDrag?: boolean;
   editorAnalyticsAPI?: EditorAnalyticsAPI;
   stickyHeaders?: RowStickyState;
   pluginConfig?: PluginConfig;
@@ -46,7 +45,6 @@ const FloatingDragMenu = ({
   index,
   targetCellPosition,
   getEditorContainerWidth,
-  canDrag,
   editorAnalyticsAPI,
   stickyHeaders,
   pluginConfig,
@@ -105,7 +103,6 @@ const FloatingDragMenu = ({
         index={index}
         targetCellPosition={targetCellPosition}
         getEditorContainerWidth={getEditorContainerWidth}
-        canDrag={canDrag}
         editorAnalyticsAPI={editorAnalyticsAPI}
         pluginConfig={pluginConfig}
       />

package/src/ui/TableFloatingColumnControls/ColumnControls/index.tsx

@@ -36,7 +36,6 @@ export interface ColumnControlsProps {
   colWidths?: (number | undefined)[];
   hasHeaderColumn?: boolean;
   isTableHovered?: boolean;
-  canDrag?: boolean;
   tableContainerWidth?: number;
   isNumberColumnEnabled?: boolean;
   isDragging?: boolean;
@@ -66,7 +65,6 @@ export const ColumnControls = ({
   colWidths,
   hasHeaderColumn,
   isTableHovered,
-  canDrag,
   tableContainerWidth,
   isNumberColumnEnabled,
   isDragging,
@@ -289,7 +287,6 @@ export const ColumnControls = ({
           onMouseOut={handleMouseOut}
           onMouseUp={handleMouseUp}
           editorView={editorView}
-          canDrag={canDrag}
         />
       </div>
     );

package/src/ui/TableFloatingColumnControls/index.tsx

@@ -35,7 +35,6 @@ export interface Props {
   ordering?: TableColumnOrdering;
   stickyHeader?: RowStickyState;
   isTableHovered?: boolean;
-  canDrag?: boolean;
   tableContainerWidth?: number;
   isNumberColumnEnabled?: boolean;
 }
@@ -52,7 +51,6 @@ export const TableFloatingColumnControls: React.FC<Props> = ({
   selection,
   isInDanger,
   isTableHovered,
-  canDrag,
   tableContainerWidth,
   isNumberColumnEnabled,
 }) => {
@@ -157,7 +155,6 @@ export const TableFloatingColumnControls: React.FC<Props> = ({
         rowHeights={rowHeights}
         colWidths={colWidths}
         hasHeaderColumn={hasHeaderColumn}
-        canDrag={canDrag}
         tableContainerWidth={tableContainerWidth}
         isNumberColumnEnabled={isNumberColumnEnabled}
         isDragging={isDragging}

package/src/ui/TableFloatingControls/RowControls/DragControls.tsx

@@ -47,7 +47,6 @@ type DragControlsProps = {
   isInDanger?: boolean;
   isResizing?: boolean;
   isTableHovered?: boolean;
-  canDrag?: boolean;
   hoverRows: (rows: number[], danger?: boolean) => void;
   selectRow: (row: number, expand: boolean) => void;
   selectRows: (rowIndexes: number[]) => void;
@@ -75,7 +74,6 @@ const DragControlsComponent = ({
   isInDanger,
   isResizing,
   isTableHovered,
-  canDrag,
   hoverRows,
   selectRow,
   selectRows,
@@ -273,7 +271,6 @@ const DragControlsComponent = ({
           onMouseOut={handleMouseOut}
           onMouseUp={onMouseUp}
           editorView={editorView}
-          canDrag={canDrag}
         />
       </div>
     );

package/src/ui/TableFloatingControls/index.tsx

@@ -29,7 +29,6 @@ export interface Props {
   isHeaderColumnEnabled?: boolean;
   isNumberColumnEnabled?: boolean;
   isDragAndDropEnabled?: boolean;
-  canDrag?: boolean;
   hasHeaderRow?: boolean;
   headerRowHeight?: number;
   hoveredRows?: number[];
@@ -107,7 +106,6 @@ export default class TableFloatingControls extends Component<Props, State> {
       stickyHeader,
       hoveredCell,
       isTableHovered,
-      canDrag,
     } = this.props;
     return (
       this.state.tableWrapperWidth !== nextState.tableWrapperWidth ||
@@ -125,8 +123,7 @@ export default class TableFloatingControls extends Component<Props, State> {
       headerRowHeight !== nextProps.headerRowHeight ||
       stickyHeader !== nextProps.stickyHeader ||
       hoveredCell !== nextProps.hoveredCell ||
-      isTableHovered !== nextProps.isTableHovered ||
-      canDrag !== nextProps.canDrag
+      isTableHovered !== nextProps.isTableHovered
     );
   }
 
@@ -153,7 +150,6 @@ export default class TableFloatingControls extends Component<Props, State> {
       isDragAndDropEnabled,
       hoveredCell,
       isTableHovered,
-      canDrag,
     } = this.props;
 
     if (!tableRef) {
@@ -213,7 +209,6 @@ export default class TableFloatingControls extends Component<Props, State> {
                     selectRow={this.selectRow}
                     selectRows={this.selectRows}
                     updateCellHoverLocation={this.updateCellHoverLocation}
-                    canDrag={canDrag}
                   />
                 </>
               ) : (