@atlaskit/editor-plugin-table 5.3.7 → 5.3.9

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # @atlaskit/editor-plugin-table
 
+## 5.3.9
+
+### Patch Changes
+
+- [#41924](https://bitbucket.org/atlassian/atlassian-frontend/pull-requests/41924) [`71cb328c202`](https://bitbucket.org/atlassian/atlassian-frontend/commits/71cb328c202) - Fixed the column controls drag and drop targets. The monitor was not responding to the targets due to there layering and pointer value. The targets are now added/removed on demand when the user starts/stop dragging
+
+## 5.3.8
+
+### Patch Changes
+
+- [#41909](https://bitbucket.org/atlassian/atlassian-frontend/pull-requests/41909) [`b122e4659bc`](https://bitbucket.org/atlassian/atlassian-frontend/commits/b122e4659bc) - Use floating column control buttons insetead of column controls implemented as decorations
+
 ## 5.3.7
 
 ### Patch Changes

package/dist/cjs/plugins/table/nodeviews/TableComponent.js

@@ -496,22 +496,23 @@ var TableComponent = /*#__PURE__*/function (_React$Component) {
         headerRowHeight: headerRow ? headerRow.offsetHeight : undefined,
         stickyHeader: this.state.stickyHeader
       }));
-      var colControls = /*#__PURE__*/_react.default.createElement("div", {
-        className: _types.TableCssClassName.COLUMN_CONTROLS_WRAPPER
-      }, /*#__PURE__*/_react.default.createElement(_TableFloatingColumnControls.default, {
+      var colControls = /*#__PURE__*/_react.default.createElement(_TableFloatingColumnControls.default, {
         editorView: view,
         tableRef: tableRef,
+        getNode: getNode,
         tableActive: tableActive,
         hoveredRows: hoveredRows,
+        hoveredCell: hoveredCell,
+        isResizing: isResizing,
         ordering: ordering,
         hasHeaderRow: hasHeaderRow
-        // pass `selection` and `tableHeight` to control re-render
+        // pass `selection` to control re-render
         ,
         selection: view.state.selection,
         headerRowHeight: headerRow ? headerRow.offsetHeight : undefined,
         stickyHeader: this.state.stickyHeader,
         getEditorFeatureFlags: this.props.getEditorFeatureFlags
-      }));
+      });
       var shadowPadding = allowControls && tableActive ? -_editorSharedStyles.akEditorTableToolbarSize : _styles.tableMarginSides;
       var shadowStyle = (0, _memoizeOne.default)(function (visible) {
         return {

package/dist/cjs/plugins/table/pm-plugins/decorations/plugin.js

@@ -8,6 +8,7 @@ var _safePlugin = require("@atlaskit/editor-common/safe-plugin");
 var _state = require("@atlaskit/editor-prosemirror/state");
 var _view = require("@atlaskit/editor-prosemirror/view");
 var _cellSelection = require("@atlaskit/editor-tables/cell-selection");
+var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _pluginKey = require("../plugin-key");
 var _tableWidth = require("../table-width");
 var _utils = require("./utils");
@@ -21,8 +22,8 @@ var handleDocOrSelectionChanged = exports.handleDocOrSelectionChanged = function
   var wasResizing = (_tableWidthPluginKey$2 = _tableWidth.pluginKey.getState(oldState)) === null || _tableWidthPluginKey$2 === void 0 ? void 0 : _tableWidthPluginKey$2.resizing;
   var changedResizing = isResizing !== wasResizing;
 
-  // Remove column controls when resizing
-  if (isResizing) {
+  // Remove column controls when resizing and don't add column decoration controls when DnD enabled
+  if (isResizing || (0, _platformFeatureFlags.getBooleanFF)('platform.editor.table.drag-and-drop')) {
     return _view.DecorationSet.empty;
   } else if (tr.docChanged || tr.selection instanceof _cellSelection.CellSelection || changedResizing || ((_tr$getMeta = tr.getMeta(_pluginKey.pluginKey)) === null || _tr$getMeta === void 0 ? void 0 : _tr$getMeta.type) === 'HOVER_CELL') {
     return (0, _utils.buildColumnControlsDecorations)({

package/dist/cjs/plugins/table/pm-plugins/decorations/utils/column-controls.js

@@ -30,7 +30,6 @@ var maybeUpdateColumnSelectedDecoration = function maybeUpdateColumnSelectedDeco
   return (0, _decoration.updateDecorations)(tr.doc, decorationSet, (0, _decoration.createColumnSelectedDecoration)(tr), _types.TableDecorations.COLUMN_SELECTED);
 };
 var maybeUpdateColumnControlsDecoration = function maybeUpdateColumnControlsDecoration(_ref3) {
-  var _meta$data;
   var decorationSet = _ref3.decorationSet,
     tr = _ref3.tr;
   var table = (0, _utils.findTable)(tr.selection);
@@ -40,7 +39,7 @@ var maybeUpdateColumnControlsDecoration = function maybeUpdateColumnControlsDeco
   if (!table && (meta === null || meta === void 0 ? void 0 : meta.type) !== 'HOVER_CELL') {
     return decorationSet;
   }
-  return (0, _decoration.updateDecorations)(tr.doc, decorationSet, (0, _decoration.createColumnControlsDecoration)(tr.selection, meta === null || meta === void 0 || (_meta$data = meta.data) === null || _meta$data === void 0 ? void 0 : _meta$data.hoveredCell), _types.TableDecorations.COLUMN_CONTROLS_DECORATIONS);
+  return (0, _decoration.updateDecorations)(tr.doc, decorationSet, (0, _decoration.createColumnControlsDecoration)(tr.selection), _types.TableDecorations.COLUMN_CONTROLS_DECORATIONS);
 };
 
 // @see: https://product-fabric.atlassian.net/browse/ED-7304

package/dist/cjs/plugins/table/pm-plugins/drag-and-drop/commands.js

@@ -77,6 +77,6 @@ var moveSource = exports.moveSource = function moveSource(sourceType, sourceInde
       return tr.setMeta('addToHistory', false);
     }
     var move = sourceType === 'table-row' ? _utils.moveRow : _utils.moveColumn;
-    return move(sourceIndex, targetIndex + (sourceIndex > targetIndex ? 0 : -1))(tr);
+    return move(sourceIndex, targetIndex)(tr);
   });
 };

package/dist/cjs/plugins/table/pm-plugins/drag-and-drop/plugin.js

@@ -76,7 +76,8 @@ var createPlugin = exports.createPlugin = function createPlugin(dispatch, eventD
             }
             var sourceType = data.sourceType,
               sourceIndexes = data.sourceIndexes,
-              targetAdjustedIndex = data.targetAdjustedIndex;
+              targetAdjustedIndex = data.targetAdjustedIndex,
+              direction = data.direction;
 
             // If the drop target index contains merged cells then we should not allow the drop to occur.
             var hasMergedCells = sourceType === 'table-row' ? _mergedCells.hasMergedCellsInRow : _mergedCells.hasMergedCellsInColumn;
@@ -86,7 +87,7 @@ var createPlugin = exports.createPlugin = function createPlugin(dispatch, eventD
             }
             var _sourceIndexes = (0, _slicedToArray2.default)(sourceIndexes, 1),
               sourceIndex = _sourceIndexes[0];
-            (0, _commands.moveSource)(sourceType, sourceIndex, targetAdjustedIndex)(editorView.state, editorView.dispatch);
+            (0, _commands.moveSource)(sourceType, sourceIndex, targetAdjustedIndex + (direction === -1 ? 0 : -1))(editorView.state, editorView.dispatch);
           }
         })
       };

package/dist/cjs/plugins/table/pm-plugins/drag-and-drop/utils/monitor.js

@@ -46,6 +46,10 @@ var getDraggableDataFromEvent = exports.getDraggableDataFromEvent = function get
   // This introduces an offset in the event the drop occured closer to the bottom/right of the target. We want
   // the new target index to be 1 index higher.
   var targetOffset = targetClosestEdge === 'right' || targetClosestEdge === 'bottom' ? 1 : 0;
+
+  // since only consecutive rows/cols can be moved we can assume that if the first index is greater then
+  // the target index, the then the direction of the DnD is decreasing
+  var direction = sourceIndexes[0] > targetIndex ? -1 : 1;
   return {
     sourceType: sourceType,
     sourceLocalId: sourceLocalId,
@@ -54,6 +58,7 @@ var getDraggableDataFromEvent = exports.getDraggableDataFromEvent = function get
     targetLocalId: targetLocalId,
     targetIndex: targetIndex,
     targetAdjustedIndex: targetIndex + targetOffset,
-    targetClosestEdge: targetClosestEdge
+    targetClosestEdge: targetClosestEdge,
+    direction: direction
   };
 };

package/dist/cjs/plugins/table/types.js

@@ -86,7 +86,7 @@ var TableCssClassName = exports.TableCssClassName = _objectSpread(_objectSpread(
   CORNER_CONTROLS_INSERT_COLUMN_MARKER: "".concat(_adfSchema.tablePrefixSelector, "-corner-controls__insert-column-marker"),
   CONTROLS_CORNER_BUTTON: "".concat(_adfSchema.tablePrefixSelector, "-corner-button"),
   /** Controls with drag handle */
-  COLUMN_CONTROLS_DECORATIONS_WITH_DRAG: "".concat(_adfSchema.tablePrefixSelector, "-column-controls-decoration-with-drag"),
+  COLUMN_CONTROLS_WITH_DRAG: "".concat(_adfSchema.tablePrefixSelector, "-column-controls-with-drag"),
   ROW_CONTROLS_WITH_DRAG: "".concat(_adfSchema.tablePrefixSelector, "-row-controls-with-drag"),
   DRAG_HANDLE_BUTTON_CONTAINER: "".concat(_adfSchema.tablePrefixSelector, "-drag-handle-button-container"),
   /** Other classes */

package/dist/cjs/plugins/table/ui/DragHandle/index.js

@@ -14,7 +14,7 @@ var _setCustomNativeDragPreview = require("@atlaskit/pragmatic-drag-and-drop/uti
 var _colors = require("@atlaskit/theme/colors");
 var _types = require("../../types");
 var _DragPreview = require("../DragPreview");
-var _DragHandleIcon = require("../icons/DragHandleIcon");
+var _icons = require("../icons");
 function _getRequireWildcardCache(nodeInterop) { if (typeof WeakMap !== "function") return null; var cacheBabelInterop = new WeakMap(); var cacheNodeInterop = new WeakMap(); return (_getRequireWildcardCache = function _getRequireWildcardCache(nodeInterop) { return nodeInterop ? cacheNodeInterop : cacheBabelInterop; })(nodeInterop); }
 function _interopRequireWildcard(obj, nodeInterop) { if (!nodeInterop && obj && obj.__esModule) { return obj; } if (obj === null || _typeof(obj) !== "object" && typeof obj !== "function") { return { default: obj }; } var cache = _getRequireWildcardCache(nodeInterop); if (cache && cache.has(obj)) { return cache.get(obj); } var newObj = {}; var hasPropertyDescriptor = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var key in obj) { if (key !== "default" && Object.prototype.hasOwnProperty.call(obj, key)) { var desc = hasPropertyDescriptor ? Object.getOwnPropertyDescriptor(obj, key) : null; if (desc && (desc.get || desc.set)) { Object.defineProperty(newObj, key, desc); } else { newObj[key] = obj[key]; } } } newObj.default = obj; if (cache) { cache.set(obj, newObj); } return newObj; }
 var mapStateToProps = function mapStateToProps(state) {
@@ -98,9 +98,11 @@ var DragHandle = exports.DragHandle = function DragHandle(_ref) {
       backgroundColor: "var(--ds-surface, white)",
       borderRadius: '4px',
       border: "2px solid ".concat("var(--ds-surface, white)"),
-      transform: direction === 'column' ? 'none' : 'rotate(90deg)'
-    }
-  }, /*#__PURE__*/_react.default.createElement(_DragHandleIcon.DragHandleIcon, iconProps), previewContainer && previewWidth !== undefined && previewHeight !== undefined && /*#__PURE__*/_reactDom.default.createPortal( /*#__PURE__*/_react.default.createElement(_DragPreview.DragPreview, {
+      transform: direction === 'column' ? 'none' : 'rotate(90deg)',
+      pointerEvents: 'auto'
+    },
+    "data-testid": "table-floating-column-controls-drag-handle"
+  }, /*#__PURE__*/_react.default.createElement(_icons.DragHandleIcon, iconProps), previewContainer && previewWidth !== undefined && previewHeight !== undefined && /*#__PURE__*/_reactDom.default.createPortal( /*#__PURE__*/_react.default.createElement(_DragPreview.DragPreview, {
     direction: direction,
     width: previewWidth,
     height: previewHeight

package/dist/cjs/plugins/table/ui/TableFloatingColumnControls/ColumnControls/index.js

@@ -0,0 +1,62 @@
+"use strict";
+
+var _interopRequireDefault = require("@babel/runtime/helpers/interopRequireDefault");
+Object.defineProperty(exports, "__esModule", {
+  value: true
+});
+exports.default = exports.ColumnControls = void 0;
+var _react = _interopRequireDefault(require("react"));
+var _types = require("../../../types");
+var _DragHandle = require("../../DragHandle");
+var ColumnControls = exports.ColumnControls = function ColumnControls(_ref) {
+  var _rowHeights$, _colWidths$map$join;
+  var editorView = _ref.editorView,
+    tableActive = _ref.tableActive,
+    tableRef = _ref.tableRef,
+    hoveredCell = _ref.hoveredCell,
+    isResizing = _ref.isResizing,
+    stickyTop = _ref.stickyTop,
+    localId = _ref.localId,
+    rowHeights = _ref.rowHeights,
+    colWidths = _ref.colWidths;
+  if (!tableRef) {
+    return null;
+  }
+  var firstRow = tableRef.querySelector('tr');
+  var hasHeaderRow = firstRow ? firstRow.getAttribute('data-header-row') : false;
+  var marginTop = hasHeaderRow && stickyTop !== undefined ? (_rowHeights$ = rowHeights === null || rowHeights === void 0 ? void 0 : rowHeights[0]) !== null && _rowHeights$ !== void 0 ? _rowHeights$ : 0 : 0;
+  var widths = (_colWidths$map$join = colWidths === null || colWidths === void 0 ? void 0 : colWidths.map(function (width) {
+    return width ? "".concat(width - 1, "px") : '0px';
+  }).join(' ')) !== null && _colWidths$map$join !== void 0 ? _colWidths$map$join : '0px';
+  var colIndex = hoveredCell === null || hoveredCell === void 0 ? void 0 : hoveredCell.colIndex;
+  var _onClick = function onClick(index, event) {};
+  var onMouseOver = function onMouseOver() {};
+  var onMouseOut = function onMouseOut() {};
+  return /*#__PURE__*/_react.default.createElement("div", {
+    className: _types.TableCssClassName.COLUMN_CONTROLS_WITH_DRAG
+  }, /*#__PURE__*/_react.default.createElement("div", {
+    className: _types.TableCssClassName.COLUMN_CONTROLS_INNER,
+    "data-testid": "table-floating-column-controls",
+    style: {
+      gridTemplateColumns: widths,
+      marginTop: marginTop
+    }
+  }, tableActive && !isResizing && Number.isFinite(colIndex) && /*#__PURE__*/_react.default.createElement("div", {
+    style: {
+      gridColumn: "".concat(colIndex + 1, " / span 1"),
+      marginTop: "-15px"
+    },
+    "data-column-control-index": colIndex,
+    "data-testid": "table-floating-column-control"
+  }, /*#__PURE__*/_react.default.createElement(_DragHandle.DragHandle, {
+    direction: "column",
+    indexes: [colIndex],
+    onClick: function onClick(event) {
+      return _onClick(colIndex, event);
+    },
+    onMouseOver: onMouseOver,
+    onMouseOut: onMouseOut,
+    tableLocalId: localId || ''
+  }))));
+};
+var _default = exports.default = ColumnControls;

package/dist/cjs/plugins/table/ui/TableFloatingColumnControls/ColumnDropTargets/ColumnDropTarget.js

@@ -0,0 +1,70 @@
+"use strict";
+
+var _typeof = require("@babel/runtime/helpers/typeof");
+Object.defineProperty(exports, "__esModule", {
+  value: true
+});
+exports.ColumnDropTarget = void 0;
+var _react = _interopRequireWildcard(require("react"));
+var _closestEdge = require("@atlaskit/pragmatic-drag-and-drop-hitbox/addon/closest-edge");
+var _element = require("@atlaskit/pragmatic-drag-and-drop/adapter/element");
+function _getRequireWildcardCache(nodeInterop) { if (typeof WeakMap !== "function") return null; var cacheBabelInterop = new WeakMap(); var cacheNodeInterop = new WeakMap(); return (_getRequireWildcardCache = function _getRequireWildcardCache(nodeInterop) { return nodeInterop ? cacheNodeInterop : cacheBabelInterop; })(nodeInterop); }
+function _interopRequireWildcard(obj, nodeInterop) { if (!nodeInterop && obj && obj.__esModule) { return obj; } if (obj === null || _typeof(obj) !== "object" && typeof obj !== "function") { return { default: obj }; } var cache = _getRequireWildcardCache(nodeInterop); if (cache && cache.has(obj)) { return cache.get(obj); } var newObj = {}; var hasPropertyDescriptor = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var key in obj) { if (key !== "default" && Object.prototype.hasOwnProperty.call(obj, key)) { var desc = hasPropertyDescriptor ? Object.getOwnPropertyDescriptor(obj, key) : null; if (desc && (desc.get || desc.set)) { Object.defineProperty(newObj, key, desc); } else { newObj[key] = obj[key]; } } } newObj.default = obj; if (cache) { cache.set(obj, newObj); } return newObj; }
+var ColumnDropTarget = exports.ColumnDropTarget = function ColumnDropTarget(_ref) {
+  var index = _ref.index,
+    localId = _ref.localId,
+    width = _ref.width,
+    height = _ref.height,
+    marginTop = _ref.marginTop;
+  var dropTargetRef = (0, _react.useRef)(null);
+  (0, _react.useEffect)(function () {
+    if (!dropTargetRef.current) {
+      return;
+    }
+    return (0, _element.dropTargetForElements)({
+      element: dropTargetRef.current,
+      canDrop: function canDrop(_ref2) {
+        var _data$indexes, _data$indexes2;
+        var source = _ref2.source;
+        var data = source.data;
+        return (
+          // Only draggables of row type can be dropped on this target
+          data.type === 'table-column' &&
+          // Only draggables which came from the same table can be dropped on this target
+          data.localId === localId &&
+          // Only draggables which DO NOT include this drop targets index can be dropped
+          !!((_data$indexes = data.indexes) !== null && _data$indexes !== void 0 && _data$indexes.length) && ((_data$indexes2 = data.indexes) === null || _data$indexes2 === void 0 ? void 0 : _data$indexes2.indexOf(index)) === -1
+        );
+      },
+      getIsSticky: function getIsSticky() {
+        return true;
+      },
+      getData: function getData(_ref3) {
+        var input = _ref3.input,
+          element = _ref3.element;
+        var data = {
+          localId: localId,
+          type: 'table-column',
+          targetIndex: index
+        };
+        return (0, _closestEdge.attachClosestEdge)(data, {
+          input: input,
+          element: element,
+          allowedEdges: ['left', 'right']
+        });
+      }
+    });
+  }, [index, localId]);
+  return /*#__PURE__*/_react.default.createElement("div", {
+    ref: dropTargetRef,
+    style: {
+      width: width && "".concat(width - 1, "px"),
+      height: height && "".concat(height, "px"),
+      marginTop: marginTop && "".concat(marginTop, "px"),
+      pointerEvents: 'auto'
+    },
+    "data-drop-target-index": index,
+    "data-drop-target-localid": localId,
+    "data-testid": "table-floating-column-controls-drop-target"
+  });
+};

package/dist/cjs/plugins/table/ui/TableFloatingColumnControls/ColumnDropTargets/index.js

@@ -1,32 +1,21 @@
 "use strict";
 
-var _typeof = require("@babel/runtime/helpers/typeof");
+var _interopRequireDefault = require("@babel/runtime/helpers/interopRequireDefault");
 Object.defineProperty(exports, "__esModule", {
   value: true
 });
-exports.default = exports.ColumnDropTargets = void 0;
-var _react = _interopRequireWildcard(require("react"));
-var _closestEdge = require("@atlaskit/pragmatic-drag-and-drop-hitbox/addon/closest-edge");
-var _element = require("@atlaskit/pragmatic-drag-and-drop/adapter/element");
+exports.ColumnDropTargets = void 0;
+var _react = _interopRequireDefault(require("react"));
 var _types = require("../../../types");
-var _utils = require("../../../utils");
-function _getRequireWildcardCache(nodeInterop) { if (typeof WeakMap !== "function") return null; var cacheBabelInterop = new WeakMap(); var cacheNodeInterop = new WeakMap(); return (_getRequireWildcardCache = function _getRequireWildcardCache(nodeInterop) { return nodeInterop ? cacheNodeInterop : cacheBabelInterop; })(nodeInterop); }
-function _interopRequireWildcard(obj, nodeInterop) { if (!nodeInterop && obj && obj.__esModule) { return obj; } if (obj === null || _typeof(obj) !== "object" && typeof obj !== "function") { return { default: obj }; } var cache = _getRequireWildcardCache(nodeInterop); if (cache && cache.has(obj)) { return cache.get(obj); } var newObj = {}; var hasPropertyDescriptor = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var key in obj) { if (key !== "default" && Object.prototype.hasOwnProperty.call(obj, key)) { var desc = hasPropertyDescriptor ? Object.getOwnPropertyDescriptor(obj, key) : null; if (desc && (desc.get || desc.set)) { Object.defineProperty(newObj, key, desc); } else { newObj[key] = obj[key]; } } } newObj.default = obj; if (cache) { cache.set(obj, newObj); } return newObj; }
+var _ColumnDropTarget = require("./ColumnDropTarget");
 var ColumnDropTargets = exports.ColumnDropTargets = function ColumnDropTargets(_ref) {
   var _rowHeights$;
-  var editorView = _ref.editorView,
-    tableRef = _ref.tableRef,
+  var tableRef = _ref.tableRef,
     tableHeight = _ref.tableHeight,
     stickyTop = _ref.stickyTop,
-    localId = _ref.localId;
-  var colWidths = (0, _utils.getColumnsWidths)(editorView);
-  var rowHeights = (0, _react.useMemo)(function () {
-    // NOTE: we don't care so much as to what tableHeight is, we only care that it changed and is a sane value.
-    if (tableRef && !!tableHeight) {
-      return (0, _utils.getRowHeights)(tableRef);
-    }
-    return [0];
-  }, [tableRef, tableHeight]);
+    localId = _ref.localId,
+    rowHeights = _ref.rowHeights,
+    colWidths = _ref.colWidths;
   if (!tableRef) {
     return null;
   }
@@ -34,12 +23,13 @@ var ColumnDropTargets = exports.ColumnDropTargets = function ColumnDropTargets(_
   var hasHeaderRow = firstRow ? firstRow.getAttribute('data-header-row') : false;
   var marginTop = hasHeaderRow && stickyTop !== undefined ? (_rowHeights$ = rowHeights === null || rowHeights === void 0 ? void 0 : rowHeights[0]) !== null && _rowHeights$ !== void 0 ? _rowHeights$ : 0 : 0;
   return /*#__PURE__*/_react.default.createElement("div", {
-    className: _types.TableCssClassName.COLUMN_DROP_TARGET_CONTROLS
+    className: _types.TableCssClassName.COLUMN_DROP_TARGET_CONTROLS,
+    contentEditable: false
   }, /*#__PURE__*/_react.default.createElement("div", {
     className: _types.TableCssClassName.COLUMN_CONTROLS_INNER,
     "data-testid": "table-floating-column-controls-drop-targets"
-  }, colWidths.map(function (width, index) {
-    return /*#__PURE__*/_react.default.createElement(ColumnDropTarget, {
+  }, colWidths === null || colWidths === void 0 ? void 0 : colWidths.map(function (width, index) {
+    return /*#__PURE__*/_react.default.createElement(_ColumnDropTarget.ColumnDropTarget, {
       key: index,
       index: index,
       localId: localId,
@@ -48,59 +38,4 @@ var ColumnDropTargets = exports.ColumnDropTargets = function ColumnDropTargets(_
       marginTop: marginTop
     });
   })));
-};
-var _default = exports.default = ColumnDropTargets;
-var ColumnDropTarget = function ColumnDropTarget(_ref2) {
-  var index = _ref2.index,
-    localId = _ref2.localId,
-    width = _ref2.width,
-    height = _ref2.height,
-    marginTop = _ref2.marginTop;
-  var dropTargetRef = (0, _react.useRef)(null);
-  (0, _react.useEffect)(function () {
-    if (!dropTargetRef.current) {
-      return;
-    }
-    return (0, _element.dropTargetForElements)({
-      element: dropTargetRef.current,
-      canDrop: function canDrop(_ref3) {
-        var _data$indexes, _data$indexes2;
-        var source = _ref3.source;
-        var data = source.data;
-        return (
-          // Only draggables of row type can be dropped on this target
-          data.type === 'table-column' &&
-          // Only draggables which came from the same table can be dropped on this target
-          data.localId === localId &&
-          // Only draggables which DO NOT include this drop targets index can be dropped
-          !!((_data$indexes = data.indexes) !== null && _data$indexes !== void 0 && _data$indexes.length) && ((_data$indexes2 = data.indexes) === null || _data$indexes2 === void 0 ? void 0 : _data$indexes2.indexOf(index)) === -1
-        );
-      },
-      getData: function getData(_ref4) {
-        var input = _ref4.input,
-          element = _ref4.element;
-        var data = {
-          localId: localId,
-          type: 'table-column',
-          targetIndex: index
-        };
-        return (0, _closestEdge.attachClosestEdge)(data, {
-          input: input,
-          element: element,
-          allowedEdges: ['left', 'right']
-        });
-      }
-    });
-  }, [index, localId]);
-  return /*#__PURE__*/_react.default.createElement("div", {
-    ref: dropTargetRef,
-    style: {
-      width: width && "".concat(width - 1, "px"),
-      height: height && "".concat(height, "px"),
-      marginTop: marginTop && "".concat(marginTop, "px")
-    },
-    "data-drop-target-index": index,
-    "data-drop-target-localid": localId,
-    "data-testid": "table-floating-column-controls-drop-target"
-  });
 };

package/dist/cjs/plugins/table/ui/TableFloatingColumnControls/index.js

@@ -8,7 +8,11 @@ Object.defineProperty(exports, "__esModule", {
 exports.default = exports.TableFloatingColumnControls = void 0;
 var _slicedToArray2 = _interopRequireDefault(require("@babel/runtime/helpers/slicedToArray"));
 var _react = _interopRequireWildcard(require("react"));
-var _editorTables = require("@atlaskit/editor-tables");
+var _reactDom = _interopRequireDefault(require("react-dom"));
+var _element = require("@atlaskit/pragmatic-drag-and-drop/adapter/element");
+var _types = require("../../types");
+var _utils = require("../../utils");
+var _ColumnControls = require("./ColumnControls");
 var _ColumnDropTargets = require("./ColumnDropTargets");
 function _getRequireWildcardCache(nodeInterop) { if (typeof WeakMap !== "function") return null; var cacheBabelInterop = new WeakMap(); var cacheNodeInterop = new WeakMap(); return (_getRequireWildcardCache = function _getRequireWildcardCache(nodeInterop) { return nodeInterop ? cacheNodeInterop : cacheBabelInterop; })(nodeInterop); }
 function _interopRequireWildcard(obj, nodeInterop) { if (!nodeInterop && obj && obj.__esModule) { return obj; } if (obj === null || _typeof(obj) !== "object" && typeof obj !== "function") { return { default: obj }; } var cache = _getRequireWildcardCache(nodeInterop); if (cache && cache.has(obj)) { return cache.get(obj); } var newObj = {}; var hasPropertyDescriptor = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var key in obj) { if (key !== "default" && Object.prototype.hasOwnProperty.call(obj, key)) { var desc = hasPropertyDescriptor ? Object.getOwnPropertyDescriptor(obj, key) : null; if (desc && (desc.get || desc.set)) { Object.defineProperty(newObj, key, desc); } else { newObj[key] = obj[key]; } } } newObj.default = obj; if (cache) { cache.set(obj, newObj); } return newObj; }
@@ -18,8 +22,11 @@ function _arrayLikeToArray(arr, len) { if (len == null || len > arr.length) len
 var TableFloatingColumnControls = exports.TableFloatingColumnControls = function TableFloatingColumnControls(_ref) {
   var editorView = _ref.editorView,
     tableRef = _ref.tableRef,
+    getNode = _ref.getNode,
     tableActive = _ref.tableActive,
     hasHeaderRow = _ref.hasHeaderRow,
+    hoveredCell = _ref.hoveredCell,
+    isResizing = _ref.isResizing,
     stickyHeader = _ref.stickyHeader,
     selection = _ref.selection;
   var _useState = (0, _react.useState)({
@@ -29,6 +36,12 @@ var TableFloatingColumnControls = exports.TableFloatingColumnControls = function
     _useState2 = (0, _slicedToArray2.default)(_useState, 2),
     tableRect = _useState2[0],
     setTableRect = _useState2[1];
+  var _useState3 = (0, _react.useState)(false),
+    _useState4 = (0, _slicedToArray2.default)(_useState3, 2),
+    hasDropTargets = _useState4[0],
+    setHasDropTargets = _useState4[1];
+  var node = getNode();
+  var currentNodeLocalId = node === null || node === void 0 ? void 0 : node.attrs.localId;
   (0, _react.useEffect)(function () {
     var _window;
     if (tableRef && (_window = window) !== null && _window !== void 0 && _window.ResizeObserver) {
@@ -60,31 +73,60 @@ var TableFloatingColumnControls = exports.TableFloatingColumnControls = function
       };
     }
   }, [tableRef]);
-  var selectedLocalId = (0, _react.useMemo)(function () {
-    if (!selection) {
-      return undefined;
-    }
-    var tableNode = (0, _editorTables.findTable)(selection);
-    if (!tableNode) {
-      return undefined;
+  (0, _react.useEffect)(function () {
+    return (0, _element.monitorForElements)({
+      canMonitor: function canMonitor(_ref2) {
+        var source = _ref2.source;
+        var _ref3 = source.data,
+          type = _ref3.type,
+          localId = _ref3.localId,
+          indexes = _ref3.indexes;
+        return type === 'table-column' && !!(indexes !== null && indexes !== void 0 && indexes.length) && localId === currentNodeLocalId;
+      },
+      onDragStart: function onDragStart() {
+        setHasDropTargets(true);
+      },
+      onDrop: function onDrop() {
+        setHasDropTargets(false);
+      }
+    });
+  }, [editorView, currentNodeLocalId]);
+  var rowHeights = (0, _react.useMemo)(function () {
+    // NOTE: we don't care so much as to what tableHeight is, we only care that it changed and is a sane value.
+    if (tableRef && !!tableRect.height) {
+      return (0, _utils.getRowHeights)(tableRef);
     }
-    return tableNode.node.attrs.localId;
-  }, [selection]);
+    return [0];
+  }, [tableRef, tableRect.height]);
   if (!tableRef) {
     return null;
   }
+  var colWidths = (0, _utils.getColumnsWidths)(editorView);
   var stickyTop = stickyHeader && stickyHeader.sticky && hasHeaderRow ? stickyHeader.top : undefined;
-  return /*#__PURE__*/_react.default.createElement("div", {
-    onMouseDown: function onMouseDown(e) {
-      return e.preventDefault();
+  var mountTo = tableRef && (tableRef === null || tableRef === void 0 ? void 0 : tableRef.parentElement) || document.body;
+  return /*#__PURE__*/_reactDom.default.createPortal( /*#__PURE__*/_react.default.createElement("div", {
+    className: _types.TableCssClassName.COLUMN_CONTROLS_WRAPPER,
+    style: {
+      pointerEvents: 'none'
     },
     "data-testid": "table-floating-column-controls-wrapper"
-  }, tableActive && /*#__PURE__*/_react.default.createElement(_ColumnDropTargets.ColumnDropTargets, {
+  }, /*#__PURE__*/_react.default.createElement(_ColumnControls.ColumnControls, {
     editorView: editorView,
+    hoveredCell: hoveredCell,
+    tableRef: tableRef,
+    isResizing: isResizing,
+    tableActive: tableActive,
+    stickyTop: tableActive ? stickyTop : undefined,
+    localId: currentNodeLocalId,
+    rowHeights: rowHeights,
+    colWidths: colWidths
+  }), hasDropTargets && /*#__PURE__*/_react.default.createElement(_ColumnDropTargets.ColumnDropTargets, {
     tableRef: tableRef,
     stickyTop: tableActive ? stickyTop : undefined,
     tableHeight: tableRect.height,
-    localId: selectedLocalId
-  }));
+    localId: currentNodeLocalId,
+    rowHeights: rowHeights,
+    colWidths: colWidths
+  })), mountTo);
 };
 var _default = exports.default = TableFloatingColumnControls;