@atlaskit/editor-plugin-table 5.3.36 → 5.3.38

package/CHANGELOG.md

@@ -1,5 +1,41 @@
 # @atlaskit/editor-plugin-table
 
+## 5.3.38
+
+### Patch Changes
+
+- [#43646](https://bitbucket.org/atlassian/atlassian-frontend/pull-requests/43646) [`d43f8e9402f`](https://bitbucket.org/atlassian/atlassian-frontend/commits/d43f8e9402f) - Make feature flags plugin optional in all plugins including:
+
+  - analytics
+  - base
+  - card
+  - code-block
+  - expand
+  - extension
+  - floating-toolbar
+  - hyperlink
+  - insert-block
+  - layout
+  - layout
+  - list
+  - media
+  - paste
+  - rule
+  - table
+  - tasks-and-decisions
+
+  We already treat it as optional in the plugins, so this is just ensuring that the plugin is not mandatory to be added to the preset.
+
+- Updated dependencies
+
+## 5.3.37
+
+### Patch Changes
+
+- [#42221](https://bitbucket.org/atlassian/atlassian-frontend/pull-requests/42221) [`7fd1f8bb312`](https://bitbucket.org/atlassian/atlassian-frontend/commits/7fd1f8bb312) - revert pr 42221
+- [#43417](https://bitbucket.org/atlassian/atlassian-frontend/pull-requests/43417) [`3f3c17f0273`](https://bitbucket.org/atlassian/atlassian-frontend/commits/3f3c17f0273) - ED-20971 Upgrade adf-schema package to ^34.0.0
+- Updated dependencies
+
 ## 5.3.36
 
 ### Patch Changes

package/dist/cjs/plugins/table/commands/selection.js

@@ -3,13 +3,12 @@
 Object.defineProperty(exports, "__esModule", {
   value: true
 });
-exports.shiftArrowUpFromTable = exports.selectRows = exports.selectColumns = exports.arrowRightFromTable = exports.arrowLeftFromTable = exports.TableSelectionDirection = void 0;
+exports.shiftArrowUpFromTable = exports.arrowRightFromTable = exports.arrowLeftFromTable = exports.TableSelectionDirection = void 0;
 var _selection = require("@atlaskit/editor-common/selection");
 var _state = require("@atlaskit/editor-prosemirror/state");
 var _cellSelection = require("@atlaskit/editor-tables/cell-selection");
 var _tableMap = require("@atlaskit/editor-tables/table-map");
 var _utils = require("@atlaskit/editor-tables/utils");
-var _misc = require("../commands/misc");
 var _toolbar = require("../toolbar");
 var TableSelectionDirection = exports.TableSelectionDirection = /*#__PURE__*/function (TableSelectionDirection) {
   TableSelectionDirection["TopToBottom"] = "TopToBottom";
@@ -46,46 +45,6 @@ var arrowRightFromTable = exports.arrowRightFromTable = function arrowRightFromT
     };
   };
 };
-var selectColumns = exports.selectColumns = function selectColumns(editorSelectionAPI) {
-  return function () {
-    return function (state, dispatch) {
-      var selection = state.selection;
-      var table = (0, _utils.findTable)(selection);
-      var rect = (0, _utils.selectedRect)(state);
-      if (table && (0, _utils.isRowSelected)(rect.top)(selection)) {
-        return selectFullTable(editorSelectionAPI)({
-          node: table.node,
-          startPos: table.start,
-          dir: TableSelectionDirection.BottomToTop
-        })(state, dispatch);
-      }
-      if (table && rect) {
-        return (0, _misc.selectColumn)(rect.left)(state, dispatch);
-      }
-      return false;
-    };
-  };
-};
-var selectRows = exports.selectRows = function selectRows(editorSelectionAPI) {
-  return function () {
-    return function (state, dispatch) {
-      var selection = state.selection;
-      var table = (0, _utils.findTable)(selection);
-      var rect = (0, _utils.selectedRect)(state);
-      if (table && (0, _utils.isColumnSelected)(rect.left)(selection)) {
-        return selectFullTable(editorSelectionAPI)({
-          node: table.node,
-          startPos: table.start,
-          dir: TableSelectionDirection.BottomToTop
-        })(state, dispatch);
-      }
-      if (table && rect) {
-        return (0, _misc.selectRow)(rect.top)(state, dispatch);
-      }
-      return false;
-    };
-  };
-};
 var arrowLeftFromCellSelection = function arrowLeftFromCellSelection(editorSelectionAPI) {
   return function (selection) {
     return function (state, dispatch) {

package/dist/cjs/plugins/table/pm-plugins/table-selection-keymap.js

@@ -16,8 +16,6 @@ function tableSelectionKeymapPlugin(editorSelectionAPI) {
   if ((0, _platformFeatureFlags.getBooleanFF)('platform.editor.table.shift-arrowup-fix')) {
     (0, _keymaps.bindKeymapWithCommand)(_keymaps.shiftArrowUp.common, (0, _selection.shiftArrowUpFromTable)(editorSelectionAPI)(), list);
   }
-  (0, _keymaps.bindKeymapWithCommand)(_keymaps.selectColumn.common, (0, _selection.selectColumns)(editorSelectionAPI)(), list);
-  (0, _keymaps.bindKeymapWithCommand)(_keymaps.selectRow.common, (0, _selection.selectRows)(editorSelectionAPI)(), list);
   return (0, _keymap.keymap)(list);
 }
 var _default = exports.default = tableSelectionKeymapPlugin;

package/dist/es2019/plugins/table/commands/selection.js

@@ -2,8 +2,7 @@ import { GapCursorSelection, isSelectionAtEndOfNode, isSelectionAtStartOfNode, R
 import { Selection, TextSelection } from '@atlaskit/editor-prosemirror/state';
 import { CellSelection } from '@atlaskit/editor-tables/cell-selection';
 import { TableMap } from '@atlaskit/editor-tables/table-map';
-import { findTable, isColumnSelected, isRowSelected, isTableSelected, selectedRect } from '@atlaskit/editor-tables/utils';
-import { selectColumn, selectRow } from '../commands/misc';
+import { findTable, isTableSelected } from '@atlaskit/editor-tables/utils';
 import { getClosestSelectionRect } from '../toolbar';
 export let TableSelectionDirection = /*#__PURE__*/function (TableSelectionDirection) {
   TableSelectionDirection["TopToBottom"] = "TopToBottom";
@@ -36,42 +35,6 @@ export const arrowRightFromTable = editorSelectionAPI => () => (state, dispatch)
   }
   return false;
 };
-export const selectColumns = editorSelectionAPI => () => (state, dispatch) => {
-  const {
-    selection
-  } = state;
-  const table = findTable(selection);
-  const rect = selectedRect(state);
-  if (table && isRowSelected(rect.top)(selection)) {
-    return selectFullTable(editorSelectionAPI)({
-      node: table.node,
-      startPos: table.start,
-      dir: TableSelectionDirection.BottomToTop
-    })(state, dispatch);
-  }
-  if (table && rect) {
-    return selectColumn(rect.left)(state, dispatch);
-  }
-  return false;
-};
-export const selectRows = editorSelectionAPI => () => (state, dispatch) => {
-  const {
-    selection
-  } = state;
-  const table = findTable(selection);
-  const rect = selectedRect(state);
-  if (table && isColumnSelected(rect.left)(selection)) {
-    return selectFullTable(editorSelectionAPI)({
-      node: table.node,
-      startPos: table.start,
-      dir: TableSelectionDirection.BottomToTop
-    })(state, dispatch);
-  }
-  if (table && rect) {
-    return selectRow(rect.top)(state, dispatch);
-  }
-  return false;
-};
 const arrowLeftFromCellSelection = editorSelectionAPI => selection => (state, dispatch) => {
   if (isTableSelected(state.selection) && editorSelectionAPI) {
     const selectionState = editorSelectionAPI.sharedState.currentState() || {};

package/dist/es2019/plugins/table/pm-plugins/table-selection-keymap.js

@@ -1,7 +1,7 @@
-import { bindKeymapWithCommand, moveLeft, moveRight, selectColumn, selectRow, shiftArrowUp } from '@atlaskit/editor-common/keymaps';
+import { bindKeymapWithCommand, moveLeft, moveRight, shiftArrowUp } from '@atlaskit/editor-common/keymaps';
 import { keymap } from '@atlaskit/editor-prosemirror/keymap';
 import { getBooleanFF } from '@atlaskit/platform-feature-flags';
-import { arrowLeftFromTable, arrowRightFromTable, selectColumns, selectRows, shiftArrowUpFromTable } from '../commands/selection';
+import { arrowLeftFromTable, arrowRightFromTable, shiftArrowUpFromTable } from '../commands/selection';
 export function tableSelectionKeymapPlugin(editorSelectionAPI) {
   const list = {};
   bindKeymapWithCommand(moveRight.common, arrowRightFromTable(editorSelectionAPI)(), list);
@@ -9,8 +9,6 @@ export function tableSelectionKeymapPlugin(editorSelectionAPI) {
   if (getBooleanFF('platform.editor.table.shift-arrowup-fix')) {
     bindKeymapWithCommand(shiftArrowUp.common, shiftArrowUpFromTable(editorSelectionAPI)(), list);
   }
-  bindKeymapWithCommand(selectColumn.common, selectColumns(editorSelectionAPI)(), list);
-  bindKeymapWithCommand(selectRow.common, selectRows(editorSelectionAPI)(), list);
   return keymap(list);
 }
 export default tableSelectionKeymapPlugin;

package/dist/esm/plugins/table/commands/selection.js

@@ -2,8 +2,7 @@ import { GapCursorSelection, isSelectionAtEndOfNode, isSelectionAtStartOfNode, R
 import { Selection, TextSelection } from '@atlaskit/editor-prosemirror/state';
 import { CellSelection } from '@atlaskit/editor-tables/cell-selection';
 import { TableMap } from '@atlaskit/editor-tables/table-map';
-import { findTable, isColumnSelected, isRowSelected, isTableSelected, selectedRect } from '@atlaskit/editor-tables/utils';
-import { selectColumn, selectRow } from '../commands/misc';
+import { findTable, isTableSelected } from '@atlaskit/editor-tables/utils';
 import { getClosestSelectionRect } from '../toolbar';
 export var TableSelectionDirection = /*#__PURE__*/function (TableSelectionDirection) {
   TableSelectionDirection["TopToBottom"] = "TopToBottom";
@@ -40,46 +39,6 @@ export var arrowRightFromTable = function arrowRightFromTable(editorSelectionAPI
     };
   };
 };
-export var selectColumns = function selectColumns(editorSelectionAPI) {
-  return function () {
-    return function (state, dispatch) {
-      var selection = state.selection;
-      var table = findTable(selection);
-      var rect = selectedRect(state);
-      if (table && isRowSelected(rect.top)(selection)) {
-        return selectFullTable(editorSelectionAPI)({
-          node: table.node,
-          startPos: table.start,
-          dir: TableSelectionDirection.BottomToTop
-        })(state, dispatch);
-      }
-      if (table && rect) {
-        return selectColumn(rect.left)(state, dispatch);
-      }
-      return false;
-    };
-  };
-};
-export var selectRows = function selectRows(editorSelectionAPI) {
-  return function () {
-    return function (state, dispatch) {
-      var selection = state.selection;
-      var table = findTable(selection);
-      var rect = selectedRect(state);
-      if (table && isColumnSelected(rect.left)(selection)) {
-        return selectFullTable(editorSelectionAPI)({
-          node: table.node,
-          startPos: table.start,
-          dir: TableSelectionDirection.BottomToTop
-        })(state, dispatch);
-      }
-      if (table && rect) {
-        return selectRow(rect.top)(state, dispatch);
-      }
-      return false;
-    };
-  };
-};
 var arrowLeftFromCellSelection = function arrowLeftFromCellSelection(editorSelectionAPI) {
   return function (selection) {
     return function (state, dispatch) {

package/dist/esm/plugins/table/pm-plugins/table-selection-keymap.js

@@ -1,7 +1,7 @@
-import { bindKeymapWithCommand, moveLeft, moveRight, selectColumn, selectRow, shiftArrowUp } from '@atlaskit/editor-common/keymaps';
+import { bindKeymapWithCommand, moveLeft, moveRight, shiftArrowUp } from '@atlaskit/editor-common/keymaps';
 import { keymap } from '@atlaskit/editor-prosemirror/keymap';
 import { getBooleanFF } from '@atlaskit/platform-feature-flags';
-import { arrowLeftFromTable, arrowRightFromTable, selectColumns, selectRows, shiftArrowUpFromTable } from '../commands/selection';
+import { arrowLeftFromTable, arrowRightFromTable, shiftArrowUpFromTable } from '../commands/selection';
 export function tableSelectionKeymapPlugin(editorSelectionAPI) {
   var list = {};
   bindKeymapWithCommand(moveRight.common, arrowRightFromTable(editorSelectionAPI)(), list);
@@ -9,8 +9,6 @@ export function tableSelectionKeymapPlugin(editorSelectionAPI) {
   if (getBooleanFF('platform.editor.table.shift-arrowup-fix')) {
     bindKeymapWithCommand(shiftArrowUp.common, shiftArrowUpFromTable(editorSelectionAPI)(), list);
   }
-  bindKeymapWithCommand(selectColumn.common, selectColumns(editorSelectionAPI)(), list);
-  bindKeymapWithCommand(selectRow.common, selectRows(editorSelectionAPI)(), list);
   return keymap(list);
 }
 export default tableSelectionKeymapPlugin;

package/dist/types/plugins/table/commands/selection.d.ts

@@ -6,6 +6,4 @@ export declare enum TableSelectionDirection {
 }
 export declare const arrowLeftFromTable: (editorSelectionAPI: ExtractInjectionAPI<typeof tablePlugin>['selection'] | undefined) => () => Command;
 export declare const arrowRightFromTable: (editorSelectionAPI: ExtractInjectionAPI<typeof tablePlugin>['selection'] | undefined) => () => Command;
-export declare const selectColumns: (editorSelectionAPI: ExtractInjectionAPI<typeof tablePlugin>['selection'] | undefined) => () => Command;
-export declare const selectRows: (editorSelectionAPI: ExtractInjectionAPI<typeof tablePlugin>['selection'] | undefined) => () => Command;
 export declare const shiftArrowUpFromTable: (editorSelectionAPI: ExtractInjectionAPI<typeof tablePlugin>['selection'] | undefined) => () => Command;

package/dist/types-ts4.5/plugins/table/commands/selection.d.ts

@@ -6,6 +6,4 @@ export declare enum TableSelectionDirection {
 }
 export declare const arrowLeftFromTable: (editorSelectionAPI: ExtractInjectionAPI<typeof tablePlugin>['selection'] | undefined) => () => Command;
 export declare const arrowRightFromTable: (editorSelectionAPI: ExtractInjectionAPI<typeof tablePlugin>['selection'] | undefined) => () => Command;
-export declare const selectColumns: (editorSelectionAPI: ExtractInjectionAPI<typeof tablePlugin>['selection'] | undefined) => () => Command;
-export declare const selectRows: (editorSelectionAPI: ExtractInjectionAPI<typeof tablePlugin>['selection'] | undefined) => () => Command;
 export declare const shiftArrowUpFromTable: (editorSelectionAPI: ExtractInjectionAPI<typeof tablePlugin>['selection'] | undefined) => () => Command;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaskit/editor-plugin-table",
-  "version": "5.3.36",
+  "version": "5.3.38",
   "description": "Table plugin for the @atlaskit/editor",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/"
@@ -27,8 +27,8 @@
     "releaseModel": "continuous"
   },
   "dependencies": {
-    "@atlaskit/adf-schema": "^33.2.3",
-    "@atlaskit/custom-steps": "^0.0.3",
+    "@atlaskit/adf-schema": "^34.0.0",
+    "@atlaskit/custom-steps": "^0.0.4",
     "@atlaskit/editor-common": "^76.22.0",
     "@atlaskit/editor-palette": "1.5.2",
     "@atlaskit/editor-plugin-analytics": "^0.3.0",
@@ -44,7 +44,7 @@
     "@atlaskit/pragmatic-drag-and-drop": "^0.24.0",
     "@atlaskit/pragmatic-drag-and-drop-auto-scroll": "^0.7.0",
     "@atlaskit/pragmatic-drag-and-drop-hitbox": "^0.12.0",
-    "@atlaskit/primitives": "^1.11.0",
+    "@atlaskit/primitives": "^1.12.0",
     "@atlaskit/theme": "^12.6.0",
     "@atlaskit/tokens": "^1.28.0",
     "@atlaskit/tooltip": "^18.0.0",
@@ -66,7 +66,7 @@
     "@atlaskit/editor-plugin-decorations": "^0.2.0",
     "@atlaskit/editor-plugin-feature-flags": "^1.0.0",
     "@atlaskit/editor-plugin-grid": "^0.3.0",
-    "@atlaskit/editor-plugin-hyperlink": "^0.5.0",
+    "@atlaskit/editor-plugin-hyperlink": "^0.6.0",
     "@atlaskit/visual-regression": "*",
     "@atlaskit/webdriver-runner": "*",
     "@atlassian/atlassian-frontend-prettier-config-1.0.1": "npm:@atlassian/atlassian-frontend-prettier-config@1.0.1",

package/src/__tests__/unit/utils/nodes.ts

@@ -2,7 +2,6 @@ import type { DocBuilder } from '@atlaskit/editor-common/types';
 // eslint-disable-next-line import/no-extraneous-dependencies -- Removed import for fixing circular dependencies
 import { analyticsPlugin } from '@atlaskit/editor-plugin-analytics';
 import { contentInsertionPlugin } from '@atlaskit/editor-plugin-content-insertion';
-import { featureFlagsPlugin } from '@atlaskit/editor-plugin-feature-flags';
 import { guidelinePlugin } from '@atlaskit/editor-plugin-guideline';
 import { selectionPlugin } from '@atlaskit/editor-plugin-selection';
 import { widthPlugin } from '@atlaskit/editor-plugin-width';
@@ -37,7 +36,6 @@ describe('table merging logic', () => {
     createEditor({
       doc,
       preset: new Preset<LightEditorPlugin>()
-        .add([featureFlagsPlugin, {}])
         .add([analyticsPlugin, {}])
         .add(contentInsertionPlugin)
         .add(widthPlugin)

package/src/__tests__/unit/utils/row-controls.ts

@@ -3,7 +3,6 @@ import type { DocBuilder } from '@atlaskit/editor-common/types';
 // eslint-disable-next-line import/no-extraneous-dependencies -- Removed import for fixing circular dependencies
 import { analyticsPlugin } from '@atlaskit/editor-plugin-analytics';
 import { contentInsertionPlugin } from '@atlaskit/editor-plugin-content-insertion';
-import { featureFlagsPlugin } from '@atlaskit/editor-plugin-feature-flags';
 import { guidelinePlugin } from '@atlaskit/editor-plugin-guideline';
 import { selectionPlugin } from '@atlaskit/editor-plugin-selection';
 import { widthPlugin } from '@atlaskit/editor-plugin-width';
@@ -46,7 +45,6 @@ describe('table plugin: utils/row-controls.js', () => {
     createEditor({
       doc,
       preset: new Preset<LightEditorPlugin>()
-        .add([featureFlagsPlugin, {}])
         .add([analyticsPlugin, {}])
         .add(contentInsertionPlugin)
         .add(widthPlugin)

package/src/plugins/table/commands/selection.ts

@@ -17,15 +17,8 @@ import type {
 import { Selection, TextSelection } from '@atlaskit/editor-prosemirror/state';
 import { CellSelection } from '@atlaskit/editor-tables/cell-selection';
 import { TableMap } from '@atlaskit/editor-tables/table-map';
-import {
-  findTable,
-  isColumnSelected,
-  isRowSelected,
-  isTableSelected,
-  selectedRect,
-} from '@atlaskit/editor-tables/utils';
-
-import { selectColumn, selectRow } from '../commands/misc';
+import { findTable, isTableSelected } from '@atlaskit/editor-tables/utils';
+
 import type tablePlugin from '../index';
 import { getClosestSelectionRect } from '../toolbar';
 
@@ -85,60 +78,6 @@ export const arrowRightFromTable =
     return false;
   };
 
-export const selectColumns =
-  (
-    editorSelectionAPI:
-      | ExtractInjectionAPI<typeof tablePlugin>['selection']
-      | undefined,
-  ) =>
-  (): Command =>
-  (state, dispatch) => {
-    const { selection } = state;
-    const table = findTable(selection);
-    const rect = selectedRect(state);
-
-    if (table && isRowSelected(rect.top)(selection)) {
-      return selectFullTable(editorSelectionAPI)({
-        node: table.node,
-        startPos: table.start,
-        dir: TableSelectionDirection.BottomToTop,
-      })(state, dispatch);
-    }
-
-    if (table && rect) {
-      return selectColumn(rect.left)(state, dispatch);
-    }
-
-    return false;
-  };
-
-export const selectRows =
-  (
-    editorSelectionAPI:
-      | ExtractInjectionAPI<typeof tablePlugin>['selection']
-      | undefined,
-  ) =>
-  (): Command =>
-  (state, dispatch) => {
-    const { selection } = state;
-    const table = findTable(selection);
-    const rect = selectedRect(state);
-
-    if (table && isColumnSelected(rect.left)(selection)) {
-      return selectFullTable(editorSelectionAPI)({
-        node: table.node,
-        startPos: table.start,
-        dir: TableSelectionDirection.BottomToTop,
-      })(state, dispatch);
-    }
-
-    if (table && rect) {
-      return selectRow(rect.top)(state, dispatch);
-    }
-
-    return false;
-  };
-
 const arrowLeftFromCellSelection =
   (
     editorSelectionAPI:

package/src/plugins/table/pm-plugins/table-selection-keymap.ts

@@ -2,8 +2,6 @@ import {
   bindKeymapWithCommand,
   moveLeft,
   moveRight,
-  selectColumn,
-  selectRow,
   shiftArrowUp,
 } from '@atlaskit/editor-common/keymaps';
 import type { SafePlugin } from '@atlaskit/editor-common/safe-plugin';
@@ -14,8 +12,6 @@ import { getBooleanFF } from '@atlaskit/platform-feature-flags';
 import {
   arrowLeftFromTable,
   arrowRightFromTable,
-  selectColumns,
-  selectRows,
   shiftArrowUpFromTable,
 } from '../commands/selection';
 import type tablePlugin from '../index';
@@ -47,18 +43,6 @@ export function tableSelectionKeymapPlugin(
     );
   }
 
-  bindKeymapWithCommand(
-    selectColumn.common!,
-    selectColumns(editorSelectionAPI)(),
-    list,
-  );
-
-  bindKeymapWithCommand(
-    selectRow.common!,
-    selectRows(editorSelectionAPI)(),
-    list,
-  );
-
   return keymap(list) as SafePlugin;
 }