@atlaskit/editor-plugin-table 34.0.12 → 34.0.14

package/CHANGELOG.md

@@ -1,5 +1,21 @@
 # @atlaskit/editor-plugin-table
 
+## 34.0.14
+
+### Patch Changes
+
+- [`8d075961b3c2c`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/8d075961b3c2c) -
+  Prevent automatic table width commits in view mode behind
+  `platform_editor_table_view_mode_scaling_fix`.
+- Updated dependencies
+
+## 34.0.13
+
+### Patch Changes
+
+- [`2fa5b04eb1bd2`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/2fa5b04eb1bd2) -
+  Clean up feature gate `platform_editor_table_flicker_issue`
+
 ## 34.0.12
 
 ### Patch Changes

package/dist/cjs/nodeviews/TableComponent.js

@@ -27,6 +27,7 @@ var _utils = require("@atlaskit/editor-common/utils");
 var _editorSharedStyles = require("@atlaskit/editor-shared-styles");
 var _utils2 = require("@atlaskit/editor-tables/utils");
 var _isExperimentEnabled = require("@atlaskit/platform-feature-experiments/is-experiment-enabled");
+var _fg = require("@atlaskit/platform-feature-flags/fg");
 var _combine = require("@atlaskit/pragmatic-drag-and-drop/utils/combine");
 var _expValEquals = require("@atlaskit/tmp-editor-statsig/exp-val-equals");
 var _commands = require("../pm-plugins/commands");
@@ -232,7 +233,11 @@ var TableComponent = /*#__PURE__*/function (_React$Component) {
     });
     // Function gets called when table is nested.
     (0, _defineProperty2.default)(_this, "scaleTable", function (scaleOptions) {
+      var _this$props$pluginInj;
       var isUserTriggered = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : false;
+      if ((0, _fg.fg)('platform_editor_table_view_mode_scaling_fix') && ((_this$props$pluginInj = _this.props.pluginInjectionApi) === null || _this$props$pluginInj === void 0 || (_this$props$pluginInj = _this$props$pluginInj.editorViewMode) === null || _this$props$pluginInj === void 0 || (_this$props$pluginInj = _this$props$pluginInj.sharedState.currentState()) === null || _this$props$pluginInj === void 0 ? void 0 : _this$props$pluginInj.mode) === 'view') {
+        return;
+      }
       var _this$props2 = _this.props,
         view = _this$props2.view,
         getNode = _this$props2.getNode,
@@ -756,8 +761,8 @@ var TableComponent = /*#__PURE__*/function (_React$Component) {
       var isNoOfColumnsChanged = (0, _nodes.tablesHaveDifferentNoOfColumns)(currentTable, previousTable);
       var isNoOfRowsChanged = (0, _nodes.tablesHaveDifferentNoOfRows)(currentTable, previousTable);
       if (isNoOfColumnsChanged || isNoOfRowsChanged) {
-        var _this$props$pluginInj;
-        (_this$props$pluginInj = this.props.pluginInjectionApi) === null || _this$props$pluginInj === void 0 || (_this$props$pluginInj = _this$props$pluginInj.accessibilityUtils) === null || _this$props$pluginInj === void 0 || _this$props$pluginInj.actions.ariaNotify((0, _table2.getAssistiveMessage)(previousTable, currentTable, this.props.intl), {
+        var _this$props$pluginInj2;
+        (_this$props$pluginInj2 = this.props.pluginInjectionApi) === null || _this$props$pluginInj2 === void 0 || (_this$props$pluginInj2 = _this$props$pluginInj2.accessibilityUtils) === null || _this$props$pluginInj2 === void 0 || _this$props$pluginInj2.actions.ariaNotify((0, _table2.getAssistiveMessage)(previousTable, currentTable, this.props.intl), {
           priority: 'important'
         });
       }

package/dist/cjs/nodeviews/TableRow.js

@@ -18,7 +18,6 @@ var _nodeVisibility = require("@atlaskit/editor-common/node-visibility");
 var _ui = require("@atlaskit/editor-common/ui");
 var _utils = require("@atlaskit/editor-prosemirror/utils");
 var _isExperimentEnabled = require("@atlaskit/platform-feature-experiments/is-experiment-enabled");
-var _fg = require("@atlaskit/platform-feature-flags/fg");
 var _expValEquals = require("@atlaskit/tmp-editor-statsig/exp-val-equals");
 var _pluginFactory = require("../pm-plugins/plugin-factory");
 var _pluginKey = require("../pm-plugins/plugin-key");
@@ -616,36 +615,11 @@ var TableRow = exports.default = /*#__PURE__*/function (_TableNodeView) {
       var wrapper = tree.wrapper;
       var tableContainer = wrapper.parentElement;
       var tableContentWrapper = tableContainer === null || tableContainer === void 0 ? void 0 : tableContainer.parentElement;
-      var parentContainer = tableContentWrapper && tableContentWrapper.parentElement;
-      var isTableInsideLayout = parentContainer && parentContainer.getAttribute('data-layout-content');
       if (tableContentWrapper) {
         if (isCurrentTableSelected) {
           this.colControlsOffset = _consts.tableControlsSpacing;
-
-          /**
-           * Adding padding left causes flicker when table is inside layout column
-           * 	and selection moves in/out of table.
-           */
-          if (!(0, _fg.fg)('platform_editor_table_flicker_issue')) {
-            // move table a little out of the way
-            // to provide spacing for table controls
-            if (isTableInsideLayout) {
-              tableContentWrapper.style.paddingLeft = '11px';
-              tableContentWrapper.style.marginLeft = '-11px';
-            }
-          }
         } else {
           this.colControlsOffset = 0;
-          /**
-           * Adding padding left causes flicker when table is inside layout column
-           * 	and selection moves in/out of table.
-           */
-          if (!(0, _fg.fg)('platform_editor_table_flicker_issue')) {
-            if (isTableInsideLayout) {
-              tableContentWrapper.style.removeProperty('padding-left');
-              tableContentWrapper.style.removeProperty('margin-left');
-            }
-          }
         }
       }
 

package/dist/cjs/nodeviews/TableRowNativeStickyWithFallback.js

@@ -20,7 +20,6 @@ var _styles = require("@atlaskit/editor-common/styles");
 var _ui = require("@atlaskit/editor-common/ui");
 var _utils = require("@atlaskit/editor-prosemirror/utils");
 var _isExperimentEnabled = require("@atlaskit/platform-feature-experiments/is-experiment-enabled");
-var _fg = require("@atlaskit/platform-feature-flags/fg");
 var _expValEquals = require("@atlaskit/tmp-editor-statsig/exp-val-equals");
 var _editorContentAreaHeight = require("../pm-plugins/editor-content-area-height");
 var _pluginFactory = require("../pm-plugins/plugin-factory");
@@ -853,34 +852,11 @@ var TableRowNativeStickyWithFallback = exports.default = /*#__PURE__*/function (
       var wrapper = tree.wrapper;
       var tableContainer = wrapper.parentElement;
       var tableContentWrapper = tableContainer === null || tableContainer === void 0 ? void 0 : tableContainer.parentElement;
-      var parentContainer = tableContentWrapper && tableContentWrapper.parentElement;
-      var isTableInsideLayout = parentContainer && parentContainer.getAttribute('data-layout-content');
       if (tableContentWrapper) {
         if (isCurrentTableSelected) {
           this.colControlsOffset = _consts.tableControlsSpacing;
-
-          /**
-           * Adding padding left causes flicker when table is inside layout column
-           * 	and selection moves in/out of table.
-           */
-          if (!(0, _fg.fg)('platform_editor_table_flicker_issue')) {
-            // move table a little out of the way
-            // to provide spacing for table controls
-            if (isTableInsideLayout) {
-              tableContentWrapper.style.paddingLeft = '11px';
-            }
-          }
         } else {
           this.colControlsOffset = 0;
-          /**
-           * Adding padding left causes flicker when table is inside layout column
-           * 	and selection moves in/out of table.
-           */
-          if (!(0, _fg.fg)('platform_editor_table_flicker_issue')) {
-            if (isTableInsideLayout) {
-              tableContentWrapper.style.removeProperty('padding-left');
-            }
-          }
         }
       }
 

package/dist/es2019/nodeviews/TableComponent.js

@@ -14,6 +14,7 @@ import { isValidPosition } from '@atlaskit/editor-common/utils';
 import { akEditorTableNumberColumnWidth } from '@atlaskit/editor-shared-styles';
 import { isTableSelected } from '@atlaskit/editor-tables/utils';
 import { isExperimentEnabled } from '@atlaskit/platform-feature-experiments/is-experiment-enabled';
+import { fg } from '@atlaskit/platform-feature-flags/fg';
 import { combine } from '@atlaskit/pragmatic-drag-and-drop/utils/combine';
 import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 import { autoSizeTable, clearHoverSelection, setTableRef } from '../pm-plugins/commands';
@@ -212,6 +213,10 @@ class TableComponent extends React.Component {
     });
     // Function gets called when table is nested.
     _defineProperty(this, "scaleTable", (scaleOptions, isUserTriggered = false) => {
+      var _this$props$pluginInj, _this$props$pluginInj2, _this$props$pluginInj3;
+      if (fg('platform_editor_table_view_mode_scaling_fix') && ((_this$props$pluginInj = this.props.pluginInjectionApi) === null || _this$props$pluginInj === void 0 ? void 0 : (_this$props$pluginInj2 = _this$props$pluginInj.editorViewMode) === null || _this$props$pluginInj2 === void 0 ? void 0 : (_this$props$pluginInj3 = _this$props$pluginInj2.sharedState.currentState()) === null || _this$props$pluginInj3 === void 0 ? void 0 : _this$props$pluginInj3.mode) === 'view') {
+        return;
+      }
       const {
         view,
         getNode,
@@ -717,8 +722,8 @@ class TableComponent extends React.Component {
     const isNoOfColumnsChanged = tablesHaveDifferentNoOfColumns(currentTable, previousTable);
     const isNoOfRowsChanged = tablesHaveDifferentNoOfRows(currentTable, previousTable);
     if (isNoOfColumnsChanged || isNoOfRowsChanged) {
-      var _this$props$pluginInj, _this$props$pluginInj2;
-      (_this$props$pluginInj = this.props.pluginInjectionApi) === null || _this$props$pluginInj === void 0 ? void 0 : (_this$props$pluginInj2 = _this$props$pluginInj.accessibilityUtils) === null || _this$props$pluginInj2 === void 0 ? void 0 : _this$props$pluginInj2.actions.ariaNotify(getAssistiveMessage(previousTable, currentTable, this.props.intl), {
+      var _this$props$pluginInj4, _this$props$pluginInj5;
+      (_this$props$pluginInj4 = this.props.pluginInjectionApi) === null || _this$props$pluginInj4 === void 0 ? void 0 : (_this$props$pluginInj5 = _this$props$pluginInj4.accessibilityUtils) === null || _this$props$pluginInj5 === void 0 ? void 0 : _this$props$pluginInj5.actions.ariaNotify(getAssistiveMessage(previousTable, currentTable, this.props.intl), {
         priority: 'important'
       });
     }

package/dist/es2019/nodeviews/TableRow.js

@@ -6,7 +6,6 @@ import { nodeVisibilityManager } from '@atlaskit/editor-common/node-visibility';
 import { findOverflowScrollParent } from '@atlaskit/editor-common/ui';
 import { findParentNodeClosestToPos } from '@atlaskit/editor-prosemirror/utils';
 import { isExperimentEnabled } from '@atlaskit/platform-feature-experiments/is-experiment-enabled';
-import { fg } from '@atlaskit/platform-feature-flags/fg';
 import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 import { getPluginState } from '../pm-plugins/plugin-factory';
 import { pluginKey as tablePluginKey } from '../pm-plugins/plugin-key';
@@ -578,36 +577,11 @@ export default class TableRow extends TableNodeView {
     } = tree;
     const tableContainer = wrapper.parentElement;
     const tableContentWrapper = tableContainer === null || tableContainer === void 0 ? void 0 : tableContainer.parentElement;
-    const parentContainer = tableContentWrapper && tableContentWrapper.parentElement;
-    const isTableInsideLayout = parentContainer && parentContainer.getAttribute('data-layout-content');
     if (tableContentWrapper) {
       if (isCurrentTableSelected) {
         this.colControlsOffset = tableControlsSpacing;
-
-        /**
-         * Adding padding left causes flicker when table is inside layout column
-         * 	and selection moves in/out of table.
-         */
-        if (!fg('platform_editor_table_flicker_issue')) {
-          // move table a little out of the way
-          // to provide spacing for table controls
-          if (isTableInsideLayout) {
-            tableContentWrapper.style.paddingLeft = '11px';
-            tableContentWrapper.style.marginLeft = '-11px';
-          }
-        }
       } else {
         this.colControlsOffset = 0;
-        /**
-         * Adding padding left causes flicker when table is inside layout column
-         * 	and selection moves in/out of table.
-         */
-        if (!fg('platform_editor_table_flicker_issue')) {
-          if (isTableInsideLayout) {
-            tableContentWrapper.style.removeProperty('padding-left');
-            tableContentWrapper.style.removeProperty('margin-left');
-          }
-        }
       }
     }
 

package/dist/es2019/nodeviews/TableRowNativeStickyWithFallback.js

@@ -8,7 +8,6 @@ import { tableMarginTop } from '@atlaskit/editor-common/styles';
 import { findOverflowScrollParent } from '@atlaskit/editor-common/ui';
 import { findParentNodeClosestToPos } from '@atlaskit/editor-prosemirror/utils';
 import { isExperimentEnabled } from '@atlaskit/platform-feature-experiments/is-experiment-enabled';
-import { fg } from '@atlaskit/platform-feature-flags/fg';
 import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 import { INITIAL_STATIC_VIEWPORT_HEIGHT } from '../pm-plugins/editor-content-area-height';
 import { getPluginState } from '../pm-plugins/plugin-factory';
@@ -806,34 +805,11 @@ export default class TableRowNativeStickyWithFallback extends TableNodeView {
     } = tree;
     const tableContainer = wrapper.parentElement;
     const tableContentWrapper = tableContainer === null || tableContainer === void 0 ? void 0 : tableContainer.parentElement;
-    const parentContainer = tableContentWrapper && tableContentWrapper.parentElement;
-    const isTableInsideLayout = parentContainer && parentContainer.getAttribute('data-layout-content');
     if (tableContentWrapper) {
       if (isCurrentTableSelected) {
         this.colControlsOffset = tableControlsSpacing;
-
-        /**
-         * Adding padding left causes flicker when table is inside layout column
-         * 	and selection moves in/out of table.
-         */
-        if (!fg('platform_editor_table_flicker_issue')) {
-          // move table a little out of the way
-          // to provide spacing for table controls
-          if (isTableInsideLayout) {
-            tableContentWrapper.style.paddingLeft = '11px';
-          }
-        }
       } else {
         this.colControlsOffset = 0;
-        /**
-         * Adding padding left causes flicker when table is inside layout column
-         * 	and selection moves in/out of table.
-         */
-        if (!fg('platform_editor_table_flicker_issue')) {
-          if (isTableInsideLayout) {
-            tableContentWrapper.style.removeProperty('padding-left');
-          }
-        }
       }
     }
 

package/dist/esm/nodeviews/TableComponent.js

@@ -27,6 +27,7 @@ import { isValidPosition } from '@atlaskit/editor-common/utils';
 import { akEditorTableNumberColumnWidth } from '@atlaskit/editor-shared-styles';
 import { isTableSelected } from '@atlaskit/editor-tables/utils';
 import { isExperimentEnabled } from '@atlaskit/platform-feature-experiments/is-experiment-enabled';
+import { fg } from '@atlaskit/platform-feature-flags/fg';
 import { combine } from '@atlaskit/pragmatic-drag-and-drop/utils/combine';
 import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 import { autoSizeTable, clearHoverSelection, setTableRef } from '../pm-plugins/commands';
@@ -226,7 +227,11 @@ var TableComponent = /*#__PURE__*/function (_React$Component) {
     });
     // Function gets called when table is nested.
     _defineProperty(_this, "scaleTable", function (scaleOptions) {
+      var _this$props$pluginInj;
       var isUserTriggered = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : false;
+      if (fg('platform_editor_table_view_mode_scaling_fix') && ((_this$props$pluginInj = _this.props.pluginInjectionApi) === null || _this$props$pluginInj === void 0 || (_this$props$pluginInj = _this$props$pluginInj.editorViewMode) === null || _this$props$pluginInj === void 0 || (_this$props$pluginInj = _this$props$pluginInj.sharedState.currentState()) === null || _this$props$pluginInj === void 0 ? void 0 : _this$props$pluginInj.mode) === 'view') {
+        return;
+      }
       var _this$props2 = _this.props,
         view = _this$props2.view,
         getNode = _this$props2.getNode,
@@ -750,8 +755,8 @@ var TableComponent = /*#__PURE__*/function (_React$Component) {
       var isNoOfColumnsChanged = tablesHaveDifferentNoOfColumns(currentTable, previousTable);
       var isNoOfRowsChanged = tablesHaveDifferentNoOfRows(currentTable, previousTable);
       if (isNoOfColumnsChanged || isNoOfRowsChanged) {
-        var _this$props$pluginInj;
-        (_this$props$pluginInj = this.props.pluginInjectionApi) === null || _this$props$pluginInj === void 0 || (_this$props$pluginInj = _this$props$pluginInj.accessibilityUtils) === null || _this$props$pluginInj === void 0 || _this$props$pluginInj.actions.ariaNotify(getAssistiveMessage(previousTable, currentTable, this.props.intl), {
+        var _this$props$pluginInj2;
+        (_this$props$pluginInj2 = this.props.pluginInjectionApi) === null || _this$props$pluginInj2 === void 0 || (_this$props$pluginInj2 = _this$props$pluginInj2.accessibilityUtils) === null || _this$props$pluginInj2 === void 0 || _this$props$pluginInj2.actions.ariaNotify(getAssistiveMessage(previousTable, currentTable, this.props.intl), {
           priority: 'important'
         });
       }

package/dist/esm/nodeviews/TableRow.js

@@ -13,7 +13,6 @@ import { nodeVisibilityManager } from '@atlaskit/editor-common/node-visibility';
 import { findOverflowScrollParent } from '@atlaskit/editor-common/ui';
 import { findParentNodeClosestToPos } from '@atlaskit/editor-prosemirror/utils';
 import { isExperimentEnabled } from '@atlaskit/platform-feature-experiments/is-experiment-enabled';
-import { fg } from '@atlaskit/platform-feature-flags/fg';
 import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 import { getPluginState } from '../pm-plugins/plugin-factory';
 import { pluginKey as tablePluginKey } from '../pm-plugins/plugin-key';
@@ -609,36 +608,11 @@ var TableRow = /*#__PURE__*/function (_TableNodeView) {
       var wrapper = tree.wrapper;
       var tableContainer = wrapper.parentElement;
       var tableContentWrapper = tableContainer === null || tableContainer === void 0 ? void 0 : tableContainer.parentElement;
-      var parentContainer = tableContentWrapper && tableContentWrapper.parentElement;
-      var isTableInsideLayout = parentContainer && parentContainer.getAttribute('data-layout-content');
       if (tableContentWrapper) {
         if (isCurrentTableSelected) {
           this.colControlsOffset = tableControlsSpacing;
-
-          /**
-           * Adding padding left causes flicker when table is inside layout column
-           * 	and selection moves in/out of table.
-           */
-          if (!fg('platform_editor_table_flicker_issue')) {
-            // move table a little out of the way
-            // to provide spacing for table controls
-            if (isTableInsideLayout) {
-              tableContentWrapper.style.paddingLeft = '11px';
-              tableContentWrapper.style.marginLeft = '-11px';
-            }
-          }
         } else {
           this.colControlsOffset = 0;
-          /**
-           * Adding padding left causes flicker when table is inside layout column
-           * 	and selection moves in/out of table.
-           */
-          if (!fg('platform_editor_table_flicker_issue')) {
-            if (isTableInsideLayout) {
-              tableContentWrapper.style.removeProperty('padding-left');
-              tableContentWrapper.style.removeProperty('margin-left');
-            }
-          }
         }
       }
 

package/dist/esm/nodeviews/TableRowNativeStickyWithFallback.js

@@ -15,7 +15,6 @@ import { tableMarginTop } from '@atlaskit/editor-common/styles';
 import { findOverflowScrollParent } from '@atlaskit/editor-common/ui';
 import { findParentNodeClosestToPos } from '@atlaskit/editor-prosemirror/utils';
 import { isExperimentEnabled } from '@atlaskit/platform-feature-experiments/is-experiment-enabled';
-import { fg } from '@atlaskit/platform-feature-flags/fg';
 import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 import { INITIAL_STATIC_VIEWPORT_HEIGHT } from '../pm-plugins/editor-content-area-height';
 import { getPluginState } from '../pm-plugins/plugin-factory';
@@ -846,34 +845,11 @@ var TableRowNativeStickyWithFallback = /*#__PURE__*/function (_TableNodeView) {
       var wrapper = tree.wrapper;
       var tableContainer = wrapper.parentElement;
       var tableContentWrapper = tableContainer === null || tableContainer === void 0 ? void 0 : tableContainer.parentElement;
-      var parentContainer = tableContentWrapper && tableContentWrapper.parentElement;
-      var isTableInsideLayout = parentContainer && parentContainer.getAttribute('data-layout-content');
       if (tableContentWrapper) {
         if (isCurrentTableSelected) {
           this.colControlsOffset = tableControlsSpacing;
-
-          /**
-           * Adding padding left causes flicker when table is inside layout column
-           * 	and selection moves in/out of table.
-           */
-          if (!fg('platform_editor_table_flicker_issue')) {
-            // move table a little out of the way
-            // to provide spacing for table controls
-            if (isTableInsideLayout) {
-              tableContentWrapper.style.paddingLeft = '11px';
-            }
-          }
         } else {
           this.colControlsOffset = 0;
-          /**
-           * Adding padding left causes flicker when table is inside layout column
-           * 	and selection moves in/out of table.
-           */
-          if (!fg('platform_editor_table_flicker_issue')) {
-            if (isTableInsideLayout) {
-              tableContentWrapper.style.removeProperty('padding-left');
-            }
-          }
         }
       }
 

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-plugin-table",
-	"version": "34.0.12",
+	"version": "34.0.14",
 	"description": "Table plugin for the @atlaskit/editor",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -99,13 +99,13 @@
 		"platform_editor_table_menu_updates_patch_1": {
 			"type": "boolean"
 		},
-		"platform_editor_table_cell_menu_update": {
+		"platform_editor_table_view_mode_scaling_fix": {
 			"type": "boolean"
 		},
-		"platform-dst-top-layer-tooltip": {
+		"platform_editor_table_cell_menu_update": {
 			"type": "boolean"
 		},
-		"platform_editor_table_flicker_issue": {
+		"platform-dst-top-layer-tooltip": {
 			"type": "boolean"
 		}
 	},