@atlaskit/editor-plugin-table 34.0.11 → 34.0.13

package/CHANGELOG.md

@@ -1,5 +1,18 @@
 # @atlaskit/editor-plugin-table
 
+## 34.0.13
+
+### Patch Changes
+
+- [`2fa5b04eb1bd2`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/2fa5b04eb1bd2) -
+  Clean up feature gate `platform_editor_table_flicker_issue`
+
+## 34.0.12
+
+### Patch Changes
+
+- Updated dependencies
+
 ## 34.0.11
 
 ### Patch Changes

package/dist/cjs/nodeviews/TableRow.js

@@ -18,7 +18,6 @@ var _nodeVisibility = require("@atlaskit/editor-common/node-visibility");
 var _ui = require("@atlaskit/editor-common/ui");
 var _utils = require("@atlaskit/editor-prosemirror/utils");
 var _isExperimentEnabled = require("@atlaskit/platform-feature-experiments/is-experiment-enabled");
-var _fg = require("@atlaskit/platform-feature-flags/fg");
 var _expValEquals = require("@atlaskit/tmp-editor-statsig/exp-val-equals");
 var _pluginFactory = require("../pm-plugins/plugin-factory");
 var _pluginKey = require("../pm-plugins/plugin-key");
@@ -616,36 +615,11 @@ var TableRow = exports.default = /*#__PURE__*/function (_TableNodeView) {
       var wrapper = tree.wrapper;
       var tableContainer = wrapper.parentElement;
       var tableContentWrapper = tableContainer === null || tableContainer === void 0 ? void 0 : tableContainer.parentElement;
-      var parentContainer = tableContentWrapper && tableContentWrapper.parentElement;
-      var isTableInsideLayout = parentContainer && parentContainer.getAttribute('data-layout-content');
       if (tableContentWrapper) {
         if (isCurrentTableSelected) {
           this.colControlsOffset = _consts.tableControlsSpacing;
-
-          /**
-           * Adding padding left causes flicker when table is inside layout column
-           * 	and selection moves in/out of table.
-           */
-          if (!(0, _fg.fg)('platform_editor_table_flicker_issue')) {
-            // move table a little out of the way
-            // to provide spacing for table controls
-            if (isTableInsideLayout) {
-              tableContentWrapper.style.paddingLeft = '11px';
-              tableContentWrapper.style.marginLeft = '-11px';
-            }
-          }
         } else {
           this.colControlsOffset = 0;
-          /**
-           * Adding padding left causes flicker when table is inside layout column
-           * 	and selection moves in/out of table.
-           */
-          if (!(0, _fg.fg)('platform_editor_table_flicker_issue')) {
-            if (isTableInsideLayout) {
-              tableContentWrapper.style.removeProperty('padding-left');
-              tableContentWrapper.style.removeProperty('margin-left');
-            }
-          }
         }
       }
 

package/dist/cjs/nodeviews/TableRowNativeStickyWithFallback.js

@@ -20,7 +20,6 @@ var _styles = require("@atlaskit/editor-common/styles");
 var _ui = require("@atlaskit/editor-common/ui");
 var _utils = require("@atlaskit/editor-prosemirror/utils");
 var _isExperimentEnabled = require("@atlaskit/platform-feature-experiments/is-experiment-enabled");
-var _fg = require("@atlaskit/platform-feature-flags/fg");
 var _expValEquals = require("@atlaskit/tmp-editor-statsig/exp-val-equals");
 var _editorContentAreaHeight = require("../pm-plugins/editor-content-area-height");
 var _pluginFactory = require("../pm-plugins/plugin-factory");
@@ -853,34 +852,11 @@ var TableRowNativeStickyWithFallback = exports.default = /*#__PURE__*/function (
       var wrapper = tree.wrapper;
       var tableContainer = wrapper.parentElement;
       var tableContentWrapper = tableContainer === null || tableContainer === void 0 ? void 0 : tableContainer.parentElement;
-      var parentContainer = tableContentWrapper && tableContentWrapper.parentElement;
-      var isTableInsideLayout = parentContainer && parentContainer.getAttribute('data-layout-content');
       if (tableContentWrapper) {
         if (isCurrentTableSelected) {
           this.colControlsOffset = _consts.tableControlsSpacing;
-
-          /**
-           * Adding padding left causes flicker when table is inside layout column
-           * 	and selection moves in/out of table.
-           */
-          if (!(0, _fg.fg)('platform_editor_table_flicker_issue')) {
-            // move table a little out of the way
-            // to provide spacing for table controls
-            if (isTableInsideLayout) {
-              tableContentWrapper.style.paddingLeft = '11px';
-            }
-          }
         } else {
           this.colControlsOffset = 0;
-          /**
-           * Adding padding left causes flicker when table is inside layout column
-           * 	and selection moves in/out of table.
-           */
-          if (!(0, _fg.fg)('platform_editor_table_flicker_issue')) {
-            if (isTableInsideLayout) {
-              tableContentWrapper.style.removeProperty('padding-left');
-            }
-          }
         }
       }
 

package/dist/es2019/nodeviews/TableRow.js

@@ -6,7 +6,6 @@ import { nodeVisibilityManager } from '@atlaskit/editor-common/node-visibility';
 import { findOverflowScrollParent } from '@atlaskit/editor-common/ui';
 import { findParentNodeClosestToPos } from '@atlaskit/editor-prosemirror/utils';
 import { isExperimentEnabled } from '@atlaskit/platform-feature-experiments/is-experiment-enabled';
-import { fg } from '@atlaskit/platform-feature-flags/fg';
 import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 import { getPluginState } from '../pm-plugins/plugin-factory';
 import { pluginKey as tablePluginKey } from '../pm-plugins/plugin-key';
@@ -578,36 +577,11 @@ export default class TableRow extends TableNodeView {
     } = tree;
     const tableContainer = wrapper.parentElement;
     const tableContentWrapper = tableContainer === null || tableContainer === void 0 ? void 0 : tableContainer.parentElement;
-    const parentContainer = tableContentWrapper && tableContentWrapper.parentElement;
-    const isTableInsideLayout = parentContainer && parentContainer.getAttribute('data-layout-content');
     if (tableContentWrapper) {
       if (isCurrentTableSelected) {
         this.colControlsOffset = tableControlsSpacing;
-
-        /**
-         * Adding padding left causes flicker when table is inside layout column
-         * 	and selection moves in/out of table.
-         */
-        if (!fg('platform_editor_table_flicker_issue')) {
-          // move table a little out of the way
-          // to provide spacing for table controls
-          if (isTableInsideLayout) {
-            tableContentWrapper.style.paddingLeft = '11px';
-            tableContentWrapper.style.marginLeft = '-11px';
-          }
-        }
       } else {
         this.colControlsOffset = 0;
-        /**
-         * Adding padding left causes flicker when table is inside layout column
-         * 	and selection moves in/out of table.
-         */
-        if (!fg('platform_editor_table_flicker_issue')) {
-          if (isTableInsideLayout) {
-            tableContentWrapper.style.removeProperty('padding-left');
-            tableContentWrapper.style.removeProperty('margin-left');
-          }
-        }
       }
     }
 

package/dist/es2019/nodeviews/TableRowNativeStickyWithFallback.js

@@ -8,7 +8,6 @@ import { tableMarginTop } from '@atlaskit/editor-common/styles';
 import { findOverflowScrollParent } from '@atlaskit/editor-common/ui';
 import { findParentNodeClosestToPos } from '@atlaskit/editor-prosemirror/utils';
 import { isExperimentEnabled } from '@atlaskit/platform-feature-experiments/is-experiment-enabled';
-import { fg } from '@atlaskit/platform-feature-flags/fg';
 import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 import { INITIAL_STATIC_VIEWPORT_HEIGHT } from '../pm-plugins/editor-content-area-height';
 import { getPluginState } from '../pm-plugins/plugin-factory';
@@ -806,34 +805,11 @@ export default class TableRowNativeStickyWithFallback extends TableNodeView {
     } = tree;
     const tableContainer = wrapper.parentElement;
     const tableContentWrapper = tableContainer === null || tableContainer === void 0 ? void 0 : tableContainer.parentElement;
-    const parentContainer = tableContentWrapper && tableContentWrapper.parentElement;
-    const isTableInsideLayout = parentContainer && parentContainer.getAttribute('data-layout-content');
     if (tableContentWrapper) {
       if (isCurrentTableSelected) {
         this.colControlsOffset = tableControlsSpacing;
-
-        /**
-         * Adding padding left causes flicker when table is inside layout column
-         * 	and selection moves in/out of table.
-         */
-        if (!fg('platform_editor_table_flicker_issue')) {
-          // move table a little out of the way
-          // to provide spacing for table controls
-          if (isTableInsideLayout) {
-            tableContentWrapper.style.paddingLeft = '11px';
-          }
-        }
       } else {
         this.colControlsOffset = 0;
-        /**
-         * Adding padding left causes flicker when table is inside layout column
-         * 	and selection moves in/out of table.
-         */
-        if (!fg('platform_editor_table_flicker_issue')) {
-          if (isTableInsideLayout) {
-            tableContentWrapper.style.removeProperty('padding-left');
-          }
-        }
       }
     }
 

package/dist/esm/nodeviews/TableRow.js

@@ -13,7 +13,6 @@ import { nodeVisibilityManager } from '@atlaskit/editor-common/node-visibility';
 import { findOverflowScrollParent } from '@atlaskit/editor-common/ui';
 import { findParentNodeClosestToPos } from '@atlaskit/editor-prosemirror/utils';
 import { isExperimentEnabled } from '@atlaskit/platform-feature-experiments/is-experiment-enabled';
-import { fg } from '@atlaskit/platform-feature-flags/fg';
 import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 import { getPluginState } from '../pm-plugins/plugin-factory';
 import { pluginKey as tablePluginKey } from '../pm-plugins/plugin-key';
@@ -609,36 +608,11 @@ var TableRow = /*#__PURE__*/function (_TableNodeView) {
       var wrapper = tree.wrapper;
       var tableContainer = wrapper.parentElement;
       var tableContentWrapper = tableContainer === null || tableContainer === void 0 ? void 0 : tableContainer.parentElement;
-      var parentContainer = tableContentWrapper && tableContentWrapper.parentElement;
-      var isTableInsideLayout = parentContainer && parentContainer.getAttribute('data-layout-content');
       if (tableContentWrapper) {
         if (isCurrentTableSelected) {
           this.colControlsOffset = tableControlsSpacing;
-
-          /**
-           * Adding padding left causes flicker when table is inside layout column
-           * 	and selection moves in/out of table.
-           */
-          if (!fg('platform_editor_table_flicker_issue')) {
-            // move table a little out of the way
-            // to provide spacing for table controls
-            if (isTableInsideLayout) {
-              tableContentWrapper.style.paddingLeft = '11px';
-              tableContentWrapper.style.marginLeft = '-11px';
-            }
-          }
         } else {
           this.colControlsOffset = 0;
-          /**
-           * Adding padding left causes flicker when table is inside layout column
-           * 	and selection moves in/out of table.
-           */
-          if (!fg('platform_editor_table_flicker_issue')) {
-            if (isTableInsideLayout) {
-              tableContentWrapper.style.removeProperty('padding-left');
-              tableContentWrapper.style.removeProperty('margin-left');
-            }
-          }
         }
       }
 

package/dist/esm/nodeviews/TableRowNativeStickyWithFallback.js

@@ -15,7 +15,6 @@ import { tableMarginTop } from '@atlaskit/editor-common/styles';
 import { findOverflowScrollParent } from '@atlaskit/editor-common/ui';
 import { findParentNodeClosestToPos } from '@atlaskit/editor-prosemirror/utils';
 import { isExperimentEnabled } from '@atlaskit/platform-feature-experiments/is-experiment-enabled';
-import { fg } from '@atlaskit/platform-feature-flags/fg';
 import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 import { INITIAL_STATIC_VIEWPORT_HEIGHT } from '../pm-plugins/editor-content-area-height';
 import { getPluginState } from '../pm-plugins/plugin-factory';
@@ -846,34 +845,11 @@ var TableRowNativeStickyWithFallback = /*#__PURE__*/function (_TableNodeView) {
       var wrapper = tree.wrapper;
       var tableContainer = wrapper.parentElement;
       var tableContentWrapper = tableContainer === null || tableContainer === void 0 ? void 0 : tableContainer.parentElement;
-      var parentContainer = tableContentWrapper && tableContentWrapper.parentElement;
-      var isTableInsideLayout = parentContainer && parentContainer.getAttribute('data-layout-content');
       if (tableContentWrapper) {
         if (isCurrentTableSelected) {
           this.colControlsOffset = tableControlsSpacing;
-
-          /**
-           * Adding padding left causes flicker when table is inside layout column
-           * 	and selection moves in/out of table.
-           */
-          if (!fg('platform_editor_table_flicker_issue')) {
-            // move table a little out of the way
-            // to provide spacing for table controls
-            if (isTableInsideLayout) {
-              tableContentWrapper.style.paddingLeft = '11px';
-            }
-          }
         } else {
           this.colControlsOffset = 0;
-          /**
-           * Adding padding left causes flicker when table is inside layout column
-           * 	and selection moves in/out of table.
-           */
-          if (!fg('platform_editor_table_flicker_issue')) {
-            if (isTableInsideLayout) {
-              tableContentWrapper.style.removeProperty('padding-left');
-            }
-          }
         }
       }
 

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-plugin-table",
-	"version": "34.0.11",
+	"version": "34.0.13",
 	"description": "Table plugin for the @atlaskit/editor",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -29,7 +29,7 @@
 		"@atlaskit/editor-plugin-batch-attribute-updates": "^22.0.0",
 		"@atlaskit/editor-plugin-content-insertion": "^22.0.0",
 		"@atlaskit/editor-plugin-editor-viewmode": "^24.0.0",
-		"@atlaskit/editor-plugin-extension": "25.0.9",
+		"@atlaskit/editor-plugin-extension": "25.0.10",
 		"@atlaskit/editor-plugin-guideline": "^22.0.0",
 		"@atlaskit/editor-plugin-interaction": "^36.0.0",
 		"@atlaskit/editor-plugin-limited-mode": "^19.0.0",
@@ -53,7 +53,7 @@
 		"@atlaskit/pragmatic-drag-and-drop-auto-scroll": "^3.2.0",
 		"@atlaskit/pragmatic-drag-and-drop-hitbox": "^3.0.0",
 		"@atlaskit/primitives": "^22.5.0",
-		"@atlaskit/tmp-editor-statsig": "^217.0.0",
+		"@atlaskit/tmp-editor-statsig": "^218.0.0",
 		"@atlaskit/toggle": "^17.3.0",
 		"@atlaskit/tokens": "^20.1.0",
 		"@atlaskit/tooltip": "^24.3.0",
@@ -104,9 +104,6 @@
 		},
 		"platform-dst-top-layer-tooltip": {
 			"type": "boolean"
-		},
-		"platform_editor_table_flicker_issue": {
-			"type": "boolean"
 		}
 	},
 	"devDependencies": {