@atlaskit/editor-plugin-table 28.0.7 → 28.0.8

package/CHANGELOG.md

@@ -1,5 +1,14 @@
 # @atlaskit/editor-plugin-table
 
+## 28.0.8
+
+### Patch Changes
+
+- [`c967639892512`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/c967639892512) -
+  Cleanup experiment `platform_editor_table_q4_patch_5` and permanently restrict sticky table
+  headers to the first header row.
+- Updated dependencies
+
 ## 28.0.7
 
 ### Patch Changes

package/dist/cjs/nodeviews/TableRow.js

@@ -110,17 +110,11 @@ var TableRow = exports.default = /*#__PURE__*/function (_TableNodeView) {
       if (pos) {
         var $pos = view.state.doc.resolve(pos);
         _this.isInNestedTable = (0, _nesting.getParentOfTypeCount)(view.state.schema.nodes.table)($pos) > 1;
-        // Resolve rowIndex only when the flag is on — otherwise it's unused
-        if ((0, _expValEquals.expValEquals)('platform_editor_fix_sticky_header_row', 'isEnabled', true) && !(0, _expValEquals.expValEquals)('platform_editor_table_q4_patch_5', 'isEnabled', true)) {
-          rowIndex = $pos.index();
-        }
       }
     } catch (_unused) {
       // Intentionally swallowed — getPos can return stale positions during AI streaming
     }
-    if ((0, _expValEquals.expValEquals)('platform_editor_table_q4_patch_5', 'isEnabled', true)) {
-      rowIndex = (0, _nodes.getTableRowIndex)(view, getPos);
-    }
+    rowIndex = (0, _nodes.getTableRowIndex)(view, getPos);
     _this.isHeaderRow = (0, _nodes.supportedHeaderRow)(node, rowIndex);
     if (_this.isHeaderRow) {
       _this.dom.setAttribute('data-vc-nvs', 'true');
@@ -167,20 +161,7 @@ var TableRow = exports.default = /*#__PURE__*/function (_TableNodeView) {
 
       // see if we're changing into a header row or
       // changing away from one
-      var rowIndex = 0;
-      if ((0, _expValEquals.expValEquals)('platform_editor_fix_sticky_header_row', 'isEnabled', true)) {
-        try {
-          var pos = this.getPos();
-          if (pos) {
-            rowIndex = this.view.state.doc.resolve(pos).index();
-          }
-        } catch (_unused2) {
-          // Intentionally swallowed — getPos can return stale positions during AI streaming
-        }
-      }
-      if ((0, _expValEquals.expValEquals)('platform_editor_table_q4_patch_5', 'isEnabled', true)) {
-        rowIndex = (0, _nodes.getTableRowIndex)(this.view, this.getPos);
-      }
+      var rowIndex = (0, _nodes.getTableRowIndex)(this.view, this.getPos);
       var newNodeIsHeaderRow = (0, _nodes.supportedHeaderRow)(node, rowIndex);
       if (this.isHeaderRow !== newNodeIsHeaderRow) {
         return false; // re-create nodeview
@@ -516,7 +497,7 @@ var TableRow = exports.default = /*#__PURE__*/function (_TableNodeView) {
                   return false;
                 }
               }
-            } catch (_unused3) {
+            } catch (_unused2) {
               // getPos can return stale positions during AI streaming — fall back to non-sticky
               return false;
             }

package/dist/cjs/nodeviews/TableRowNativeStickyWithFallback.js

@@ -109,12 +109,8 @@ var TableRowNativeStickyWithFallback = exports.default = /*#__PURE__*/function (
         _this.disableNativeSticky = false;
       }
     });
-    if ((0, _expValEquals.expValEquals)('platform_editor_table_q4_patch_5', 'isEnabled', true)) {
-      var rowIndex = (0, _nodes.getTableRowIndex)(view, getPos);
-      _this.isHeaderRow = (0, _nodes.supportedHeaderRow)(node, rowIndex);
-    } else {
-      _this.isHeaderRow = (0, _nodes.supportedHeaderRow)(node);
-    }
+    var rowIndex = (0, _nodes.getTableRowIndex)(view, getPos);
+    _this.isHeaderRow = (0, _nodes.supportedHeaderRow)(node, rowIndex);
     if (_this.isHeaderRow && (0, _expValEquals.expValEquals)('platform_editor_table_q4_patch_4', 'isEnabled', true)) {
       _this.isSingleRowTable = _this.checkIsSingleRowTable();
     }
@@ -207,19 +203,7 @@ var TableRowNativeStickyWithFallback = exports.default = /*#__PURE__*/function (
 
       // see if we're changing into a header row or
       // changing away from one
-      var rowIndex = 0;
-      if ((0, _expValEquals.expValEquals)('platform_editor_table_q4_patch_5', 'isEnabled', true)) {
-        rowIndex = (0, _nodes.getTableRowIndex)(this.view, this.getPos);
-      } else if ((0, _expValEquals.expValEquals)('platform_editor_fix_sticky_header_row', 'isEnabled', true)) {
-        try {
-          var pos = this.getPos();
-          if (pos) {
-            rowIndex = this.view.state.doc.resolve(pos).index();
-          }
-        } catch (_unused2) {
-          // Intentionally swallowed — getPos can return stale positions during AI streaming
-        }
-      }
+      var rowIndex = (0, _nodes.getTableRowIndex)(this.view, this.getPos);
       var newNodeIsHeaderRow = (0, _nodes.supportedHeaderRow)(node, rowIndex);
       if (this.isHeaderRow !== newNodeIsHeaderRow) {
         if (!newNodeIsHeaderRow && this.isHeaderRow) {
@@ -756,7 +740,7 @@ var TableRowNativeStickyWithFallback = exports.default = /*#__PURE__*/function (
                   return false;
                 }
               }
-            } catch (_unused3) {
+            } catch (_unused2) {
               // getPos can return stale positions during AI streaming — fall back to non-sticky
               return false;
             }
@@ -936,7 +920,7 @@ var TableRowNativeStickyWithFallback = exports.default = /*#__PURE__*/function (
           return node.type === _this1.view.state.schema.nodes.table;
         })) === null || _findParentNodeCloses3 === void 0 ? void 0 : _findParentNodeCloses3.node;
         return (tableNode === null || tableNode === void 0 ? void 0 : tableNode.childCount) === 1;
-      } catch (_unused4) {
+      } catch (_unused3) {
         // getPos can return stale positions during AI streaming. Preserve the original sticky
         // header behaviour when the containing table cannot be determined.
         return false;

package/dist/cjs/pm-plugins/utils/nodes.js

@@ -153,7 +153,7 @@ var getTableRowIndex = exports.getTableRowIndex = function getTableRowIndex(view
 
 /**
  * Check if a given node is a header row with this definition:
- *  - the row is the first row when platform_editor_table_q4_patch_5 is enabled
+ *  - the row is the first row
  *  - all children are tableHeader cells
  *  - no table cells have been merged with other table row cells (rowspan > 1)
  *  - no table cells have been merged with other table column cells (colspan > 1),
@@ -167,7 +167,7 @@ var getTableRowIndex = exports.getTableRowIndex = function getTableRowIndex(view
  */
 var supportedHeaderRow = exports.supportedHeaderRow = function supportedHeaderRow(node) {
   var rowIndex = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : 0;
-  if ((0, _expValEquals.expValEquals)('platform_editor_table_q4_patch_5', 'isEnabled', true) && rowIndex !== 0) {
+  if (rowIndex !== 0) {
     return false;
   }
   var allHeaders = (0, _utils.mapChildren)(node, function (child) {

package/dist/es2019/nodeviews/TableRow.js

@@ -95,17 +95,11 @@ export default class TableRow extends TableNodeView {
       if (pos) {
         const $pos = view.state.doc.resolve(pos);
         this.isInNestedTable = getParentOfTypeCount(view.state.schema.nodes.table)($pos) > 1;
-        // Resolve rowIndex only when the flag is on — otherwise it's unused
-        if (expValEquals('platform_editor_fix_sticky_header_row', 'isEnabled', true) && !expValEquals('platform_editor_table_q4_patch_5', 'isEnabled', true)) {
-          rowIndex = $pos.index();
-        }
       }
     } catch {
       // Intentionally swallowed — getPos can return stale positions during AI streaming
     }
-    if (expValEquals('platform_editor_table_q4_patch_5', 'isEnabled', true)) {
-      rowIndex = getTableRowIndex(view, getPos);
-    }
+    rowIndex = getTableRowIndex(view, getPos);
     this.isHeaderRow = supportedHeaderRow(node, rowIndex);
     if (this.isHeaderRow) {
       this.dom.setAttribute('data-vc-nvs', 'true');
@@ -147,20 +141,7 @@ export default class TableRow extends TableNodeView {
 
     // see if we're changing into a header row or
     // changing away from one
-    let rowIndex = 0;
-    if (expValEquals('platform_editor_fix_sticky_header_row', 'isEnabled', true)) {
-      try {
-        const pos = this.getPos();
-        if (pos) {
-          rowIndex = this.view.state.doc.resolve(pos).index();
-        }
-      } catch {
-        // Intentionally swallowed — getPos can return stale positions during AI streaming
-      }
-    }
-    if (expValEquals('platform_editor_table_q4_patch_5', 'isEnabled', true)) {
-      rowIndex = getTableRowIndex(this.view, this.getPos);
-    }
+    const rowIndex = getTableRowIndex(this.view, this.getPos);
     const newNodeIsHeaderRow = supportedHeaderRow(node, rowIndex);
     if (this.isHeaderRow !== newNodeIsHeaderRow) {
       return false; // re-create nodeview

package/dist/es2019/nodeviews/TableRowNativeStickyWithFallback.js

@@ -93,12 +93,8 @@ export default class TableRowNativeStickyWithFallback extends TableNodeView {
         this.disableNativeSticky = false;
       }
     });
-    if (expValEquals('platform_editor_table_q4_patch_5', 'isEnabled', true)) {
-      const rowIndex = getTableRowIndex(view, getPos);
-      this.isHeaderRow = supportedHeaderRow(node, rowIndex);
-    } else {
-      this.isHeaderRow = supportedHeaderRow(node);
-    }
+    const rowIndex = getTableRowIndex(view, getPos);
+    this.isHeaderRow = supportedHeaderRow(node, rowIndex);
     if (this.isHeaderRow && expValEquals('platform_editor_table_q4_patch_4', 'isEnabled', true)) {
       this.isSingleRowTable = this.checkIsSingleRowTable();
     }
@@ -188,19 +184,7 @@ export default class TableRowNativeStickyWithFallback extends TableNodeView {
 
     // see if we're changing into a header row or
     // changing away from one
-    let rowIndex = 0;
-    if (expValEquals('platform_editor_table_q4_patch_5', 'isEnabled', true)) {
-      rowIndex = getTableRowIndex(this.view, this.getPos);
-    } else if (expValEquals('platform_editor_fix_sticky_header_row', 'isEnabled', true)) {
-      try {
-        const pos = this.getPos();
-        if (pos) {
-          rowIndex = this.view.state.doc.resolve(pos).index();
-        }
-      } catch {
-        // Intentionally swallowed — getPos can return stale positions during AI streaming
-      }
-    }
+    const rowIndex = getTableRowIndex(this.view, this.getPos);
     const newNodeIsHeaderRow = supportedHeaderRow(node, rowIndex);
     if (this.isHeaderRow !== newNodeIsHeaderRow) {
       if (!newNodeIsHeaderRow && this.isHeaderRow) {

package/dist/es2019/pm-plugins/utils/nodes.js

@@ -121,7 +121,7 @@ export const getTableRowIndex = (view, getPos) => {
 
 /**
  * Check if a given node is a header row with this definition:
- *  - the row is the first row when platform_editor_table_q4_patch_5 is enabled
+ *  - the row is the first row
  *  - all children are tableHeader cells
  *  - no table cells have been merged with other table row cells (rowspan > 1)
  *  - no table cells have been merged with other table column cells (colspan > 1),
@@ -134,7 +134,7 @@ export const getTableRowIndex = (view, getPos) => {
  * @returns boolean if it meets definition
  */
 export const supportedHeaderRow = (node, rowIndex = 0) => {
-  if (expValEquals('platform_editor_table_q4_patch_5', 'isEnabled', true) && rowIndex !== 0) {
+  if (rowIndex !== 0) {
     return false;
   }
   const allHeaders = mapChildren(node, child => child.type.name === 'tableHeader').every(Boolean);

package/dist/esm/nodeviews/TableRow.js

@@ -103,17 +103,11 @@ var TableRow = /*#__PURE__*/function (_TableNodeView) {
       if (pos) {
         var $pos = view.state.doc.resolve(pos);
         _this.isInNestedTable = getParentOfTypeCount(view.state.schema.nodes.table)($pos) > 1;
-        // Resolve rowIndex only when the flag is on — otherwise it's unused
-        if (expValEquals('platform_editor_fix_sticky_header_row', 'isEnabled', true) && !expValEquals('platform_editor_table_q4_patch_5', 'isEnabled', true)) {
-          rowIndex = $pos.index();
-        }
       }
     } catch (_unused) {
       // Intentionally swallowed — getPos can return stale positions during AI streaming
     }
-    if (expValEquals('platform_editor_table_q4_patch_5', 'isEnabled', true)) {
-      rowIndex = getTableRowIndex(view, getPos);
-    }
+    rowIndex = getTableRowIndex(view, getPos);
     _this.isHeaderRow = supportedHeaderRow(node, rowIndex);
     if (_this.isHeaderRow) {
       _this.dom.setAttribute('data-vc-nvs', 'true');
@@ -160,20 +154,7 @@ var TableRow = /*#__PURE__*/function (_TableNodeView) {
 
       // see if we're changing into a header row or
       // changing away from one
-      var rowIndex = 0;
-      if (expValEquals('platform_editor_fix_sticky_header_row', 'isEnabled', true)) {
-        try {
-          var pos = this.getPos();
-          if (pos) {
-            rowIndex = this.view.state.doc.resolve(pos).index();
-          }
-        } catch (_unused2) {
-          // Intentionally swallowed — getPos can return stale positions during AI streaming
-        }
-      }
-      if (expValEquals('platform_editor_table_q4_patch_5', 'isEnabled', true)) {
-        rowIndex = getTableRowIndex(this.view, this.getPos);
-      }
+      var rowIndex = getTableRowIndex(this.view, this.getPos);
       var newNodeIsHeaderRow = supportedHeaderRow(node, rowIndex);
       if (this.isHeaderRow !== newNodeIsHeaderRow) {
         return false; // re-create nodeview
@@ -509,7 +490,7 @@ var TableRow = /*#__PURE__*/function (_TableNodeView) {
                   return false;
                 }
               }
-            } catch (_unused3) {
+            } catch (_unused2) {
               // getPos can return stale positions during AI streaming — fall back to non-sticky
               return false;
             }

package/dist/esm/nodeviews/TableRowNativeStickyWithFallback.js

@@ -102,12 +102,8 @@ var TableRowNativeStickyWithFallback = /*#__PURE__*/function (_TableNodeView) {
         _this.disableNativeSticky = false;
       }
     });
-    if (expValEquals('platform_editor_table_q4_patch_5', 'isEnabled', true)) {
-      var rowIndex = getTableRowIndex(view, getPos);
-      _this.isHeaderRow = supportedHeaderRow(node, rowIndex);
-    } else {
-      _this.isHeaderRow = supportedHeaderRow(node);
-    }
+    var rowIndex = getTableRowIndex(view, getPos);
+    _this.isHeaderRow = supportedHeaderRow(node, rowIndex);
     if (_this.isHeaderRow && expValEquals('platform_editor_table_q4_patch_4', 'isEnabled', true)) {
       _this.isSingleRowTable = _this.checkIsSingleRowTable();
     }
@@ -200,19 +196,7 @@ var TableRowNativeStickyWithFallback = /*#__PURE__*/function (_TableNodeView) {
 
       // see if we're changing into a header row or
       // changing away from one
-      var rowIndex = 0;
-      if (expValEquals('platform_editor_table_q4_patch_5', 'isEnabled', true)) {
-        rowIndex = getTableRowIndex(this.view, this.getPos);
-      } else if (expValEquals('platform_editor_fix_sticky_header_row', 'isEnabled', true)) {
-        try {
-          var pos = this.getPos();
-          if (pos) {
-            rowIndex = this.view.state.doc.resolve(pos).index();
-          }
-        } catch (_unused2) {
-          // Intentionally swallowed — getPos can return stale positions during AI streaming
-        }
-      }
+      var rowIndex = getTableRowIndex(this.view, this.getPos);
       var newNodeIsHeaderRow = supportedHeaderRow(node, rowIndex);
       if (this.isHeaderRow !== newNodeIsHeaderRow) {
         if (!newNodeIsHeaderRow && this.isHeaderRow) {
@@ -749,7 +733,7 @@ var TableRowNativeStickyWithFallback = /*#__PURE__*/function (_TableNodeView) {
                   return false;
                 }
               }
-            } catch (_unused3) {
+            } catch (_unused2) {
               // getPos can return stale positions during AI streaming — fall back to non-sticky
               return false;
             }
@@ -929,7 +913,7 @@ var TableRowNativeStickyWithFallback = /*#__PURE__*/function (_TableNodeView) {
           return node.type === _this1.view.state.schema.nodes.table;
         })) === null || _findParentNodeCloses3 === void 0 ? void 0 : _findParentNodeCloses3.node;
         return (tableNode === null || tableNode === void 0 ? void 0 : tableNode.childCount) === 1;
-      } catch (_unused4) {
+      } catch (_unused3) {
         // getPos can return stale positions during AI streaming. Preserve the original sticky
         // header behaviour when the containing table cannot be determined.
         return false;

package/dist/esm/pm-plugins/utils/nodes.js

@@ -146,7 +146,7 @@ export var getTableRowIndex = function getTableRowIndex(view, getPos) {
 
 /**
  * Check if a given node is a header row with this definition:
- *  - the row is the first row when platform_editor_table_q4_patch_5 is enabled
+ *  - the row is the first row
  *  - all children are tableHeader cells
  *  - no table cells have been merged with other table row cells (rowspan > 1)
  *  - no table cells have been merged with other table column cells (colspan > 1),
@@ -160,7 +160,7 @@ export var getTableRowIndex = function getTableRowIndex(view, getPos) {
  */
 export var supportedHeaderRow = function supportedHeaderRow(node) {
   var rowIndex = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : 0;
-  if (expValEquals('platform_editor_table_q4_patch_5', 'isEnabled', true) && rowIndex !== 0) {
+  if (rowIndex !== 0) {
     return false;
   }
   var allHeaders = mapChildren(node, function (child) {

package/dist/types/pm-plugins/utils/nodes.d.ts

@@ -21,7 +21,7 @@ export declare const isTableNestedUnderBodiedSyncBlock: (state: EditorState, tab
 export declare const getTableRowIndex: (view: EditorView, getPos: () => number | undefined) => number;
 /**
  * Check if a given node is a header row with this definition:
- *  - the row is the first row when platform_editor_table_q4_patch_5 is enabled
+ *  - the row is the first row
  *  - all children are tableHeader cells
  *  - no table cells have been merged with other table row cells (rowspan > 1)
  *  - no table cells have been merged with other table column cells (colspan > 1),

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-plugin-table",
-	"version": "28.0.7",
+	"version": "28.0.8",
 	"description": "Table plugin for the @atlaskit/editor",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -29,7 +29,7 @@
 		"@atlaskit/editor-plugin-batch-attribute-updates": "^16.0.0",
 		"@atlaskit/editor-plugin-content-insertion": "^16.0.0",
 		"@atlaskit/editor-plugin-editor-viewmode": "^18.0.0",
-		"@atlaskit/editor-plugin-extension": "19.0.5",
+		"@atlaskit/editor-plugin-extension": "19.0.6",
 		"@atlaskit/editor-plugin-guideline": "^16.0.0",
 		"@atlaskit/editor-plugin-interaction": "^27.0.0",
 		"@atlaskit/editor-plugin-limited-mode": "^13.0.0",
@@ -53,7 +53,7 @@
 		"@atlaskit/pragmatic-drag-and-drop-auto-scroll": "^3.1.0",
 		"@atlaskit/pragmatic-drag-and-drop-hitbox": "^2.1.0",
 		"@atlaskit/primitives": "^22.4.0",
-		"@atlaskit/tmp-editor-statsig": "^165.0.0",
+		"@atlaskit/tmp-editor-statsig": "^166.0.0",
 		"@atlaskit/toggle": "^17.2.0",
 		"@atlaskit/tokens": "^16.8.0",
 		"@atlaskit/tooltip": "^24.2.0",