@atlaskit/editor-plugin-table 24.4.5 → 24.4.6

package/CHANGELOG.md

@@ -1,5 +1,14 @@
 # @atlaskit/editor-plugin-table
 
+## 24.4.6
+
+### Patch Changes
+
+- [`d86bd1324d82b`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/d86bd1324d82b) -
+  Fix table cell selection when moving a table with the keyboard shortcut behind the
+  `platform_editor_fix_table_move_shortcut` experiment.
+- Updated dependencies
+
 ## 24.4.5
 
 ### Patch Changes

package/dist/cjs/nodeviews/table.js

@@ -21,6 +21,7 @@ var _table = require("@atlaskit/editor-common/table");
 var _model = require("@atlaskit/editor-prosemirror/model");
 var _state = require("@atlaskit/editor-prosemirror/state");
 var _editorSharedStyles = require("@atlaskit/editor-shared-styles");
+var _cellSelection = require("@atlaskit/editor-tables/cell-selection");
 var _tableMap = require("@atlaskit/editor-tables/table-map");
 var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _expValEquals = require("@atlaskit/tmp-editor-statsig/exp-val-equals");
@@ -143,6 +144,10 @@ var TableView = exports.default = /*#__PURE__*/function (_ReactNodeView) {
 
       // Only proceed if we have both a node and table, and the table isn't already inside the node
       if (node && this.table && !node.contains(this.table)) {
+        // Patch to prevent selection collapsing when moving the table down with ctrl + shift + down
+        var selectionBeforeMove = this.view.state.selection;
+        var shouldPreserveCellSelection = (0, _expValEquals.expValEquals)('platform_editor_fix_table_move_shortcut', 'isEnabled', true) && selectionBeforeMove instanceof _cellSelection.CellSelection;
+
         // Store the current ignoreMutation handler so we can restore it later
         oldIgnoreMutation = this.ignoreMutation;
 
@@ -154,7 +159,7 @@ var TableView = exports.default = /*#__PURE__*/function (_ReactNodeView) {
           if (!isSelectionMutation) {
             mutationsIgnored = true;
           }
-          return !isSelectionMutation;
+          return !isSelectionMutation || shouldPreserveCellSelection && _this2.view.state.selection.eq(selectionBeforeMove);
         };
 
         // Store the current selection state if there is a visible selection

package/dist/es2019/nodeviews/table.js

@@ -7,6 +7,7 @@ import { isTableInContentMode } from '@atlaskit/editor-common/table';
 import { DOMSerializer } from '@atlaskit/editor-prosemirror/model';
 import { TextSelection } from '@atlaskit/editor-prosemirror/state';
 import { akEditorTableNumberColumnWidth } from '@atlaskit/editor-shared-styles';
+import { CellSelection } from '@atlaskit/editor-tables/cell-selection';
 import { TableMap } from '@atlaskit/editor-tables/table-map';
 import { fg } from '@atlaskit/platform-feature-flags';
 import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
@@ -113,6 +114,10 @@ export default class TableView extends ReactNodeView {
 
     // Only proceed if we have both a node and table, and the table isn't already inside the node
     if (node && this.table && !node.contains(this.table)) {
+      // Patch to prevent selection collapsing when moving the table down with ctrl + shift + down
+      const selectionBeforeMove = this.view.state.selection;
+      const shouldPreserveCellSelection = expValEquals('platform_editor_fix_table_move_shortcut', 'isEnabled', true) && selectionBeforeMove instanceof CellSelection;
+
       // Store the current ignoreMutation handler so we can restore it later
       oldIgnoreMutation = this.ignoreMutation;
 
@@ -124,7 +129,7 @@ export default class TableView extends ReactNodeView {
         if (!isSelectionMutation) {
           mutationsIgnored = true;
         }
-        return !isSelectionMutation;
+        return !isSelectionMutation || shouldPreserveCellSelection && this.view.state.selection.eq(selectionBeforeMove);
       };
 
       // Store the current selection state if there is a visible selection

package/dist/esm/nodeviews/table.js

@@ -17,6 +17,7 @@ import { isTableInContentMode } from '@atlaskit/editor-common/table';
 import { DOMSerializer } from '@atlaskit/editor-prosemirror/model';
 import { TextSelection } from '@atlaskit/editor-prosemirror/state';
 import { akEditorTableNumberColumnWidth } from '@atlaskit/editor-shared-styles';
+import { CellSelection } from '@atlaskit/editor-tables/cell-selection';
 import { TableMap } from '@atlaskit/editor-tables/table-map';
 import { fg } from '@atlaskit/platform-feature-flags';
 import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
@@ -136,6 +137,10 @@ var TableView = /*#__PURE__*/function (_ReactNodeView) {
 
       // Only proceed if we have both a node and table, and the table isn't already inside the node
       if (node && this.table && !node.contains(this.table)) {
+        // Patch to prevent selection collapsing when moving the table down with ctrl + shift + down
+        var selectionBeforeMove = this.view.state.selection;
+        var shouldPreserveCellSelection = expValEquals('platform_editor_fix_table_move_shortcut', 'isEnabled', true) && selectionBeforeMove instanceof CellSelection;
+
         // Store the current ignoreMutation handler so we can restore it later
         oldIgnoreMutation = this.ignoreMutation;
 
@@ -147,7 +152,7 @@ var TableView = /*#__PURE__*/function (_ReactNodeView) {
           if (!isSelectionMutation) {
             mutationsIgnored = true;
           }
-          return !isSelectionMutation;
+          return !isSelectionMutation || shouldPreserveCellSelection && _this2.view.state.selection.eq(selectionBeforeMove);
         };
 
         // Store the current selection state if there is a visible selection

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-plugin-table",
-	"version": "24.4.5",
+	"version": "24.4.6",
 	"description": "Table plugin for the @atlaskit/editor",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -52,7 +52,7 @@
 		"@atlaskit/pragmatic-drag-and-drop-auto-scroll": "^3.0.0",
 		"@atlaskit/pragmatic-drag-and-drop-hitbox": "^2.0.0",
 		"@atlaskit/primitives": "^20.6.0",
-		"@atlaskit/tmp-editor-statsig": "^125.0.0",
+		"@atlaskit/tmp-editor-statsig": "^125.1.0",
 		"@atlaskit/toggle": "^17.1.0",
 		"@atlaskit/tokens": "^15.8.0",
 		"@atlaskit/tooltip": "^23.1.0",