@atlaskit/editor-plugin-table 23.3.2 → 23.3.4

package/CHANGELOG.md

@@ -1,5 +1,31 @@
 # @atlaskit/editor-plugin-table
 
+## 23.3.4
+
+### Patch Changes
+
+- [`a4f97c853dccf`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/a4f97c853dccf) -
+  Extend `no-module-level-eval` lint rule to cover editor experiment APIs (`expValEquals`, `expVal`,
+  `editorExperiment`, `expValEqualsNoExposure`) imported from `@atlaskit/tmp-editor-statsig`
+  subpaths. Module-level evaluation of these functions causes flakiness because experiment values
+  may not be resolved yet at import time.
+
+  Fix existing violations in `editor-plugin-block-controls` (`global-styles.tsx`) and
+  `editor-plugin-table` (`ContextualMenu.tsx`) by converting module-level experiment evaluations to
+  lazy function calls.
+
+  Clean up fully-launched experiment `platform_editor_unify_native_dnd_selectors` — replace
+  conditional selector logic with the winning `dragHandlerAnchorSelectorWithTaskExclusion` value and
+  remove the experiment from `experiments-config.ts`.
+
+- Updated dependencies
+
+## 23.3.3
+
+### Patch Changes
+
+- Updated dependencies
+
 ## 23.3.2
 
 ### Patch Changes

package/dist/cjs/ui/FloatingContextualMenu/ContextualMenu.js

@@ -15,6 +15,7 @@ var _inherits2 = _interopRequireDefault(require("@babel/runtime/helpers/inherits
 var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/defineProperty"));
 var _react = _interopRequireWildcard(require("react"));
 var _react2 = require("@emotion/react");
+var _memoizeOne = _interopRequireDefault(require("memoize-one"));
 var _reactIntl = require("react-intl");
 var _customSteps = require("@atlaskit/custom-steps");
 var _analytics = require("@atlaskit/editor-common/analytics");
@@ -59,7 +60,6 @@ function _isNativeReflectConstruct() { try { var t = !Boolean.prototype.valueOf.
  * @jsxRuntime classic
  * @jsx jsx
  */ /* eslint-disable @typescript-eslint/consistent-type-imports, @atlaskit/ui-styling-standard/use-compiled -- Ignored via go/DSP-18766; jsx required at runtime for @jsxRuntime classic */ // eslint-disable-next-line @atlaskit/design-system/no-emotion-primitives -- to be migrated to @atlaskit/primitives/compiled – go/akcss
-var arrowsList = new Set(!(0, _expValEquals.expValEquals)('platform_editor_toolbar_submenu_open_click', 'isEnabled', true) ? ['ArrowRight', 'ArrowLeft'] : ['ArrowRight']);
 var dropdownMenuSection = {
   hasSeparator: true
 };
@@ -67,6 +67,10 @@ var elementBeforeIconStyles = (0, _primitives.xcss)({
   marginRight: 'space.negative.075',
   display: 'flex'
 });
+var getArrowsList = (0, _memoizeOne.default)(function () {
+  return new Set(!(0, _expValEquals.expValEquals)('platform_editor_toolbar_submenu_open_click', 'isEnabled', true) ? ['ArrowRight', 'ArrowLeft'] : ['ArrowRight']);
+});
+
 // eslint-disable-next-line @repo/internal/react/no-class-components
 var ContextualMenu = exports.ContextualMenu = /*#__PURE__*/function (_Component) {
   function ContextualMenu() {
@@ -569,7 +573,7 @@ var ContextualMenu = exports.ContextualMenu = /*#__PURE__*/function (_Component)
         var event = payload.event;
         if (event && event instanceof KeyboardEvent) {
           if (!_this.state.isSubmenuOpen) {
-            if (arrowsList.has(event.key)) {
+            if (getArrowsList().has(event.key)) {
               // preventing default behavior for avoiding cursor jump to next/previous table column
               // when left/right arrow pressed.
               event.preventDefault();

package/dist/es2019/ui/FloatingContextualMenu/ContextualMenu.js

@@ -4,9 +4,12 @@ import _defineProperty from "@babel/runtime/helpers/defineProperty";
  * @jsxRuntime classic
  * @jsx jsx
  */
+
 import React, { Component } from 'react';
+
 /* eslint-disable @typescript-eslint/consistent-type-imports, @atlaskit/ui-styling-standard/use-compiled -- Ignored via go/DSP-18766; jsx required at runtime for @jsxRuntime classic */
 import { jsx } from '@emotion/react';
+import memoizeOne from 'memoize-one';
 import { injectIntl } from 'react-intl';
 import { TableSortOrder as SortOrder } from '@atlaskit/custom-steps';
 import { INPUT_METHOD } from '@atlaskit/editor-common/analytics';
@@ -44,7 +47,6 @@ import { getMergedCellsPositions } from '../../pm-plugins/utils/table';
 import { TableCssClassName as ClassName } from '../../types';
 import { colorPalletteColumns, contextualMenuDropdownWidthDnD } from '../consts';
 import { cellColourPreviewStyles } from './styles';
-const arrowsList = new Set(!expValEquals('platform_editor_toolbar_submenu_open_click', 'isEnabled', true) ? ['ArrowRight', 'ArrowLeft'] : ['ArrowRight']);
 const dropdownMenuSection = {
   hasSeparator: true
 };
@@ -52,6 +54,8 @@ const elementBeforeIconStyles = xcss({
   marginRight: 'space.negative.075',
   display: 'flex'
 });
+const getArrowsList = memoizeOne(() => new Set(!expValEquals('platform_editor_toolbar_submenu_open_click', 'isEnabled', true) ? ['ArrowRight', 'ArrowLeft'] : ['ArrowRight']));
+
 // eslint-disable-next-line @repo/internal/react/no-class-components
 export class ContextualMenu extends Component {
   constructor(...args) {
@@ -605,7 +609,7 @@ export class ContextualMenu extends Component {
         } = payload;
         if (event && event instanceof KeyboardEvent) {
           if (!this.state.isSubmenuOpen) {
-            if (arrowsList.has(event.key)) {
+            if (getArrowsList().has(event.key)) {
               // preventing default behavior for avoiding cursor jump to next/previous table column
               // when left/right arrow pressed.
               event.preventDefault();

package/dist/esm/ui/FloatingContextualMenu/ContextualMenu.js

@@ -14,9 +14,12 @@ function _isNativeReflectConstruct() { try { var t = !Boolean.prototype.valueOf.
  * @jsxRuntime classic
  * @jsx jsx
  */
+
 import React, { Component } from 'react';
+
 /* eslint-disable @typescript-eslint/consistent-type-imports, @atlaskit/ui-styling-standard/use-compiled -- Ignored via go/DSP-18766; jsx required at runtime for @jsxRuntime classic */
 import { jsx } from '@emotion/react';
+import memoizeOne from 'memoize-one';
 import { injectIntl } from 'react-intl';
 import { TableSortOrder as SortOrder } from '@atlaskit/custom-steps';
 import { INPUT_METHOD } from '@atlaskit/editor-common/analytics';
@@ -54,7 +57,6 @@ import { getMergedCellsPositions } from '../../pm-plugins/utils/table';
 import { TableCssClassName as ClassName } from '../../types';
 import { colorPalletteColumns, contextualMenuDropdownWidthDnD } from '../consts';
 import { cellColourPreviewStyles } from './styles';
-var arrowsList = new Set(!expValEquals('platform_editor_toolbar_submenu_open_click', 'isEnabled', true) ? ['ArrowRight', 'ArrowLeft'] : ['ArrowRight']);
 var dropdownMenuSection = {
   hasSeparator: true
 };
@@ -62,6 +64,10 @@ var elementBeforeIconStyles = xcss({
   marginRight: 'space.negative.075',
   display: 'flex'
 });
+var getArrowsList = memoizeOne(function () {
+  return new Set(!expValEquals('platform_editor_toolbar_submenu_open_click', 'isEnabled', true) ? ['ArrowRight', 'ArrowLeft'] : ['ArrowRight']);
+});
+
 // eslint-disable-next-line @repo/internal/react/no-class-components
 export var ContextualMenu = /*#__PURE__*/function (_Component) {
   function ContextualMenu() {
@@ -564,7 +570,7 @@ export var ContextualMenu = /*#__PURE__*/function (_Component) {
         var event = payload.event;
         if (event && event instanceof KeyboardEvent) {
           if (!_this.state.isSubmenuOpen) {
-            if (arrowsList.has(event.key)) {
+            if (getArrowsList().has(event.key)) {
               // preventing default behavior for avoiding cursor jump to next/previous table column
               // when left/right arrow pressed.
               event.preventDefault();

package/dist/types/ui/FloatingContextualMenu/ContextualMenu.d.ts

@@ -1,7 +1,3 @@
-/**
- * @jsxRuntime classic
- * @jsx jsx
- */
 import React, { Component } from 'react';
 import { jsx } from '@emotion/react';
 import type { WithIntlProps, WrappedComponentProps } from 'react-intl';

package/dist/types-ts4.5/ui/FloatingContextualMenu/ContextualMenu.d.ts

@@ -1,7 +1,3 @@
-/**
- * @jsxRuntime classic
- * @jsx jsx
- */
 import React, { Component } from 'react';
 import { jsx } from '@emotion/react';
 import type { WithIntlProps, WrappedComponentProps } from 'react-intl';

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-plugin-table",
-	"version": "23.3.2",
+	"version": "23.3.4",
 	"description": "Table plugin for the @atlaskit/editor",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -37,7 +37,7 @@
 		"@atlaskit/editor-plugin-batch-attribute-updates": "^11.0.0",
 		"@atlaskit/editor-plugin-content-insertion": "^11.0.0",
 		"@atlaskit/editor-plugin-editor-viewmode": "^13.0.0",
-		"@atlaskit/editor-plugin-extension": "14.1.3",
+		"@atlaskit/editor-plugin-extension": "14.1.4",
 		"@atlaskit/editor-plugin-guideline": "^11.0.0",
 		"@atlaskit/editor-plugin-interaction": "^20.0.0",
 		"@atlaskit/editor-plugin-limited-mode": "^8.0.0",
@@ -60,7 +60,7 @@
 		"@atlaskit/pragmatic-drag-and-drop-auto-scroll": "^2.1.0",
 		"@atlaskit/pragmatic-drag-and-drop-hitbox": "^1.2.0",
 		"@atlaskit/primitives": "^19.0.0",
-		"@atlaskit/tmp-editor-statsig": "^92.0.0",
+		"@atlaskit/tmp-editor-statsig": "^93.0.0",
 		"@atlaskit/toggle": "^16.1.0",
 		"@atlaskit/tokens": "^13.3.0",
 		"@atlaskit/tooltip": "^22.6.0",