@atlaskit/editor-plugin-table 23.1.1 → 23.1.2

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # @atlaskit/editor-plugin-table
 
+## 23.1.2
+
+### Patch Changes
+
+- [`cac6bd11a2e56`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/cac6bd11a2e56) -
+  CCI-16976 Fixed position out of range error coming from table behind feature gate
+  platform_editor_ai_table_ai_streaming_pos_fix
+
 ## 23.1.1
 
 ### Patch Changes

package/dist/cjs/nodeviews/TableRow.js

@@ -17,6 +17,7 @@ var _nesting = require("@atlaskit/editor-common/nesting");
 var _nodeVisibility = require("@atlaskit/editor-common/node-visibility");
 var _ui = require("@atlaskit/editor-common/ui");
 var _utils = require("@atlaskit/editor-prosemirror/utils");
+var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _pluginFactory = require("../pm-plugins/plugin-factory");
 var _pluginKey = require("../pm-plugins/plugin-key");
 var _commands = require("../pm-plugins/sticky-headers/commands");
@@ -476,17 +477,38 @@ var TableRow = exports.default = /*#__PURE__*/function (_TableNodeView) {
       navigator.userAgent.includes('AppleWebKit') && !navigator.userAgent.includes('Chrome')) {
         var pos = this.getPos();
         if (typeof pos === 'number') {
-          var $tableRowPos = this.view.state.doc.resolve(pos);
-
-          // layout -> layout column -> table -> table row
-          if ($tableRowPos.depth >= 3) {
-            var _findParentNodeCloses;
-            var isInsideLayout = (_findParentNodeCloses = (0, _utils.findParentNodeClosestToPos)($tableRowPos, function (node) {
-              return node.type.name === 'layoutColumn';
-            })) === null || _findParentNodeCloses === void 0 ? void 0 : _findParentNodeCloses.node;
-            if (isInsideLayout) {
+          if ((0, _platformFeatureFlags.fg)('platform_editor_ai_table_ai_streaming_pos_fix')) {
+            try {
+              // getPos can return stale positions during AI streaming which cannot be resolved
+              var $tableRowPos = this.view.state.doc.resolve(pos);
+
+              // layout -> layout column -> table -> table row
+              if ($tableRowPos.depth >= 3) {
+                var _findParentNodeCloses;
+                var isInsideLayout = (_findParentNodeCloses = (0, _utils.findParentNodeClosestToPos)($tableRowPos, function (node) {
+                  return node.type.name === 'layoutColumn';
+                })) === null || _findParentNodeCloses === void 0 ? void 0 : _findParentNodeCloses.node;
+                if (isInsideLayout) {
+                  return false;
+                }
+              }
+            } catch (_unused2) {
+              // getPos can return stale positions during AI streaming — fall back to non-sticky
               return false;
             }
+          } else {
+            var _$tableRowPos = this.view.state.doc.resolve(pos);
+
+            // layout -> layout column -> table -> table row
+            if (_$tableRowPos.depth >= 3) {
+              var _findParentNodeCloses2;
+              var _isInsideLayout = (_findParentNodeCloses2 = (0, _utils.findParentNodeClosestToPos)(_$tableRowPos, function (node) {
+                return node.type.name === 'layoutColumn';
+              })) === null || _findParentNodeCloses2 === void 0 ? void 0 : _findParentNodeCloses2.node;
+              if (_isInsideLayout) {
+                return false;
+              }
+            }
           }
         }
       }

package/dist/cjs/nodeviews/TableRowNativeStickyWithFallback.js

@@ -121,8 +121,22 @@ var TableRowNativeStickyWithFallback = exports.default = /*#__PURE__*/function (
     }
     var pos = _this.getPos();
     _this.isInNestedTable = false;
-    if (pos) {
-      _this.isInNestedTable = (0, _nesting.getParentOfTypeCount)(view.state.schema.nodes.table)(view.state.doc.resolve(pos)) > 1;
+    if ((0, _platformFeatureFlags.fg)('platform_editor_ai_table_ai_streaming_pos_fix')) {
+      try {
+        // We cannot trust that the value from getPos will be defined
+        // https://discuss.prosemirror.net/t/getpos-is-undefined-in-nodeview-constructor/1246/4
+        // There are also scenarios where the value it brings back does not tally with the current doc
+        // E.g. when AI streaming brings in new content, this position brings back incorrect values that cannot be resolved
+        if (pos) {
+          _this.isInNestedTable = (0, _nesting.getParentOfTypeCount)(view.state.schema.nodes.table)(view.state.doc.resolve(pos)) > 1;
+        }
+      } catch (_unused) {
+        // Intentionally swallowed — getPos can return stale positions during AI streaming
+      }
+    } else {
+      if (pos) {
+        _this.isInNestedTable = (0, _nesting.getParentOfTypeCount)(view.state.schema.nodes.table)(view.state.doc.resolve(pos)) > 1;
+      }
     }
     if (_this.isHeaderRow) {
       _this.dom.setAttribute('data-vc-nvs', 'true');
@@ -711,17 +725,38 @@ var TableRowNativeStickyWithFallback = exports.default = /*#__PURE__*/function (
       navigator.userAgent.includes('AppleWebKit') && !navigator.userAgent.includes('Chrome')) {
         var pos = this.getPos();
         if (typeof pos === 'number') {
-          var $tableRowPos = this.view.state.doc.resolve(pos);
-
-          // layout -> layout column -> table -> table row
-          if ($tableRowPos.depth >= 3) {
-            var _findParentNodeCloses;
-            var isInsideLayout = (_findParentNodeCloses = (0, _utils.findParentNodeClosestToPos)($tableRowPos, function (node) {
-              return node.type.name === 'layoutColumn';
-            })) === null || _findParentNodeCloses === void 0 ? void 0 : _findParentNodeCloses.node;
-            if (isInsideLayout) {
+          if ((0, _platformFeatureFlags.fg)('platform_editor_ai_table_ai_streaming_pos_fix')) {
+            try {
+              // getPos can return stale positions during AI streaming which cannot be resolved
+              var $tableRowPos = this.view.state.doc.resolve(pos);
+
+              // layout -> layout column -> table -> table row
+              if ($tableRowPos.depth >= 3) {
+                var _findParentNodeCloses;
+                var isInsideLayout = (_findParentNodeCloses = (0, _utils.findParentNodeClosestToPos)($tableRowPos, function (node) {
+                  return node.type.name === 'layoutColumn';
+                })) === null || _findParentNodeCloses === void 0 ? void 0 : _findParentNodeCloses.node;
+                if (isInsideLayout) {
+                  return false;
+                }
+              }
+            } catch (_unused2) {
+              // getPos can return stale positions during AI streaming — fall back to non-sticky
               return false;
             }
+          } else {
+            var _$tableRowPos = this.view.state.doc.resolve(pos);
+
+            // layout -> layout column -> table -> table row
+            if (_$tableRowPos.depth >= 3) {
+              var _findParentNodeCloses2;
+              var _isInsideLayout = (_findParentNodeCloses2 = (0, _utils.findParentNodeClosestToPos)(_$tableRowPos, function (node) {
+                return node.type.name === 'layoutColumn';
+              })) === null || _findParentNodeCloses2 === void 0 ? void 0 : _findParentNodeCloses2.node;
+              if (_isInsideLayout) {
+                return false;
+              }
+            }
           }
         }
       }

package/dist/es2019/nodeviews/TableRow.js

@@ -5,6 +5,7 @@ import { getParentOfTypeCount } from '@atlaskit/editor-common/nesting';
 import { nodeVisibilityManager } from '@atlaskit/editor-common/node-visibility';
 import { findOverflowScrollParent } from '@atlaskit/editor-common/ui';
 import { findParentNodeClosestToPos } from '@atlaskit/editor-prosemirror/utils';
+import { fg } from '@atlaskit/platform-feature-flags';
 import { getPluginState } from '../pm-plugins/plugin-factory';
 import { pluginKey as tablePluginKey } from '../pm-plugins/plugin-key';
 import { updateStickyState } from '../pm-plugins/sticky-headers/commands';
@@ -437,17 +438,38 @@ export default class TableRow extends TableNodeView {
     navigator.userAgent.includes('AppleWebKit') && !navigator.userAgent.includes('Chrome')) {
       const pos = this.getPos();
       if (typeof pos === 'number') {
-        const $tableRowPos = this.view.state.doc.resolve(pos);
-
-        // layout -> layout column -> table -> table row
-        if ($tableRowPos.depth >= 3) {
-          var _findParentNodeCloses;
-          const isInsideLayout = (_findParentNodeCloses = findParentNodeClosestToPos($tableRowPos, node => {
-            return node.type.name === 'layoutColumn';
-          })) === null || _findParentNodeCloses === void 0 ? void 0 : _findParentNodeCloses.node;
-          if (isInsideLayout) {
+        if (fg('platform_editor_ai_table_ai_streaming_pos_fix')) {
+          try {
+            // getPos can return stale positions during AI streaming which cannot be resolved
+            const $tableRowPos = this.view.state.doc.resolve(pos);
+
+            // layout -> layout column -> table -> table row
+            if ($tableRowPos.depth >= 3) {
+              var _findParentNodeCloses;
+              const isInsideLayout = (_findParentNodeCloses = findParentNodeClosestToPos($tableRowPos, node => {
+                return node.type.name === 'layoutColumn';
+              })) === null || _findParentNodeCloses === void 0 ? void 0 : _findParentNodeCloses.node;
+              if (isInsideLayout) {
+                return false;
+              }
+            }
+          } catch {
+            // getPos can return stale positions during AI streaming — fall back to non-sticky
             return false;
           }
+        } else {
+          const $tableRowPos = this.view.state.doc.resolve(pos);
+
+          // layout -> layout column -> table -> table row
+          if ($tableRowPos.depth >= 3) {
+            var _findParentNodeCloses2;
+            const isInsideLayout = (_findParentNodeCloses2 = findParentNodeClosestToPos($tableRowPos, node => {
+              return node.type.name === 'layoutColumn';
+            })) === null || _findParentNodeCloses2 === void 0 ? void 0 : _findParentNodeCloses2.node;
+            if (isInsideLayout) {
+              return false;
+            }
+          }
         }
       }
     }

package/dist/es2019/nodeviews/TableRowNativeStickyWithFallback.js

@@ -106,8 +106,22 @@ export default class TableRowNativeStickyWithFallback extends TableNodeView {
     }
     const pos = this.getPos();
     this.isInNestedTable = false;
-    if (pos) {
-      this.isInNestedTable = getParentOfTypeCount(view.state.schema.nodes.table)(view.state.doc.resolve(pos)) > 1;
+    if (fg('platform_editor_ai_table_ai_streaming_pos_fix')) {
+      try {
+        // We cannot trust that the value from getPos will be defined
+        // https://discuss.prosemirror.net/t/getpos-is-undefined-in-nodeview-constructor/1246/4
+        // There are also scenarios where the value it brings back does not tally with the current doc
+        // E.g. when AI streaming brings in new content, this position brings back incorrect values that cannot be resolved
+        if (pos) {
+          this.isInNestedTable = getParentOfTypeCount(view.state.schema.nodes.table)(view.state.doc.resolve(pos)) > 1;
+        }
+      } catch {
+        // Intentionally swallowed — getPos can return stale positions during AI streaming
+      }
+    } else {
+      if (pos) {
+        this.isInNestedTable = getParentOfTypeCount(view.state.schema.nodes.table)(view.state.doc.resolve(pos)) > 1;
+      }
     }
     if (this.isHeaderRow) {
       this.dom.setAttribute('data-vc-nvs', 'true');
@@ -663,17 +677,38 @@ export default class TableRowNativeStickyWithFallback extends TableNodeView {
     navigator.userAgent.includes('AppleWebKit') && !navigator.userAgent.includes('Chrome')) {
       const pos = this.getPos();
       if (typeof pos === 'number') {
-        const $tableRowPos = this.view.state.doc.resolve(pos);
-
-        // layout -> layout column -> table -> table row
-        if ($tableRowPos.depth >= 3) {
-          var _findParentNodeCloses;
-          const isInsideLayout = (_findParentNodeCloses = findParentNodeClosestToPos($tableRowPos, node => {
-            return node.type.name === 'layoutColumn';
-          })) === null || _findParentNodeCloses === void 0 ? void 0 : _findParentNodeCloses.node;
-          if (isInsideLayout) {
+        if (fg('platform_editor_ai_table_ai_streaming_pos_fix')) {
+          try {
+            // getPos can return stale positions during AI streaming which cannot be resolved
+            const $tableRowPos = this.view.state.doc.resolve(pos);
+
+            // layout -> layout column -> table -> table row
+            if ($tableRowPos.depth >= 3) {
+              var _findParentNodeCloses;
+              const isInsideLayout = (_findParentNodeCloses = findParentNodeClosestToPos($tableRowPos, node => {
+                return node.type.name === 'layoutColumn';
+              })) === null || _findParentNodeCloses === void 0 ? void 0 : _findParentNodeCloses.node;
+              if (isInsideLayout) {
+                return false;
+              }
+            }
+          } catch {
+            // getPos can return stale positions during AI streaming — fall back to non-sticky
             return false;
           }
+        } else {
+          const $tableRowPos = this.view.state.doc.resolve(pos);
+
+          // layout -> layout column -> table -> table row
+          if ($tableRowPos.depth >= 3) {
+            var _findParentNodeCloses2;
+            const isInsideLayout = (_findParentNodeCloses2 = findParentNodeClosestToPos($tableRowPos, node => {
+              return node.type.name === 'layoutColumn';
+            })) === null || _findParentNodeCloses2 === void 0 ? void 0 : _findParentNodeCloses2.node;
+            if (isInsideLayout) {
+              return false;
+            }
+          }
         }
       }
     }

package/dist/esm/nodeviews/TableRow.js

@@ -12,6 +12,7 @@ import { getParentOfTypeCount } from '@atlaskit/editor-common/nesting';
 import { nodeVisibilityManager } from '@atlaskit/editor-common/node-visibility';
 import { findOverflowScrollParent } from '@atlaskit/editor-common/ui';
 import { findParentNodeClosestToPos } from '@atlaskit/editor-prosemirror/utils';
+import { fg } from '@atlaskit/platform-feature-flags';
 import { getPluginState } from '../pm-plugins/plugin-factory';
 import { pluginKey as tablePluginKey } from '../pm-plugins/plugin-key';
 import { updateStickyState } from '../pm-plugins/sticky-headers/commands';
@@ -469,17 +470,38 @@ var TableRow = /*#__PURE__*/function (_TableNodeView) {
       navigator.userAgent.includes('AppleWebKit') && !navigator.userAgent.includes('Chrome')) {
         var pos = this.getPos();
         if (typeof pos === 'number') {
-          var $tableRowPos = this.view.state.doc.resolve(pos);
-
-          // layout -> layout column -> table -> table row
-          if ($tableRowPos.depth >= 3) {
-            var _findParentNodeCloses;
-            var isInsideLayout = (_findParentNodeCloses = findParentNodeClosestToPos($tableRowPos, function (node) {
-              return node.type.name === 'layoutColumn';
-            })) === null || _findParentNodeCloses === void 0 ? void 0 : _findParentNodeCloses.node;
-            if (isInsideLayout) {
+          if (fg('platform_editor_ai_table_ai_streaming_pos_fix')) {
+            try {
+              // getPos can return stale positions during AI streaming which cannot be resolved
+              var $tableRowPos = this.view.state.doc.resolve(pos);
+
+              // layout -> layout column -> table -> table row
+              if ($tableRowPos.depth >= 3) {
+                var _findParentNodeCloses;
+                var isInsideLayout = (_findParentNodeCloses = findParentNodeClosestToPos($tableRowPos, function (node) {
+                  return node.type.name === 'layoutColumn';
+                })) === null || _findParentNodeCloses === void 0 ? void 0 : _findParentNodeCloses.node;
+                if (isInsideLayout) {
+                  return false;
+                }
+              }
+            } catch (_unused2) {
+              // getPos can return stale positions during AI streaming — fall back to non-sticky
               return false;
             }
+          } else {
+            var _$tableRowPos = this.view.state.doc.resolve(pos);
+
+            // layout -> layout column -> table -> table row
+            if (_$tableRowPos.depth >= 3) {
+              var _findParentNodeCloses2;
+              var _isInsideLayout = (_findParentNodeCloses2 = findParentNodeClosestToPos(_$tableRowPos, function (node) {
+                return node.type.name === 'layoutColumn';
+              })) === null || _findParentNodeCloses2 === void 0 ? void 0 : _findParentNodeCloses2.node;
+              if (_isInsideLayout) {
+                return false;
+              }
+            }
           }
         }
       }

package/dist/esm/nodeviews/TableRowNativeStickyWithFallback.js

@@ -114,8 +114,22 @@ var TableRowNativeStickyWithFallback = /*#__PURE__*/function (_TableNodeView) {
     }
     var pos = _this.getPos();
     _this.isInNestedTable = false;
-    if (pos) {
-      _this.isInNestedTable = getParentOfTypeCount(view.state.schema.nodes.table)(view.state.doc.resolve(pos)) > 1;
+    if (fg('platform_editor_ai_table_ai_streaming_pos_fix')) {
+      try {
+        // We cannot trust that the value from getPos will be defined
+        // https://discuss.prosemirror.net/t/getpos-is-undefined-in-nodeview-constructor/1246/4
+        // There are also scenarios where the value it brings back does not tally with the current doc
+        // E.g. when AI streaming brings in new content, this position brings back incorrect values that cannot be resolved
+        if (pos) {
+          _this.isInNestedTable = getParentOfTypeCount(view.state.schema.nodes.table)(view.state.doc.resolve(pos)) > 1;
+        }
+      } catch (_unused) {
+        // Intentionally swallowed — getPos can return stale positions during AI streaming
+      }
+    } else {
+      if (pos) {
+        _this.isInNestedTable = getParentOfTypeCount(view.state.schema.nodes.table)(view.state.doc.resolve(pos)) > 1;
+      }
     }
     if (_this.isHeaderRow) {
       _this.dom.setAttribute('data-vc-nvs', 'true');
@@ -704,17 +718,38 @@ var TableRowNativeStickyWithFallback = /*#__PURE__*/function (_TableNodeView) {
       navigator.userAgent.includes('AppleWebKit') && !navigator.userAgent.includes('Chrome')) {
         var pos = this.getPos();
         if (typeof pos === 'number') {
-          var $tableRowPos = this.view.state.doc.resolve(pos);
-
-          // layout -> layout column -> table -> table row
-          if ($tableRowPos.depth >= 3) {
-            var _findParentNodeCloses;
-            var isInsideLayout = (_findParentNodeCloses = findParentNodeClosestToPos($tableRowPos, function (node) {
-              return node.type.name === 'layoutColumn';
-            })) === null || _findParentNodeCloses === void 0 ? void 0 : _findParentNodeCloses.node;
-            if (isInsideLayout) {
+          if (fg('platform_editor_ai_table_ai_streaming_pos_fix')) {
+            try {
+              // getPos can return stale positions during AI streaming which cannot be resolved
+              var $tableRowPos = this.view.state.doc.resolve(pos);
+
+              // layout -> layout column -> table -> table row
+              if ($tableRowPos.depth >= 3) {
+                var _findParentNodeCloses;
+                var isInsideLayout = (_findParentNodeCloses = findParentNodeClosestToPos($tableRowPos, function (node) {
+                  return node.type.name === 'layoutColumn';
+                })) === null || _findParentNodeCloses === void 0 ? void 0 : _findParentNodeCloses.node;
+                if (isInsideLayout) {
+                  return false;
+                }
+              }
+            } catch (_unused2) {
+              // getPos can return stale positions during AI streaming — fall back to non-sticky
               return false;
             }
+          } else {
+            var _$tableRowPos = this.view.state.doc.resolve(pos);
+
+            // layout -> layout column -> table -> table row
+            if (_$tableRowPos.depth >= 3) {
+              var _findParentNodeCloses2;
+              var _isInsideLayout = (_findParentNodeCloses2 = findParentNodeClosestToPos(_$tableRowPos, function (node) {
+                return node.type.name === 'layoutColumn';
+              })) === null || _findParentNodeCloses2 === void 0 ? void 0 : _findParentNodeCloses2.node;
+              if (_isInsideLayout) {
+                return false;
+              }
+            }
           }
         }
       }

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-plugin-table",
-	"version": "23.1.1",
+	"version": "23.1.2",
 	"description": "Table plugin for the @atlaskit/editor",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -62,7 +62,7 @@
 		"@atlaskit/primitives": "^19.0.0",
 		"@atlaskit/tmp-editor-statsig": "^89.1.0",
 		"@atlaskit/toggle": "^16.1.0",
-		"@atlaskit/tokens": "^13.1.0",
+		"@atlaskit/tokens": "^13.2.0",
 		"@atlaskit/tooltip": "^22.6.0",
 		"@babel/runtime": "^7.0.0",
 		"@compiled/react": "^0.20.0",
@@ -170,6 +170,9 @@
 		},
 		"platform_editor_max_width_default_width": {
 			"type": "boolean"
+		},
+		"platform_editor_ai_table_ai_streaming_pos_fix": {
+			"type": "boolean"
 		}
 	},
 	"devDependencies": {