@atlaskit/editor-plugin-table 22.2.8 → 22.2.10

package/CHANGELOG.md

@@ -1,5 +1,19 @@
 # @atlaskit/editor-plugin-table
 
+## 22.2.10
+
+### Patch Changes
+
+- [`0281a1c2161a9`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/0281a1c2161a9) -
+  [ux] cleanup platform_editor_table_remove_last_cell_decoration
+- Updated dependencies
+
+## 22.2.9
+
+### Patch Changes
+
+- Updated dependencies
+
 ## 22.2.8
 
 ### Patch Changes

package/dist/cjs/pm-plugins/analytics/plugin-factory.js

@@ -7,7 +7,7 @@ exports.getPluginState = exports.createPluginState = exports.createCommand = voi
 var _utils = require("@atlaskit/editor-common/utils");
 var _pluginKey = require("./plugin-key");
 var _reducer = require("./reducer");
-var _pluginFactory = (0, _utils.pluginFactory)(_pluginKey.pluginKey, _reducer.reducer),
-  createPluginState = exports.createPluginState = _pluginFactory.createPluginState,
-  createCommand = exports.createCommand = _pluginFactory.createCommand,
-  getPluginState = exports.getPluginState = _pluginFactory.getPluginState;
+var dest = (0, _utils.pluginFactory)(_pluginKey.pluginKey, _reducer.reducer);
+var createPluginState = exports.createPluginState = dest.createPluginState;
+var createCommand = exports.createCommand = dest.createCommand;
+var getPluginState = exports.getPluginState = dest.getPluginState;

package/dist/cjs/pm-plugins/decorations/utils/column-resizing.js

@@ -1,15 +1,12 @@
 "use strict";
 
-var _interopRequireDefault = require("@babel/runtime/helpers/interopRequireDefault");
 Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.clearColumnResizingDecorations = exports.buildColumnResizingDecorations = void 0;
-var _slicedToArray2 = _interopRequireDefault(require("@babel/runtime/helpers/slicedToArray"));
 var _types = require("../../../types");
 var _decoration = require("../../utils/decoration");
 var _composeDecorations = require("./compose-decorations");
-var emptyDecorations = [[], []];
 var updateColumnResizeHandle = function updateColumnResizeHandle(columnResizesDecorations) {
   return function (_ref) {
     var decorationSet = _ref.decorationSet,
@@ -17,36 +14,24 @@ var updateColumnResizeHandle = function updateColumnResizeHandle(columnResizesDe
     return (0, _decoration.updateDecorations)(tr.doc, decorationSet, columnResizesDecorations, _types.TableDecorations.COLUMN_RESIZING_HANDLE_WIDGET);
   };
 };
-var updateLastCellElement = function updateLastCellElement(lastCellElementsDecorations) {
-  return function (_ref2) {
-    var decorationSet = _ref2.decorationSet,
-      tr = _ref2.tr;
-    return (0, _decoration.updateDecorations)(tr.doc, decorationSet, lastCellElementsDecorations, _types.TableDecorations.LAST_CELL_ELEMENT);
-  };
-};
 var buildColumnResizingDecorations = exports.buildColumnResizingDecorations = function buildColumnResizingDecorations(rowEndIndex, columnEndIndex, includeTooltip, getIntl, nodeViewPortalProviderAPI) {
-  return function (_ref3) {
-    var tr = _ref3.tr,
-      decorationSet = _ref3.decorationSet;
-    var _ref4 = columnEndIndex < 0 ? emptyDecorations : (0, _decoration.createResizeHandleDecoration)(tr, rowEndIndex, {
-        right: columnEndIndex
-      }, includeTooltip, getIntl, nodeViewPortalProviderAPI),
-      _ref5 = (0, _slicedToArray2.default)(_ref4, 2),
-      columnResizesDecorations = _ref5[0],
-      lastCellElementsDecorations = _ref5[1];
-    return (0, _composeDecorations.composeDecorations)([updateColumnResizeHandle(columnResizesDecorations), updateLastCellElement(lastCellElementsDecorations)])({
+  return function (_ref2) {
+    var tr = _ref2.tr,
+      decorationSet = _ref2.decorationSet;
+    var columnResizesDecorations = columnEndIndex < 0 ? [] : (0, _decoration.createResizeHandleDecoration)(tr, rowEndIndex, {
+      right: columnEndIndex
+    }, includeTooltip, getIntl, nodeViewPortalProviderAPI);
+    return (0, _composeDecorations.composeDecorations)([updateColumnResizeHandle(columnResizesDecorations)])({
       decorationSet: decorationSet,
       tr: tr
     });
   };
 };
 var clearColumnResizingDecorations = exports.clearColumnResizingDecorations = function clearColumnResizingDecorations() {
-  return function (_ref6) {
-    var tr = _ref6.tr,
-      decorationSet = _ref6.decorationSet;
-    var columnResizesDecorations = emptyDecorations[0],
-      lastCellElementsDecorations = emptyDecorations[1];
-    return (0, _composeDecorations.composeDecorations)([updateColumnResizeHandle(columnResizesDecorations), updateLastCellElement(lastCellElementsDecorations)])({
+  return function (_ref3) {
+    var tr = _ref3.tr,
+      decorationSet = _ref3.decorationSet;
+    return (0, _composeDecorations.composeDecorations)([updateColumnResizeHandle([])])({
       decorationSet: decorationSet,
       tr: tr
     });

package/dist/cjs/pm-plugins/drag-and-drop/plugin-factory.js

@@ -12,24 +12,24 @@ var _pluginKey2 = require("./plugin-key");
 var _reducer = _interopRequireDefault(require("./reducer"));
 function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
 function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { (0, _defineProperty2.default)(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; }
-var _pluginFactory = (0, _utils.pluginFactory)(_pluginKey2.pluginKey, _reducer.default, {
-    mapping: function mapping(tr, pluginState) {
-      if (tr.docChanged) {
-        var decorationSet = pluginState.decorationSet;
-        var meta = tr.getMeta(_pluginKey.pluginKey);
-        if (meta && meta.data && meta.data.decorationSet) {
-          decorationSet = meta.data.decorationSet;
-        }
-        if (decorationSet) {
-          decorationSet = decorationSet.map(tr.mapping, tr.doc);
-        }
-        return _objectSpread(_objectSpread({}, pluginState), {
-          decorationSet: decorationSet
-        });
+var dest = (0, _utils.pluginFactory)(_pluginKey2.pluginKey, _reducer.default, {
+  mapping: function mapping(tr, pluginState) {
+    if (tr.docChanged) {
+      var decorationSet = pluginState.decorationSet;
+      var meta = tr.getMeta(_pluginKey.pluginKey);
+      if (meta && meta.data && meta.data.decorationSet) {
+        decorationSet = meta.data.decorationSet;
       }
-      return pluginState;
+      if (decorationSet) {
+        decorationSet = decorationSet.map(tr.mapping, tr.doc);
+      }
+      return _objectSpread(_objectSpread({}, pluginState), {}, {
+        decorationSet: decorationSet
+      });
     }
-  }),
-  createPluginState = exports.createPluginState = _pluginFactory.createPluginState,
-  createCommand = exports.createCommand = _pluginFactory.createCommand,
-  getPluginState = exports.getPluginState = _pluginFactory.getPluginState;
+    return pluginState;
+  }
+});
+var createPluginState = exports.createPluginState = dest.createPluginState;
+var createCommand = exports.createCommand = dest.createCommand;
+var getPluginState = exports.getPluginState = dest.getPluginState;

package/dist/cjs/pm-plugins/plugin-factory.js

@@ -12,34 +12,34 @@ var _pluginKey = require("./plugin-key");
 var _reducer = _interopRequireDefault(require("./reducer"));
 function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
 function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { (0, _defineProperty2.default)(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; }
-var _pluginFactory = (0, _utils.pluginFactory)(_pluginKey.pluginKey, _reducer.default, {
-    mapping: function mapping(tr, pluginState) {
-      if (tr.docChanged) {
-        var updatedTargetCell = {};
-        if (pluginState.targetCellPosition) {
-          var _tr$mapping$mapResult = tr.mapping.mapResult(pluginState.targetCellPosition),
-            pos = _tr$mapping$mapResult.pos,
-            deleted = _tr$mapping$mapResult.deleted;
-          updatedTargetCell = {
-            targetCellPosition: deleted ? undefined : pos
-          };
-        }
-        var updatedTablePos = {};
-        if (pluginState.tablePos) {
-          var _tr$mapping$mapResult2 = tr.mapping.mapResult(pluginState.tablePos, -1),
-            _pos = _tr$mapping$mapResult2.pos,
-            _deleted = _tr$mapping$mapResult2.deleted;
-          updatedTablePos = {
-            tablePos: _deleted ? undefined : _pos
-          };
-        }
-        return _objectSpread(_objectSpread(_objectSpread({}, pluginState), updatedTargetCell), updatedTablePos);
+var dest = (0, _utils.pluginFactory)(_pluginKey.pluginKey, _reducer.default, {
+  mapping: function mapping(tr, pluginState) {
+    if (tr.docChanged) {
+      var updatedTargetCell = {};
+      if (pluginState.targetCellPosition) {
+        var _tr$mapping$mapResult = tr.mapping.mapResult(pluginState.targetCellPosition),
+          pos = _tr$mapping$mapResult.pos,
+          deleted = _tr$mapping$mapResult.deleted;
+        updatedTargetCell = {
+          targetCellPosition: deleted ? undefined : pos
+        };
       }
-      return pluginState;
-    },
-    onDocChanged: _handlers.handleDocOrSelectionChanged,
-    onSelectionChanged: _handlers.handleDocOrSelectionChanged
-  }),
-  createPluginState = exports.createPluginState = _pluginFactory.createPluginState,
-  createCommand = exports.createCommand = _pluginFactory.createCommand,
-  getPluginState = exports.getPluginState = _pluginFactory.getPluginState;
+      var updatedTablePos = {};
+      if (pluginState.tablePos) {
+        var _tr$mapping$mapResult2 = tr.mapping.mapResult(pluginState.tablePos, -1),
+          _pos = _tr$mapping$mapResult2.pos,
+          _deleted = _tr$mapping$mapResult2.deleted;
+        updatedTablePos = {
+          tablePos: _deleted ? undefined : _pos
+        };
+      }
+      return _objectSpread(_objectSpread(_objectSpread({}, pluginState), updatedTargetCell), updatedTablePos);
+    }
+    return pluginState;
+  },
+  onDocChanged: _handlers.handleDocOrSelectionChanged,
+  onSelectionChanged: _handlers.handleDocOrSelectionChanged
+});
+var createPluginState = exports.createPluginState = dest.createPluginState;
+var createCommand = exports.createCommand = dest.createCommand;
+var getPluginState = exports.getPluginState = dest.getPluginState;

package/dist/cjs/pm-plugins/sticky-headers/plugin-state.js

@@ -32,20 +32,20 @@ var reducer = function reducer(pluginState, action) {
   }
   return pluginState;
 };
-var _pluginFactory = (0, _utils.pluginFactory)(_pluginKey.pluginKey, reducer, {
-    mapping: function mapping(tr, pluginState) {
-      if (tr.docChanged) {
-        return pluginState.map(function (rowInfo) {
-          var remapped = tr.mapping.mapResult(rowInfo.pos);
-          return remapped ? _objectSpread(_objectSpread({}, rowInfo), {}, {
-            pos: remapped.pos
-          }) : undefined;
-        }).filter(function (f) {
-          return f !== undefined;
-        });
-      }
-      return pluginState;
+var dest = (0, _utils.pluginFactory)(_pluginKey.pluginKey, reducer, {
+  mapping: function mapping(tr, pluginState) {
+    if (tr.docChanged) {
+      return pluginState.map(function (rowInfo) {
+        var remapped = tr.mapping.mapResult(rowInfo.pos);
+        return remapped ? _objectSpread(_objectSpread({}, rowInfo), {}, {
+          pos: remapped.pos
+        }) : undefined;
+      }).filter(function (f) {
+        return f !== undefined;
+      });
     }
-  }),
-  createPluginState = exports.createPluginState = _pluginFactory.createPluginState,
-  createCommand = exports.createCommand = _pluginFactory.createCommand;
+    return pluginState;
+  }
+});
+var createPluginState = exports.createPluginState = dest.createPluginState;
+var createCommand = exports.createCommand = dest.createCommand;

package/dist/cjs/pm-plugins/utils/decoration.js

@@ -13,7 +13,6 @@ var _utils = require("@atlaskit/editor-common/utils");
 var _view = require("@atlaskit/editor-prosemirror/view");
 var _tableMap = require("@atlaskit/editor-tables/table-map");
 var _utils2 = require("@atlaskit/editor-tables/utils");
-var _expValEquals = require("@atlaskit/tmp-editor-statsig/exp-val-equals");
 var _types = require("../../types");
 var _ColumnResizeWidget = require("../../ui/ColumnResizeWidget");
 // eslint-disable-next-line @atlaskit/platform/prefer-crypto-random-uuid -- Use crypto.randomUUID instead
@@ -209,9 +208,7 @@ var makeArray = function makeArray(n) {
  * the CellColumnPositioning interface.
  *
  * Let's say the `columnEndIndexTarget.right` is 3,
- * so this function will return two types of decorations for each cell on that column,
- * that means 2 `resizerHandle` and 2 `lastCellElement`,
- * here is the explanation for each one of them :
+ * so this function will return the resize handle decoration for each cell on that column:
  *
  * - resizerHandle:
  *
@@ -226,45 +223,18 @@ var makeArray = function makeArray(n) {
  *   This ▒ represents the area where table resizing will start,
  *   and you can follow that using checking the class name `ClassName.RESIZE_HANDLE_DECORATION` on the code
  *
- * - lastCellElementDecoration
- *
- *   Given the content of the cell C1
- *    ▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁
- *   |                   |
- *   |   _____________   |
- *   |  |             |  |
- *   |  |     <p>     |  |
- *   |  |_____________|  |
- *   |                   |
- *   |   _____________   |
- *   |  |             |  |
- *   |  |   <media>   |  |
- *   |  |_____________|  |
- *   |                   |
- *   |   _____________   |
- *   |  |             |  |
- *   |  |   <media>   |  |
- *   |  |_____________|  |
- *   |                   |
- *    ▔▔▔▔▔▔▔▔▔▔▔▔▔▔▔▔▔▔▔
- *   Currently, we are removing the margin-bottom from the last media using this kind of CSS rule:
- *   `div:last-of-type`; This is quite unstable, and after we create the `resizerHandle` div,
- *   that logic will apply the margin in the wrong element, to avoid that,
- *   we will add a new class on the last item for each cell,
- *   hence the second media will receive this class `ClassName.LAST_ITEM_IN_CELL`
  */
 var createResizeHandleDecoration = exports.createResizeHandleDecoration = function createResizeHandleDecoration(tr, rowIndexTarget, columnEndIndexTarget) {
   var includeTooltip = arguments.length > 3 && arguments[3] !== undefined ? arguments[3] : false;
   var getIntl = arguments.length > 4 ? arguments[4] : undefined;
   var nodeViewPortalProviderAPI = arguments.length > 5 ? arguments[5] : undefined;
-  var emptyResult = [[], []];
   var table = (0, _utils2.findTable)(tr.selection);
   if (!table || !table.node) {
-    return emptyResult;
+    return [];
   }
   var map = _tableMap.TableMap.get(table.node);
   if (!map.width) {
-    return emptyResult;
+    return [];
   }
   var createResizerHandleDecoration = function createResizerHandleDecoration(cellColumnPositioning, columnIndex, rowIndex, cellPos, cellNode) {
     // eslint-disable-next-line @atlaskit/platform/prefer-crypto-random-uuid -- Use crypto.randomUUID instead
@@ -289,33 +259,7 @@ var createResizeHandleDecoration = exports.createResizeHandleDecoration = functi
       }
     });
   };
-  var createLastCellElementDecoration = function createLastCellElementDecoration(cellColumnPositioning, cellPos, cellNode) {
-    if ((0, _expValEquals.expValEquals)('platform_editor_table_remove_last_cell_decoration', 'isEnabled', true)) {
-      // no longer need to add the last cell decoration to override marginBottom as media wrapper doesn't have margin bottom. This will avoid unnecessary decoration computation/mutation and improve performance
-      // consider clean up ClassName.LAST_ITEM_IN_CELL with platform_editor_table_remove_last_cell_decoration experiment
-      return null;
-    }
-    var lastItemPositions;
-    cellNode.forEach(function (childNode, offset, index) {
-      if (index === cellNode.childCount - 1) {
-        var from = offset + cellPos + 1;
-        lastItemPositions = {
-          from: from,
-          to: from + childNode.nodeSize
-        };
-      }
-    });
-    if (!lastItemPositions) {
-      return null;
-    }
-    return _view.Decoration.node(lastItemPositions.from, lastItemPositions.to, {
-      class: _types.TableCssClassName.LAST_ITEM_IN_CELL
-    }, {
-      key: "".concat(_types.TableDecorations.LAST_CELL_ELEMENT, "_").concat(cellColumnPositioning.left, "_").concat(cellColumnPositioning.right)
-    });
-  };
   var resizeHandleCellDecorations = [];
-  var lastCellElementsDecorations = [];
   for (var rowIndex = 0; rowIndex < map.height; rowIndex++) {
     var seen = {};
     if (rowIndex !== rowIndexTarget) {
@@ -342,15 +286,10 @@ var createResizeHandleDecoration = exports.createResizeHandleDecoration = functi
         left: startIndex,
         right: endIndex
       }, columnIndex, rowIndex, cellPos, cell);
-      var lastCellDec = createLastCellElementDecoration({
-        left: startIndex,
-        right: endIndex
-      }, cellPos, cell);
       resizeHandleCellDecorations.push(resizerHandleDec);
-      lastCellElementsDecorations.push(lastCellDec);
     }
   }
-  return [resizeHandleCellDecorations, lastCellElementsDecorations.filter(_utils.nonNullable)];
+  return resizeHandleCellDecorations;
 };
 
 /*

package/dist/cjs/types/index.js

@@ -58,7 +58,6 @@ var TableDecorations = exports.TableDecorations = /*#__PURE__*/function (TableDe
   TableDecorations["COLUMN_RESIZING_HANDLE_LINE"] = "COLUMN_RESIZING_HANDLE_LINE";
   TableDecorations["COLUMN_INSERT_LINE"] = "COLUMN_INSERT_LINE";
   TableDecorations["ROW_INSERT_LINE"] = "ROW_INSERT_LINE";
-  TableDecorations["LAST_CELL_ELEMENT"] = "LAST_CELL_ELEMENT";
   return TableDecorations;
 }({});
 var TableCssClassName = exports.TableCssClassName = _objectSpread(_objectSpread({}, _styles.TableSharedCssClassName), {}, {
@@ -153,7 +152,6 @@ var TableCssClassName = exports.TableCssClassName = _objectSpread(_objectSpread(
   TABLE_STICKY: "".concat(_adfSchema.tablePrefixSelector, "-sticky"),
   TABLE_CHROMELESS: "".concat(_adfSchema.tablePrefixSelector, "-chromeless"),
   TOP_LEFT_CELL: 'table > tbody > tr:nth-child(2) > td:nth-child(1)',
-  LAST_ITEM_IN_CELL: "".concat(_adfSchema.tablePrefixSelector, "-last-item-in-cell"),
   WITH_COLUMN_INSERT_LINE: "".concat(_adfSchema.tablePrefixSelector, "-column-insert-line"),
   WITH_COLUMN_INSERT_LINE_INACTIVE: "".concat(_adfSchema.tablePrefixSelector, "-column-insert-line__inactive"),
   WITH_FIRST_COLUMN_INSERT_LINE: "".concat(_adfSchema.tablePrefixSelector, "-first-column-insert-line"),