@atlaskit/editor-plugin-table 2.5.4 → 2.5.5

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @atlaskit/editor-plugin-table
 
+## 2.5.5
+
+### Patch Changes
+
+- [`d55db921de3`](https://bitbucket.org/atlassian/atlassian-frontend/commits/d55db921de3) - improve performance when adding a new column in table
+
 ## 2.5.4
 
 ### Patch Changes

package/dist/cjs/plugins/table/pm-plugins/sticky-headers/nodeviews/tableRow.js

@@ -32,22 +32,6 @@ var anyChildCellMergedAcrossRow = function anyChildCellMergedAcrossRow(node) {
   });
 };
 
-/**
- * Compare two table row nodes and return true if the two table rows have a
- * different number of table cells or if table cell row spans are different
- */
-var rowHasDifferentMergedCells = function rowHasDifferentMergedCells(prevNode, incomingNode) {
-  var incomingNodeChildrenRowSpan = (0, _utils.mapChildren)(prevNode, function (child) {
-    return child.attrs.rowspan || 0;
-  });
-  var currentNodeChildrenRowSpan = (0, _utils.mapChildren)(incomingNode, function (child) {
-    return child.attrs.rowspan || 0;
-  });
-  return incomingNodeChildrenRowSpan.length !== currentNodeChildrenRowSpan.length || currentNodeChildrenRowSpan.some(function (child, index) {
-    return child !== incomingNodeChildrenRowSpan[index];
-  });
-};
-
 /**
  * Check if a given node is a header row with this definition:
  *  - all children are tableHeader cells
@@ -512,10 +496,6 @@ var TableRowNodeView = /*#__PURE__*/function () {
         return false; // re-create nodeview
       }
 
-      if (rowHasDifferentMergedCells(this.node, node)) {
-        return false;
-      }
-
       // node is different but no need to re-create nodeview
       this.node = node;
 

package/dist/cjs/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/editor-plugin-table",
-	"version": "2.5.4",
+	"version": "2.5.5",
 	"sideEffects": false
 }

package/dist/es2019/plugins/table/pm-plugins/sticky-headers/nodeviews/tableRow.js

@@ -18,16 +18,6 @@ const HEADER_ROW_SCROLL_THROTTLE_TIMEOUT = 200;
 const HEADER_ROW_SCROLL_RESET_DEBOUNCE_TIMEOUT = 400;
 const anyChildCellMergedAcrossRow = node => mapChildren(node, child => child.attrs.rowspan || 0).some(rowspan => rowspan > 1);
 
-/**
- * Compare two table row nodes and return true if the two table rows have a
- * different number of table cells or if table cell row spans are different
- */
-const rowHasDifferentMergedCells = (prevNode, incomingNode) => {
-  const incomingNodeChildrenRowSpan = mapChildren(prevNode, child => child.attrs.rowspan || 0);
-  const currentNodeChildrenRowSpan = mapChildren(incomingNode, child => child.attrs.rowspan || 0);
-  return incomingNodeChildrenRowSpan.length !== currentNodeChildrenRowSpan.length || currentNodeChildrenRowSpan.some((child, index) => child !== incomingNodeChildrenRowSpan[index]);
-};
-
 /**
  * Check if a given node is a header row with this definition:
  *  - all children are tableHeader cells
@@ -477,10 +467,6 @@ export class TableRowNodeView {
       return false; // re-create nodeview
     }
 
-    if (rowHasDifferentMergedCells(this.node, node)) {
-      return false;
-    }
-
     // node is different but no need to re-create nodeview
     this.node = node;
 

package/dist/es2019/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/editor-plugin-table",
-	"version": "2.5.4",
+	"version": "2.5.5",
 	"sideEffects": false
 }

package/dist/esm/plugins/table/pm-plugins/sticky-headers/nodeviews/tableRow.js

@@ -26,22 +26,6 @@ var anyChildCellMergedAcrossRow = function anyChildCellMergedAcrossRow(node) {
   });
 };
 
-/**
- * Compare two table row nodes and return true if the two table rows have a
- * different number of table cells or if table cell row spans are different
- */
-var rowHasDifferentMergedCells = function rowHasDifferentMergedCells(prevNode, incomingNode) {
-  var incomingNodeChildrenRowSpan = mapChildren(prevNode, function (child) {
-    return child.attrs.rowspan || 0;
-  });
-  var currentNodeChildrenRowSpan = mapChildren(incomingNode, function (child) {
-    return child.attrs.rowspan || 0;
-  });
-  return incomingNodeChildrenRowSpan.length !== currentNodeChildrenRowSpan.length || currentNodeChildrenRowSpan.some(function (child, index) {
-    return child !== incomingNodeChildrenRowSpan[index];
-  });
-};
-
 /**
  * Check if a given node is a header row with this definition:
  *  - all children are tableHeader cells
@@ -505,10 +489,6 @@ export var TableRowNodeView = /*#__PURE__*/function () {
         return false; // re-create nodeview
       }
 
-      if (rowHasDifferentMergedCells(this.node, node)) {
-        return false;
-      }
-
       // node is different but no need to re-create nodeview
       this.node = node;
 

package/dist/esm/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/editor-plugin-table",
-	"version": "2.5.4",
+	"version": "2.5.5",
 	"sideEffects": false
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaskit/editor-plugin-table",
-  "version": "2.5.4",
+  "version": "2.5.5",
   "description": "Table plugin for the @atlaskit/editor",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/"
@@ -27,7 +27,7 @@
     "releaseModel": "continuous"
   },
   "dependencies": {
-    "@atlaskit/adf-schema": "^26.2.0",
+    "@atlaskit/adf-schema": "^26.3.0",
     "@atlaskit/editor-common": "^74.26.0",
     "@atlaskit/editor-palette": "1.5.1",
     "@atlaskit/editor-plugin-analytics": "^0.1.0",

package/src/__tests__/visual-regression/sticky-header.ts

@@ -39,7 +39,8 @@ describe('Snapshot Test: Table', () => {
   });
 
   describe('sticky header', () => {
-    it('should align with table cell when active', async () => {
+    // FIXME: This test was automatically skipped due to failure on 26/07/2023: https://product-fabric.atlassian.net/browse/ED-19223
+    it.skip('should align with table cell when active', async () => {
       await initEditor(page, stickyHeaderWithHorizontalScroll);
 
       await clickFirstCell(page, true);

package/src/plugins/table/pm-plugins/sticky-headers/nodeviews/tableRow.ts

@@ -40,28 +40,6 @@ const anyChildCellMergedAcrossRow = (node: PmNode) =>
     (rowspan) => rowspan > 1,
   );
 
-/**
- * Compare two table row nodes and return true if the two table rows have a
- * different number of table cells or if table cell row spans are different
- */
-const rowHasDifferentMergedCells = (prevNode: PmNode, incomingNode: PmNode) => {
-  const incomingNodeChildrenRowSpan = mapChildren(
-    prevNode,
-    (child) => child.attrs.rowspan || 0,
-  );
-  const currentNodeChildrenRowSpan = mapChildren(
-    incomingNode,
-    (child) => child.attrs.rowspan || 0,
-  );
-
-  return (
-    incomingNodeChildrenRowSpan.length !== currentNodeChildrenRowSpan.length ||
-    currentNodeChildrenRowSpan.some(
-      (child, index) => child !== incomingNodeChildrenRowSpan[index],
-    )
-  );
-};
-
 /**
  * Check if a given node is a header row with this definition:
  *  - all children are tableHeader cells
@@ -429,10 +407,6 @@ export class TableRowNodeView implements NodeView {
       return false; // re-create nodeview
     }
 
-    if (rowHasDifferentMergedCells(this.node, node)) {
-      return false;
-    }
-
     // node is different but no need to re-create nodeview
     this.node = node;