@atlaskit/editor-plugin-table 2.5.1 → 2.5.3

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # @atlaskit/editor-plugin-table
 
+## 2.5.3
+
+### Patch Changes
+
+- [`e8885f55db6`](https://bitbucket.org/atlassian/atlassian-frontend/commits/e8885f55db6) - Fixed type issue
+
+## 2.5.2
+
+### Patch Changes
+
+- [`8b77d484c89`](https://bitbucket.org/atlassian/atlassian-frontend/commits/8b77d484c89) - Change snap gap for tables guideline to 9px
+
 ## 2.5.1
 
 ### Patch Changes

package/dist/cjs/plugins/table/ui/consts.js

@@ -143,7 +143,7 @@ var stickyRowOffsetTop = 8;
 exports.stickyRowOffsetTop = stickyRowOffsetTop;
 var stickyHeaderBorderBottomWidth = 1;
 exports.stickyHeaderBorderBottomWidth = stickyHeaderBorderBottomWidth;
-var TABLE_SNAP_GAP = 5;
+var TABLE_SNAP_GAP = 9;
 exports.TABLE_SNAP_GAP = TABLE_SNAP_GAP;
 var TABLE_HIGHLIGHT_GAP = 10;
 exports.TABLE_HIGHLIGHT_GAP = TABLE_HIGHLIGHT_GAP;

package/dist/cjs/plugins/table/utils/snapping.js

@@ -4,6 +4,7 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.findClosestSnap = void 0;
+var _guideline = require("@atlaskit/editor-common/guideline");
 /**
  * Returns keys of guidelines that are closest to the table and withthin the snapGap
  */
@@ -19,7 +20,7 @@ var findClosestSnap = function findClosestSnap(currentWidth, snapWidths, guideli
       // NOTE: The snap points are based on the guidelines, however their formatted as a length value whereas the guidelines
       // are point based. The point base x coords are calculated by halving the lengths. This means we can convert the
       // point base position to length by simply multiplying by 2.
-      if (Math.round(Math.abs(guideline.position.x) * 2) === snappingWidth) {
+      if ((0, _guideline.isVerticalPosition)(guideline.position) && Math.round(Math.abs(guideline.position.x) * 2) === snappingWidth) {
         acc.push(guideline.key);
       }
       return acc;

package/dist/cjs/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/editor-plugin-table",
-	"version": "2.5.1",
+	"version": "2.5.3",
 	"sideEffects": false
 }

package/dist/es2019/plugins/table/ui/consts.js

@@ -97,5 +97,5 @@ export const contextualMenuDropdownWidth = 180;
 export const stickyRowZIndex = resizeHandlerZIndex + 2;
 export const stickyRowOffsetTop = 8;
 export const stickyHeaderBorderBottomWidth = 1;
-export const TABLE_SNAP_GAP = 5;
+export const TABLE_SNAP_GAP = 9;
 export const TABLE_HIGHLIGHT_GAP = 10;

package/dist/es2019/plugins/table/utils/snapping.js

@@ -1,3 +1,5 @@
+import { isVerticalPosition } from '@atlaskit/editor-common/guideline';
+
 /**
  * Returns keys of guidelines that are closest to the table and withthin the snapGap
  */
@@ -10,7 +12,7 @@ export const findClosestSnap = (currentWidth, snapWidths, guidelines, snapGap =
       // NOTE: The snap points are based on the guidelines, however their formatted as a length value whereas the guidelines
       // are point based. The point base x coords are calculated by halving the lengths. This means we can convert the
       // point base position to length by simply multiplying by 2.
-      if (Math.round(Math.abs(guideline.position.x) * 2) === snappingWidth) {
+      if (isVerticalPosition(guideline.position) && Math.round(Math.abs(guideline.position.x) * 2) === snappingWidth) {
         acc.push(guideline.key);
       }
       return acc;

package/dist/es2019/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/editor-plugin-table",
-	"version": "2.5.1",
+	"version": "2.5.3",
 	"sideEffects": false
 }

package/dist/esm/plugins/table/ui/consts.js

@@ -97,5 +97,5 @@ export var contextualMenuDropdownWidth = 180;
 export var stickyRowZIndex = resizeHandlerZIndex + 2;
 export var stickyRowOffsetTop = 8;
 export var stickyHeaderBorderBottomWidth = 1;
-export var TABLE_SNAP_GAP = 5;
+export var TABLE_SNAP_GAP = 9;
 export var TABLE_HIGHLIGHT_GAP = 10;

package/dist/esm/plugins/table/utils/snapping.js

@@ -1,3 +1,5 @@
+import { isVerticalPosition } from '@atlaskit/editor-common/guideline';
+
 /**
  * Returns keys of guidelines that are closest to the table and withthin the snapGap
  */
@@ -13,7 +15,7 @@ export var findClosestSnap = function findClosestSnap(currentWidth, snapWidths,
       // NOTE: The snap points are based on the guidelines, however their formatted as a length value whereas the guidelines
       // are point based. The point base x coords are calculated by halving the lengths. This means we can convert the
       // point base position to length by simply multiplying by 2.
-      if (Math.round(Math.abs(guideline.position.x) * 2) === snappingWidth) {
+      if (isVerticalPosition(guideline.position) && Math.round(Math.abs(guideline.position.x) * 2) === snappingWidth) {
         acc.push(guideline.key);
       }
       return acc;

package/dist/esm/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/editor-plugin-table",
-	"version": "2.5.1",
+	"version": "2.5.3",
 	"sideEffects": false
 }

package/dist/types/plugins/table/ui/consts.d.ts

@@ -42,5 +42,5 @@ export declare const contextualMenuDropdownWidth = 180;
 export declare const stickyRowZIndex: number;
 export declare const stickyRowOffsetTop = 8;
 export declare const stickyHeaderBorderBottomWidth = 1;
-export declare const TABLE_SNAP_GAP = 5;
+export declare const TABLE_SNAP_GAP = 9;
 export declare const TABLE_HIGHLIGHT_GAP = 10;

package/dist/types/plugins/table/utils/snapping.d.ts

@@ -1,4 +1,4 @@
-import type { GuidelineConfig } from '@atlaskit/editor-plugin-guideline';
+import { type GuidelineConfig } from '@atlaskit/editor-common/guideline';
 /**
  * Returns keys of guidelines that are closest to the table and withthin the snapGap
  */

package/dist/types-ts4.5/plugins/table/ui/consts.d.ts

@@ -42,5 +42,5 @@ export declare const contextualMenuDropdownWidth = 180;
 export declare const stickyRowZIndex: number;
 export declare const stickyRowOffsetTop = 8;
 export declare const stickyHeaderBorderBottomWidth = 1;
-export declare const TABLE_SNAP_GAP = 5;
+export declare const TABLE_SNAP_GAP = 9;
 export declare const TABLE_HIGHLIGHT_GAP = 10;

package/dist/types-ts4.5/plugins/table/utils/snapping.d.ts

@@ -1,4 +1,4 @@
-import type { GuidelineConfig } from '@atlaskit/editor-plugin-guideline';
+import { type GuidelineConfig } from '@atlaskit/editor-common/guideline';
 /**
  * Returns keys of guidelines that are closest to the table and withthin the snapGap
  */

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaskit/editor-plugin-table",
-  "version": "2.5.1",
+  "version": "2.5.3",
   "description": "Table plugin for the @atlaskit/editor",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/"

package/src/plugins/table/ui/consts.ts

@@ -131,5 +131,5 @@ export const stickyRowZIndex = resizeHandlerZIndex + 2;
 export const stickyRowOffsetTop = 8;
 export const stickyHeaderBorderBottomWidth = 1;
 
-export const TABLE_SNAP_GAP = 5;
+export const TABLE_SNAP_GAP = 9;
 export const TABLE_HIGHLIGHT_GAP = 10;

package/src/plugins/table/utils/snapping.ts

@@ -1,4 +1,7 @@
-import type { GuidelineConfig } from '@atlaskit/editor-plugin-guideline';
+import {
+  type GuidelineConfig,
+  isVerticalPosition,
+} from '@atlaskit/editor-common/guideline';
 
 /**
  * Returns keys of guidelines that are closest to the table and withthin the snapGap
@@ -23,7 +26,10 @@ export const findClosestSnap = (
       // NOTE: The snap points are based on the guidelines, however their formatted as a length value whereas the guidelines
       // are point based. The point base x coords are calculated by halving the lengths. This means we can convert the
       // point base position to length by simply multiplying by 2.
-      if (Math.round(Math.abs(guideline.position.x) * 2) === snappingWidth) {
+      if (
+        isVerticalPosition(guideline.position) &&
+        Math.round(Math.abs(guideline.position.x) * 2) === snappingWidth
+      ) {
         acc.push(guideline.key);
       }
       return acc;