@atlaskit/editor-plugin-table 2.14.1 → 3.0.1

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # @atlaskit/editor-plugin-table
 
+## 3.0.1
+
+### Patch Changes
+
+- Updated dependencies
+
+## 3.0.0
+
+### Major Changes
+
+- [`18e8e6cc9c8`](https://bitbucket.org/atlassian/atlassian-frontend/commits/18e8e6cc9c8) - ED-19782: Clean up feature flag types from table optimisation related feature flags.
+
 ## 2.14.1
 
 ### Patch Changes

package/dist/types/plugins/table/types.d.ts

@@ -40,12 +40,6 @@ export interface PluginConfig {
     stickyHeaders?: boolean;
     allowCellOptionsInFloatingToolbar?: boolean;
     allowDistributeColumns?: boolean;
-    tableCellOptimization?: boolean;
-    tableRenderOptimization?: boolean;
-    stickyHeadersOptimization?: boolean;
-    initialRenderOptimization?: boolean;
-    mouseMoveOptimization?: boolean;
-    tableOverflowShadowsOptimization?: boolean;
 }
 export type { ColumnResizingPluginState } from '@atlaskit/editor-common/types';
 export type CellColumnPositioning = Pick<Rect, 'right' | 'left'>;

package/dist/types-ts4.5/plugins/table/types.d.ts

@@ -40,12 +40,6 @@ export interface PluginConfig {
     stickyHeaders?: boolean;
     allowCellOptionsInFloatingToolbar?: boolean;
     allowDistributeColumns?: boolean;
-    tableCellOptimization?: boolean;
-    tableRenderOptimization?: boolean;
-    stickyHeadersOptimization?: boolean;
-    initialRenderOptimization?: boolean;
-    mouseMoveOptimization?: boolean;
-    tableOverflowShadowsOptimization?: boolean;
 }
 export type { ColumnResizingPluginState } from '@atlaskit/editor-common/types';
 export type CellColumnPositioning = Pick<Rect, 'right' | 'left'>;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaskit/editor-plugin-table",
-  "version": "2.14.1",
+  "version": "3.0.1",
   "description": "Table plugin for the @atlaskit/editor",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/"
@@ -28,7 +28,7 @@
   },
   "dependencies": {
     "@atlaskit/adf-schema": "^29.1.0",
-    "@atlaskit/editor-common": "^74.59.0",
+    "@atlaskit/editor-common": "^75.0.0",
     "@atlaskit/editor-palette": "1.5.1",
     "@atlaskit/editor-plugin-analytics": "^0.2.0",
     "@atlaskit/editor-plugin-content-insertion": "^0.1.0",

package/report.api.md

@@ -63,23 +63,11 @@ interface PluginConfig {
   // (undocumented)
   allowNumberColumn?: boolean;
   // (undocumented)
-  initialRenderOptimization?: boolean;
-  // (undocumented)
   isHeaderRowRequired?: boolean;
   // (undocumented)
-  mouseMoveOptimization?: boolean;
-  // (undocumented)
   permittedLayouts?: PermittedLayoutsDescriptor;
   // (undocumented)
   stickyHeaders?: boolean;
-  // (undocumented)
-  stickyHeadersOptimization?: boolean;
-  // (undocumented)
-  tableCellOptimization?: boolean;
-  // (undocumented)
-  tableOverflowShadowsOptimization?: boolean;
-  // (undocumented)
-  tableRenderOptimization?: boolean;
 }
 
 // @public (undocumented)

package/src/__tests__/unit/nodeviews/TableContainer.tsx

@@ -338,4 +338,73 @@ describe('table -> nodeviews -> TableContainer.tsx', () => {
       expect(selectionActionMock).toHaveBeenNthCalledWith(2, true);
     });
   });
+
+  describe('deletion', () => {
+    const selectionActionMock = jest.fn().mockReturnValue(() => {});
+    const actualGuidelineMock = jest.fn();
+    const guidelineActionMock = jest.fn().mockReturnValue(actualGuidelineMock);
+    const buildContainer = (attrs: TableAttributes) => {
+      const { table, editorView } = createNode(attrs);
+
+      const { container, unmount } = render(
+        <ResizableTableContainer
+          containerWidth={1800}
+          lineLength={720}
+          node={table}
+          className={''}
+          editorView={editorView}
+          getPos={() => 0}
+          tableRef={
+            {
+              querySelector: () => null,
+              insertBefore: () => {},
+              style: {},
+            } as any
+          }
+          pluginInjectionApi={
+            {
+              selection: {
+                commands: { displayGapCursor: selectionActionMock },
+              },
+              guideline: {
+                actions: { displayGuideline: guidelineActionMock },
+              },
+              // mock core so the selection command will execute
+              core: { actions: { execute: jest.fn() } },
+            } as any
+          }
+        />,
+      );
+
+      return { container, unmount, selectionActionMock, actualGuidelineMock };
+    };
+
+    afterEach(() => {
+      selectionActionMock.mockClear();
+      actualGuidelineMock.mockClear();
+      guidelineActionMock.mockClear();
+    });
+
+    // this is testing logic inside TableResizer, targeting the clean up in the useEffect
+    it('should call selection plugin action to display gapcursor when removed', () => {
+      const { container, unmount, selectionActionMock } = buildContainer({});
+
+      fireEvent.mouseDown(container.querySelector('.resizer-handle.right')!);
+      fireEvent.mouseMove(container.querySelector('.resizer-handle.right')!);
+
+      unmount();
+      expect(selectionActionMock).toHaveBeenCalledWith(true);
+    });
+
+    // this is testing logic inside TableResizer, targeting the clean up in the useEffect
+    it('should call guideline plugin action to remove guidelines when removed', () => {
+      const { container, unmount, actualGuidelineMock } = buildContainer({});
+
+      fireEvent.mouseDown(container.querySelector('.resizer-handle.right')!);
+      fireEvent.mouseMove(container.querySelector('.resizer-handle.right')!);
+
+      unmount();
+      expect(actualGuidelineMock).toHaveBeenCalledWith({ guidelines: [] });
+    });
+  });
 });

package/src/plugins/table/types.ts

@@ -55,13 +55,6 @@ export interface PluginConfig {
   stickyHeaders?: boolean;
   allowCellOptionsInFloatingToolbar?: boolean;
   allowDistributeColumns?: boolean;
-  // to be cleaned up in ED-19477 after confluence no longer consumes table optimisation flags
-  tableCellOptimization?: boolean;
-  tableRenderOptimization?: boolean;
-  stickyHeadersOptimization?: boolean;
-  initialRenderOptimization?: boolean;
-  mouseMoveOptimization?: boolean;
-  tableOverflowShadowsOptimization?: boolean;
 }
 
 export type { ColumnResizingPluginState } from '@atlaskit/editor-common/types';

package/tmp/api-report-tmp.d.ts

@@ -52,23 +52,11 @@ interface PluginConfig {
     // (undocumented)
     allowNumberColumn?: boolean;
     // (undocumented)
-    initialRenderOptimization?: boolean;
-    // (undocumented)
     isHeaderRowRequired?: boolean;
     // (undocumented)
-    mouseMoveOptimization?: boolean;
-    // (undocumented)
     permittedLayouts?: PermittedLayoutsDescriptor;
     // (undocumented)
     stickyHeaders?: boolean;
-    // (undocumented)
-    stickyHeadersOptimization?: boolean;
-    // (undocumented)
-    tableCellOptimization?: boolean;
-    // (undocumented)
-    tableOverflowShadowsOptimization?: boolean;
-    // (undocumented)
-    tableRenderOptimization?: boolean;
 }
 
 // @public (undocumented)