@atlaskit/editor-plugin-table 18.1.13 → 18.1.15

package/CHANGELOG.md

@@ -1,5 +1,19 @@
 # @atlaskit/editor-plugin-table
 
+## 18.1.15
+
+### Patch Changes
+
+- [`12e112a137d5f`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/12e112a137d5f) -
+  Clean up platform_editor_table_fw_numcol_overflow_fix feature flag
+- Updated dependencies
+
+## 18.1.14
+
+### Patch Changes
+
+- Updated dependencies
+
 ## 18.1.13
 
 ### Patch Changes

package/dist/cjs/nodeviews/TableContainer.js

@@ -228,22 +228,14 @@ var ResizableTableContainer = exports.ResizableTableContainer = /*#__PURE__*/_re
         // When: Show scroll bars -> containerWidth = akEditorGutterPadding * 2 + lineLength;
         // When: Always -> containerWidth = akEditorGutterPadding * 2 + lineLength + scrollbarWidth;
         // scrollbarWidth can vary. Values can be 14, 15, 16 and up to 20px;
-        responsiveContainerWidth = isTableScalingEnabled ? lineLength : containerWidth - padding * 2 - resizeHandleSpacing;
-
-        // platform_editor_table_fw_numcol_overflow_fix:
         // lineLength is undefined on first paint → width: NaN → wrapper expands to page
         // width. rAF col-sizing then runs before the number-column padding and
         // the final shrink, so column widths are locked in wrong.
-        // With the flag ON, if the value isn’t finite we fall back to gutterWidth
-        // for that first frame—no flash, no premature rAF.
-        //
-        // Type clean-up comes later:
-        // 1) ship this runtime guard (quick fix, no breakage);
-        // 2) TODO: widen lineLength to `number|undefined` and remove this block.
-        if ((0, _platformFeatureFlags.fg)('platform_editor_table_fw_numcol_overflow_fix')) {
-          if (isTableScalingEnabled && !Number.isFinite(responsiveContainerWidth)) {
-            responsiveContainerWidth = containerWidth - padding * 2 - resizeHandleSpacing;
-          }
+        // If the value isn't finite we fall back to gutterWidth for that first frame.
+        if (isTableScalingEnabled && Number.isFinite(lineLength) && lineLength !== undefined) {
+          responsiveContainerWidth = lineLength;
+        } else {
+          responsiveContainerWidth = containerWidth - padding * 2 - resizeHandleSpacing;
         }
       } else if (isCommentEditor) {
         responsiveContainerWidth = containerWidth - _consts.TABLE_OFFSET_IN_COMMENT_EDITOR;
@@ -288,6 +280,8 @@ var ResizableTableContainer = exports.ResizableTableContainer = /*#__PURE__*/_re
     // when not resizing, maxWidth is calculated based on the container width via CSS
     return !isResizing ? nonResizingMaxWidth : maxResizerWidth;
   }, [isCommentEditor, isChromelessEditor, isTableScalingEnabled, isResizing, maxResizerWidth]);
+
+  // TODO: EDITOR-1679 - Add support for lineLength being undefined at runtime.
   var tableResizerProps = {
     // The `width` is used for .resizer-item in <TableResizer>, and it has to be a number
     // So we can't use min(var(--ak-editor-table-width), ${tableWidth}px) here
@@ -295,6 +289,7 @@ var ResizableTableContainer = exports.ResizableTableContainer = /*#__PURE__*/_re
     width: width,
     maxWidth: tableResizerMaxWidth,
     containerWidth: containerWidth,
+    // oxlint-disable-next-line @typescript-eslint/no-non-null-assertion -- To be fixed in EDITOR-1679
     lineLength: lineLength,
     updateWidth: updateWidth,
     editorView: editorView,

package/dist/es2019/nodeviews/TableContainer.js

@@ -224,22 +224,14 @@ export const ResizableTableContainer = /*#__PURE__*/React.memo(({
       // When: Show scroll bars -> containerWidth = akEditorGutterPadding * 2 + lineLength;
       // When: Always -> containerWidth = akEditorGutterPadding * 2 + lineLength + scrollbarWidth;
       // scrollbarWidth can vary. Values can be 14, 15, 16 and up to 20px;
-      responsiveContainerWidth = isTableScalingEnabled ? lineLength : containerWidth - padding * 2 - resizeHandleSpacing;
-
-      // platform_editor_table_fw_numcol_overflow_fix:
       // lineLength is undefined on first paint → width: NaN → wrapper expands to page
       // width. rAF col-sizing then runs before the number-column padding and
       // the final shrink, so column widths are locked in wrong.
-      // With the flag ON, if the value isn’t finite we fall back to gutterWidth
-      // for that first frame—no flash, no premature rAF.
-      //
-      // Type clean-up comes later:
-      // 1) ship this runtime guard (quick fix, no breakage);
-      // 2) TODO: widen lineLength to `number|undefined` and remove this block.
-      if (fg('platform_editor_table_fw_numcol_overflow_fix')) {
-        if (isTableScalingEnabled && !Number.isFinite(responsiveContainerWidth)) {
-          responsiveContainerWidth = containerWidth - padding * 2 - resizeHandleSpacing;
-        }
+      // If the value isn't finite we fall back to gutterWidth for that first frame.
+      if (isTableScalingEnabled && Number.isFinite(lineLength) && lineLength !== undefined) {
+        responsiveContainerWidth = lineLength;
+      } else {
+        responsiveContainerWidth = containerWidth - padding * 2 - resizeHandleSpacing;
       }
     } else if (isCommentEditor) {
       responsiveContainerWidth = containerWidth - TABLE_OFFSET_IN_COMMENT_EDITOR;
@@ -282,6 +274,8 @@ export const ResizableTableContainer = /*#__PURE__*/React.memo(({
     // when not resizing, maxWidth is calculated based on the container width via CSS
     return !isResizing ? nonResizingMaxWidth : maxResizerWidth;
   }, [isCommentEditor, isChromelessEditor, isTableScalingEnabled, isResizing, maxResizerWidth]);
+
+  // TODO: EDITOR-1679 - Add support for lineLength being undefined at runtime.
   const tableResizerProps = {
     // The `width` is used for .resizer-item in <TableResizer>, and it has to be a number
     // So we can't use min(var(--ak-editor-table-width), ${tableWidth}px) here
@@ -289,7 +283,8 @@ export const ResizableTableContainer = /*#__PURE__*/React.memo(({
     width,
     maxWidth: tableResizerMaxWidth,
     containerWidth,
-    lineLength,
+    // oxlint-disable-next-line @typescript-eslint/no-non-null-assertion -- To be fixed in EDITOR-1679
+    lineLength: lineLength,
     updateWidth,
     editorView,
     getPos,

package/dist/esm/nodeviews/TableContainer.js

@@ -219,22 +219,14 @@ export var ResizableTableContainer = /*#__PURE__*/React.memo(function (_ref4) {
         // When: Show scroll bars -> containerWidth = akEditorGutterPadding * 2 + lineLength;
         // When: Always -> containerWidth = akEditorGutterPadding * 2 + lineLength + scrollbarWidth;
         // scrollbarWidth can vary. Values can be 14, 15, 16 and up to 20px;
-        responsiveContainerWidth = isTableScalingEnabled ? lineLength : containerWidth - padding * 2 - resizeHandleSpacing;
-
-        // platform_editor_table_fw_numcol_overflow_fix:
         // lineLength is undefined on first paint → width: NaN → wrapper expands to page
         // width. rAF col-sizing then runs before the number-column padding and
         // the final shrink, so column widths are locked in wrong.
-        // With the flag ON, if the value isn’t finite we fall back to gutterWidth
-        // for that first frame—no flash, no premature rAF.
-        //
-        // Type clean-up comes later:
-        // 1) ship this runtime guard (quick fix, no breakage);
-        // 2) TODO: widen lineLength to `number|undefined` and remove this block.
-        if (fg('platform_editor_table_fw_numcol_overflow_fix')) {
-          if (isTableScalingEnabled && !Number.isFinite(responsiveContainerWidth)) {
-            responsiveContainerWidth = containerWidth - padding * 2 - resizeHandleSpacing;
-          }
+        // If the value isn't finite we fall back to gutterWidth for that first frame.
+        if (isTableScalingEnabled && Number.isFinite(lineLength) && lineLength !== undefined) {
+          responsiveContainerWidth = lineLength;
+        } else {
+          responsiveContainerWidth = containerWidth - padding * 2 - resizeHandleSpacing;
         }
       } else if (isCommentEditor) {
         responsiveContainerWidth = containerWidth - TABLE_OFFSET_IN_COMMENT_EDITOR;
@@ -279,6 +271,8 @@ export var ResizableTableContainer = /*#__PURE__*/React.memo(function (_ref4) {
     // when not resizing, maxWidth is calculated based on the container width via CSS
     return !isResizing ? nonResizingMaxWidth : maxResizerWidth;
   }, [isCommentEditor, isChromelessEditor, isTableScalingEnabled, isResizing, maxResizerWidth]);
+
+  // TODO: EDITOR-1679 - Add support for lineLength being undefined at runtime.
   var tableResizerProps = {
     // The `width` is used for .resizer-item in <TableResizer>, and it has to be a number
     // So we can't use min(var(--ak-editor-table-width), ${tableWidth}px) here
@@ -286,6 +280,7 @@ export var ResizableTableContainer = /*#__PURE__*/React.memo(function (_ref4) {
     width: width,
     maxWidth: tableResizerMaxWidth,
     containerWidth: containerWidth,
+    // oxlint-disable-next-line @typescript-eslint/no-non-null-assertion -- To be fixed in EDITOR-1679
     lineLength: lineLength,
     updateWidth: updateWidth,
     editorView: editorView,

package/dist/types/nodeviews/TableContainer.d.ts

@@ -16,7 +16,7 @@ type ResizableTableContainerProps = {
     isTableAlignmentEnabled?: boolean;
     isTableScalingEnabled?: boolean;
     isWholeTableInDanger?: boolean;
-    lineLength: number;
+    lineLength: number | undefined;
     node: PMNode;
     pluginInjectionApi?: PluginInjectionAPI;
     shouldUseIncreasedScalingPercent?: boolean;

package/dist/types-ts4.5/nodeviews/TableContainer.d.ts

@@ -16,7 +16,7 @@ type ResizableTableContainerProps = {
     isTableAlignmentEnabled?: boolean;
     isTableScalingEnabled?: boolean;
     isWholeTableInDanger?: boolean;
-    lineLength: number;
+    lineLength: number | undefined;
     node: PMNode;
     pluginInjectionApi?: PluginInjectionAPI;
     shouldUseIncreasedScalingPercent?: boolean;

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-plugin-table",
-	"version": "18.1.13",
+	"version": "18.1.15",
 	"description": "Table plugin for the @atlaskit/editor",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -49,16 +49,16 @@
 		"@atlaskit/editor-shared-styles": "^3.10.0",
 		"@atlaskit/editor-tables": "^2.9.0",
 		"@atlaskit/icon": "^33.1.0",
-		"@atlaskit/insm": "^0.3.0",
+		"@atlaskit/insm": "^0.4.0",
 		"@atlaskit/menu": "^8.4.0",
 		"@atlaskit/platform-feature-flags": "^1.1.0",
 		"@atlaskit/pragmatic-drag-and-drop": "^1.7.0",
 		"@atlaskit/pragmatic-drag-and-drop-auto-scroll": "^2.1.0",
 		"@atlaskit/pragmatic-drag-and-drop-hitbox": "^1.1.0",
 		"@atlaskit/primitives": "^18.1.0",
-		"@atlaskit/tmp-editor-statsig": "^48.0.0",
+		"@atlaskit/tmp-editor-statsig": "^48.2.0",
 		"@atlaskit/toggle": "^15.2.0",
-		"@atlaskit/tokens": "^11.3.0",
+		"@atlaskit/tokens": "^11.4.0",
 		"@atlaskit/tooltip": "^21.0.0",
 		"@babel/runtime": "^7.0.0",
 		"@emotion/react": "^11.7.1",
@@ -69,7 +69,7 @@
 		"uuid": "^3.1.0"
 	},
 	"peerDependencies": {
-		"@atlaskit/editor-common": "^112.11.0",
+		"@atlaskit/editor-common": "^112.12.0",
 		"react": "^18.2.0",
 		"react-dom": "^18.2.0",
 		"react-intl-next": "npm:react-intl@^5.18.1"
@@ -111,9 +111,6 @@
 		"platform_editor_tables_table_selector": {
 			"type": "boolean"
 		},
-		"platform_editor_table_fw_numcol_overflow_fix": {
-			"type": "boolean"
-		},
 		"platform_editor_adf_with_localid": {
 			"type": "boolean"
 		},