@atlaskit/editor-plugin-table 17.7.1 → 17.7.2

package/CHANGELOG.md

@@ -1,5 +1,16 @@
 # @atlaskit/editor-plugin-table
 
+## 17.7.2
+
+### Patch Changes
+
+- [`1fd2b267eb592`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/1fd2b267eb592) -
+  Cleanup `platform_editor_ai_aifc_patch_ga` flag
+- [`ac4a428022f83`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/ac4a428022f83) -
+  [EDITOR-5480] Removes data-borders-ready fix from table and adds border to prosemirror toDOM
+  instead
+- Updated dependencies
+
 ## 17.7.1
 
 ### Patch Changes

package/dist/cjs/nodeviews/TableContainer.js

@@ -30,9 +30,7 @@ var InnerContainer = /*#__PURE__*/(0, _react.forwardRef)(function (_ref, ref) {
   var className = _ref.className,
     style = _ref.style,
     node = _ref.node,
-    children = _ref.children,
-    tableWrapperHeight = _ref.tableWrapperHeight;
-  var bordersReady = (0, _expValEquals.expValEquals)('platform_editor_vc90_transition_table_border', 'isEnabled', true) ? tableWrapperHeight !== undefined && tableWrapperHeight > 0 : undefined;
+    children = _ref.children;
   return /*#__PURE__*/_react.default.createElement("div", {
     ref: ref
     // eslint-disable-next-line @atlaskit/ui-styling-standard/enforce-style-prop -- Ignored via go/DSP-18766
@@ -43,7 +41,6 @@ var InnerContainer = /*#__PURE__*/(0, _react.forwardRef)(function (_ref, ref) {
     className: className,
     "data-number-column": node.attrs.isNumberColumnEnabled,
     "data-layout": node.attrs.layout,
-    "data-borders-ready": bordersReady,
     "data-testid": "table-container"
   }, children);
 });
@@ -345,8 +342,7 @@ var ResizableTableContainer = exports.ResizableTableContainer = /*#__PURE__*/_re
   // eslint-disable-next-line @atlaskit/ui-styling-standard/no-classname-prop -- Ignored via go/DSP-18766
   , {
     className: className,
-    node: node,
-    tableWrapperHeight: tableWrapperHeight
+    node: node
   }, children))));
 });
 var TableContainer = exports.TableContainer = function TableContainer(_ref5) {
@@ -405,8 +401,7 @@ var TableContainer = exports.TableContainer = function TableContainer(_ref5) {
   var isFullPageAppearance = !isCommentEditor && !isChromelessEditor;
   var resizableTableWidth = isFullPageAppearance ? (0, _misc.getTableResizerContainerForFullPageWidthInCSS)(node, isTableScalingEnabled) : "calc(100cqw - calc(var(--ak-editor--large-gutter-padding) * 2))";
   return /*#__PURE__*/_react.default.createElement(InnerContainer, {
-    node: node,
-    tableWrapperHeight: tableWrapperHeight
+    node: node
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-classname-prop -- Ignored via go/DSP-18766
     ,
     className: (0, _classnames.default)(className, {

package/dist/cjs/nodeviews/TableRow.js

@@ -17,7 +17,6 @@ var _nesting = require("@atlaskit/editor-common/nesting");
 var _nodeVisibility = require("@atlaskit/editor-common/node-visibility");
 var _ui = require("@atlaskit/editor-common/ui");
 var _utils = require("@atlaskit/editor-prosemirror/utils");
-var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _pluginFactory = require("../pm-plugins/plugin-factory");
 var _pluginKey = require("../pm-plugins/plugin-key");
 var _commands = require("../pm-plugins/sticky-headers/commands");
@@ -101,20 +100,16 @@ var TableRow = exports.default = /*#__PURE__*/function (_TableNodeView) {
     }
     var pos = _this.getPos();
     _this.isInNestedTable = false;
-    if ((0, _platformFeatureFlags.fg)('platform_editor_ai_aifc_patch_ga')) {
-      try {
-        // We cannot trust that the value from getPos will be defined
-        // https://discuss.prosemirror.net/t/getpos-is-undefined-in-nodeview-constructor/1246/4
-        // There are also scenarios where the value it brings back does not tally with the current doc
-        // E.g. when AI streaming brings in new content, this position brings back incorrect values that cannot be resolved
-        if (pos) {
-          _this.isInNestedTable = (0, _nesting.getParentOfTypeCount)(view.state.schema.nodes.table)(view.state.doc.resolve(pos)) > 1;
-        }
-      } catch (e) {}
-    } else {
+    try {
+      // We cannot trust that the value from getPos will be defined
+      // https://discuss.prosemirror.net/t/getpos-is-undefined-in-nodeview-constructor/1246/4
+      // There are also scenarios where the value it brings back does not tally with the current doc
+      // E.g. when AI streaming brings in new content, this position brings back incorrect values that cannot be resolved
       if (pos) {
         _this.isInNestedTable = (0, _nesting.getParentOfTypeCount)(view.state.schema.nodes.table)(view.state.doc.resolve(pos)) > 1;
       }
+    } catch (_unused) {
+      // Intentionally swallowed — getPos can return stale positions during AI streaming
     }
     if (_this.isHeaderRow) {
       _this.dom.setAttribute('data-vc-nvs', 'true');

package/dist/cjs/nodeviews/toDOM.js

@@ -62,7 +62,16 @@ var tableNodeSpecWithFixedToDOM = exports.tableNodeSpecWithFixedToDOM = function
       }, ['table', attrs, colgroup, ['tbody', 0]]], ['div', {
         class: 'pm-table-sticky-sentinel-bottom',
         'data-testid': 'sticky-sentinel-bottom'
-      }]];
+      }]].concat((0, _toConsumableArray2.default)((0, _expValEquals.expValEquals)('platform_editor_vc90_transition_table_border', 'isEnabled', true) ? [['div', {
+        contenteditable: 'false',
+        class: 'pm-table-left-border',
+        'data-with-numbered-table': node.attrs.isNumberColumnEnabled,
+        'data-testid': 'table-left-border'
+      }], ['div', {
+        contenteditable: 'false',
+        class: 'pm-table-right-border',
+        'data-testid': 'table-right-border'
+      }]] : []));
       if (!config.tableResizingEnabled || config.isNested) {
         return ['div', {
           class: 'tableView-content-wrap',

package/dist/es2019/nodeviews/TableContainer.js

@@ -20,10 +20,8 @@ const InnerContainer = /*#__PURE__*/forwardRef(({
   className,
   style,
   node,
-  children,
-  tableWrapperHeight
+  children
 }, ref) => {
-  const bordersReady = expValEquals('platform_editor_vc90_transition_table_border', 'isEnabled', true) ? tableWrapperHeight !== undefined && tableWrapperHeight > 0 : undefined;
   return /*#__PURE__*/React.createElement("div", {
     ref: ref
     // eslint-disable-next-line @atlaskit/ui-styling-standard/enforce-style-prop -- Ignored via go/DSP-18766
@@ -34,7 +32,6 @@ const InnerContainer = /*#__PURE__*/forwardRef(({
     className: className,
     "data-number-column": node.attrs.isNumberColumnEnabled,
     "data-layout": node.attrs.layout,
-    "data-borders-ready": bordersReady,
     "data-testid": "table-container"
   }, children);
 });
@@ -339,8 +336,7 @@ export const ResizableTableContainer = /*#__PURE__*/React.memo(({
   // eslint-disable-next-line @atlaskit/ui-styling-standard/no-classname-prop -- Ignored via go/DSP-18766
   , {
     className: className,
-    node: node,
-    tableWrapperHeight: tableWrapperHeight
+    node: node
   }, children))));
 });
 export const TableContainer = ({
@@ -402,8 +398,7 @@ export const TableContainer = ({
   const isFullPageAppearance = !isCommentEditor && !isChromelessEditor;
   const resizableTableWidth = isFullPageAppearance ? getTableResizerContainerForFullPageWidthInCSS(node, isTableScalingEnabled) : `calc(100cqw - calc(var(--ak-editor--large-gutter-padding) * 2))`;
   return /*#__PURE__*/React.createElement(InnerContainer, {
-    node: node,
-    tableWrapperHeight: tableWrapperHeight
+    node: node
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-classname-prop -- Ignored via go/DSP-18766
     ,
     className: classNames(className, {

package/dist/es2019/nodeviews/TableRow.js

@@ -5,7 +5,6 @@ import { getParentOfTypeCount } from '@atlaskit/editor-common/nesting';
 import { nodeVisibilityManager } from '@atlaskit/editor-common/node-visibility';
 import { findOverflowScrollParent } from '@atlaskit/editor-common/ui';
 import { findParentNodeClosestToPos } from '@atlaskit/editor-prosemirror/utils';
-import { fg } from '@atlaskit/platform-feature-flags';
 import { getPluginState } from '../pm-plugins/plugin-factory';
 import { pluginKey as tablePluginKey } from '../pm-plugins/plugin-key';
 import { updateStickyState } from '../pm-plugins/sticky-headers/commands';
@@ -86,20 +85,16 @@ export default class TableRow extends TableNodeView {
     }
     const pos = this.getPos();
     this.isInNestedTable = false;
-    if (fg('platform_editor_ai_aifc_patch_ga')) {
-      try {
-        // We cannot trust that the value from getPos will be defined
-        // https://discuss.prosemirror.net/t/getpos-is-undefined-in-nodeview-constructor/1246/4
-        // There are also scenarios where the value it brings back does not tally with the current doc
-        // E.g. when AI streaming brings in new content, this position brings back incorrect values that cannot be resolved
-        if (pos) {
-          this.isInNestedTable = getParentOfTypeCount(view.state.schema.nodes.table)(view.state.doc.resolve(pos)) > 1;
-        }
-      } catch (e) {}
-    } else {
+    try {
+      // We cannot trust that the value from getPos will be defined
+      // https://discuss.prosemirror.net/t/getpos-is-undefined-in-nodeview-constructor/1246/4
+      // There are also scenarios where the value it brings back does not tally with the current doc
+      // E.g. when AI streaming brings in new content, this position brings back incorrect values that cannot be resolved
       if (pos) {
         this.isInNestedTable = getParentOfTypeCount(view.state.schema.nodes.table)(view.state.doc.resolve(pos)) > 1;
       }
+    } catch {
+      // Intentionally swallowed — getPos can return stale positions during AI streaming
     }
     if (this.isHeaderRow) {
       this.dom.setAttribute('data-vc-nvs', 'true');

package/dist/es2019/nodeviews/toDOM.js

@@ -46,7 +46,16 @@ export const tableNodeSpecWithFixedToDOM = config => {
       }, ['table', attrs, colgroup, ['tbody', 0]]], ['div', {
         class: 'pm-table-sticky-sentinel-bottom',
         'data-testid': 'sticky-sentinel-bottom'
-      }]];
+      }], ...(expValEquals('platform_editor_vc90_transition_table_border', 'isEnabled', true) ? [['div', {
+        contenteditable: 'false',
+        class: 'pm-table-left-border',
+        'data-with-numbered-table': node.attrs.isNumberColumnEnabled,
+        'data-testid': 'table-left-border'
+      }], ['div', {
+        contenteditable: 'false',
+        class: 'pm-table-right-border',
+        'data-testid': 'table-right-border'
+      }]] : [])];
       if (!config.tableResizingEnabled || config.isNested) {
         return ['div', {
           class: 'tableView-content-wrap',

package/dist/esm/nodeviews/TableContainer.js

@@ -21,9 +21,7 @@ var InnerContainer = /*#__PURE__*/forwardRef(function (_ref, ref) {
   var className = _ref.className,
     style = _ref.style,
     node = _ref.node,
-    children = _ref.children,
-    tableWrapperHeight = _ref.tableWrapperHeight;
-  var bordersReady = expValEquals('platform_editor_vc90_transition_table_border', 'isEnabled', true) ? tableWrapperHeight !== undefined && tableWrapperHeight > 0 : undefined;
+    children = _ref.children;
   return /*#__PURE__*/React.createElement("div", {
     ref: ref
     // eslint-disable-next-line @atlaskit/ui-styling-standard/enforce-style-prop -- Ignored via go/DSP-18766
@@ -34,7 +32,6 @@ var InnerContainer = /*#__PURE__*/forwardRef(function (_ref, ref) {
     className: className,
     "data-number-column": node.attrs.isNumberColumnEnabled,
     "data-layout": node.attrs.layout,
-    "data-borders-ready": bordersReady,
     "data-testid": "table-container"
   }, children);
 });
@@ -336,8 +333,7 @@ export var ResizableTableContainer = /*#__PURE__*/React.memo(function (_ref4) {
   // eslint-disable-next-line @atlaskit/ui-styling-standard/no-classname-prop -- Ignored via go/DSP-18766
   , {
     className: className,
-    node: node,
-    tableWrapperHeight: tableWrapperHeight
+    node: node
   }, children))));
 });
 export var TableContainer = function TableContainer(_ref5) {
@@ -396,8 +392,7 @@ export var TableContainer = function TableContainer(_ref5) {
   var isFullPageAppearance = !isCommentEditor && !isChromelessEditor;
   var resizableTableWidth = isFullPageAppearance ? getTableResizerContainerForFullPageWidthInCSS(node, isTableScalingEnabled) : "calc(100cqw - calc(var(--ak-editor--large-gutter-padding) * 2))";
   return /*#__PURE__*/React.createElement(InnerContainer, {
-    node: node,
-    tableWrapperHeight: tableWrapperHeight
+    node: node
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-classname-prop -- Ignored via go/DSP-18766
     ,
     className: classNames(className, {

package/dist/esm/nodeviews/TableRow.js

@@ -12,7 +12,6 @@ import { getParentOfTypeCount } from '@atlaskit/editor-common/nesting';
 import { nodeVisibilityManager } from '@atlaskit/editor-common/node-visibility';
 import { findOverflowScrollParent } from '@atlaskit/editor-common/ui';
 import { findParentNodeClosestToPos } from '@atlaskit/editor-prosemirror/utils';
-import { fg } from '@atlaskit/platform-feature-flags';
 import { getPluginState } from '../pm-plugins/plugin-factory';
 import { pluginKey as tablePluginKey } from '../pm-plugins/plugin-key';
 import { updateStickyState } from '../pm-plugins/sticky-headers/commands';
@@ -94,20 +93,16 @@ var TableRow = /*#__PURE__*/function (_TableNodeView) {
     }
     var pos = _this.getPos();
     _this.isInNestedTable = false;
-    if (fg('platform_editor_ai_aifc_patch_ga')) {
-      try {
-        // We cannot trust that the value from getPos will be defined
-        // https://discuss.prosemirror.net/t/getpos-is-undefined-in-nodeview-constructor/1246/4
-        // There are also scenarios where the value it brings back does not tally with the current doc
-        // E.g. when AI streaming brings in new content, this position brings back incorrect values that cannot be resolved
-        if (pos) {
-          _this.isInNestedTable = getParentOfTypeCount(view.state.schema.nodes.table)(view.state.doc.resolve(pos)) > 1;
-        }
-      } catch (e) {}
-    } else {
+    try {
+      // We cannot trust that the value from getPos will be defined
+      // https://discuss.prosemirror.net/t/getpos-is-undefined-in-nodeview-constructor/1246/4
+      // There are also scenarios where the value it brings back does not tally with the current doc
+      // E.g. when AI streaming brings in new content, this position brings back incorrect values that cannot be resolved
       if (pos) {
         _this.isInNestedTable = getParentOfTypeCount(view.state.schema.nodes.table)(view.state.doc.resolve(pos)) > 1;
       }
+    } catch (_unused) {
+      // Intentionally swallowed — getPos can return stale positions during AI streaming
     }
     if (_this.isHeaderRow) {
       _this.dom.setAttribute('data-vc-nvs', 'true');

package/dist/esm/nodeviews/toDOM.js

@@ -55,7 +55,16 @@ export var tableNodeSpecWithFixedToDOM = function tableNodeSpecWithFixedToDOM(co
       }, ['table', attrs, colgroup, ['tbody', 0]]], ['div', {
         class: 'pm-table-sticky-sentinel-bottom',
         'data-testid': 'sticky-sentinel-bottom'
-      }]];
+      }]].concat(_toConsumableArray(expValEquals('platform_editor_vc90_transition_table_border', 'isEnabled', true) ? [['div', {
+        contenteditable: 'false',
+        class: 'pm-table-left-border',
+        'data-with-numbered-table': node.attrs.isNumberColumnEnabled,
+        'data-testid': 'table-left-border'
+      }], ['div', {
+        contenteditable: 'false',
+        class: 'pm-table-right-border',
+        'data-testid': 'table-right-border'
+      }]] : []));
       if (!config.tableResizingEnabled || config.isNested) {
         return ['div', {
           class: 'tableView-content-wrap',

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-plugin-table",
-	"version": "17.7.1",
+	"version": "17.7.2",
 	"description": "Table plugin for the @atlaskit/editor",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -41,7 +41,7 @@
 		"@atlaskit/editor-plugin-guideline": "^7.0.0",
 		"@atlaskit/editor-plugin-interaction": "^14.0.0",
 		"@atlaskit/editor-plugin-limited-mode": "^4.0.0",
-		"@atlaskit/editor-plugin-selection": "^7.0.0",
+		"@atlaskit/editor-plugin-selection": "^7.1.0",
 		"@atlaskit/editor-plugin-toolbar": "^4.1.0",
 		"@atlaskit/editor-plugin-user-intent": "^5.0.0",
 		"@atlaskit/editor-plugin-width": "^8.1.0",
@@ -57,9 +57,9 @@
 		"@atlaskit/pragmatic-drag-and-drop-hitbox": "^1.1.0",
 		"@atlaskit/primitives": "^18.0.0",
 		"@atlaskit/theme": "^22.0.0",
-		"@atlaskit/tmp-editor-statsig": "^35.0.0",
+		"@atlaskit/tmp-editor-statsig": "^35.5.0",
 		"@atlaskit/toggle": "^15.2.0",
-		"@atlaskit/tokens": "^11.0.0",
+		"@atlaskit/tokens": "^11.1.0",
 		"@atlaskit/tooltip": "^20.14.0",
 		"@babel/runtime": "^7.0.0",
 		"@emotion/react": "^11.7.1",
@@ -70,7 +70,7 @@
 		"uuid": "^3.1.0"
 	},
 	"peerDependencies": {
-		"@atlaskit/editor-common": "^111.30.0",
+		"@atlaskit/editor-common": "^111.32.0",
 		"react": "^18.2.0",
 		"react-dom": "^18.2.0",
 		"react-intl-next": "npm:react-intl@^5.18.1"
@@ -136,9 +136,6 @@
 		"platform_editor_table_height_analytics_event": {
 			"type": "boolean"
 		},
-		"platform_editor_ai_aifc_patch_ga": {
-			"type": "boolean"
-		},
 		"platform_editor_change_table_nesting_check": {
 			"type": "boolean"
 		},