@atlaskit/editor-plugin-table 17.7.0 → 17.7.1

package/CHANGELOG.md

@@ -1,5 +1,15 @@
 # @atlaskit/editor-plugin-table
 
+## 17.7.1
+
+### Patch Changes
+
+- [`94dbc76370522`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/94dbc76370522) -
+  [ux] remove unnecessary decoration for last cell element in table
+- [`1d6c1d6ba61dc`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/1d6c1d6ba61dc) -
+  FFCLEANUP-79953 clean up stale experiment platform_editor_editor_width_analytics
+- Updated dependencies
+
 ## 17.7.0
 
 ### Minor Changes

package/dist/cjs/pm-plugins/utils/decoration.js

@@ -13,6 +13,7 @@ var _utils = require("@atlaskit/editor-common/utils");
 var _view = require("@atlaskit/editor-prosemirror/view");
 var _tableMap = require("@atlaskit/editor-tables/table-map");
 var _utils2 = require("@atlaskit/editor-tables/utils");
+var _expValEquals = require("@atlaskit/tmp-editor-statsig/exp-val-equals");
 var _types = require("../../types");
 var _ColumnResizeWidget = require("../../ui/ColumnResizeWidget");
 // eslint-disable-next-line @atlaskit/platform/prefer-crypto-random-uuid -- Use crypto.randomUUID instead
@@ -287,12 +288,17 @@ var createResizeHandleDecoration = exports.createResizeHandleDecoration = functi
       return element;
     }, {
       key: "".concat(_types.TableDecorations.COLUMN_RESIZING_HANDLE_WIDGET, "_").concat(rowIndex, "_").concat(columnIndex, "_").concat(includeTooltip ? 'with' : 'no', "-tooltip"),
-      destroy: function destroy(node) {
+      destroy: function destroy(_node) {
         nodeViewPortalProviderAPI.remove(decorationRenderKey);
       }
     });
   };
   var createLastCellElementDecoration = function createLastCellElementDecoration(cellColumnPositioning, cellPos, cellNode) {
+    if ((0, _expValEquals.expValEquals)('platform_editor_table_remove_last_cell_decoration', 'isEnabled', true)) {
+      // no longer need to add the last cell decoration to override marginBottom as media wrapper doesn't have margin bottom. This will avoid unnecessary decoration computation/mutation and improve performance
+      // consider clean up ClassName.LAST_ITEM_IN_CELL with platform_editor_table_remove_last_cell_decoration experiment
+      return null;
+    }
     var lastItemPositions;
     cellNode.forEach(function (childNode, offset, index) {
       if (index === cellNode.childCount - 1) {

package/dist/cjs/tablePlugin.js

@@ -433,39 +433,37 @@ var tablePlugin = function tablePlugin(_ref) {
           return new _safePlugin.SafePlugin({
             view: function view(editorView) {
               editorViewRef.current = editorView;
-              var setTimeoutID;
               var rafID;
               var ricID;
-              if ((0, _expValEquals.expValEquals)('platform_editor_editor_width_analytics', 'isEnabled', true)) {
-                // send statistics about the widths of the tables on the page for alerting
-                // only send this event once, after the editorView is first initialised
-                setTimeoutID = setTimeout(function () {
-                  var requestIdleCallbackFn = function requestIdleCallbackFn() {
-                    var _api$width$sharedStat2;
-                    var editorWidth = api === null || api === void 0 || (_api$width$sharedStat2 = api.width.sharedState.currentState()) === null || _api$width$sharedStat2 === void 0 ? void 0 : _api$width$sharedStat2.width;
-                    if (editorViewRef.current) {
-                      if (editorWidth) {
-                        var payload = (0, _analytics2.getWidthInfoPayload)(editorViewRef.current, editorWidth);
-                        if (payload) {
-                          dispatchAnalyticsEvent(payload);
-                        }
+
+              // send statistics about the widths of the tables on the page for alerting
+              // only send this event once, after the editorView is first initialised
+              var setTimeoutID = setTimeout(function () {
+                var requestIdleCallbackFn = function requestIdleCallbackFn() {
+                  var _api$width$sharedStat2;
+                  var editorWidth = api === null || api === void 0 || (_api$width$sharedStat2 = api.width.sharedState.currentState()) === null || _api$width$sharedStat2 === void 0 ? void 0 : _api$width$sharedStat2.width;
+                  if (editorViewRef.current) {
+                    if (editorWidth) {
+                      var payload = (0, _analytics2.getWidthInfoPayload)(editorViewRef.current, editorWidth);
+                      if (payload) {
+                        dispatchAnalyticsEvent(payload);
                       }
-                      if ((0, _platformFeatureFlags.fg)('platform_editor_table_height_analytics_event')) {
-                        var payloadHeight = (0, _analytics2.getHeightInfoPayload)(editorViewRef.current);
-                        if (payloadHeight) {
-                          dispatchAnalyticsEvent(payloadHeight);
-                        }
+                    }
+                    if ((0, _platformFeatureFlags.fg)('platform_editor_table_height_analytics_event')) {
+                      var payloadHeight = (0, _analytics2.getHeightInfoPayload)(editorViewRef.current);
+                      if (payloadHeight) {
+                        dispatchAnalyticsEvent(payloadHeight);
                       }
                     }
-                  };
-                  if (window && typeof window.requestIdleCallback === 'function') {
-                    ricID = window.requestIdleCallback(requestIdleCallbackFn);
-                  } else if (window && typeof window.requestAnimationFrame === 'function') {
-                    // requestIdleCallback is not supported in safari, fallback to requestAnimationFrame
-                    rafID = window.requestAnimationFrame(requestIdleCallbackFn);
                   }
-                }, TABLE_WIDTH_INFO_TIMEOUT);
-              }
+                };
+                if (window && typeof window.requestIdleCallback === 'function') {
+                  ricID = window.requestIdleCallback(requestIdleCallbackFn);
+                } else if (window && typeof window.requestAnimationFrame === 'function') {
+                  // requestIdleCallback is not supported in safari, fallback to requestAnimationFrame
+                  rafID = window.requestAnimationFrame(requestIdleCallbackFn);
+                }
+              }, TABLE_WIDTH_INFO_TIMEOUT);
               return {
                 destroy: function destroy() {
                   editorViewRef.current = null;

package/dist/es2019/pm-plugins/utils/decoration.js

@@ -9,6 +9,7 @@ import { nonNullable } from '@atlaskit/editor-common/utils';
 import { Decoration } from '@atlaskit/editor-prosemirror/view';
 import { TableMap } from '@atlaskit/editor-tables/table-map';
 import { findTable, getCellsInRow, getSelectionRect } from '@atlaskit/editor-tables/utils';
+import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 import { TableCssClassName as ClassName, TableDecorations } from '../../types';
 import { ColumnResizeWidget } from '../../ui/ColumnResizeWidget';
 const filterDecorationByKey = (key, decorationSet) => decorationSet.find(undefined, undefined, spec => spec.key.indexOf(key) > -1);
@@ -254,12 +255,17 @@ export const createResizeHandleDecoration = (tr, rowIndexTarget, columnEndIndexT
       return element;
     }, {
       key: `${TableDecorations.COLUMN_RESIZING_HANDLE_WIDGET}_${rowIndex}_${columnIndex}_${includeTooltip ? 'with' : 'no'}-tooltip`,
-      destroy: node => {
+      destroy: _node => {
         nodeViewPortalProviderAPI.remove(decorationRenderKey);
       }
     });
   };
   const createLastCellElementDecoration = (cellColumnPositioning, cellPos, cellNode) => {
+    if (expValEquals('platform_editor_table_remove_last_cell_decoration', 'isEnabled', true)) {
+      // no longer need to add the last cell decoration to override marginBottom as media wrapper doesn't have margin bottom. This will avoid unnecessary decoration computation/mutation and improve performance
+      // consider clean up ClassName.LAST_ITEM_IN_CELL with platform_editor_table_remove_last_cell_decoration experiment
+      return null;
+    }
     let lastItemPositions;
     cellNode.forEach((childNode, offset, index) => {
       if (index === cellNode.childCount - 1) {

package/dist/es2019/tablePlugin.js

@@ -423,39 +423,37 @@ const tablePlugin = ({
           return new SafePlugin({
             view: editorView => {
               editorViewRef.current = editorView;
-              let setTimeoutID;
               let rafID;
               let ricID;
-              if (expValEquals('platform_editor_editor_width_analytics', 'isEnabled', true)) {
-                // send statistics about the widths of the tables on the page for alerting
-                // only send this event once, after the editorView is first initialised
-                setTimeoutID = setTimeout(() => {
-                  const requestIdleCallbackFn = () => {
-                    var _api$width$sharedStat2;
-                    const editorWidth = api === null || api === void 0 ? void 0 : (_api$width$sharedStat2 = api.width.sharedState.currentState()) === null || _api$width$sharedStat2 === void 0 ? void 0 : _api$width$sharedStat2.width;
-                    if (editorViewRef.current) {
-                      if (editorWidth) {
-                        const payload = getWidthInfoPayload(editorViewRef.current, editorWidth);
-                        if (payload) {
-                          dispatchAnalyticsEvent(payload);
-                        }
+
+              // send statistics about the widths of the tables on the page for alerting
+              // only send this event once, after the editorView is first initialised
+              const setTimeoutID = setTimeout(() => {
+                const requestIdleCallbackFn = () => {
+                  var _api$width$sharedStat2;
+                  const editorWidth = api === null || api === void 0 ? void 0 : (_api$width$sharedStat2 = api.width.sharedState.currentState()) === null || _api$width$sharedStat2 === void 0 ? void 0 : _api$width$sharedStat2.width;
+                  if (editorViewRef.current) {
+                    if (editorWidth) {
+                      const payload = getWidthInfoPayload(editorViewRef.current, editorWidth);
+                      if (payload) {
+                        dispatchAnalyticsEvent(payload);
                       }
-                      if (fg('platform_editor_table_height_analytics_event')) {
-                        const payloadHeight = getHeightInfoPayload(editorViewRef.current);
-                        if (payloadHeight) {
-                          dispatchAnalyticsEvent(payloadHeight);
-                        }
+                    }
+                    if (fg('platform_editor_table_height_analytics_event')) {
+                      const payloadHeight = getHeightInfoPayload(editorViewRef.current);
+                      if (payloadHeight) {
+                        dispatchAnalyticsEvent(payloadHeight);
                       }
                     }
-                  };
-                  if (window && typeof window.requestIdleCallback === 'function') {
-                    ricID = window.requestIdleCallback(requestIdleCallbackFn);
-                  } else if (window && typeof window.requestAnimationFrame === 'function') {
-                    // requestIdleCallback is not supported in safari, fallback to requestAnimationFrame
-                    rafID = window.requestAnimationFrame(requestIdleCallbackFn);
                   }
-                }, TABLE_WIDTH_INFO_TIMEOUT);
-              }
+                };
+                if (window && typeof window.requestIdleCallback === 'function') {
+                  ricID = window.requestIdleCallback(requestIdleCallbackFn);
+                } else if (window && typeof window.requestAnimationFrame === 'function') {
+                  // requestIdleCallback is not supported in safari, fallback to requestAnimationFrame
+                  rafID = window.requestAnimationFrame(requestIdleCallbackFn);
+                }
+              }, TABLE_WIDTH_INFO_TIMEOUT);
               return {
                 destroy: () => {
                   editorViewRef.current = null;

package/dist/esm/pm-plugins/utils/decoration.js

@@ -10,6 +10,7 @@ import { nonNullable } from '@atlaskit/editor-common/utils';
 import { Decoration } from '@atlaskit/editor-prosemirror/view';
 import { TableMap } from '@atlaskit/editor-tables/table-map';
 import { findTable, getCellsInRow, getSelectionRect } from '@atlaskit/editor-tables/utils';
+import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 import { TableCssClassName as ClassName, TableDecorations } from '../../types';
 import { ColumnResizeWidget } from '../../ui/ColumnResizeWidget';
 var filterDecorationByKey = function filterDecorationByKey(key, decorationSet) {
@@ -280,12 +281,17 @@ export var createResizeHandleDecoration = function createResizeHandleDecoration(
       return element;
     }, {
       key: "".concat(TableDecorations.COLUMN_RESIZING_HANDLE_WIDGET, "_").concat(rowIndex, "_").concat(columnIndex, "_").concat(includeTooltip ? 'with' : 'no', "-tooltip"),
-      destroy: function destroy(node) {
+      destroy: function destroy(_node) {
         nodeViewPortalProviderAPI.remove(decorationRenderKey);
       }
     });
   };
   var createLastCellElementDecoration = function createLastCellElementDecoration(cellColumnPositioning, cellPos, cellNode) {
+    if (expValEquals('platform_editor_table_remove_last_cell_decoration', 'isEnabled', true)) {
+      // no longer need to add the last cell decoration to override marginBottom as media wrapper doesn't have margin bottom. This will avoid unnecessary decoration computation/mutation and improve performance
+      // consider clean up ClassName.LAST_ITEM_IN_CELL with platform_editor_table_remove_last_cell_decoration experiment
+      return null;
+    }
     var lastItemPositions;
     cellNode.forEach(function (childNode, offset, index) {
       if (index === cellNode.childCount - 1) {

package/dist/esm/tablePlugin.js

@@ -424,39 +424,37 @@ var tablePlugin = function tablePlugin(_ref) {
           return new SafePlugin({
             view: function view(editorView) {
               editorViewRef.current = editorView;
-              var setTimeoutID;
               var rafID;
               var ricID;
-              if (expValEquals('platform_editor_editor_width_analytics', 'isEnabled', true)) {
-                // send statistics about the widths of the tables on the page for alerting
-                // only send this event once, after the editorView is first initialised
-                setTimeoutID = setTimeout(function () {
-                  var requestIdleCallbackFn = function requestIdleCallbackFn() {
-                    var _api$width$sharedStat2;
-                    var editorWidth = api === null || api === void 0 || (_api$width$sharedStat2 = api.width.sharedState.currentState()) === null || _api$width$sharedStat2 === void 0 ? void 0 : _api$width$sharedStat2.width;
-                    if (editorViewRef.current) {
-                      if (editorWidth) {
-                        var payload = getWidthInfoPayload(editorViewRef.current, editorWidth);
-                        if (payload) {
-                          dispatchAnalyticsEvent(payload);
-                        }
+
+              // send statistics about the widths of the tables on the page for alerting
+              // only send this event once, after the editorView is first initialised
+              var setTimeoutID = setTimeout(function () {
+                var requestIdleCallbackFn = function requestIdleCallbackFn() {
+                  var _api$width$sharedStat2;
+                  var editorWidth = api === null || api === void 0 || (_api$width$sharedStat2 = api.width.sharedState.currentState()) === null || _api$width$sharedStat2 === void 0 ? void 0 : _api$width$sharedStat2.width;
+                  if (editorViewRef.current) {
+                    if (editorWidth) {
+                      var payload = getWidthInfoPayload(editorViewRef.current, editorWidth);
+                      if (payload) {
+                        dispatchAnalyticsEvent(payload);
                       }
-                      if (fg('platform_editor_table_height_analytics_event')) {
-                        var payloadHeight = getHeightInfoPayload(editorViewRef.current);
-                        if (payloadHeight) {
-                          dispatchAnalyticsEvent(payloadHeight);
-                        }
+                    }
+                    if (fg('platform_editor_table_height_analytics_event')) {
+                      var payloadHeight = getHeightInfoPayload(editorViewRef.current);
+                      if (payloadHeight) {
+                        dispatchAnalyticsEvent(payloadHeight);
                       }
                     }
-                  };
-                  if (window && typeof window.requestIdleCallback === 'function') {
-                    ricID = window.requestIdleCallback(requestIdleCallbackFn);
-                  } else if (window && typeof window.requestAnimationFrame === 'function') {
-                    // requestIdleCallback is not supported in safari, fallback to requestAnimationFrame
-                    rafID = window.requestAnimationFrame(requestIdleCallbackFn);
                   }
-                }, TABLE_WIDTH_INFO_TIMEOUT);
-              }
+                };
+                if (window && typeof window.requestIdleCallback === 'function') {
+                  ricID = window.requestIdleCallback(requestIdleCallbackFn);
+                } else if (window && typeof window.requestAnimationFrame === 'function') {
+                  // requestIdleCallback is not supported in safari, fallback to requestAnimationFrame
+                  rafID = window.requestAnimationFrame(requestIdleCallbackFn);
+                }
+              }, TABLE_WIDTH_INFO_TIMEOUT);
               return {
                 destroy: function destroy() {
                   editorViewRef.current = null;

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-plugin-table",
-	"version": "17.7.0",
+	"version": "17.7.1",
 	"description": "Table plugin for the @atlaskit/editor",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -37,7 +37,7 @@
 		"@atlaskit/editor-plugin-batch-attribute-updates": "^7.0.0",
 		"@atlaskit/editor-plugin-content-insertion": "^7.0.0",
 		"@atlaskit/editor-plugin-editor-viewmode": "^9.0.0",
-		"@atlaskit/editor-plugin-extension": "10.1.17",
+		"@atlaskit/editor-plugin-extension": "10.1.18",
 		"@atlaskit/editor-plugin-guideline": "^7.0.0",
 		"@atlaskit/editor-plugin-interaction": "^14.0.0",
 		"@atlaskit/editor-plugin-limited-mode": "^4.0.0",
@@ -57,7 +57,7 @@
 		"@atlaskit/pragmatic-drag-and-drop-hitbox": "^1.1.0",
 		"@atlaskit/primitives": "^18.0.0",
 		"@atlaskit/theme": "^22.0.0",
-		"@atlaskit/tmp-editor-statsig": "^34.1.0",
+		"@atlaskit/tmp-editor-statsig": "^35.0.0",
 		"@atlaskit/toggle": "^15.2.0",
 		"@atlaskit/tokens": "^11.0.0",
 		"@atlaskit/tooltip": "^20.14.0",
@@ -70,7 +70,7 @@
 		"uuid": "^3.1.0"
 	},
 	"peerDependencies": {
-		"@atlaskit/editor-common": "^111.28.0",
+		"@atlaskit/editor-common": "^111.30.0",
 		"react": "^18.2.0",
 		"react-dom": "^18.2.0",
 		"react-intl-next": "npm:react-intl@^5.18.1"