@atlaskit/editor-plugin-table 15.6.7 → 15.6.8

package/CHANGELOG.md

@@ -1,5 +1,12 @@
 # @atlaskit/editor-plugin-table
 
+## 15.6.8
+
+### Patch Changes
+
+- [`b1ea4fa4e8e56`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/b1ea4fa4e8e56) -
+  Remove static scroll listener
+
 ## 15.6.7
 
 ### Patch Changes

package/dist/cjs/nodeviews/TableRowNativeStickyWithFallback.js

@@ -79,6 +79,7 @@ var TableRowNativeStickyWithFallback = exports.default = /*#__PURE__*/function (
     (0, _defineProperty2.default)(_this, "listening", false);
     (0, _defineProperty2.default)(_this, "padding", 0);
     (0, _defineProperty2.default)(_this, "top", 0);
+    (0, _defineProperty2.default)(_this, "hasScrolledSinceLoad", false);
     (0, _defineProperty2.default)(_this, "disableNativeSticky", false);
     /**
      * Methods
@@ -261,45 +262,43 @@ var TableRowNativeStickyWithFallback = exports.default = /*#__PURE__*/function (
       if (this.editorScrollableElement) {
         this.initObservers();
         this.topPosEditorElement = (0, _dom2.getTop)(this.editorScrollableElement);
-        if (!TableRowNativeStickyWithFallback.scrollListener && (0, _platformFeatureFlags.fg)('platform_editor_table_sticky_header_patch_5')) {
-          TableRowNativeStickyWithFallback.scrollListener = function () {
-            if (TableRowNativeStickyWithFallback.hasScrolledSinceLoad) {
+        if ((0, _platformFeatureFlags.fg)('platform_editor_table_sticky_header_patch_5')) {
+          this.scrollListener = function () {
+            var _this3$overflowObserv;
+            if (_this3.hasScrolledSinceLoad) {
               return;
             }
-            TableRowNativeStickyWithFallback.hasScrolledSinceLoad = true;
+            _this3.hasScrolledSinceLoad = true;
             if (!_this3.overflowObserver) {
               return;
             }
 
             // Re-check intersection state now that scrolling has occurred
-            if (_this3.overflowObserver) {
-              var _this3$overflowObserv;
-              var entries = (_this3$overflowObserv = _this3.overflowObserverEntries) !== null && _this3$overflowObserv !== void 0 ? _this3$overflowObserv : _this3.overflowObserver.takeRecords();
-              _this3.overflowObserverEntries = undefined;
-
-              /** NOTE: This logic is duplicated in the overflowObserver callback
-               *  to avoid conflicting with a follow up refactor where this will
-               *  be cleaned up.
-               */
-              entries.forEach(function (entry) {
-                var tableWrapper = _this3.dom.closest(".".concat(_types.TableCssClassName.TABLE_NODE_WRAPPER));
-                if (tableWrapper && tableWrapper instanceof HTMLElement) {
-                  if (entry.isIntersecting) {
-                    tableWrapper.classList.add(_types.TableCssClassName.TABLE_NODE_WRAPPER_NO_OVERFLOW);
-                    _this3.dom.classList.add(_types.TableCssClassName.NATIVE_STICKY);
-                    _this3.isNativeSticky = true;
-                  } else {
-                    tableWrapper.classList.remove(_types.TableCssClassName.TABLE_NODE_WRAPPER_NO_OVERFLOW);
-                    _this3.dom.classList.remove(_types.TableCssClassName.NATIVE_STICKY);
-                    _this3.isNativeSticky = false;
-                  }
-                  _this3.refreshLegacyStickyState();
+            var entries = (_this3$overflowObserv = _this3.overflowObserverEntries) !== null && _this3$overflowObserv !== void 0 ? _this3$overflowObserv : _this3.overflowObserver.takeRecords();
+            _this3.overflowObserverEntries = undefined;
+
+            /** NOTE: This logic is duplicated in the overflowObserver callback
+             *  to avoid conflicting with a follow up refactor where this will
+             *  be cleaned up.
+             */
+            entries.forEach(function (entry) {
+              var tableWrapper = _this3.dom.closest(".".concat(_types.TableCssClassName.TABLE_NODE_WRAPPER));
+              if (tableWrapper && tableWrapper instanceof HTMLElement) {
+                if (entry.isIntersecting) {
+                  tableWrapper.classList.add(_types.TableCssClassName.TABLE_NODE_WRAPPER_NO_OVERFLOW);
+                  _this3.dom.classList.add(_types.TableCssClassName.NATIVE_STICKY);
+                  _this3.isNativeSticky = true;
+                } else {
+                  tableWrapper.classList.remove(_types.TableCssClassName.TABLE_NODE_WRAPPER_NO_OVERFLOW);
+                  _this3.dom.classList.remove(_types.TableCssClassName.NATIVE_STICKY);
+                  _this3.isNativeSticky = false;
                 }
-              });
-            }
+                _this3.refreshLegacyStickyState();
+              }
+            });
           };
           // eslint-disable-next-line @repo/internal/dom-events/no-unsafe-event-listeners
-          this.editorScrollableElement.addEventListener('scroll', TableRowNativeStickyWithFallback.scrollListener, {
+          this.editorScrollableElement.addEventListener('scroll', this.scrollListener, {
             passive: true,
             once: true
           });
@@ -342,10 +341,10 @@ var TableRowNativeStickyWithFallback = exports.default = /*#__PURE__*/function (
       if (this.resizeObserver) {
         this.resizeObserver.disconnect();
       }
-      if (TableRowNativeStickyWithFallback.scrollListener && this.editorScrollableElement) {
+      if (this.scrollListener && this.editorScrollableElement) {
         // eslint-disable-next-line @repo/internal/dom-events/no-unsafe-event-listeners
-        this.editorScrollableElement.removeEventListener('scroll', TableRowNativeStickyWithFallback.scrollListener);
-        TableRowNativeStickyWithFallback.scrollListener = undefined;
+        this.editorScrollableElement.removeEventListener('scroll', this.scrollListener);
+        this.scrollListener = undefined;
       }
       this.eventDispatcher.off('widthPlugin', this.updateStickyHeaderWidth);
       // Ignored via go/ees005
@@ -378,7 +377,7 @@ var TableRowNativeStickyWithFallback = exports.default = /*#__PURE__*/function (
             return;
           }
           // Only apply classes if page has scrolled since load
-          if (!TableRowNativeStickyWithFallback.hasScrolledSinceLoad && (0, _platformFeatureFlags.fg)('platform_editor_table_sticky_header_patch_5')) {
+          if (!_this4.hasScrolledSinceLoad && (0, _platformFeatureFlags.fg)('platform_editor_table_sticky_header_patch_5')) {
             _this4.overflowObserverEntries = entries;
             return;
           }
@@ -976,5 +975,4 @@ var TableRowNativeStickyWithFallback = exports.default = /*#__PURE__*/function (
       }
     }
   }]);
-}(_TableNodeViewBase.default);
-(0, _defineProperty2.default)(TableRowNativeStickyWithFallback, "hasScrolledSinceLoad", false);
+}(_TableNodeViewBase.default);

package/dist/es2019/nodeviews/TableRowNativeStickyWithFallback.js

@@ -63,6 +63,7 @@ export default class TableRowNativeStickyWithFallback extends TableNodeView {
     _defineProperty(this, "listening", false);
     _defineProperty(this, "padding", 0);
     _defineProperty(this, "top", 0);
+    _defineProperty(this, "hasScrolledSinceLoad", false);
     _defineProperty(this, "disableNativeSticky", false);
     /**
      * Methods
@@ -235,45 +236,43 @@ export default class TableRowNativeStickyWithFallback extends TableNodeView {
     if (this.editorScrollableElement) {
       this.initObservers();
       this.topPosEditorElement = getTop(this.editorScrollableElement);
-      if (!TableRowNativeStickyWithFallback.scrollListener && fg('platform_editor_table_sticky_header_patch_5')) {
-        TableRowNativeStickyWithFallback.scrollListener = () => {
-          if (TableRowNativeStickyWithFallback.hasScrolledSinceLoad) {
+      if (fg('platform_editor_table_sticky_header_patch_5')) {
+        this.scrollListener = () => {
+          var _this$overflowObserve;
+          if (this.hasScrolledSinceLoad) {
             return;
           }
-          TableRowNativeStickyWithFallback.hasScrolledSinceLoad = true;
+          this.hasScrolledSinceLoad = true;
           if (!this.overflowObserver) {
             return;
           }
 
           // Re-check intersection state now that scrolling has occurred
-          if (this.overflowObserver) {
-            var _this$overflowObserve;
-            const entries = (_this$overflowObserve = this.overflowObserverEntries) !== null && _this$overflowObserve !== void 0 ? _this$overflowObserve : this.overflowObserver.takeRecords();
-            this.overflowObserverEntries = undefined;
-
-            /** NOTE: This logic is duplicated in the overflowObserver callback
-             *  to avoid conflicting with a follow up refactor where this will
-             *  be cleaned up.
-             */
-            entries.forEach(entry => {
-              const tableWrapper = this.dom.closest(`.${ClassName.TABLE_NODE_WRAPPER}`);
-              if (tableWrapper && tableWrapper instanceof HTMLElement) {
-                if (entry.isIntersecting) {
-                  tableWrapper.classList.add(ClassName.TABLE_NODE_WRAPPER_NO_OVERFLOW);
-                  this.dom.classList.add(ClassName.NATIVE_STICKY);
-                  this.isNativeSticky = true;
-                } else {
-                  tableWrapper.classList.remove(ClassName.TABLE_NODE_WRAPPER_NO_OVERFLOW);
-                  this.dom.classList.remove(ClassName.NATIVE_STICKY);
-                  this.isNativeSticky = false;
-                }
-                this.refreshLegacyStickyState();
+          const entries = (_this$overflowObserve = this.overflowObserverEntries) !== null && _this$overflowObserve !== void 0 ? _this$overflowObserve : this.overflowObserver.takeRecords();
+          this.overflowObserverEntries = undefined;
+
+          /** NOTE: This logic is duplicated in the overflowObserver callback
+           *  to avoid conflicting with a follow up refactor where this will
+           *  be cleaned up.
+           */
+          entries.forEach(entry => {
+            const tableWrapper = this.dom.closest(`.${ClassName.TABLE_NODE_WRAPPER}`);
+            if (tableWrapper && tableWrapper instanceof HTMLElement) {
+              if (entry.isIntersecting) {
+                tableWrapper.classList.add(ClassName.TABLE_NODE_WRAPPER_NO_OVERFLOW);
+                this.dom.classList.add(ClassName.NATIVE_STICKY);
+                this.isNativeSticky = true;
+              } else {
+                tableWrapper.classList.remove(ClassName.TABLE_NODE_WRAPPER_NO_OVERFLOW);
+                this.dom.classList.remove(ClassName.NATIVE_STICKY);
+                this.isNativeSticky = false;
               }
-            });
-          }
+              this.refreshLegacyStickyState();
+            }
+          });
         };
         // eslint-disable-next-line @repo/internal/dom-events/no-unsafe-event-listeners
-        this.editorScrollableElement.addEventListener('scroll', TableRowNativeStickyWithFallback.scrollListener, {
+        this.editorScrollableElement.addEventListener('scroll', this.scrollListener, {
           passive: true,
           once: true
         });
@@ -314,10 +313,10 @@ export default class TableRowNativeStickyWithFallback extends TableNodeView {
     if (this.resizeObserver) {
       this.resizeObserver.disconnect();
     }
-    if (TableRowNativeStickyWithFallback.scrollListener && this.editorScrollableElement) {
+    if (this.scrollListener && this.editorScrollableElement) {
       // eslint-disable-next-line @repo/internal/dom-events/no-unsafe-event-listeners
-      this.editorScrollableElement.removeEventListener('scroll', TableRowNativeStickyWithFallback.scrollListener);
-      TableRowNativeStickyWithFallback.scrollListener = undefined;
+      this.editorScrollableElement.removeEventListener('scroll', this.scrollListener);
+      this.scrollListener = undefined;
     }
     this.eventDispatcher.off('widthPlugin', this.updateStickyHeaderWidth);
     // Ignored via go/ees005
@@ -347,7 +346,7 @@ export default class TableRowNativeStickyWithFallback extends TableNodeView {
           return;
         }
         // Only apply classes if page has scrolled since load
-        if (!TableRowNativeStickyWithFallback.hasScrolledSinceLoad && fg('platform_editor_table_sticky_header_patch_5')) {
+        if (!this.hasScrolledSinceLoad && fg('platform_editor_table_sticky_header_patch_5')) {
           this.overflowObserverEntries = entries;
           return;
         }
@@ -906,5 +905,4 @@ export default class TableRowNativeStickyWithFallback extends TableNodeView {
       })(this.view.state, this.view.dispatch, this.view);
     }
   }
-}
-_defineProperty(TableRowNativeStickyWithFallback, "hasScrolledSinceLoad", false);
+}

package/dist/esm/nodeviews/TableRowNativeStickyWithFallback.js

@@ -72,6 +72,7 @@ var TableRowNativeStickyWithFallback = /*#__PURE__*/function (_ref) {
     _defineProperty(_this, "listening", false);
     _defineProperty(_this, "padding", 0);
     _defineProperty(_this, "top", 0);
+    _defineProperty(_this, "hasScrolledSinceLoad", false);
     _defineProperty(_this, "disableNativeSticky", false);
     /**
      * Methods
@@ -254,45 +255,43 @@ var TableRowNativeStickyWithFallback = /*#__PURE__*/function (_ref) {
       if (this.editorScrollableElement) {
         this.initObservers();
         this.topPosEditorElement = getTop(this.editorScrollableElement);
-        if (!TableRowNativeStickyWithFallback.scrollListener && fg('platform_editor_table_sticky_header_patch_5')) {
-          TableRowNativeStickyWithFallback.scrollListener = function () {
-            if (TableRowNativeStickyWithFallback.hasScrolledSinceLoad) {
+        if (fg('platform_editor_table_sticky_header_patch_5')) {
+          this.scrollListener = function () {
+            var _this3$overflowObserv;
+            if (_this3.hasScrolledSinceLoad) {
               return;
             }
-            TableRowNativeStickyWithFallback.hasScrolledSinceLoad = true;
+            _this3.hasScrolledSinceLoad = true;
             if (!_this3.overflowObserver) {
               return;
             }
 
             // Re-check intersection state now that scrolling has occurred
-            if (_this3.overflowObserver) {
-              var _this3$overflowObserv;
-              var entries = (_this3$overflowObserv = _this3.overflowObserverEntries) !== null && _this3$overflowObserv !== void 0 ? _this3$overflowObserv : _this3.overflowObserver.takeRecords();
-              _this3.overflowObserverEntries = undefined;
-
-              /** NOTE: This logic is duplicated in the overflowObserver callback
-               *  to avoid conflicting with a follow up refactor where this will
-               *  be cleaned up.
-               */
-              entries.forEach(function (entry) {
-                var tableWrapper = _this3.dom.closest(".".concat(ClassName.TABLE_NODE_WRAPPER));
-                if (tableWrapper && tableWrapper instanceof HTMLElement) {
-                  if (entry.isIntersecting) {
-                    tableWrapper.classList.add(ClassName.TABLE_NODE_WRAPPER_NO_OVERFLOW);
-                    _this3.dom.classList.add(ClassName.NATIVE_STICKY);
-                    _this3.isNativeSticky = true;
-                  } else {
-                    tableWrapper.classList.remove(ClassName.TABLE_NODE_WRAPPER_NO_OVERFLOW);
-                    _this3.dom.classList.remove(ClassName.NATIVE_STICKY);
-                    _this3.isNativeSticky = false;
-                  }
-                  _this3.refreshLegacyStickyState();
+            var entries = (_this3$overflowObserv = _this3.overflowObserverEntries) !== null && _this3$overflowObserv !== void 0 ? _this3$overflowObserv : _this3.overflowObserver.takeRecords();
+            _this3.overflowObserverEntries = undefined;
+
+            /** NOTE: This logic is duplicated in the overflowObserver callback
+             *  to avoid conflicting with a follow up refactor where this will
+             *  be cleaned up.
+             */
+            entries.forEach(function (entry) {
+              var tableWrapper = _this3.dom.closest(".".concat(ClassName.TABLE_NODE_WRAPPER));
+              if (tableWrapper && tableWrapper instanceof HTMLElement) {
+                if (entry.isIntersecting) {
+                  tableWrapper.classList.add(ClassName.TABLE_NODE_WRAPPER_NO_OVERFLOW);
+                  _this3.dom.classList.add(ClassName.NATIVE_STICKY);
+                  _this3.isNativeSticky = true;
+                } else {
+                  tableWrapper.classList.remove(ClassName.TABLE_NODE_WRAPPER_NO_OVERFLOW);
+                  _this3.dom.classList.remove(ClassName.NATIVE_STICKY);
+                  _this3.isNativeSticky = false;
                 }
-              });
-            }
+                _this3.refreshLegacyStickyState();
+              }
+            });
           };
           // eslint-disable-next-line @repo/internal/dom-events/no-unsafe-event-listeners
-          this.editorScrollableElement.addEventListener('scroll', TableRowNativeStickyWithFallback.scrollListener, {
+          this.editorScrollableElement.addEventListener('scroll', this.scrollListener, {
             passive: true,
             once: true
           });
@@ -335,10 +334,10 @@ var TableRowNativeStickyWithFallback = /*#__PURE__*/function (_ref) {
       if (this.resizeObserver) {
         this.resizeObserver.disconnect();
       }
-      if (TableRowNativeStickyWithFallback.scrollListener && this.editorScrollableElement) {
+      if (this.scrollListener && this.editorScrollableElement) {
         // eslint-disable-next-line @repo/internal/dom-events/no-unsafe-event-listeners
-        this.editorScrollableElement.removeEventListener('scroll', TableRowNativeStickyWithFallback.scrollListener);
-        TableRowNativeStickyWithFallback.scrollListener = undefined;
+        this.editorScrollableElement.removeEventListener('scroll', this.scrollListener);
+        this.scrollListener = undefined;
       }
       this.eventDispatcher.off('widthPlugin', this.updateStickyHeaderWidth);
       // Ignored via go/ees005
@@ -371,7 +370,7 @@ var TableRowNativeStickyWithFallback = /*#__PURE__*/function (_ref) {
             return;
           }
           // Only apply classes if page has scrolled since load
-          if (!TableRowNativeStickyWithFallback.hasScrolledSinceLoad && fg('platform_editor_table_sticky_header_patch_5')) {
+          if (!_this4.hasScrolledSinceLoad && fg('platform_editor_table_sticky_header_patch_5')) {
             _this4.overflowObserverEntries = entries;
             return;
           }
@@ -970,5 +969,4 @@ var TableRowNativeStickyWithFallback = /*#__PURE__*/function (_ref) {
     }
   }]);
 }(TableNodeView);
-_defineProperty(TableRowNativeStickyWithFallback, "hasScrolledSinceLoad", false);
 export { TableRowNativeStickyWithFallback as default };

package/dist/types/nodeviews/TableRowNativeStickyWithFallback.d.ts

@@ -4,8 +4,6 @@ import type { EditorView, NodeView } from '@atlaskit/editor-prosemirror/view';
 import { type PluginInjectionAPI } from '../types';
 import TableNodeView from './TableNodeViewBase';
 export default class TableRowNativeStickyWithFallback extends TableNodeView<HTMLTableRowElement> implements NodeView {
-    static hasScrolledSinceLoad: boolean;
-    static scrollListener?: () => void;
     private nodeVisibilityObserverCleanupFn?;
     cleanup: () => void;
     constructor(node: PMNode, view: EditorView, getPos: () => number | undefined, eventDispatcher: EventDispatcher, api?: PluginInjectionAPI);
@@ -33,6 +31,8 @@ export default class TableRowNativeStickyWithFallback extends TableNodeView<HTML
     /** Native sticky header variables */
     private overflowObserver?;
     private stickyStateObserver?;
+    private hasScrolledSinceLoad;
+    private scrollListener?;
     private overflowObserverEntries?;
     private isNativeSticky?;
     private disableNativeSticky;

package/dist/types-ts4.5/nodeviews/TableRowNativeStickyWithFallback.d.ts

@@ -4,8 +4,6 @@ import type { EditorView, NodeView } from '@atlaskit/editor-prosemirror/view';
 import { type PluginInjectionAPI } from '../types';
 import TableNodeView from './TableNodeViewBase';
 export default class TableRowNativeStickyWithFallback extends TableNodeView<HTMLTableRowElement> implements NodeView {
-    static hasScrolledSinceLoad: boolean;
-    static scrollListener?: () => void;
     private nodeVisibilityObserverCleanupFn?;
     cleanup: () => void;
     constructor(node: PMNode, view: EditorView, getPos: () => number | undefined, eventDispatcher: EventDispatcher, api?: PluginInjectionAPI);
@@ -33,6 +31,8 @@ export default class TableRowNativeStickyWithFallback extends TableNodeView<HTML
     /** Native sticky header variables */
     private overflowObserver?;
     private stickyStateObserver?;
+    private hasScrolledSinceLoad;
+    private scrollListener?;
     private overflowObserverEntries?;
     private isNativeSticky?;
     private disableNativeSticky;

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-plugin-table",
-	"version": "15.6.7",
+	"version": "15.6.8",
 	"description": "Table plugin for the @atlaskit/editor",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"