@atlaskit/editor-plugin-table 10.9.18 → 10.9.20

package/CHANGELOG.md

@@ -1,5 +1,25 @@
 # @atlaskit/editor-plugin-table
 
+## 10.9.20
+
+### Patch Changes
+
+- [#153256](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/pull-requests/153256)
+  [`3644fbe36073d`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/3644fbe36073d) -
+  [ux] When ViewAll dropdown closes via ESC key press or submenus close via ESC or Enter, the focus
+  is set on ViewAll button.
+- Updated dependencies
+
+## 10.9.19
+
+### Patch Changes
+
+- [#149969](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/pull-requests/149969)
+  [`42c3f35e57188`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/42c3f35e57188) -
+  ED-27882: Get rid of parent offset check in \_handleRef in the react node view. Add metadata to
+  these calls in the \_handleRef and \_handleTableRef.
+- Updated dependencies
+
 ## 10.9.18
 
 ### Patch Changes

package/dist/cjs/nodeviews/table.js

@@ -187,7 +187,13 @@ var TableView = exports.default = /*#__PURE__*/function (_ReactNodeView) {
             var resolvedSelection = selectionBookmark.resolve(_this2.view.state.tr.doc);
             // Don't set the selection if it's the same as the current selection.
             if (!resolvedSelection.eq(_this2.view.state.selection)) {
-              _this2.view.dispatch(_this2.view.state.tr.setSelection(resolvedSelection));
+              if ((0, _platformFeatureFlags.fg)('platform_editor_r18_fix_selection_resync')) {
+                var tr = _this2.view.state.tr.setSelection(resolvedSelection);
+                tr.setMeta('source', 'TableNodeView:_handleTableRef:selection-resync');
+                _this2.view.dispatch(tr);
+              } else {
+                _this2.view.dispatch(_this2.view.state.tr.setSelection(resolvedSelection));
+              }
             }
           }
         });

package/dist/cjs/ui/toolbar.js

@@ -495,6 +495,10 @@ var getToolbarConfig = exports.getToolbarConfig = function getToolbarConfig(getE
           };
         };
         var shouldGroupWithoutSeparators = (0, _experiments.editorExperiment)('platform_editor_controls', 'variant1') && (0, _platformFeatureFlags.fg)('platform_editor_controls_patch_6');
+
+        // testId is required to show focus on trigger button on ESC key press
+        // see hideOnEsc in platform/packages/editor/editor-plugin-floating-toolbar/src/ui/Dropdown.tsx
+        var overflowDropdownTestId = (0, _platformFeatureFlags.fg)('platform_editor_controls_patch_8') ? 'table-overflow-dropdown-trigger' : undefined;
         return {
           title: toolbarTitle,
           getDomRef: getDomRef,
@@ -515,6 +519,7 @@ var getToolbarConfig = exports.getToolbarConfig = function getToolbarConfig(getE
             fullHeight: true
           }, {
             type: 'overflow-dropdown',
+            testId: overflowDropdownTestId,
             dropdownWidth: 220,
             options: [{
               type: 'custom',

package/dist/es2019/nodeviews/table.js

@@ -158,7 +158,13 @@ export default class TableView extends ReactNodeView {
           const resolvedSelection = selectionBookmark.resolve(this.view.state.tr.doc);
           // Don't set the selection if it's the same as the current selection.
           if (!resolvedSelection.eq(this.view.state.selection)) {
-            this.view.dispatch(this.view.state.tr.setSelection(resolvedSelection));
+            if (fg('platform_editor_r18_fix_selection_resync')) {
+              const tr = this.view.state.tr.setSelection(resolvedSelection);
+              tr.setMeta('source', 'TableNodeView:_handleTableRef:selection-resync');
+              this.view.dispatch(tr);
+            } else {
+              this.view.dispatch(this.view.state.tr.setSelection(resolvedSelection));
+            }
           }
         }
       });

package/dist/es2019/ui/toolbar.js

@@ -464,6 +464,10 @@ export const getToolbarConfig = (getEditorContainerWidth, api, editorAnalyticsAP
       onBlur: clearHoverSelection()
     });
     const shouldGroupWithoutSeparators = editorExperiment('platform_editor_controls', 'variant1') && fg('platform_editor_controls_patch_6');
+
+    // testId is required to show focus on trigger button on ESC key press
+    // see hideOnEsc in platform/packages/editor/editor-plugin-floating-toolbar/src/ui/Dropdown.tsx
+    const overflowDropdownTestId = fg('platform_editor_controls_patch_8') ? 'table-overflow-dropdown-trigger' : undefined;
     return {
       title: toolbarTitle,
       getDomRef,
@@ -484,6 +488,7 @@ export const getToolbarConfig = (getEditorContainerWidth, api, editorAnalyticsAP
         fullHeight: true
       }, {
         type: 'overflow-dropdown',
+        testId: overflowDropdownTestId,
         dropdownWidth: 220,
         options: [{
           type: 'custom',

package/dist/esm/nodeviews/table.js

@@ -180,7 +180,13 @@ var TableView = /*#__PURE__*/function (_ReactNodeView) {
             var resolvedSelection = selectionBookmark.resolve(_this2.view.state.tr.doc);
             // Don't set the selection if it's the same as the current selection.
             if (!resolvedSelection.eq(_this2.view.state.selection)) {
-              _this2.view.dispatch(_this2.view.state.tr.setSelection(resolvedSelection));
+              if (fg('platform_editor_r18_fix_selection_resync')) {
+                var tr = _this2.view.state.tr.setSelection(resolvedSelection);
+                tr.setMeta('source', 'TableNodeView:_handleTableRef:selection-resync');
+                _this2.view.dispatch(tr);
+              } else {
+                _this2.view.dispatch(_this2.view.state.tr.setSelection(resolvedSelection));
+              }
             }
           }
         });

package/dist/esm/ui/toolbar.js

@@ -487,6 +487,10 @@ export var getToolbarConfig = function getToolbarConfig(getEditorContainerWidth,
           };
         };
         var shouldGroupWithoutSeparators = editorExperiment('platform_editor_controls', 'variant1') && fg('platform_editor_controls_patch_6');
+
+        // testId is required to show focus on trigger button on ESC key press
+        // see hideOnEsc in platform/packages/editor/editor-plugin-floating-toolbar/src/ui/Dropdown.tsx
+        var overflowDropdownTestId = fg('platform_editor_controls_patch_8') ? 'table-overflow-dropdown-trigger' : undefined;
         return {
           title: toolbarTitle,
           getDomRef: getDomRef,
@@ -507,6 +511,7 @@ export var getToolbarConfig = function getToolbarConfig(getEditorContainerWidth,
             fullHeight: true
           }, {
             type: 'overflow-dropdown',
+            testId: overflowDropdownTestId,
             dropdownWidth: 220,
             options: [{
               type: 'custom',

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-plugin-table",
-	"version": "10.9.18",
+	"version": "10.9.20",
 	"description": "Table plugin for the @atlaskit/editor",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -32,14 +32,14 @@
 		"@atlaskit/adf-schema": "^47.6.0",
 		"@atlaskit/button": "^23.0.0",
 		"@atlaskit/custom-steps": "^0.11.0",
-		"@atlaskit/editor-common": "^104.1.0",
+		"@atlaskit/editor-common": "^105.0.0",
 		"@atlaskit/editor-palette": "^2.1.0",
 		"@atlaskit/editor-plugin-accessibility-utils": "^2.0.0",
 		"@atlaskit/editor-plugin-analytics": "^2.2.0",
 		"@atlaskit/editor-plugin-batch-attribute-updates": "^2.1.0",
 		"@atlaskit/editor-plugin-content-insertion": "^2.1.0",
 		"@atlaskit/editor-plugin-editor-viewmode": "^3.1.0",
-		"@atlaskit/editor-plugin-extension": "5.3.6",
+		"@atlaskit/editor-plugin-extension": "5.3.7",
 		"@atlaskit/editor-plugin-guideline": "^2.0.0",
 		"@atlaskit/editor-plugin-selection": "^2.2.0",
 		"@atlaskit/editor-plugin-width": "^3.0.0",
@@ -206,6 +206,12 @@
 		},
 		"platform_editor_table_last_col_drag_handle_fix": {
 			"type": "boolean"
+		},
+		"platform_editor_r18_fix_selection_resync": {
+			"type": "boolean"
+		},
+		"platform_editor_controls_patch_8": {
+			"type": "boolean"
 		}
 	}
 }

package/src/nodeviews/table.tsx

@@ -225,7 +225,13 @@ export default class TableView extends ReactNodeView<Props> {
 					const resolvedSelection = selectionBookmark.resolve(this.view.state.tr.doc);
 					// Don't set the selection if it's the same as the current selection.
 					if (!resolvedSelection.eq(this.view.state.selection)) {
-						this.view.dispatch(this.view.state.tr.setSelection(resolvedSelection));
+						if (fg('platform_editor_r18_fix_selection_resync')) {
+							const tr = this.view.state.tr.setSelection(resolvedSelection);
+							tr.setMeta('source', 'TableNodeView:_handleTableRef:selection-resync');
+							this.view.dispatch(tr);
+						} else {
+							this.view.dispatch(this.view.state.tr.setSelection(resolvedSelection));
+						}
 					}
 				}
 			});

package/src/ui/toolbar.tsx

@@ -676,6 +676,12 @@ export const getToolbarConfig =
 				editorExperiment('platform_editor_controls', 'variant1') &&
 				fg('platform_editor_controls_patch_6');
 
+			// testId is required to show focus on trigger button on ESC key press
+			// see hideOnEsc in platform/packages/editor/editor-plugin-floating-toolbar/src/ui/Dropdown.tsx
+			const overflowDropdownTestId = fg('platform_editor_controls_patch_8')
+				? 'table-overflow-dropdown-trigger'
+				: undefined;
+
 			return {
 				title: toolbarTitle,
 				getDomRef,
@@ -705,6 +711,7 @@ export const getToolbarConfig =
 								shouldGroupWithoutSeparators && { type: 'separator', fullHeight: true },
 								{
 									type: 'overflow-dropdown',
+									testId: overflowDropdownTestId,
 									dropdownWidth: 220,
 									options: [
 										{