@atlaskit/editor-plugin-table 10.13.3 → 11.0.1

package/CHANGELOG.md

@@ -1,5 +1,51 @@
 # @atlaskit/editor-plugin-table
 
+## 11.0.1
+
+### Patch Changes
+
+- Updated dependencies
+
+## 11.0.0
+
+### Major Changes
+
+- [#181024](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/pull-requests/181024)
+  [`8e80c487ca307`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/8e80c487ca307) - ##
+  Make `@atlaskit/editor-common` a peer dependency
+
+  **WHAT:** `@atlaskit/editor-common` has been moved from `dependencies` to `peerDependencies` in
+  all editor plugin packages.
+
+  **WHY:** This change ensures that only a single version of `@atlaskit/editor-common` is used in
+  consuming applications, preventing issues caused by multiple versions of singleton libraries (such
+  as context mismatches or duplicated state). This is especially important for packages that rely on
+  shared context or singletons.
+
+  **HOW TO ADJUST:**
+
+  - Consumers must now explicitly install `@atlaskit/editor-common` in their own project if they use
+    any of these editor plugins.
+  - Ensure the version you install matches the version required by the plugins.
+  - You can use the
+    [`check-peer-dependencies`](https://www.npmjs.com/package/check-peer-dependencies) package to
+    verify that all required peer dependencies are installed and compatible.
+  - Example install command:
+    ```
+    npm install @atlaskit/editor-common
+    ```
+    or
+    ```
+    yarn add @atlaskit/editor-common
+    ```
+
+  **Note:** This is a breaking change. If `@atlaskit/editor-common` is not installed at the
+  application level, you may see errors or unexpected behavior.
+
+### Patch Changes
+
+- Updated dependencies
+
 ## 10.13.3
 
 ### Patch Changes

package/afm-cc/tsconfig.json

@@ -23,9 +23,6 @@
         {
             "path": "../../custom-steps/afm-cc/tsconfig.json"
         },
-        {
-            "path": "../../editor-common/afm-cc/tsconfig.json"
-        },
         {
             "path": "../../editor-palette/afm-cc/tsconfig.json"
         },
@@ -100,6 +97,9 @@
         },
         {
             "path": "../../../design-system/tooltip/afm-cc/tsconfig.json"
+        },
+        {
+            "path": "../../editor-common/afm-cc/tsconfig.json"
         }
     ]
 }

package/afm-jira/tsconfig.json

@@ -23,9 +23,6 @@
 		{
 			"path": "../../custom-steps/afm-jira/tsconfig.json"
 		},
-		{
-			"path": "../../editor-common/afm-jira/tsconfig.json"
-		},
 		{
 			"path": "../../editor-palette/afm-jira/tsconfig.json"
 		},
@@ -100,6 +97,9 @@
 		},
 		{
 			"path": "../../../design-system/tooltip/afm-jira/tsconfig.json"
+		},
+		{
+			"path": "../../editor-common/afm-jira/tsconfig.json"
 		}
 	]
 }

package/afm-post-office/tsconfig.json

@@ -23,9 +23,6 @@
 		{
 			"path": "../../custom-steps/afm-post-office/tsconfig.json"
 		},
-		{
-			"path": "../../editor-common/afm-post-office/tsconfig.json"
-		},
 		{
 			"path": "../../editor-palette/afm-post-office/tsconfig.json"
 		},
@@ -100,6 +97,9 @@
 		},
 		{
 			"path": "../../../design-system/tooltip/afm-post-office/tsconfig.json"
+		},
+		{
+			"path": "../../editor-common/afm-post-office/tsconfig.json"
 		}
 	]
 }

package/dist/cjs/nodeviews/TableComponent.js

@@ -28,7 +28,6 @@ var _editorSharedStyles = require("@atlaskit/editor-shared-styles");
 var _utils2 = require("@atlaskit/editor-tables/utils");
 var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _combine = require("@atlaskit/pragmatic-drag-and-drop/combine");
-var _experiments = require("@atlaskit/tmp-editor-statsig/experiments");
 var _commands = require("../pm-plugins/commands");
 var _autoscrollers = require("../pm-plugins/drag-and-drop/utils/autoscrollers");
 var _pluginFactory = require("../pm-plugins/plugin-factory");
@@ -403,12 +402,6 @@ var TableComponent = /*#__PURE__*/function (_React$Component) {
     key: "componentDidMount",
     value: function componentDidMount() {
       var _this2 = this;
-      if ((0, _experiments.editorExperiment)('platform_editor_nodevisibility', false, {
-        exposure: true
-      })) {
-        this.initialiseEventListenersAfterMount();
-        return;
-      }
       var _nodeVisibilityManage = (0, _nodeVisibility.nodeVisibilityManager)(this.props.view.dom),
         observe = _nodeVisibilityManage.observe;
       if (this.table) {
@@ -416,6 +409,12 @@ var TableComponent = /*#__PURE__*/function (_React$Component) {
           element: this.table,
           onFirstVisible: function onFirstVisible() {
             _this2.initialiseEventListenersAfterMount();
+            // force width calculcation - missed resize event under firefox when
+            // table is nested within bodied extension
+            if (_this2.wrapper && (0, _platformFeatureFlags.fg)('platform_editor_nodevisibility_resize_sync')) {
+              var _this2$wrapper;
+              _this2.wrapperWidth = (_this2$wrapper = _this2.wrapper) === null || _this2$wrapper === void 0 ? void 0 : _this2$wrapper.clientWidth;
+            }
           }
         });
       }

package/dist/cjs/nodeviews/TableRow.js

@@ -17,7 +17,6 @@ var _nesting = require("@atlaskit/editor-common/nesting");
 var _nodeVisibility = require("@atlaskit/editor-common/node-visibility");
 var _ui = require("@atlaskit/editor-common/ui");
 var _utils = require("@atlaskit/editor-prosemirror/utils");
-var _experiments = require("@atlaskit/tmp-editor-statsig/experiments");
 var _pluginFactory = require("../pm-plugins/plugin-factory");
 var _pluginKey = require("../pm-plugins/plugin-key");
 var _commands = require("../pm-plugins/sticky-headers/commands");
@@ -85,20 +84,14 @@ var TableRow = exports.default = /*#__PURE__*/function (_TableNodeView) {
       _this.isInNestedTable = (0, _nesting.getParentOfTypeCount)(view.state.schema.nodes.table)(view.state.doc.resolve(pos)) > 1;
     }
     if (_this.isHeaderRow) {
-      if ((0, _experiments.editorExperiment)('platform_editor_nodevisibility', false, {
-        exposure: true
-      })) {
-        _this.subscribeWhenRowVisible();
-      } else {
-        var _nodeVisibilityManage = (0, _nodeVisibility.nodeVisibilityManager)(view.dom),
-          observe = _nodeVisibilityManage.observe;
-        _this.nodeVisibilityObserverCleanupFn = observe({
-          element: _this.contentDOM,
-          onFirstVisible: function onFirstVisible() {
-            _this.subscribeWhenRowVisible();
-          }
-        });
-      }
+      var _nodeVisibilityManage = (0, _nodeVisibility.nodeVisibilityManager)(view.dom),
+        observe = _nodeVisibilityManage.observe;
+      _this.nodeVisibilityObserverCleanupFn = observe({
+        element: _this.contentDOM,
+        onFirstVisible: function onFirstVisible() {
+          _this.subscribeWhenRowVisible();
+        }
+      });
     }
     return _this;
   }

package/dist/es2019/nodeviews/TableComponent.js

@@ -15,7 +15,6 @@ import { akEditorTableNumberColumnWidth, akEditorTableToolbarSize as tableToolba
 import { findTable, isTableSelected } from '@atlaskit/editor-tables/utils';
 import { fg } from '@atlaskit/platform-feature-flags';
 import { combine } from '@atlaskit/pragmatic-drag-and-drop/combine';
-import { editorExperiment } from '@atlaskit/tmp-editor-statsig/experiments';
 import { autoSizeTable, clearHoverSelection } from '../pm-plugins/commands';
 import { autoScrollerFactory } from '../pm-plugins/drag-and-drop/utils/autoscrollers';
 import { getPluginState } from '../pm-plugins/plugin-factory';
@@ -387,12 +386,6 @@ class TableComponent extends React.Component {
     }
   }
   componentDidMount() {
-    if (editorExperiment('platform_editor_nodevisibility', false, {
-      exposure: true
-    })) {
-      this.initialiseEventListenersAfterMount();
-      return;
-    }
     const {
       observe
     } = nodeVisibilityManager(this.props.view.dom);
@@ -401,6 +394,12 @@ class TableComponent extends React.Component {
         element: this.table,
         onFirstVisible: () => {
           this.initialiseEventListenersAfterMount();
+          // force width calculcation - missed resize event under firefox when
+          // table is nested within bodied extension
+          if (this.wrapper && fg('platform_editor_nodevisibility_resize_sync')) {
+            var _this$wrapper;
+            this.wrapperWidth = (_this$wrapper = this.wrapper) === null || _this$wrapper === void 0 ? void 0 : _this$wrapper.clientWidth;
+          }
         }
       });
     }
@@ -689,7 +688,7 @@ class TableComponent extends React.Component {
   // Ignored via go/ees005
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
   componentDidUpdate(_, prevState) {
-    var _this$props$options0, _this$props$options1, _this$wrapper;
+    var _this$props$options0, _this$props$options1, _this$wrapper2;
     const {
       view,
       getNode,
@@ -735,7 +734,7 @@ class TableComponent extends React.Component {
     if ((_this$props$options1 = this.props.options) !== null && _this$props$options1 !== void 0 && _this$props$options1.isCommentEditor && allowTableResizing && !(options !== null && options !== void 0 && options.isTableScalingEnabled)) {
       this.removeInlineTableWidth();
     }
-    if ((_this$wrapper = this.wrapper) !== null && _this$wrapper !== void 0 && _this$wrapper.parentElement && this.table && !this.overflowShadowsObserver) {
+    if ((_this$wrapper2 = this.wrapper) !== null && _this$wrapper2 !== void 0 && _this$wrapper2.parentElement && this.table && !this.overflowShadowsObserver) {
       if (this.props.isDragAndDropEnabled) {
         // requestAnimationFrame is used here to fix a race condition issue
         // that happens when a table is nested in expand and expand's width is
@@ -914,8 +913,8 @@ class TableComponent extends React.Component {
       tableContainerWidth: tableContainerWidth,
       isNumberColumnEnabled: node.attrs.isNumberColumnEnabled,
       getScrollOffset: () => {
-        var _this$wrapper2;
-        return ((_this$wrapper2 = this.wrapper) === null || _this$wrapper2 === void 0 ? void 0 : _this$wrapper2.scrollLeft) || 0;
+        var _this$wrapper3;
+        return ((_this$wrapper3 = this.wrapper) === null || _this$wrapper3 === void 0 ? void 0 : _this$wrapper3.scrollLeft) || 0;
       },
       tableWrapperHeight: this.state.tableWrapperHeight,
       api: pluginInjectionApi,
@@ -991,12 +990,12 @@ class TableComponent extends React.Component {
       editorView: view,
       node: node,
       getScrollOffset: () => {
-        var _this$wrapper3;
-        return ((_this$wrapper3 = this.wrapper) === null || _this$wrapper3 === void 0 ? void 0 : _this$wrapper3.scrollLeft) || 0;
+        var _this$wrapper4;
+        return ((_this$wrapper4 = this.wrapper) === null || _this$wrapper4 === void 0 ? void 0 : _this$wrapper4.scrollLeft) || 0;
       },
       getTableWrapperWidth: () => {
-        var _this$wrapper4;
-        return ((_this$wrapper4 = this.wrapper) === null || _this$wrapper4 === void 0 ? void 0 : _this$wrapper4.clientWidth) || 760;
+        var _this$wrapper5;
+        return ((_this$wrapper5 = this.wrapper) === null || _this$wrapper5 === void 0 ? void 0 : _this$wrapper5.clientWidth) || 760;
       }
     }), /*#__PURE__*/React.createElement("div", {
       contentEditable: false

package/dist/es2019/nodeviews/TableRow.js

@@ -5,7 +5,6 @@ import { getParentOfTypeCount } from '@atlaskit/editor-common/nesting';
 import { nodeVisibilityManager } from '@atlaskit/editor-common/node-visibility';
 import { findOverflowScrollParent } from '@atlaskit/editor-common/ui';
 import { findParentNodeClosestToPos } from '@atlaskit/editor-prosemirror/utils';
-import { editorExperiment } from '@atlaskit/tmp-editor-statsig/experiments';
 import { getPluginState } from '../pm-plugins/plugin-factory';
 import { pluginKey as tablePluginKey } from '../pm-plugins/plugin-key';
 import { updateStickyState } from '../pm-plugins/sticky-headers/commands';
@@ -70,21 +69,15 @@ export default class TableRow extends TableNodeView {
       this.isInNestedTable = getParentOfTypeCount(view.state.schema.nodes.table)(view.state.doc.resolve(pos)) > 1;
     }
     if (this.isHeaderRow) {
-      if (editorExperiment('platform_editor_nodevisibility', false, {
-        exposure: true
-      })) {
-        this.subscribeWhenRowVisible();
-      } else {
-        const {
-          observe
-        } = nodeVisibilityManager(view.dom);
-        this.nodeVisibilityObserverCleanupFn = observe({
-          element: this.contentDOM,
-          onFirstVisible: () => {
-            this.subscribeWhenRowVisible();
-          }
-        });
-      }
+      const {
+        observe
+      } = nodeVisibilityManager(view.dom);
+      this.nodeVisibilityObserverCleanupFn = observe({
+        element: this.contentDOM,
+        onFirstVisible: () => {
+          this.subscribeWhenRowVisible();
+        }
+      });
     }
   }
   subscribeWhenRowVisible() {

package/dist/esm/nodeviews/TableComponent.js

@@ -28,7 +28,6 @@ import { akEditorTableNumberColumnWidth, akEditorTableToolbarSize as tableToolba
 import { findTable, isTableSelected } from '@atlaskit/editor-tables/utils';
 import { fg } from '@atlaskit/platform-feature-flags';
 import { combine } from '@atlaskit/pragmatic-drag-and-drop/combine';
-import { editorExperiment } from '@atlaskit/tmp-editor-statsig/experiments';
 import { autoSizeTable, clearHoverSelection } from '../pm-plugins/commands';
 import { autoScrollerFactory } from '../pm-plugins/drag-and-drop/utils/autoscrollers';
 import { getPluginState } from '../pm-plugins/plugin-factory';
@@ -397,12 +396,6 @@ var TableComponent = /*#__PURE__*/function (_React$Component) {
     key: "componentDidMount",
     value: function componentDidMount() {
       var _this2 = this;
-      if (editorExperiment('platform_editor_nodevisibility', false, {
-        exposure: true
-      })) {
-        this.initialiseEventListenersAfterMount();
-        return;
-      }
       var _nodeVisibilityManage = nodeVisibilityManager(this.props.view.dom),
         observe = _nodeVisibilityManage.observe;
       if (this.table) {
@@ -410,6 +403,12 @@ var TableComponent = /*#__PURE__*/function (_React$Component) {
           element: this.table,
           onFirstVisible: function onFirstVisible() {
             _this2.initialiseEventListenersAfterMount();
+            // force width calculcation - missed resize event under firefox when
+            // table is nested within bodied extension
+            if (_this2.wrapper && fg('platform_editor_nodevisibility_resize_sync')) {
+              var _this2$wrapper;
+              _this2.wrapperWidth = (_this2$wrapper = _this2.wrapper) === null || _this2$wrapper === void 0 ? void 0 : _this2$wrapper.clientWidth;
+            }
           }
         });
       }

package/dist/esm/nodeviews/TableRow.js

@@ -12,7 +12,6 @@ import { getParentOfTypeCount } from '@atlaskit/editor-common/nesting';
 import { nodeVisibilityManager } from '@atlaskit/editor-common/node-visibility';
 import { findOverflowScrollParent } from '@atlaskit/editor-common/ui';
 import { findParentNodeClosestToPos } from '@atlaskit/editor-prosemirror/utils';
-import { editorExperiment } from '@atlaskit/tmp-editor-statsig/experiments';
 import { getPluginState } from '../pm-plugins/plugin-factory';
 import { pluginKey as tablePluginKey } from '../pm-plugins/plugin-key';
 import { updateStickyState } from '../pm-plugins/sticky-headers/commands';
@@ -78,20 +77,14 @@ var TableRow = /*#__PURE__*/function (_TableNodeView) {
       _this.isInNestedTable = getParentOfTypeCount(view.state.schema.nodes.table)(view.state.doc.resolve(pos)) > 1;
     }
     if (_this.isHeaderRow) {
-      if (editorExperiment('platform_editor_nodevisibility', false, {
-        exposure: true
-      })) {
-        _this.subscribeWhenRowVisible();
-      } else {
-        var _nodeVisibilityManage = nodeVisibilityManager(view.dom),
-          observe = _nodeVisibilityManage.observe;
-        _this.nodeVisibilityObserverCleanupFn = observe({
-          element: _this.contentDOM,
-          onFirstVisible: function onFirstVisible() {
-            _this.subscribeWhenRowVisible();
-          }
-        });
-      }
+      var _nodeVisibilityManage = nodeVisibilityManager(view.dom),
+        observe = _nodeVisibilityManage.observe;
+      _this.nodeVisibilityObserverCleanupFn = observe({
+        element: _this.contentDOM,
+        onFirstVisible: function onFirstVisible() {
+          _this.subscribeWhenRowVisible();
+        }
+      });
     }
     return _this;
   }

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-plugin-table",
-	"version": "10.13.3",
+	"version": "11.0.1",
 	"description": "Table plugin for the @atlaskit/editor",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -31,22 +31,21 @@
 		"@atlaskit/adf-schema": "^47.6.0",
 		"@atlaskit/button": "^23.2.0",
 		"@atlaskit/custom-steps": "^0.11.0",
-		"@atlaskit/editor-common": "^107.6.0",
 		"@atlaskit/editor-palette": "^2.1.0",
-		"@atlaskit/editor-plugin-accessibility-utils": "^2.0.0",
-		"@atlaskit/editor-plugin-analytics": "^2.3.0",
-		"@atlaskit/editor-plugin-batch-attribute-updates": "^2.1.0",
-		"@atlaskit/editor-plugin-content-insertion": "^2.1.0",
-		"@atlaskit/editor-plugin-editor-viewmode": "^4.0.0",
-		"@atlaskit/editor-plugin-extension": "5.5.14",
-		"@atlaskit/editor-plugin-guideline": "^2.0.0",
-		"@atlaskit/editor-plugin-interaction": "^3.0.0",
-		"@atlaskit/editor-plugin-selection": "^2.2.0",
-		"@atlaskit/editor-plugin-width": "^3.0.0",
+		"@atlaskit/editor-plugin-accessibility-utils": "^3.0.0",
+		"@atlaskit/editor-plugin-analytics": "^3.0.0",
+		"@atlaskit/editor-plugin-batch-attribute-updates": "^3.0.0",
+		"@atlaskit/editor-plugin-content-insertion": "^3.0.0",
+		"@atlaskit/editor-plugin-editor-viewmode": "^5.0.0",
+		"@atlaskit/editor-plugin-extension": "6.0.1",
+		"@atlaskit/editor-plugin-guideline": "^3.0.0",
+		"@atlaskit/editor-plugin-interaction": "^4.0.0",
+		"@atlaskit/editor-plugin-selection": "^3.0.0",
+		"@atlaskit/editor-plugin-width": "^4.0.0",
 		"@atlaskit/editor-prosemirror": "7.0.0",
 		"@atlaskit/editor-shared-styles": "^3.4.0",
 		"@atlaskit/editor-tables": "^2.9.0",
-		"@atlaskit/icon": "^27.2.0",
+		"@atlaskit/icon": "^27.3.0",
 		"@atlaskit/menu": "^8.0.0",
 		"@atlaskit/platform-feature-flags": "^1.1.0",
 		"@atlaskit/pragmatic-drag-and-drop": "^1.7.0",
@@ -54,7 +53,7 @@
 		"@atlaskit/pragmatic-drag-and-drop-hitbox": "^1.1.0",
 		"@atlaskit/primitives": "^14.10.0",
 		"@atlaskit/theme": "^18.0.0",
-		"@atlaskit/tmp-editor-statsig": "^8.7.0",
+		"@atlaskit/tmp-editor-statsig": "^9.0.0",
 		"@atlaskit/toggle": "^15.0.0",
 		"@atlaskit/tokens": "^5.4.0",
 		"@atlaskit/tooltip": "^20.3.0",
@@ -67,6 +66,7 @@
 		"uuid": "^3.1.0"
 	},
 	"peerDependencies": {
+		"@atlaskit/editor-common": "^107.7.0",
 		"react": "^18.2.0",
 		"react-dom": "^18.2.0",
 		"react-intl-next": "npm:react-intl@^5.18.1"
@@ -191,6 +191,9 @@
 		},
 		"platform_editor_table_fw_numcol_overflow_fix": {
 			"type": "boolean"
+		},
+		"platform_editor_nodevisibility_resize_sync": {
+			"type": "boolean"
 		}
 	}
 }

package/src/nodeviews/TableComponent.tsx

@@ -29,7 +29,6 @@ import { findTable, isTableSelected } from '@atlaskit/editor-tables/utils';
 import { fg } from '@atlaskit/platform-feature-flags';
 import { combine } from '@atlaskit/pragmatic-drag-and-drop/combine';
 import type { CleanupFn } from '@atlaskit/pragmatic-drag-and-drop/types';
-import { editorExperiment } from '@atlaskit/tmp-editor-statsig/experiments';
 import { token } from '@atlaskit/tokens';
 
 import { autoSizeTable, clearHoverSelection } from '../pm-plugins/commands';
@@ -252,17 +251,17 @@ class TableComponent extends React.Component<ComponentProps, TableState> {
 	};
 
 	componentDidMount() {
-		if (editorExperiment('platform_editor_nodevisibility', false, { exposure: true })) {
-			this.initialiseEventListenersAfterMount();
-			return;
-		}
-
 		const { observe } = nodeVisibilityManager(this.props.view.dom);
 		if (this.table) {
 			this.nodeVisibilityObserverCleanupFn = observe({
 				element: this.table,
 				onFirstVisible: () => {
 					this.initialiseEventListenersAfterMount();
+					// force width calculcation - missed resize event under firefox when
+					// table is nested within bodied extension
+					if (this.wrapper && fg('platform_editor_nodevisibility_resize_sync')) {
+						this.wrapperWidth = this.wrapper?.clientWidth;
+					}
 				},
 			});
 		}

package/src/nodeviews/TableRow.ts

@@ -8,7 +8,6 @@ import { findOverflowScrollParent } from '@atlaskit/editor-common/ui';
 import type { Node as PMNode } from '@atlaskit/editor-prosemirror/model';
 import { findParentNodeClosestToPos } from '@atlaskit/editor-prosemirror/utils';
 import type { EditorView, NodeView } from '@atlaskit/editor-prosemirror/view';
-import { editorExperiment } from '@atlaskit/tmp-editor-statsig/experiments';
 
 import { getPluginState } from '../pm-plugins/plugin-factory';
 import { pluginKey as tablePluginKey } from '../pm-plugins/plugin-key';
@@ -69,17 +68,13 @@ export default class TableRow extends TableNodeView<HTMLTableRowElement> impleme
 		}
 
 		if (this.isHeaderRow) {
-			if (editorExperiment('platform_editor_nodevisibility', false, { exposure: true })) {
-				this.subscribeWhenRowVisible();
-			} else {
-				const { observe } = nodeVisibilityManager(view.dom);
-				this.nodeVisibilityObserverCleanupFn = observe({
-					element: this.contentDOM,
-					onFirstVisible: () => {
-						this.subscribeWhenRowVisible();
-					},
-				});
-			}
+			const { observe } = nodeVisibilityManager(view.dom);
+			this.nodeVisibilityObserverCleanupFn = observe({
+				element: this.contentDOM,
+				onFirstVisible: () => {
+					this.subscribeWhenRowVisible();
+				},
+			});
 		}
 	}