@atlaskit/editor-plugin-table 10.11.1 → 10.11.2

package/CHANGELOG.md

@@ -1,5 +1,14 @@
 # @atlaskit/editor-plugin-table
 
+## 10.11.2
+
+### Patch Changes
+
+- [#161309](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/pull-requests/161309)
+  [`ec4edba1f5f2d`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/ec4edba1f5f2d) -
+  Fix selection colour bug after deleting a column or row
+- Updated dependencies
+
 ## 10.11.1
 
 ### Patch Changes

package/dist/cjs/pm-plugins/commands/delete.js

@@ -4,6 +4,8 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.deleteColumnsCommand = void 0;
+var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
+var _pluginKey = require("../plugin-key");
 var _deleteColumns = require("../transforms/delete-columns");
 var _getAllowAddColumnCustomStep = require("../utils/get-allow-add-column-custom-step");
 var deleteColumnsCommand = exports.deleteColumnsCommand = function deleteColumnsCommand(rect, api) {
@@ -13,6 +15,16 @@ var deleteColumnsCommand = exports.deleteColumnsCommand = function deleteColumns
   var isCommentEditor = arguments.length > 5 && arguments[5] !== undefined ? arguments[5] : false;
   return function (state, dispatch, view) {
     var tr = (0, _deleteColumns.deleteColumns)(rect, (0, _getAllowAddColumnCustomStep.getAllowAddColumnCustomStep)(state), api, view, isTableScalingEnabled, isTableFixedColumnWidthsOptionEnabled, shouldUseIncreasedScalingPercent, isCommentEditor)(state.tr);
+    // If we delete a column we should also clean up the hover selection
+    if ((0, _platformFeatureFlags.fg)('platform_editor_remove_slow_table_transactions')) {
+      tr.setMeta(_pluginKey.pluginKey, {
+        type: 'CLEAR_HOVER_SELECTION',
+        data: {
+          isInDanger: false,
+          isWholeTableInDanger: false
+        }
+      });
+    }
     if (dispatch) {
       dispatch(tr);
       return true;

package/dist/cjs/pm-plugins/transforms/delete-rows.js

@@ -10,6 +10,8 @@ var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/de
 var _state = require("@atlaskit/editor-prosemirror/state");
 var _tableMap = require("@atlaskit/editor-tables/table-map");
 var _utils = require("@atlaskit/editor-tables/utils");
+var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
+var _pluginKey = require("../plugin-key");
 var _merge = require("./merge");
 function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
 function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { (0, _defineProperty2.default)(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; }
@@ -116,6 +118,17 @@ var deleteRows = exports.deleteRows = function deleteRows(rect) {
       return tr;
     }
     var cursorPos = getNextCursorPos(newTable, rowsToDelete);
+
+    // If we delete a row we should also clean up the hover selection
+    if ((0, _platformFeatureFlags.fg)('platform_editor_remove_slow_table_transactions')) {
+      tr.setMeta(_pluginKey.pluginKey, {
+        type: 'CLEAR_HOVER_SELECTION',
+        data: {
+          isInDanger: false,
+          isWholeTableInDanger: false
+        }
+      });
+    }
     return tr.replaceWith(table.pos, table.pos + table.node.nodeSize, fixedTable)
     // move cursor before the deleted rows if possible, otherwise - to the first row
     .setSelection(_state.Selection.near(tr.doc.resolve(table.pos + cursorPos)));

package/dist/es2019/pm-plugins/commands/delete.js

@@ -1,7 +1,19 @@
+import { fg } from '@atlaskit/platform-feature-flags';
+import { pluginKey } from '../plugin-key';
 import { deleteColumns } from '../transforms/delete-columns';
 import { getAllowAddColumnCustomStep } from '../utils/get-allow-add-column-custom-step';
 export const deleteColumnsCommand = (rect, api, isTableScalingEnabled = false, isTableFixedColumnWidthsOptionEnabled = false, shouldUseIncreasedScalingPercent = false, isCommentEditor = false) => (state, dispatch, view) => {
   const tr = deleteColumns(rect, getAllowAddColumnCustomStep(state), api, view, isTableScalingEnabled, isTableFixedColumnWidthsOptionEnabled, shouldUseIncreasedScalingPercent, isCommentEditor)(state.tr);
+  // If we delete a column we should also clean up the hover selection
+  if (fg('platform_editor_remove_slow_table_transactions')) {
+    tr.setMeta(pluginKey, {
+      type: 'CLEAR_HOVER_SELECTION',
+      data: {
+        isInDanger: false,
+        isWholeTableInDanger: false
+      }
+    });
+  }
   if (dispatch) {
     dispatch(tr);
     return true;

package/dist/es2019/pm-plugins/transforms/delete-rows.js

@@ -1,6 +1,8 @@
 import { Selection } from '@atlaskit/editor-prosemirror/state';
 import { TableMap } from '@atlaskit/editor-tables/table-map';
 import { findTable } from '@atlaskit/editor-tables/utils';
+import { fg } from '@atlaskit/platform-feature-flags';
+import { pluginKey } from '../plugin-key';
 import { mergeEmptyColumns } from './merge';
 export const deleteRows = (rect, isHeaderRowRequired = false) => tr => {
   const table = findTable(tr.selection);
@@ -97,6 +99,17 @@ export const deleteRows = (rect, isHeaderRowRequired = false) => tr => {
     return tr;
   }
   const cursorPos = getNextCursorPos(newTable, rowsToDelete);
+
+  // If we delete a row we should also clean up the hover selection
+  if (fg('platform_editor_remove_slow_table_transactions')) {
+    tr.setMeta(pluginKey, {
+      type: 'CLEAR_HOVER_SELECTION',
+      data: {
+        isInDanger: false,
+        isWholeTableInDanger: false
+      }
+    });
+  }
   return tr.replaceWith(table.pos, table.pos + table.node.nodeSize, fixedTable)
   // move cursor before the deleted rows if possible, otherwise - to the first row
   .setSelection(Selection.near(tr.doc.resolve(table.pos + cursorPos)));

package/dist/esm/pm-plugins/commands/delete.js

@@ -1,3 +1,5 @@
+import { fg } from '@atlaskit/platform-feature-flags';
+import { pluginKey } from '../plugin-key';
 import { deleteColumns } from '../transforms/delete-columns';
 import { getAllowAddColumnCustomStep } from '../utils/get-allow-add-column-custom-step';
 export var deleteColumnsCommand = function deleteColumnsCommand(rect, api) {
@@ -7,6 +9,16 @@ export var deleteColumnsCommand = function deleteColumnsCommand(rect, api) {
   var isCommentEditor = arguments.length > 5 && arguments[5] !== undefined ? arguments[5] : false;
   return function (state, dispatch, view) {
     var tr = deleteColumns(rect, getAllowAddColumnCustomStep(state), api, view, isTableScalingEnabled, isTableFixedColumnWidthsOptionEnabled, shouldUseIncreasedScalingPercent, isCommentEditor)(state.tr);
+    // If we delete a column we should also clean up the hover selection
+    if (fg('platform_editor_remove_slow_table_transactions')) {
+      tr.setMeta(pluginKey, {
+        type: 'CLEAR_HOVER_SELECTION',
+        data: {
+          isInDanger: false,
+          isWholeTableInDanger: false
+        }
+      });
+    }
     if (dispatch) {
       dispatch(tr);
       return true;

package/dist/esm/pm-plugins/transforms/delete-rows.js

@@ -5,6 +5,8 @@ function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t =
 import { Selection } from '@atlaskit/editor-prosemirror/state';
 import { TableMap } from '@atlaskit/editor-tables/table-map';
 import { findTable } from '@atlaskit/editor-tables/utils';
+import { fg } from '@atlaskit/platform-feature-flags';
+import { pluginKey } from '../plugin-key';
 import { mergeEmptyColumns } from './merge';
 export var deleteRows = function deleteRows(rect) {
   var isHeaderRowRequired = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : false;
@@ -109,6 +111,17 @@ export var deleteRows = function deleteRows(rect) {
       return tr;
     }
     var cursorPos = getNextCursorPos(newTable, rowsToDelete);
+
+    // If we delete a row we should also clean up the hover selection
+    if (fg('platform_editor_remove_slow_table_transactions')) {
+      tr.setMeta(pluginKey, {
+        type: 'CLEAR_HOVER_SELECTION',
+        data: {
+          isInDanger: false,
+          isWholeTableInDanger: false
+        }
+      });
+    }
     return tr.replaceWith(table.pos, table.pos + table.node.nodeSize, fixedTable)
     // move cursor before the deleted rows if possible, otherwise - to the first row
     .setSelection(Selection.near(tr.doc.resolve(table.pos + cursorPos)));

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-plugin-table",
-	"version": "10.11.1",
+	"version": "10.11.2",
 	"description": "Table plugin for the @atlaskit/editor",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -58,7 +58,7 @@
 		"@atlaskit/tmp-editor-statsig": "^5.1.0",
 		"@atlaskit/toggle": "^15.0.0",
 		"@atlaskit/tokens": "^4.9.0",
-		"@atlaskit/tooltip": "^20.0.0",
+		"@atlaskit/tooltip": "^20.1.0",
 		"@babel/runtime": "^7.0.0",
 		"@emotion/react": "^11.7.1",
 		"classnames": "^2.2.5",

package/src/pm-plugins/commands/delete.ts

@@ -1,7 +1,9 @@
 import type { Command } from '@atlaskit/editor-common/types';
 import type { Rect } from '@atlaskit/editor-tables/table-map';
+import { fg } from '@atlaskit/platform-feature-flags';
 
 import type { PluginInjectionAPI } from '../../types';
+import { pluginKey } from '../plugin-key';
 import { deleteColumns } from '../transforms/delete-columns';
 import { getAllowAddColumnCustomStep } from '../utils/get-allow-add-column-custom-step';
 
@@ -25,6 +27,16 @@ export const deleteColumnsCommand =
 			shouldUseIncreasedScalingPercent,
 			isCommentEditor,
 		)(state.tr);
+		// If we delete a column we should also clean up the hover selection
+		if (fg('platform_editor_remove_slow_table_transactions')) {
+			tr.setMeta(pluginKey, {
+				type: 'CLEAR_HOVER_SELECTION',
+				data: {
+					isInDanger: false,
+					isWholeTableInDanger: false,
+				},
+			});
+		}
 		if (dispatch) {
 			dispatch(tr);
 			return true;

package/src/pm-plugins/transforms/delete-rows.ts

@@ -5,6 +5,9 @@ import { Selection } from '@atlaskit/editor-prosemirror/state';
 import type { Rect } from '@atlaskit/editor-tables/table-map';
 import { TableMap } from '@atlaskit/editor-tables/table-map';
 import { findTable } from '@atlaskit/editor-tables/utils';
+import { fg } from '@atlaskit/platform-feature-flags';
+
+import { pluginKey } from '../plugin-key';
 
 import { mergeEmptyColumns } from './merge';
 
@@ -127,6 +130,17 @@ export const deleteRows =
 		}
 		const cursorPos = getNextCursorPos(newTable, rowsToDelete);
 
+		// If we delete a row we should also clean up the hover selection
+		if (fg('platform_editor_remove_slow_table_transactions')) {
+			tr.setMeta(pluginKey, {
+				type: 'CLEAR_HOVER_SELECTION',
+				data: {
+					isInDanger: false,
+					isWholeTableInDanger: false,
+				},
+			});
+		}
+
 		return (
 			tr
 				.replaceWith(table.pos, table.pos + table.node.nodeSize, fixedTable)