@atlaskit/editor-plugin-table 10.10.1 → 10.10.3

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (6) hide show
  1. package/CHANGELOG.md +16 -0
  2. package/dist/cjs/nodeviews/lazy-node-views.js +12 -8
  3. package/dist/es2019/nodeviews/lazy-node-views.js +12 -8
  4. package/dist/esm/nodeviews/lazy-node-views.js +12 -8
  5. package/package.json +7 -4
  6. package/src/nodeviews/lazy-node-views.ts +12 -8
package/CHANGELOG.md CHANGED
@@ -1,5 +1,21 @@
1
1
  # @atlaskit/editor-plugin-table
2
2
 
3
+ ## 10.10.3
4
+
5
+ ### Patch Changes
6
+
7
+ - Updated dependencies
8
+
9
+ ## 10.10.2
10
+
11
+ ### Patch Changes
12
+
13
+ - [#158294](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/pull-requests/158294)
14
+ [`c017b7dd6fc06`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/c017b7dd6fc06) -
15
+ NOISSUE - Add platform_editor_enable_table_lnv feature flag to re-enable lazy node view for
16
+ tables.
17
+ - Updated dependencies
18
+
3
19
  ## 10.10.1
4
20
 
5
21
  ### Patch Changes
package/dist/cjs/nodeviews/lazy-node-views.js CHANGED
@@ -15,8 +15,9 @@ var _TableRow = _interopRequireDefault(require("./TableRow"));
15
15
  function _getRequireWildcardCache(e) { if ("function" != typeof WeakMap) return null; var r = new WeakMap(), t = new WeakMap(); return (_getRequireWildcardCache = function _getRequireWildcardCache(e) { return e ? t : r; })(e); }
16
16
  function _interopRequireWildcard(e, r) { if (!r && e && e.__esModule) return e; if (null === e || "object" != (0, _typeof2.default)(e) && "function" != typeof e) return { default: e }; var t = _getRequireWildcardCache(r); if (t && t.has(e)) return t.get(e); var n = { __proto__: null }, a = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var u in e) if ("default" !== u && {}.hasOwnProperty.call(e, u)) { var i = a ? Object.getOwnPropertyDescriptor(e, u) : null; i && (i.get || i.set) ? Object.defineProperty(n, u, i) : n[u] = e[u]; } return n.default = e, t && t.set(e, n), n; } // TODO: ED-23976 - Clean up
17
17
  var lazyTableView = exports.lazyTableView = function lazyTableView(options) {
18
- // LNV tables are broken in concurrent mode - temporarily disable to unblock concurrent mode
19
- if ((0, _experiments.editorExperiment)('platform_editor_exp_lazy_node_views', false) || (0, _platformFeatureFlags.fg)('platform_editor_disable_table_lnv')) {
18
+ // LNV tables were broken in concurrent mode - they were temporarily disabled to unblock concurrent mode.
19
+ // Enabling them again via the platform_editor_enable_table_lnv flag.
20
+ if ((0, _experiments.editorExperiment)('platform_editor_exp_lazy_node_views', false) || !(0, _platformFeatureFlags.fg)('platform_editor_enable_table_lnv') && (0, _platformFeatureFlags.fg)('platform_editor_disable_table_lnv')) {
20
21
  return function (node, view, getPos) {
21
22
  return (0, _table.createTableView)(node, view, getPos, options.portalProviderAPI, options.eventDispatcher, options.getEditorContainerWidth, options.getEditorFeatureFlags, options.dispatchAnalyticsEvent, options.pluginInjectionApi, options.isCommentEditor, options.isChromelessEditor);
22
23
  };
@@ -51,8 +52,9 @@ var lazyTableView = exports.lazyTableView = function lazyTableView(options) {
51
52
  });
52
53
  };
53
54
  var lazyTableCellView = exports.lazyTableCellView = function lazyTableCellView(options) {
54
- // LNV tables are broken in concurrent mode - temporarily disable to unblock concurrent mode
55
- if ((0, _experiments.editorExperiment)('platform_editor_exp_lazy_node_views', false) || (0, _platformFeatureFlags.fg)('platform_editor_disable_table_lnv')) {
55
+ // LNV tables were broken in concurrent mode - they were temporarily disabled to unblock concurrent mode.
56
+ // Enabling them again via the platform_editor_enable_table_lnv flag.
57
+ if ((0, _experiments.editorExperiment)('platform_editor_exp_lazy_node_views', false) || !(0, _platformFeatureFlags.fg)('platform_editor_enable_table_lnv') && (0, _platformFeatureFlags.fg)('platform_editor_disable_table_lnv')) {
56
58
  return function (node, view, getPos) {
57
59
  var _options$pluginInject;
58
60
  return new _TableCell.default(node, view, getPos, options.eventDispatcher, (_options$pluginInject = options.pluginInjectionApi) === null || _options$pluginInject === void 0 || (_options$pluginInject = _options$pluginInject.analytics) === null || _options$pluginInject === void 0 ? void 0 : _options$pluginInject.actions);
@@ -83,8 +85,9 @@ var lazyTableCellView = exports.lazyTableCellView = function lazyTableCellView(o
83
85
  });
84
86
  };
85
87
  var lazyTableHeaderView = exports.lazyTableHeaderView = function lazyTableHeaderView(options) {
86
- // LNV tables are broken in concurrent mode - temporarily disable to unblock concurrent mode
87
- if ((0, _experiments.editorExperiment)('platform_editor_exp_lazy_node_views', false) || (0, _platformFeatureFlags.fg)('platform_editor_disable_table_lnv')) {
88
+ // LNV tables were broken in concurrent mode - they were temporarily disabled to unblock concurrent mode.
89
+ // Enabling them again via the platform_editor_enable_table_lnv flag.
90
+ if ((0, _experiments.editorExperiment)('platform_editor_exp_lazy_node_views', false) || !(0, _platformFeatureFlags.fg)('platform_editor_enable_table_lnv') && (0, _platformFeatureFlags.fg)('platform_editor_disable_table_lnv')) {
88
91
  return function (node, view, getPos) {
89
92
  var _options$pluginInject2;
90
93
  return new _TableCell.default(node, view, getPos, options.eventDispatcher, (_options$pluginInject2 = options.pluginInjectionApi) === null || _options$pluginInject2 === void 0 || (_options$pluginInject2 = _options$pluginInject2.analytics) === null || _options$pluginInject2 === void 0 ? void 0 : _options$pluginInject2.actions);
@@ -115,8 +118,9 @@ var lazyTableHeaderView = exports.lazyTableHeaderView = function lazyTableHeader
115
118
  });
116
119
  };
117
120
  var lazyTableRowView = exports.lazyTableRowView = function lazyTableRowView(options) {
118
- // LNV tables are broken in concurrent mode - temporarily disable to unblock concurrent mode
119
- if ((0, _experiments.editorExperiment)('platform_editor_exp_lazy_node_views', false) || (0, _platformFeatureFlags.fg)('platform_editor_disable_table_lnv')) {
121
+ // LNV tables were broken in concurrent mode - they were temporarily disabled to unblock concurrent mode.
122
+ // Enabling them again via the platform_editor_enable_table_lnv flag.
123
+ if ((0, _experiments.editorExperiment)('platform_editor_exp_lazy_node_views', false) || !(0, _platformFeatureFlags.fg)('platform_editor_enable_table_lnv') && (0, _platformFeatureFlags.fg)('platform_editor_disable_table_lnv')) {
120
124
  return function (node, view, getPos) {
121
125
  return new _TableRow.default(node, view, getPos, options.eventDispatcher);
122
126
  };
package/dist/es2019/nodeviews/lazy-node-views.js CHANGED
@@ -6,8 +6,9 @@ import { createTableView } from './table';
6
6
  import TableCell from './TableCell';
7
7
  import TableRow from './TableRow';
8
8
  export const lazyTableView = options => {
9
- // LNV tables are broken in concurrent mode - temporarily disable to unblock concurrent mode
10
- if (editorExperiment('platform_editor_exp_lazy_node_views', false) || fg('platform_editor_disable_table_lnv')) {
9
+ // LNV tables were broken in concurrent mode - they were temporarily disabled to unblock concurrent mode.
10
+ // Enabling them again via the platform_editor_enable_table_lnv flag.
11
+ if (editorExperiment('platform_editor_exp_lazy_node_views', false) || !fg('platform_editor_enable_table_lnv') && fg('platform_editor_disable_table_lnv')) {
11
12
  return (node, view, getPos) => {
12
13
  return createTableView(node, view, getPos, options.portalProviderAPI, options.eventDispatcher, options.getEditorContainerWidth, options.getEditorFeatureFlags, options.dispatchAnalyticsEvent, options.pluginInjectionApi, options.isCommentEditor, options.isChromelessEditor);
13
14
  };
@@ -40,8 +41,9 @@ export const lazyTableView = options => {
40
41
  });
41
42
  };
42
43
  export const lazyTableCellView = options => {
43
- // LNV tables are broken in concurrent mode - temporarily disable to unblock concurrent mode
44
- if (editorExperiment('platform_editor_exp_lazy_node_views', false) || fg('platform_editor_disable_table_lnv')) {
44
+ // LNV tables were broken in concurrent mode - they were temporarily disabled to unblock concurrent mode.
45
+ // Enabling them again via the platform_editor_enable_table_lnv flag.
46
+ if (editorExperiment('platform_editor_exp_lazy_node_views', false) || !fg('platform_editor_enable_table_lnv') && fg('platform_editor_disable_table_lnv')) {
45
47
  return (node, view, getPos) => {
46
48
  var _options$pluginInject, _options$pluginInject2;
47
49
  return new TableCell(node, view, getPos, options.eventDispatcher, (_options$pluginInject = options.pluginInjectionApi) === null || _options$pluginInject === void 0 ? void 0 : (_options$pluginInject2 = _options$pluginInject.analytics) === null || _options$pluginInject2 === void 0 ? void 0 : _options$pluginInject2.actions);
@@ -70,8 +72,9 @@ export const lazyTableCellView = options => {
70
72
  });
71
73
  };
72
74
  export const lazyTableHeaderView = options => {
73
- // LNV tables are broken in concurrent mode - temporarily disable to unblock concurrent mode
74
- if (editorExperiment('platform_editor_exp_lazy_node_views', false) || fg('platform_editor_disable_table_lnv')) {
75
+ // LNV tables were broken in concurrent mode - they were temporarily disabled to unblock concurrent mode.
76
+ // Enabling them again via the platform_editor_enable_table_lnv flag.
77
+ if (editorExperiment('platform_editor_exp_lazy_node_views', false) || !fg('platform_editor_enable_table_lnv') && fg('platform_editor_disable_table_lnv')) {
75
78
  return (node, view, getPos) => {
76
79
  var _options$pluginInject3, _options$pluginInject4;
77
80
  return new TableCell(node, view, getPos, options.eventDispatcher, (_options$pluginInject3 = options.pluginInjectionApi) === null || _options$pluginInject3 === void 0 ? void 0 : (_options$pluginInject4 = _options$pluginInject3.analytics) === null || _options$pluginInject4 === void 0 ? void 0 : _options$pluginInject4.actions);
@@ -100,8 +103,9 @@ export const lazyTableHeaderView = options => {
100
103
  });
101
104
  };
102
105
  export const lazyTableRowView = options => {
103
- // LNV tables are broken in concurrent mode - temporarily disable to unblock concurrent mode
104
- if (editorExperiment('platform_editor_exp_lazy_node_views', false) || fg('platform_editor_disable_table_lnv')) {
106
+ // LNV tables were broken in concurrent mode - they were temporarily disabled to unblock concurrent mode.
107
+ // Enabling them again via the platform_editor_enable_table_lnv flag.
108
+ if (editorExperiment('platform_editor_exp_lazy_node_views', false) || !fg('platform_editor_enable_table_lnv') && fg('platform_editor_disable_table_lnv')) {
105
109
  return (node, view, getPos) => {
106
110
  return new TableRow(node, view, getPos, options.eventDispatcher);
107
111
  };
package/dist/esm/nodeviews/lazy-node-views.js CHANGED
@@ -6,8 +6,9 @@ import { createTableView } from './table';
6
6
  import TableCell from './TableCell';
7
7
  import TableRow from './TableRow';
8
8
  export var lazyTableView = function lazyTableView(options) {
9
- // LNV tables are broken in concurrent mode - temporarily disable to unblock concurrent mode
10
- if (editorExperiment('platform_editor_exp_lazy_node_views', false) || fg('platform_editor_disable_table_lnv')) {
9
+ // LNV tables were broken in concurrent mode - they were temporarily disabled to unblock concurrent mode.
10
+ // Enabling them again via the platform_editor_enable_table_lnv flag.
11
+ if (editorExperiment('platform_editor_exp_lazy_node_views', false) || !fg('platform_editor_enable_table_lnv') && fg('platform_editor_disable_table_lnv')) {
11
12
  return function (node, view, getPos) {
12
13
  return createTableView(node, view, getPos, options.portalProviderAPI, options.eventDispatcher, options.getEditorContainerWidth, options.getEditorFeatureFlags, options.dispatchAnalyticsEvent, options.pluginInjectionApi, options.isCommentEditor, options.isChromelessEditor);
13
14
  };
@@ -40,8 +41,9 @@ export var lazyTableView = function lazyTableView(options) {
40
41
  });
41
42
  };
42
43
  export var lazyTableCellView = function lazyTableCellView(options) {
43
- // LNV tables are broken in concurrent mode - temporarily disable to unblock concurrent mode
44
- if (editorExperiment('platform_editor_exp_lazy_node_views', false) || fg('platform_editor_disable_table_lnv')) {
44
+ // LNV tables were broken in concurrent mode - they were temporarily disabled to unblock concurrent mode.
45
+ // Enabling them again via the platform_editor_enable_table_lnv flag.
46
+ if (editorExperiment('platform_editor_exp_lazy_node_views', false) || !fg('platform_editor_enable_table_lnv') && fg('platform_editor_disable_table_lnv')) {
45
47
  return function (node, view, getPos) {
46
48
  var _options$pluginInject;
47
49
  return new TableCell(node, view, getPos, options.eventDispatcher, (_options$pluginInject = options.pluginInjectionApi) === null || _options$pluginInject === void 0 || (_options$pluginInject = _options$pluginInject.analytics) === null || _options$pluginInject === void 0 ? void 0 : _options$pluginInject.actions);
@@ -70,8 +72,9 @@ export var lazyTableCellView = function lazyTableCellView(options) {
70
72
  });
71
73
  };
72
74
  export var lazyTableHeaderView = function lazyTableHeaderView(options) {
73
- // LNV tables are broken in concurrent mode - temporarily disable to unblock concurrent mode
74
- if (editorExperiment('platform_editor_exp_lazy_node_views', false) || fg('platform_editor_disable_table_lnv')) {
75
+ // LNV tables were broken in concurrent mode - they were temporarily disabled to unblock concurrent mode.
76
+ // Enabling them again via the platform_editor_enable_table_lnv flag.
77
+ if (editorExperiment('platform_editor_exp_lazy_node_views', false) || !fg('platform_editor_enable_table_lnv') && fg('platform_editor_disable_table_lnv')) {
75
78
  return function (node, view, getPos) {
76
79
  var _options$pluginInject2;
77
80
  return new TableCell(node, view, getPos, options.eventDispatcher, (_options$pluginInject2 = options.pluginInjectionApi) === null || _options$pluginInject2 === void 0 || (_options$pluginInject2 = _options$pluginInject2.analytics) === null || _options$pluginInject2 === void 0 ? void 0 : _options$pluginInject2.actions);
@@ -100,8 +103,9 @@ export var lazyTableHeaderView = function lazyTableHeaderView(options) {
100
103
  });
101
104
  };
102
105
  export var lazyTableRowView = function lazyTableRowView(options) {
103
- // LNV tables are broken in concurrent mode - temporarily disable to unblock concurrent mode
104
- if (editorExperiment('platform_editor_exp_lazy_node_views', false) || fg('platform_editor_disable_table_lnv')) {
106
+ // LNV tables were broken in concurrent mode - they were temporarily disabled to unblock concurrent mode.
107
+ // Enabling them again via the platform_editor_enable_table_lnv flag.
108
+ if (editorExperiment('platform_editor_exp_lazy_node_views', false) || !fg('platform_editor_enable_table_lnv') && fg('platform_editor_disable_table_lnv')) {
105
109
  return function (node, view, getPos) {
106
110
  return new TableRow(node, view, getPos, options.eventDispatcher);
107
111
  };
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@atlaskit/editor-plugin-table",
3
- "version": "10.10.1",
3
+ "version": "10.10.3",
4
4
  "description": "Table plugin for the @atlaskit/editor",
5
5
  "publishConfig": {
6
6
  "registry": "https://registry.npmjs.org/"
@@ -32,7 +32,7 @@
32
32
  "@atlaskit/adf-schema": "^47.6.0",
33
33
  "@atlaskit/button": "^23.2.0",
34
34
  "@atlaskit/custom-steps": "^0.11.0",
35
- "@atlaskit/editor-common": "^105.6.0",
35
+ "@atlaskit/editor-common": "^105.8.0",
36
36
  "@atlaskit/editor-palette": "^2.1.0",
37
37
  "@atlaskit/editor-plugin-accessibility-utils": "^2.0.0",
38
38
  "@atlaskit/editor-plugin-analytics": "^2.3.0",
@@ -47,14 +47,14 @@
47
47
  "@atlaskit/editor-shared-styles": "^3.4.0",
48
48
  "@atlaskit/editor-tables": "^2.9.0",
49
49
  "@atlaskit/icon": "^26.1.0",
50
- "@atlaskit/menu": "^7.1.0",
50
+ "@atlaskit/menu": "^8.0.0",
51
51
  "@atlaskit/platform-feature-flags": "^1.1.0",
52
52
  "@atlaskit/pragmatic-drag-and-drop": "^1.7.0",
53
53
  "@atlaskit/pragmatic-drag-and-drop-auto-scroll": "^2.1.0",
54
54
  "@atlaskit/pragmatic-drag-and-drop-hitbox": "^1.1.0",
55
55
  "@atlaskit/primitives": "^14.8.0",
56
56
  "@atlaskit/theme": "^18.0.0",
57
- "@atlaskit/tmp-editor-statsig": "^4.22.0",
57
+ "@atlaskit/tmp-editor-statsig": "^4.24.0",
58
58
  "@atlaskit/toggle": "^15.0.0",
59
59
  "@atlaskit/tokens": "^4.9.0",
60
60
  "@atlaskit/tooltip": "^20.0.0",
@@ -138,6 +138,9 @@
138
138
  "platform_editor_disable_table_lnv": {
139
139
  "type": "boolean"
140
140
  },
141
+ "platform_editor_enable_table_lnv": {
142
+ "type": "boolean"
143
+ },
141
144
  "nested_table_control_padding_with_css": {
142
145
  "type": "boolean"
143
146
  },
package/src/nodeviews/lazy-node-views.ts CHANGED
@@ -27,10 +27,11 @@ type TableViewOptions = {
27
27
  };
28
28
 
29
29
  export const lazyTableView = (options: TableViewOptions) => {
30
- // LNV tables are broken in concurrent mode - temporarily disable to unblock concurrent mode
30
+ // LNV tables were broken in concurrent mode - they were temporarily disabled to unblock concurrent mode.
31
+ // Enabling them again via the platform_editor_enable_table_lnv flag.
31
32
  if (
32
33
  editorExperiment('platform_editor_exp_lazy_node_views', false) ||
33
- fg('platform_editor_disable_table_lnv')
34
+ (!fg('platform_editor_enable_table_lnv') && fg('platform_editor_disable_table_lnv'))
34
35
  ) {
35
36
  return (node: PMNode, view: EditorView, getPos: () => number | undefined) => {
36
37
  return createTableView(
@@ -102,10 +103,11 @@ type TableCellViewOptions = {
102
103
  pluginInjectionApi?: PluginInjectionAPI;
103
104
  };
104
105
  export const lazyTableCellView = (options: TableCellViewOptions) => {
105
- // LNV tables are broken in concurrent mode - temporarily disable to unblock concurrent mode
106
+ // LNV tables were broken in concurrent mode - they were temporarily disabled to unblock concurrent mode.
107
+ // Enabling them again via the platform_editor_enable_table_lnv flag.
106
108
  if (
107
109
  editorExperiment('platform_editor_exp_lazy_node_views', false) ||
108
- fg('platform_editor_disable_table_lnv')
110
+ (!fg('platform_editor_enable_table_lnv') && fg('platform_editor_disable_table_lnv'))
109
111
  ) {
110
112
  return (node: PMNode, view: EditorView, getPos: () => number | undefined) => {
111
113
  return new TableCell(
@@ -153,10 +155,11 @@ export const lazyTableCellView = (options: TableCellViewOptions) => {
153
155
  };
154
156
 
155
157
  export const lazyTableHeaderView = (options: TableCellViewOptions) => {
156
- // LNV tables are broken in concurrent mode - temporarily disable to unblock concurrent mode
158
+ // LNV tables were broken in concurrent mode - they were temporarily disabled to unblock concurrent mode.
159
+ // Enabling them again via the platform_editor_enable_table_lnv flag.
157
160
  if (
158
161
  editorExperiment('platform_editor_exp_lazy_node_views', false) ||
159
- fg('platform_editor_disable_table_lnv')
162
+ (!fg('platform_editor_enable_table_lnv') && fg('platform_editor_disable_table_lnv'))
160
163
  ) {
161
164
  return (node: PMNode, view: EditorView, getPos: () => number | undefined) => {
162
165
  return new TableCell(
@@ -204,10 +207,11 @@ export const lazyTableHeaderView = (options: TableCellViewOptions) => {
204
207
  };
205
208
 
206
209
  export const lazyTableRowView = (options: TableCellViewOptions) => {
207
- // LNV tables are broken in concurrent mode - temporarily disable to unblock concurrent mode
210
+ // LNV tables were broken in concurrent mode - they were temporarily disabled to unblock concurrent mode.
211
+ // Enabling them again via the platform_editor_enable_table_lnv flag.
208
212
  if (
209
213
  editorExperiment('platform_editor_exp_lazy_node_views', false) ||
210
- fg('platform_editor_disable_table_lnv')
214
+ (!fg('platform_editor_enable_table_lnv') && fg('platform_editor_disable_table_lnv'))
211
215
  ) {
212
216
  return (node: PMNode, view: EditorView, getPos: () => number | undefined) => {
213
217
  return new TableRow(node, view, getPos, options.eventDispatcher);