@atlaskit/editor-plugin-table 1.2.5 → 1.2.7

package/CHANGELOG.md

@@ -1,5 +1,19 @@
 # @atlaskit/editor-plugin-table
 
+## 1.2.7
+
+### Patch Changes
+
+- [`55b4a026119`](https://bitbucket.org/atlassian/atlassian-frontend/commits/55b4a026119) - [ux] ED-17710 Cellbackground button in context menu is tokenised.
+
+## 1.2.6
+
+### Patch Changes
+
+- [`0ffb55018c9`](https://bitbucket.org/atlassian/atlassian-frontend/commits/0ffb55018c9) - Revert "[ED-17172] Bumped prosemirror-view from 1.23.2 to 1.23.7 and removed work-around for fixed issues"
+- [`888cd482b98`](https://bitbucket.org/atlassian/atlassian-frontend/commits/888cd482b98) - Fix logic of generated new duplicated localIds when pasting a copied node above the copied node
+- Updated dependencies
+
 ## 1.2.5
 
 ### Patch Changes

package/dist/cjs/plugins/table/commands/selection.js

@@ -9,12 +9,12 @@ var _tableMap = require("@atlaskit/editor-tables/table-map");
 var _cellSelection = require("@atlaskit/editor-tables/cell-selection");
 var _utils = require("@atlaskit/editor-tables/utils");
 var _selection = require("@atlaskit/editor-common/selection");
-var TableSelectionDirection;
-exports.TableSelectionDirection = TableSelectionDirection;
-(function (TableSelectionDirection) {
+var TableSelectionDirection = /*#__PURE__*/function (TableSelectionDirection) {
   TableSelectionDirection["TopToBottom"] = "TopToBottom";
   TableSelectionDirection["BottomToTop"] = "BottomToTop";
-})(TableSelectionDirection || (exports.TableSelectionDirection = TableSelectionDirection = {}));
+  return TableSelectionDirection;
+}({});
+exports.TableSelectionDirection = TableSelectionDirection;
 var arrowLeftFromTable = function arrowLeftFromTable(editorSelectionAPI) {
   return function () {
     return function (state, dispatch) {

package/dist/cjs/plugins/table/event-handlers.js

@@ -227,8 +227,8 @@ var handleMouseMove = function handleMouseMove(getEditorFeatureFlags) {
     var _getEditorFeatureFlag = getEditorFeatureFlags(),
       mouseMoveOptimization = _getEditorFeatureFlag.mouseMoveOptimization;
     if (!(0, _utils3.isResizeHandleDecoration)(element) && (0, _utils3.isCell)(element)) {
-      var positionColumn = (0, _utils3.getMousePositionHorizontalRelativeByElement)(event, mouseMoveOptimization, elementContentRects, _types.RESIZE_HANDLE_AREA_DECORATION_GAP);
-      if (positionColumn !== null) {
+      var _positionColumn = (0, _utils3.getMousePositionHorizontalRelativeByElement)(event, mouseMoveOptimization, elementContentRects, _types.RESIZE_HANDLE_AREA_DECORATION_GAP);
+      if (_positionColumn !== null) {
         var _state4 = view.state,
           _dispatch5 = view.dispatch;
         var _getPluginState5 = (0, _pluginFactory.getPluginState)(_state4),
@@ -238,7 +238,7 @@ var handleMouseMove = function handleMouseMove(getEditorFeatureFlags) {
         var cellStartPosition = view.posAtDOM(tableCell, 0);
         var rect = (0, _utils.findCellRectClosestToPos)(_state4.doc.resolve(cellStartPosition));
         if (rect) {
-          var columnEndIndexTarget = positionColumn === 'left' ? rect.left : rect.right;
+          var columnEndIndexTarget = _positionColumn === 'left' ? rect.left : rect.right;
           var rowIndexTarget = rect.top;
           if (columnEndIndexTarget !== resizeHandleColumnIndex || rowIndexTarget !== resizeHandleRowIndex || !(0, _utils3.hasResizeHandler)({
             target: element,

package/dist/cjs/plugins/table/nodeviews/OverflowShadowsObserver.js

@@ -76,6 +76,11 @@ var OverflowShadowsObserver = /*#__PURE__*/function () {
         _this.shadowsObserved = true;
       }
     });
+    /**
+     * Takes a heightStyle if it can be computed in a less expensive manner,
+     * e.g. bounds on an IntersectionObserverEntry, otherwise proceed with
+     * reading it from sticky cell
+     */
     (0, _defineProperty2.default)(this, "updateStickyShadows", function (stickyRowHeight) {
       var _this$wrapper, _this$wrapper2, _this$wrapper2$parent, _this$wrapper3, _this$wrapper3$parent;
       if (!_this.isSticky) {
@@ -122,12 +127,6 @@ var OverflowShadowsObserver = /*#__PURE__*/function () {
       var stickyCell = stickyRow && stickyRow.firstElementChild;
       return stickyCell;
     }
-
-    /**
-     * Takes a heightStyle if it can be computed in a less expensive manner,
-     * e.g. bounds on an IntersectionObserverEntry, otherwise proceed with
-     * reading it from sticky cell
-     */
   }, {
     key: "dispose",
     value: function dispose() {

package/dist/cjs/plugins/table/pm-plugins/sticky-headers/nodeviews/tableRow.js

@@ -68,15 +68,20 @@ var TableRowNodeView = /*#__PURE__*/function () {
   function TableRowNodeView(node, view, getPos, eventDispatcher, getEditorFeatureFlags) {
     var _this = this;
     (0, _classCallCheck2.default)(this, TableRowNodeView);
+    // this is the sticky header table row
     (0, _defineProperty2.default)(this, "colControlsOffset", 0);
     (0, _defineProperty2.default)(this, "focused", false);
     (0, _defineProperty2.default)(this, "topPosEditorElement", 0);
     (0, _defineProperty2.default)(this, "stickyHeadersOptimization", false);
     (0, _defineProperty2.default)(this, "sentinels", {});
+    /* external events */
     (0, _defineProperty2.default)(this, "listening", false);
     (0, _defineProperty2.default)(this, "headerRowMouseScrollEnd", (0, _debounce.default)(function () {
       _this.dom.classList.remove('no-pointer-events');
     }, HEADER_ROW_SCROLL_RESET_DEBOUNCE_TIMEOUT));
+    // When the header is sticky, the header row is set to position: fixed
+    // This prevents mouse wheel scrolling on the scroll-parent div when user's mouse is hovering the header row.
+    // This fix sets pointer-events: none on the header row briefly to avoid this behaviour
     (0, _defineProperty2.default)(this, "headerRowMouseScroll", (0, _throttle.default)(function () {
       if (_this.isSticky) {
         _this.dom.classList.add('no-pointer-events');
@@ -135,6 +140,7 @@ var TableRowNodeView = /*#__PURE__*/function () {
       _this.dom.scrollLeft = wrapper.scrollLeft;
       _this.lastTimePainted = performance.now();
     });
+    /* receive external events */
     (0, _defineProperty2.default)(this, "onTablePluginState", function (state) {
       var tableRef = state.tableRef;
       var focusChanged = false;
@@ -270,12 +276,14 @@ var TableRowNodeView = /*#__PURE__*/function () {
     (0, _defineProperty2.default)(this, "getWrapperRefTop", function (wrapper) {
       return Math.round((0, _dom2.getTop)(wrapper)) + _this.getWrapperoffset();
     });
+    // TODO: rename!
     (0, _defineProperty2.default)(this, "getScrolledTableTop", function (wrapper) {
       return _this.getWrapperRefTop(wrapper) - _this.topPosEditorElement;
     });
     (0, _defineProperty2.default)(this, "getCurrentTableTop", function (tree) {
       return _this.getScrolledTableTop(tree.wrapper) + tree.table.clientHeight;
     });
+    /* emit external events */
     (0, _defineProperty2.default)(this, "padding", 0);
     (0, _defineProperty2.default)(this, "top", 0);
     (0, _defineProperty2.default)(this, "emitOn", function (top, padding) {
@@ -323,18 +331,9 @@ var TableRowNodeView = /*#__PURE__*/function () {
       this.subscribe();
     }
   }
-
-  /* external events */
-
-  // When the header is sticky, the header row is set to position: fixed
-  // This prevents mouse wheel scrolling on the scroll-parent div when user's mouse is hovering the header row.
-  // This fix sets pointer-events: none on the header row briefly to avoid this behaviour
   (0, _createClass2.default)(TableRowNodeView, [{
     key: "tree",
-    get:
-    // this is the sticky header table row
-
-    function get() {
+    get: function get() {
       return (0, _dom2.getTree)(this.dom);
     }
   }, {
@@ -563,12 +562,6 @@ var TableRowNodeView = /*#__PURE__*/function () {
       }
       return true;
     }
-
-    /* receive external events */
-
-    // TODO: rename!
-
-    /* emit external events */
   }]);
   return TableRowNodeView;
 }();

package/dist/cjs/plugins/table/pm-plugins/table-local-id.js

@@ -11,6 +11,9 @@ var _prosemirrorState = require("prosemirror-state");
 var _rafSchd = _interopRequireDefault(require("raf-schd"));
 var _adfSchema = require("@atlaskit/adf-schema");
 var _utils = require("@atlaskit/editor-common/utils");
+function _createForOfIteratorHelper(o, allowArrayLike) { var it = typeof Symbol !== "undefined" && o[Symbol.iterator] || o["@@iterator"]; if (!it) { if (Array.isArray(o) || (it = _unsupportedIterableToArray(o)) || allowArrayLike && o && typeof o.length === "number") { if (it) o = it; var i = 0; var F = function F() {}; return { s: F, n: function n() { if (i >= o.length) return { done: true }; return { done: false, value: o[i++] }; }, e: function e(_e) { throw _e; }, f: F }; } throw new TypeError("Invalid attempt to iterate non-iterable instance.\nIn order to be iterable, non-array objects must have a [Symbol.iterator]() method."); } var normalCompletion = true, didErr = false, err; return { s: function s() { it = it.call(o); }, n: function n() { var step = it.next(); normalCompletion = step.done; return step; }, e: function e(_e2) { didErr = true; err = _e2; }, f: function f() { try { if (!normalCompletion && it.return != null) it.return(); } finally { if (didErr) throw err; } } }; }
+function _unsupportedIterableToArray(o, minLen) { if (!o) return; if (typeof o === "string") return _arrayLikeToArray(o, minLen); var n = Object.prototype.toString.call(o).slice(8, -1); if (n === "Object" && o.constructor) n = o.constructor.name; if (n === "Map" || n === "Set") return Array.from(o); if (n === "Arguments" || /^(?:Ui|I)nt(?:8|16|32)(?:Clamped)?Array$/.test(n)) return _arrayLikeToArray(o, minLen); }
+function _arrayLikeToArray(arr, len) { if (len == null || len > arr.length) len = arr.length; for (var i = 0, arr2 = new Array(len); i < len; i++) arr2[i] = arr[i]; return arr2; }
 function ownKeys(object, enumerableOnly) { var keys = Object.keys(object); if (Object.getOwnPropertySymbols) { var symbols = Object.getOwnPropertySymbols(object); enumerableOnly && (symbols = symbols.filter(function (sym) { return Object.getOwnPropertyDescriptor(object, sym).enumerable; })), keys.push.apply(keys, symbols); } return keys; }
 function _objectSpread(target) { for (var i = 1; i < arguments.length; i++) { var source = null != arguments[i] ? arguments[i] : {}; i % 2 ? ownKeys(Object(source), !0).forEach(function (key) { (0, _defineProperty2.default)(target, key, source[key]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(target, Object.getOwnPropertyDescriptors(source)) : ownKeys(Object(source)).forEach(function (key) { Object.defineProperty(target, key, Object.getOwnPropertyDescriptor(source, key)); }); } return target; } /**
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                           * A plugin for ensuring tables always have unique local IDs, and to
@@ -29,15 +32,6 @@ var getPluginState = function getPluginState(state) {
   return state && pluginKey.getState(state);
 };
 
-/**
- * Traverses a transaction's steps to see if we're inserting any tables
- */
-var checkIsAddingTable = function checkIsAddingTable(transaction, nodeType) {
-  return transaction.steps.some(function (step) {
-    return (0, _utils.stepAddsOneOf)(step, new Set([nodeType]));
-  });
-};
-
 /**
  * Ensures uniqueness of `localId`s on tables being created or edited
  */
@@ -130,7 +124,9 @@ var createPlugin = function createPlugin(dispatch) {
       var modified = false;
       var tr = newState.tr;
       var table = newState.schema.nodes.table;
-      var idsObserved = new Set();
+      var addedTableNodes = new Set();
+      var addedTableNodePos = new Map();
+      var localIds = new Set();
       transactions.forEach(function (transaction) {
         if (!transaction.docChanged) {
           return;
@@ -143,38 +139,70 @@ var createPlugin = function createPlugin(dispatch) {
           return;
         }
 
-        /** Check if we're actually inserting a table, otherwise we can ignore this tr */
-        var isAddingTable = checkIsAddingTable(transaction, table);
-        if (!isAddingTable) {
-          return;
-        }
-
-        // Can't simply look at changed nodes, as we could be adding a table
-        newState.doc.descendants(function (node, pos) {
-          var isTable = node.type === table;
-          var localId = node.attrs.localId;
-
-          // Dealing with a table - make sure it's a unique ID
-          if (isTable) {
-            if (localId && !idsObserved.has(localId)) {
-              idsObserved.add(localId);
-              // Also add a localId if it happens to not have one,
-            } else if (!localId || idsObserved.has(localId)) {
-              modified = true;
-              tr.setNodeMarkup(pos, undefined, _objectSpread(_objectSpread({}, node.attrs), {}, {
-                localId: _adfSchema.uuid.generate()
-              }));
+        /** Get the tables we are adding and their position */
+        var _iterator = _createForOfIteratorHelper(transaction.steps),
+          _step;
+        try {
+          for (_iterator.s(); !(_step = _iterator.n()).done;) {
+            var step = _step.value;
+            if (!(0, _utils.stepHasSlice)(step)) {
+              continue;
             }
-            return false;
+            step.slice.content.descendants(function (node, pos) {
+              if (node.type === table) {
+                addedTableNodes.add(node);
+              }
+              return true;
+            });
           }
+        } catch (err) {
+          _iterator.e(err);
+        } finally {
+          _iterator.f();
+        }
+      });
+      if (!addedTableNodes.size) {
+        return;
+      }
 
-          /**
-           * Otherwise continue traversing, we can encounter tables nested in
-           * expands/bodiedExtensions
-           */
+      // Get the existing localIds on the page
+      newState.doc.descendants(function (node, pos) {
+        // Skip if this is position of added table
+        if (addedTableNodes.has(node)) {
+          addedTableNodePos.set(node, pos);
+          return false;
+        }
+        if (node.type !== table) {
           return true;
-        });
+        }
+        localIds.add(node.attrs.localId);
+
+        // can't have table within a table
+        return false;
       });
+
+      // If the added nodes have duplicate id, generate a new one
+      var _iterator2 = _createForOfIteratorHelper(addedTableNodes),
+        _step2;
+      try {
+        for (_iterator2.s(); !(_step2 = _iterator2.n()).done;) {
+          var node = _step2.value;
+          if (!node.attrs.localId || localIds.has(node.attrs.localId)) {
+            var pos = addedTableNodePos.get(node);
+            if (pos === undefined) {
+              continue;
+            }
+            tr.setNodeMarkup(pos, undefined, _objectSpread(_objectSpread({}, node.attrs), {}, {
+              localId: _adfSchema.uuid.generate()
+            }));
+            modified = true;
+          }
+        }
+      } catch (err) {
+        _iterator2.e(err);
+      } finally {
+        _iterator2.f();
+      }
       if (modified) {
         return tr;
       }

package/dist/cjs/plugins/table/pm-plugins/table-resizing/utils/resize-logic.js

@@ -98,12 +98,12 @@ function reduceSpace(state, amount) {
   }
   return state;
 }
-var ColType; // TODO: should handle when destIdx:
-// - is beyond the range, and then not give it back
-(function (ColType) {
+var ColType = /*#__PURE__*/function (ColType) {
   ColType["SOURCE"] = "src";
   ColType["DEST"] = "dest";
-})(ColType || (ColType = {}));
+  return ColType;
+}(ColType || {}); // TODO: should handle when destIdx:
+// - is beyond the range, and then not give it back
 function moveSpaceFrom(state, srcIdx, destIdx, amount) {
   var useFreeSpace = arguments.length > 4 && arguments[4] !== undefined ? arguments[4] : true;
   var srcCol = state.cols[srcIdx];

package/dist/cjs/plugins/table/transforms/delete-rows.js

@@ -43,7 +43,7 @@ var deleteRows = function deleteRows(rect) {
     var _loop = function _loop(rowIndex) {
       var rowCells = [];
       var row = table.node.child(rowIndex);
-      var _loop2 = function _loop2(colIndex) {
+      var _loop2 = function _loop2() {
         var cellPos = map.map[rowIndex * map.width + colIndex];
         var cell = table.node.nodeAt(cellPos);
         if (!cell) {
@@ -97,7 +97,7 @@ var deleteRows = function deleteRows(rect) {
         }
       };
       for (var colIndex = 0; colIndex < map.width; colIndex++) {
-        var _ret = _loop2(colIndex);
+        var _ret = _loop2();
         if (_ret === "continue") continue;
       }
       if (rowCells.length) {

package/dist/cjs/plugins/table/types.js

@@ -37,9 +37,7 @@ var RESIZE_HANDLE_AREA_DECORATION_GAP = 30;
  *
  */
 exports.RESIZE_HANDLE_AREA_DECORATION_GAP = RESIZE_HANDLE_AREA_DECORATION_GAP;
-var TableDecorations;
-exports.TableDecorations = TableDecorations;
-(function (TableDecorations) {
+var TableDecorations = /*#__PURE__*/function (TableDecorations) {
   TableDecorations["ALL_CONTROLS_HOVER"] = "CONTROLS_HOVER";
   TableDecorations["ROW_CONTROLS_HOVER"] = "ROW_CONTROLS_HOVER";
   TableDecorations["COLUMN_CONTROLS_HOVER"] = "COLUMN_CONTROLS_HOVER";
@@ -50,7 +48,9 @@ exports.TableDecorations = TableDecorations;
   TableDecorations["COLUMN_RESIZING_HANDLE"] = "COLUMN_RESIZING_HANDLE";
   TableDecorations["COLUMN_RESIZING_HANDLE_LINE"] = "COLUMN_RESIZING_HANDLE_LINE";
   TableDecorations["LAST_CELL_ELEMENT"] = "LAST_CELL_ELEMENT";
-})(TableDecorations || (exports.TableDecorations = TableDecorations = {}));
+  return TableDecorations;
+}({});
+exports.TableDecorations = TableDecorations;
 var TableCssClassName = _objectSpread(_objectSpread({}, _styles.TableSharedCssClassName), {}, {
   COLUMN_CONTROLS: "".concat(_adfSchema.tablePrefixSelector, "-column-controls"),
   COLUMN_CONTROLS_DECORATIONS: "".concat(_adfSchema.tablePrefixSelector, "-column-controls-decoration"),
@@ -113,9 +113,9 @@ var TableCssClassName = _objectSpread(_objectSpread({}, _styles.TableSharedCssCl
   WITH_RESIZE_LINE_LAST_COLUMN: "".concat(_adfSchema.tablePrefixSelector, "-column-resize-line-last-column")
 });
 exports.TableCssClassName = TableCssClassName;
-var ShadowEvent;
-exports.ShadowEvent = ShadowEvent;
-(function (ShadowEvent) {
+var ShadowEvent = /*#__PURE__*/function (ShadowEvent) {
   ShadowEvent["SHOW_BEFORE_SHADOW"] = "showBeforeShadow";
   ShadowEvent["SHOW_AFTER_SHADOW"] = "showAfterShadow";
-})(ShadowEvent || (exports.ShadowEvent = ShadowEvent = {}));
+  return ShadowEvent;
+}({});
+exports.ShadowEvent = ShadowEvent;

package/dist/cjs/plugins/table/ui/FloatingContextualMenu/ContextualMenu.js

@@ -128,7 +128,7 @@ var ContextualMenu = /*#__PURE__*/function (_Component) {
       if (allowBackgroundColor) {
         var _node$attrs;
         var node = isOpen && targetCellPosition ? state.doc.nodeAt(targetCellPosition) : null;
-        var background = (node === null || node === void 0 ? void 0 : (_node$attrs = node.attrs) === null || _node$attrs === void 0 ? void 0 : _node$attrs.background) || '#ffffff';
+        var background = (0, _editorPalette.hexToEditorBackgroundPaletteColor)((node === null || node === void 0 ? void 0 : (_node$attrs = node.attrs) === null || _node$attrs === void 0 ? void 0 : _node$attrs.background) || '#ffffff');
         items.push({
           content: formatMessage(messages.cellBackground),
           value: {

package/dist/cjs/plugins/table/ui/FloatingDeleteButton/index.js

@@ -106,6 +106,12 @@ var FloatingDeleteButton = /*#__PURE__*/function (_Component) {
         dispatch = _this$props$editorVie2.dispatch;
       return (0, _commands.clearHoverSelection)()(state, dispatch);
     });
+    /**
+     *
+     *
+     * @private
+     * @memberof FloatingDeleteButton
+     */
     (0, _defineProperty2.default)((0, _assertThisInitialized2.default)(_this), "handleClick", function (event) {
       event.preventDefault();
       var editorAnalyticsAPI = _this.props.editorAnalyticsAPI;
@@ -288,13 +294,6 @@ var FloatingDeleteButton = /*#__PURE__*/function (_Component) {
       // Do nothing if doesn't change anything
       return null;
     }
-
-    /**
-     *
-     *
-     * @private
-     * @memberof FloatingDeleteButton
-     */
   }]);
   return FloatingDeleteButton;
 }(_react.Component);

package/dist/cjs/plugins/table/ui/TableFloatingControls/index.js

@@ -24,7 +24,7 @@ function _getRequireWildcardCache(nodeInterop) { if (typeof WeakMap !== "functio
 function _interopRequireWildcard(obj, nodeInterop) { if (!nodeInterop && obj && obj.__esModule) { return obj; } if (obj === null || _typeof(obj) !== "object" && typeof obj !== "function") { return { default: obj }; } var cache = _getRequireWildcardCache(nodeInterop); if (cache && cache.has(obj)) { return cache.get(obj); } var newObj = {}; var hasPropertyDescriptor = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var key in obj) { if (key !== "default" && Object.prototype.hasOwnProperty.call(obj, key)) { var desc = hasPropertyDescriptor ? Object.getOwnPropertyDescriptor(obj, key) : null; if (desc && (desc.get || desc.set)) { Object.defineProperty(newObj, key, desc); } else { newObj[key] = obj[key]; } } } newObj.default = obj; if (cache) { cache.set(obj, newObj); } return newObj; }
 function _createForOfIteratorHelper(o, allowArrayLike) { var it = typeof Symbol !== "undefined" && o[Symbol.iterator] || o["@@iterator"]; if (!it) { if (Array.isArray(o) || (it = _unsupportedIterableToArray(o)) || allowArrayLike && o && typeof o.length === "number") { if (it) o = it; var i = 0; var F = function F() {}; return { s: F, n: function n() { if (i >= o.length) return { done: true }; return { done: false, value: o[i++] }; }, e: function e(_e) { throw _e; }, f: F }; } throw new TypeError("Invalid attempt to iterate non-iterable instance.\nIn order to be iterable, non-array objects must have a [Symbol.iterator]() method."); } var normalCompletion = true, didErr = false, err; return { s: function s() { it = it.call(o); }, n: function n() { var step = it.next(); normalCompletion = step.done; return step; }, e: function e(_e2) { didErr = true; err = _e2; }, f: function f() { try { if (!normalCompletion && it.return != null) it.return(); } finally { if (didErr) throw err; } } }; }
 function _unsupportedIterableToArray(o, minLen) { if (!o) return; if (typeof o === "string") return _arrayLikeToArray(o, minLen); var n = Object.prototype.toString.call(o).slice(8, -1); if (n === "Object" && o.constructor) n = o.constructor.name; if (n === "Map" || n === "Set") return Array.from(o); if (n === "Arguments" || /^(?:Ui|I)nt(?:8|16|32)(?:Clamped)?Array$/.test(n)) return _arrayLikeToArray(o, minLen); }
-function _arrayLikeToArray(arr, len) { if (len == null || len > arr.length) len = arr.length; for (var i = 0, arr2 = new Array(len); i < len; i++) { arr2[i] = arr[i]; } return arr2; }
+function _arrayLikeToArray(arr, len) { if (len == null || len > arr.length) len = arr.length; for (var i = 0, arr2 = new Array(len); i < len; i++) arr2[i] = arr[i]; return arr2; }
 function _createSuper(Derived) { var hasNativeReflectConstruct = _isNativeReflectConstruct(); return function _createSuperInternal() { var Super = (0, _getPrototypeOf2.default)(Derived), result; if (hasNativeReflectConstruct) { var NewTarget = (0, _getPrototypeOf2.default)(this).constructor; result = Reflect.construct(Super, arguments, NewTarget); } else { result = Super.apply(this, arguments); } return (0, _possibleConstructorReturn2.default)(this, result); }; }
 function _isNativeReflectConstruct() { if (typeof Reflect === "undefined" || !Reflect.construct) return false; if (Reflect.construct.sham) return false; if (typeof Proxy === "function") return true; try { Boolean.prototype.valueOf.call(Reflect.construct(Boolean, [], function () {})); return true; } catch (e) { return false; } }
 var TableFloatingControls = /*#__PURE__*/function (_Component) {

package/dist/cjs/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/editor-plugin-table",
-	"version": "1.2.5",
+	"version": "1.2.7",
 	"sideEffects": false
 }

package/dist/es2019/plugins/table/commands/selection.js

@@ -3,11 +3,11 @@ import { TableMap } from '@atlaskit/editor-tables/table-map';
 import { CellSelection } from '@atlaskit/editor-tables/cell-selection';
 import { findTable, isTableSelected } from '@atlaskit/editor-tables/utils';
 import { RelativeSelectionPos, GapCursorSelection, Side, isSelectionAtStartOfNode, isSelectionAtEndOfNode } from '@atlaskit/editor-common/selection';
-export let TableSelectionDirection;
-(function (TableSelectionDirection) {
+export let TableSelectionDirection = /*#__PURE__*/function (TableSelectionDirection) {
   TableSelectionDirection["TopToBottom"] = "TopToBottom";
   TableSelectionDirection["BottomToTop"] = "BottomToTop";
-})(TableSelectionDirection || (TableSelectionDirection = {}));
+  return TableSelectionDirection;
+}({});
 export const arrowLeftFromTable = editorSelectionAPI => () => (state, dispatch) => {
   const {
     selection

package/dist/es2019/plugins/table/nodeviews/OverflowShadowsObserver.js

@@ -63,6 +63,11 @@ export class OverflowShadowsObserver {
         this.shadowsObserved = true;
       }
     });
+    /**
+     * Takes a heightStyle if it can be computed in a less expensive manner,
+     * e.g. bounds on an IntersectionObserverEntry, otherwise proceed with
+     * reading it from sticky cell
+     */
     _defineProperty(this, "updateStickyShadows", stickyRowHeight => {
       var _this$wrapper, _this$wrapper2, _this$wrapper2$parent, _this$wrapper3, _this$wrapper3$parent;
       if (!this.isSticky) {
@@ -105,13 +110,6 @@ export class OverflowShadowsObserver {
     const stickyCell = stickyRow && stickyRow.firstElementChild;
     return stickyCell;
   }
-
-  /**
-   * Takes a heightStyle if it can be computed in a less expensive manner,
-   * e.g. bounds on an IntersectionObserverEntry, otherwise proceed with
-   * reading it from sticky cell
-   */
-
   dispose() {
     if (this.tableIntersectionObserver) {
       this.tableIntersectionObserver.disconnect();

package/dist/es2019/plugins/table/pm-plugins/sticky-headers/nodeviews/tableRow.js

@@ -42,21 +42,24 @@ export const supportedHeaderRow = node => {
   return allHeaders && !someMerged;
 };
 export class TableRowNodeView {
-  // this is the sticky header table row
-
   get tree() {
     return getTree(this.dom);
   }
   constructor(node, view, getPos, eventDispatcher, getEditorFeatureFlags) {
+    // this is the sticky header table row
     _defineProperty(this, "colControlsOffset", 0);
     _defineProperty(this, "focused", false);
     _defineProperty(this, "topPosEditorElement", 0);
     _defineProperty(this, "stickyHeadersOptimization", false);
     _defineProperty(this, "sentinels", {});
+    /* external events */
     _defineProperty(this, "listening", false);
     _defineProperty(this, "headerRowMouseScrollEnd", debounce(() => {
       this.dom.classList.remove('no-pointer-events');
     }, HEADER_ROW_SCROLL_RESET_DEBOUNCE_TIMEOUT));
+    // When the header is sticky, the header row is set to position: fixed
+    // This prevents mouse wheel scrolling on the scroll-parent div when user's mouse is hovering the header row.
+    // This fix sets pointer-events: none on the header row briefly to avoid this behaviour
     _defineProperty(this, "headerRowMouseScroll", throttle(() => {
       if (this.isSticky) {
         this.dom.classList.add('no-pointer-events');
@@ -117,6 +120,7 @@ export class TableRowNodeView {
       this.dom.scrollLeft = wrapper.scrollLeft;
       this.lastTimePainted = performance.now();
     });
+    /* receive external events */
     _defineProperty(this, "onTablePluginState", state => {
       const tableRef = state.tableRef;
       let focusChanged = false;
@@ -254,8 +258,10 @@ export class TableRowNodeView {
       return focusValue ? 0 : tableControlsSpacing;
     });
     _defineProperty(this, "getWrapperRefTop", wrapper => Math.round(getTop(wrapper)) + this.getWrapperoffset());
+    // TODO: rename!
     _defineProperty(this, "getScrolledTableTop", wrapper => this.getWrapperRefTop(wrapper) - this.topPosEditorElement);
     _defineProperty(this, "getCurrentTableTop", tree => this.getScrolledTableTop(tree.wrapper) + tree.table.clientHeight);
+    /* emit external events */
     _defineProperty(this, "padding", 0);
     _defineProperty(this, "top", 0);
     _defineProperty(this, "emitOn", (top, padding) => {
@@ -305,12 +311,6 @@ export class TableRowNodeView {
       this.subscribe();
     }
   }
-
-  /* external events */
-
-  // When the header is sticky, the header row is set to position: fixed
-  // This prevents mouse wheel scrolling on the scroll-parent div when user's mouse is hovering the header row.
-  // This fix sets pointer-events: none on the header row briefly to avoid this behaviour
   subscribe() {
     this.editorScrollableElement = findOverflowScrollParent(this.view.dom) || window;
     if (this.editorScrollableElement) {
@@ -523,10 +523,4 @@ export class TableRowNodeView {
     }
     return true;
   }
-
-  /* receive external events */
-
-  // TODO: rename!
-
-  /* emit external events */
 }

package/dist/es2019/plugins/table/pm-plugins/table-local-id.js

@@ -15,17 +15,10 @@ import { SafePlugin } from '@atlaskit/editor-common/safe-plugin';
 import { PluginKey } from 'prosemirror-state';
 import rafSchedule from 'raf-schd';
 import { uuid } from '@atlaskit/adf-schema';
-import { stepAddsOneOf } from '@atlaskit/editor-common/utils';
+import { stepHasSlice } from '@atlaskit/editor-common/utils';
 const pluginKey = new PluginKey('tableLocalIdPlugin');
 const getPluginState = state => state && pluginKey.getState(state);
 
-/**
- * Traverses a transaction's steps to see if we're inserting any tables
- */
-const checkIsAddingTable = (transaction, nodeType) => {
-  return transaction.steps.some(step => stepAddsOneOf(step, new Set([nodeType])));
-};
-
 /**
  * Ensures uniqueness of `localId`s on tables being created or edited
  */
@@ -127,7 +120,9 @@ const createPlugin = dispatch => new SafePlugin({
     const {
       table
     } = newState.schema.nodes;
-    const idsObserved = new Set();
+    const addedTableNodes = new Set();
+    const addedTableNodePos = new Map();
+    const localIds = new Set();
     transactions.forEach(transaction => {
       if (!transaction.docChanged) {
         return;
@@ -140,39 +135,53 @@ const createPlugin = dispatch => new SafePlugin({
         return;
       }
 
-      /** Check if we're actually inserting a table, otherwise we can ignore this tr */
-      const isAddingTable = checkIsAddingTable(transaction, table);
-      if (!isAddingTable) {
-        return;
-      }
-
-      // Can't simply look at changed nodes, as we could be adding a table
-      newState.doc.descendants((node, pos) => {
-        const isTable = node.type === table;
-        const localId = node.attrs.localId;
-
-        // Dealing with a table - make sure it's a unique ID
-        if (isTable) {
-          if (localId && !idsObserved.has(localId)) {
-            idsObserved.add(localId);
-            // Also add a localId if it happens to not have one,
-          } else if (!localId || idsObserved.has(localId)) {
-            modified = true;
-            tr.setNodeMarkup(pos, undefined, {
-              ...node.attrs,
-              localId: uuid.generate()
-            });
-          }
-          return false;
+      /** Get the tables we are adding and their position */
+      for (const step of transaction.steps) {
+        if (!stepHasSlice(step)) {
+          continue;
         }
+        step.slice.content.descendants((node, pos) => {
+          if (node.type === table) {
+            addedTableNodes.add(node);
+          }
+          return true;
+        });
+      }
+    });
+    if (!addedTableNodes.size) {
+      return;
+    }
 
-        /**
-         * Otherwise continue traversing, we can encounter tables nested in
-         * expands/bodiedExtensions
-         */
+    // Get the existing localIds on the page
+    newState.doc.descendants((node, pos) => {
+      // Skip if this is position of added table
+      if (addedTableNodes.has(node)) {
+        addedTableNodePos.set(node, pos);
+        return false;
+      }
+      if (node.type !== table) {
         return true;
-      });
+      }
+      localIds.add(node.attrs.localId);
+
+      // can't have table within a table
+      return false;
     });
+
+    // If the added nodes have duplicate id, generate a new one
+    for (const node of addedTableNodes) {
+      if (!node.attrs.localId || localIds.has(node.attrs.localId)) {
+        const pos = addedTableNodePos.get(node);
+        if (pos === undefined) {
+          continue;
+        }
+        tr.setNodeMarkup(pos, undefined, {
+          ...node.attrs,
+          localId: uuid.generate()
+        });
+        modified = true;
+      }
+    }
     if (modified) {
       return tr;
     }