@atlaskit/editor-plugin-table 1.2.0 → 1.2.2

package/dist/esm/plugins/table/utils/row-controls.js

@@ -10,8 +10,9 @@ import { TableCssClassName as ClassName } from '../types';
 import { tableDeleteButtonSize } from '../ui/consts';
 export var getRowHeights = function getRowHeights(tableRef) {
   var heights = [];
-  if (tableRef.lastChild) {
-    var rows = tableRef.lastChild.childNodes;
+  var tableBody = tableRef.querySelector('tbody');
+  if (tableBody) {
+    var rows = tableBody.childNodes;
     for (var i = 0, count = rows.length; i < count; i++) {
       var row = rows[i];
       heights[i] = row.getBoundingClientRect().height + 1;

package/dist/esm/types/i18n.js

@@ -0,0 +1 @@
+export {};

package/dist/esm/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/editor-plugin-table",
-	"version": "1.2.0",
+	"version": "1.2.2",
 	"sideEffects": false
 }

package/dist/types/i18n/en.d.ts

@@ -0,0 +1,35 @@
+declare const _default: {
+    'fabric.editor.canNotSortTable': string;
+    'fabric.editor.cellBackground': string;
+    'fabric.editor.cellOptions': string;
+    'fabric.editor.clearCells': string;
+    'fabric.editor.collapseTable': string;
+    'fabric.editor.cornerControl': string;
+    'fabric.editor.distributeColumns': string;
+    'fabric.editor.extension.confirmDeleteLinkedModalMessagePrefix': string;
+    'fabric.editor.extension.deleteElementTitle': string;
+    'fabric.editor.extension.sourceNoTitledName': string;
+    'fabric.editor.floatingToolbar.confirmModalCheckboxLabel': string;
+    'fabric.editor.headerColumn': string;
+    'fabric.editor.headerRow': string;
+    'fabric.editor.insertColumn': string;
+    'fabric.editor.insertRow': string;
+    'fabric.editor.mergeCells': string;
+    'fabric.editor.numberedColumn': string;
+    'fabric.editor.removeColumns': string;
+    'fabric.editor.removeRows': string;
+    'fabric.editor.rowControl': string;
+    'fabric.editor.sortColumnASC': string;
+    'fabric.editor.sortColumnDESC': string;
+    'fabric.editor.splitCell': string;
+    'fabric.editor.tableOptions': string;
+    'fabric.editor.tables.confirmDeleteLinkedModalMessage': string;
+    'fabric.editor.tables.confirmDeleteLinkedModalOKButton': string;
+};
+/**
+ * NOTE:
+ *
+ * This file is automatically generated by Traduki 2.0.
+ * DO NOT CHANGE IT BY HAND or your changes will be lost.
+ */
+export default _default;

package/dist/types/i18n/en_GB.d.ts

@@ -0,0 +1,35 @@
+declare const _default: {
+    'fabric.editor.canNotSortTable': string;
+    'fabric.editor.cellBackground': string;
+    'fabric.editor.cellOptions': string;
+    'fabric.editor.clearCells': string;
+    'fabric.editor.collapseTable': string;
+    'fabric.editor.cornerControl': string;
+    'fabric.editor.distributeColumns': string;
+    'fabric.editor.extension.confirmDeleteLinkedModalMessagePrefix': string;
+    'fabric.editor.extension.deleteElementTitle': string;
+    'fabric.editor.extension.sourceNoTitledName': string;
+    'fabric.editor.floatingToolbar.confirmModalCheckboxLabel': string;
+    'fabric.editor.headerColumn': string;
+    'fabric.editor.headerRow': string;
+    'fabric.editor.insertColumn': string;
+    'fabric.editor.insertRow': string;
+    'fabric.editor.mergeCells': string;
+    'fabric.editor.numberedColumn': string;
+    'fabric.editor.removeColumns': string;
+    'fabric.editor.removeRows': string;
+    'fabric.editor.rowControl': string;
+    'fabric.editor.sortColumnASC': string;
+    'fabric.editor.sortColumnDESC': string;
+    'fabric.editor.splitCell': string;
+    'fabric.editor.tableOptions': string;
+    'fabric.editor.tables.confirmDeleteLinkedModalMessage': string;
+    'fabric.editor.tables.confirmDeleteLinkedModalOKButton': string;
+};
+/**
+ * NOTE:
+ *
+ * This file is automatically generated by Traduki 2.0.
+ * DO NOT CHANGE IT BY HAND or your changes will be lost.
+ */
+export default _default;

package/dist/types/plugins/table/nodeviews/OverflowShadowsObserver.d.ts

@@ -4,10 +4,9 @@ export declare class OverflowShadowsObserver {
     private updateShadowState;
     private table;
     private wrapper;
-    private firstCell;
-    private lastCell;
-    private getFirstCell;
-    private getLastCell;
+    private leftShadowSentinel;
+    private rightShadowSentinel;
+    private shadowsObserved;
     private isSticky;
     private stickyRowHeight;
     constructor(updateShadowState: (shadowKey: ShadowEvent, value: boolean) => void, table: HTMLElement, wrapper: HTMLDivElement);
@@ -15,7 +14,7 @@ export declare class OverflowShadowsObserver {
     private checkIntersectionEvent;
     private updateStickyShadowsHeightIfChanged;
     private getStickyCell;
-    observeCells: (isSticky?: boolean | undefined, hasHeaderRow?: boolean | undefined) => void;
+    observeShadowSentinels: (isSticky?: boolean | undefined) => void;
     /**
      * Takes a heightStyle if it can be computed in a less expensive manner,
      * e.g. bounds on an IntersectionObserverEntry, otherwise proceed with

package/dist/types/plugins/table/nodeviews/TableComponent.d.ts

@@ -50,6 +50,7 @@ declare class TableComponent extends React.Component<ComponentProps, TableState>
     componentDidUpdate(prevProps: ComponentProps): void;
     private updateShadows;
     private updateShadowState;
+    private createShadowSentinels;
     onStickyState: (state: StickyPluginState) => void;
     prevTableState: any;
     render(): JSX.Element;

package/dist/types/plugins/table/nodeviews/__mocks__/OverflowShadowsObserver.d.ts

@@ -1,9 +1,9 @@
 import { OverridableMock } from './OverridableMock';
 export declare class OverflowShadowsObserver extends OverridableMock {
-    firstCell: HTMLElement | null;
-    lastCell: HTMLElement | null;
+    leftShadowSentinel: HTMLElement | null;
+    rightShadowSentinel: HTMLElement | null;
     constructor(...inputs: any[]);
-    observeCells: any;
+    observeShadowSentinels: any;
     updateStickyShadows: any;
     dispose: any;
 }

package/dist/types/plugins/table/pm-plugins/sticky-headers/nodeviews/tableRow.d.ts

@@ -57,9 +57,9 @@ export declare class TableRowNodeView implements NodeView {
         target: Element;
     }): boolean;
     onTablePluginState: (state: TablePluginState) => void;
-    onWidthPluginState: () => void;
+    updateStickyHeaderWidth: () => void;
     shouldHeaderStick: (tree: TableDOMElements) => boolean;
-    makeHeaderRowSticky: (tree: TableDOMElements) => void;
+    makeHeaderRowSticky: (tree: TableDOMElements, scrollTop?: number | undefined) => void;
     makeRowHeaderNotSticky: (table: HTMLElement, isEditorDestroyed?: boolean) => void;
     getWrapperoffset: (inverse?: boolean) => number;
     getWrapperRefTop: (wrapper: HTMLElement) => number;

package/dist/types/plugins/table/pm-plugins/table-resizing/utils/misc.d.ts

@@ -18,6 +18,5 @@ interface getTableMaxWidthProps {
     layout: TableLayout;
     getEditorContainerWidth: GetEditorContainerWidth;
 }
-export declare const getTableMaxWidth: ({ table, tableStart, state, layout, getEditorContainerWidth, }: getTableMaxWidthProps) => number;
-export declare const getParentWidthWithoutPadding: (parentWidth: number, tableStartPos: number, state: EditorState) => number | undefined;
+export declare const getTableMaxWidth: ({ table, tableStart, state, layout, getEditorContainerWidth, }: getTableMaxWidthProps) => any;
 export {};

package/dist/types/plugins/table/transforms/index.d.ts

@@ -1,5 +1,5 @@
-export { mergeCells, canMergeCells, removeEmptyColumns } from './merge';
 export { fireAnalytics, fixTables, fixAutoSizedTable } from './fix-tables';
+export { mergeCells, canMergeCells, mergeEmptyColumns } from './merge';
 export { deleteColumns } from './delete-columns';
 export { deleteRows } from './delete-rows';
 export { updateColumnWidths } from './column-width';

package/dist/types/plugins/table/transforms/merge.d.ts

@@ -2,4 +2,4 @@ import { Node as PMNode } from 'prosemirror-model';
 import { Transaction } from 'prosemirror-state';
 export declare function mergeCells(tr: Transaction): Transaction;
 export declare function canMergeCells(tr: Transaction): boolean;
-export declare function removeEmptyColumns(table: PMNode): PMNode | null;
+export declare function mergeEmptyColumns(table: PMNode): PMNode | null;

package/dist/types/plugins/table/types.d.ts

@@ -291,6 +291,8 @@ export declare const TableCssClassName: {
     TABLE_STICKY_WRAPPER: string;
     TABLE_STICKY_SENTINEL_TOP: string;
     TABLE_STICKY_SENTINEL_BOTTOM: string;
+    TABLE_SHADOW_SENTINEL_LEFT: string;
+    TABLE_SHADOW_SENTINEL_RIGHT: string;
     TABLE_CELL_NODEVIEW_CONTENT_DOM: string;
     TABLE_CELL_WRAPPER: string;
     TABLE_HEADER_CELL_WRAPPER: string;

package/dist/types/plugins/table/ui/FloatingContextualMenu/ContextualMenu.d.ts

@@ -4,7 +4,7 @@ import { jsx } from '@emotion/react';
 import { Rect } from '@atlaskit/editor-tables/table-map';
 import { EditorView } from 'prosemirror-view';
 import { WrappedComponentProps } from 'react-intl-next';
-import type { GetEditorContainerWidth } from '@atlaskit/editor-common/types';
+import type { GetEditorContainerWidth, GetEditorFeatureFlags } from '@atlaskit/editor-common/types';
 import type { EditorAnalyticsAPI } from '@atlaskit/editor-common/analytics';
 export declare const messages: {
     cellBackground: {
@@ -61,6 +61,7 @@ export interface Props {
     offset?: Array<number>;
     editorAnalyticsAPI?: EditorAnalyticsAPI;
     getEditorContainerWidth: GetEditorContainerWidth;
+    getEditorFeatureFlags: GetEditorFeatureFlags;
 }
 export interface State {
     isSubmenuOpen: boolean;

package/dist/types/plugins/table/ui/FloatingContextualMenu/index.d.ts

@@ -3,11 +3,12 @@ import { jsx } from '@emotion/react';
 import { EditorView } from 'prosemirror-view';
 import { PluginConfig } from '../../types';
 import type { EditorAnalyticsAPI } from '@atlaskit/editor-common/analytics';
-import type { GetEditorContainerWidth } from '@atlaskit/editor-common/types';
+import type { GetEditorContainerWidth, GetEditorFeatureFlags } from '@atlaskit/editor-common/types';
 export interface Props {
     editorView: EditorView;
     isOpen: boolean;
     getEditorContainerWidth: GetEditorContainerWidth;
+    getEditorFeatureFlags: GetEditorFeatureFlags;
     targetCellPosition?: number;
     mountPoint?: HTMLElement;
     boundariesElement?: HTMLElement;
@@ -16,7 +17,7 @@ export interface Props {
     editorAnalyticsAPI?: EditorAnalyticsAPI;
 }
 declare const FloatingContextualMenu: {
-    ({ mountPoint, boundariesElement, scrollableElement, editorView, isOpen, pluginConfig, editorAnalyticsAPI, getEditorContainerWidth, }: Props): jsx.JSX.Element | null;
+    ({ mountPoint, boundariesElement, scrollableElement, editorView, isOpen, pluginConfig, editorAnalyticsAPI, getEditorContainerWidth, getEditorFeatureFlags, }: Props): jsx.JSX.Element | null;
     displayName: string;
 };
 export default FloatingContextualMenu;

package/dist/types/types/i18n.d.ts

@@ -0,0 +1,5 @@
+export interface MessageDescriptor {
+    id: string;
+    description: string;
+    defaultMessage: string;
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaskit/editor-plugin-table",
-  "version": "1.2.0",
+  "version": "1.2.2",
   "description": "Table plugin for the @atlaskit/editor",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/"
@@ -18,12 +18,12 @@
     "releaseModel": "scheduled"
   },
   "dependencies": {
-    "@atlaskit/adf-schema": "^25.3.0",
-    "@atlaskit/editor-common": "^72.5.0",
+    "@atlaskit/adf-schema": "^25.4.0",
+    "@atlaskit/editor-common": "^72.7.0",
     "@atlaskit/editor-shared-styles": "^2.3.0",
     "@atlaskit/editor-tables": "^2.2.0",
     "@atlaskit/icon": "^21.11.0",
-    "@atlaskit/theme": "^12.1.0",
+    "@atlaskit/theme": "^12.3.0",
     "@atlaskit/tokens": "^1.2.0",
     "@atlaskit/tooltip": "^17.7.0",
     "@babel/runtime": "^7.0.0",
@@ -50,14 +50,15 @@
   },
   "devDependencies": {
     "@atlaskit/analytics-next": "^9.0.0",
-    "@atlaskit/button": "^16.5.0",
-    "@atlaskit/editor-core": "^180.1.0",
-    "@atlaskit/editor-test-helpers": "^18.0.0",
+    "@atlaskit/button": "^16.6.0",
+    "@atlaskit/editor-core": "^182.0.0",
+    "@atlaskit/editor-plugin-feature-flags": "^0.0.2",
+    "@atlaskit/editor-test-helpers": "^18.2.0",
     "@atlaskit/link-provider": "^1.5.0",
     "@atlaskit/logo": "^13.11.0",
     "@atlaskit/media-integration-test-helpers": "^2.6.0",
     "@atlaskit/synchrony-test-helpers": "^2.3.0",
-    "@atlaskit/util-data-test": "^17.6.0",
+    "@atlaskit/util-data-test": "^17.7.0",
     "@atlaskit/visual-regression": "*",
     "@atlaskit/webdriver-runner": "*",
     "@atlassian/atlassian-frontend-prettier-config-1.0.1": "npm:@atlassian/atlassian-frontend-prettier-config@1.0.1",
@@ -87,4 +88,4 @@
       ]
     }
   }
-}
+}

package/src/__tests__/integration/__fixtures__/table-and-paragraph-adf.ts

@@ -0,0 +1,130 @@
+export default {
+  version: 1,
+  type: 'doc',
+  content: [
+    {
+      type: 'table',
+      attrs: {
+        isNumberColumnEnabled: false,
+        layout: 'default',
+        localId: '79259280-56bc-4cb0-9587-572864b97f39',
+      },
+      content: [
+        {
+          type: 'tableRow',
+          content: [
+            {
+              type: 'tableHeader',
+              attrs: {},
+              content: [
+                {
+                  type: 'paragraph',
+                  content: [],
+                },
+              ],
+            },
+            {
+              type: 'tableHeader',
+              attrs: {},
+              content: [
+                {
+                  type: 'paragraph',
+                  content: [],
+                },
+              ],
+            },
+            {
+              type: 'tableHeader',
+              attrs: {},
+              content: [
+                {
+                  type: 'paragraph',
+                  content: [],
+                },
+              ],
+            },
+          ],
+        },
+        {
+          type: 'tableRow',
+          content: [
+            {
+              type: 'tableCell',
+              attrs: {},
+              content: [
+                {
+                  type: 'paragraph',
+                  content: [],
+                },
+              ],
+            },
+            {
+              type: 'tableCell',
+              attrs: {},
+              content: [
+                {
+                  type: 'paragraph',
+                  content: [],
+                },
+              ],
+            },
+            {
+              type: 'tableCell',
+              attrs: {},
+              content: [
+                {
+                  type: 'paragraph',
+                  content: [],
+                },
+              ],
+            },
+          ],
+        },
+        {
+          type: 'tableRow',
+          content: [
+            {
+              type: 'tableCell',
+              attrs: {},
+              content: [
+                {
+                  type: 'paragraph',
+                  content: [],
+                },
+              ],
+            },
+            {
+              type: 'tableCell',
+              attrs: {},
+              content: [
+                {
+                  type: 'paragraph',
+                  content: [],
+                },
+              ],
+            },
+            {
+              type: 'tableCell',
+              attrs: {},
+              content: [
+                {
+                  type: 'paragraph',
+                  content: [],
+                },
+              ],
+            },
+          ],
+        },
+      ],
+    },
+    {
+      type: 'paragraph',
+      content: [
+        {
+          type: 'text',
+          text: 'test',
+        },
+      ],
+    },
+  ],
+};

package/src/__tests__/integration/horizontal-scroll-shadows.ts

@@ -0,0 +1,199 @@
+import { BrowserTestCase } from '@atlaskit/webdriver-runner/runner';
+import WebdriverPage from '@atlaskit/webdriver-runner/wd-wrapper';
+
+import {
+  goToEditorTestingWDExample,
+  mountEditor,
+} from '@atlaskit/editor-test-helpers/testing-example-page';
+
+import {
+  fullpage,
+  resizeColumn,
+} from '@atlaskit/editor-test-helpers/integration/helpers';
+
+import { TableCssClassName as className } from '../../plugins/table/types';
+import basicTable from './__fixtures__/basic-table';
+
+const checkShadows = async (page: WebdriverPage, side?: 'left' | 'right') => {
+  const leftShadow = await page.$(`.${className.TABLE_LEFT_SHADOW}`);
+  const leftShadowStyle = await leftShadow.getAttribute('style');
+  const rightShadow = await page.$(`.${className.TABLE_RIGHT_SHADOW}`);
+  const rightShadowStyle = await rightShadow.getAttribute('style');
+
+  if (!side) {
+    return (
+      leftShadowStyle.includes('display: block;') &&
+      rightShadowStyle.includes('display: block;')
+    );
+  } else if (side === 'left') {
+    return leftShadowStyle.includes('display: block;');
+  } else if (side === 'right') {
+    return rightShadowStyle.includes('display: block;');
+  }
+};
+
+BrowserTestCase(
+  'Table does not show horizontal scroll shadows when there is no scrollbar',
+  {},
+  async (client: any, testName: string) => {
+    const page = await goToEditorTestingWDExample(
+      client,
+      'editor-plugin-table',
+    );
+
+    await mountEditor(page, {
+      appearance: fullpage.appearance,
+      defaultValue: JSON.stringify(basicTable),
+      allowTables: {
+        advanced: true,
+      },
+    });
+
+    await page.waitForSelector('table');
+    expect(await checkShadows(page)).toBeFalsy();
+  },
+);
+
+BrowserTestCase(
+  'Table shows right shadow when table is scrollable and all the way to the left',
+  {},
+  async (client: any, testName: string) => {
+    const page = await goToEditorTestingWDExample(
+      client,
+      'editor-plugin-table',
+    );
+
+    await mountEditor(page, {
+      appearance: fullpage.appearance,
+      defaultValue: JSON.stringify(basicTable),
+      allowTables: {
+        advanced: true,
+      },
+    });
+
+    await page.waitForSelector('table');
+    await resizeColumn(page, { cellHandlePos: 2, resizeWidth: 1000 });
+
+    expect(await checkShadows(page, 'right')).toBeTruthy();
+  },
+);
+
+BrowserTestCase(
+  'Table should not show left shadow when table is scrollable and all the way to the left',
+  {},
+  async (client: any, testName: string) => {
+    const page = await goToEditorTestingWDExample(
+      client,
+      'editor-plugin-table',
+    );
+
+    await mountEditor(page, {
+      appearance: fullpage.appearance,
+      defaultValue: JSON.stringify(basicTable),
+      allowTables: {
+        advanced: true,
+      },
+    });
+
+    await page.waitForSelector('table');
+    await resizeColumn(page, { cellHandlePos: 2, resizeWidth: 1000 });
+
+    expect(await checkShadows(page, 'left')).toBeFalsy();
+  },
+);
+
+BrowserTestCase(
+  'Table should show both left and right shadows when table is scrollable and scrolled',
+  {},
+  async (client: any, testName: string) => {
+    const page = await goToEditorTestingWDExample(
+      client,
+      'editor-plugin-table',
+    );
+
+    await mountEditor(page, {
+      appearance: fullpage.appearance,
+      defaultValue: JSON.stringify(basicTable),
+      allowTables: {
+        advanced: true,
+      },
+    });
+
+    await page.waitForSelector('table');
+    await resizeColumn(page, { cellHandlePos: 2, resizeWidth: 1000 });
+    await page.evaluate(() => {
+      const tableWrapper =
+        document.querySelector<HTMLElement>('.pm-table-wrapper');
+      if (tableWrapper) {
+        tableWrapper.scrollLeft += 500;
+      }
+      return tableWrapper;
+    });
+
+    expect(await checkShadows(page)).toBeTruthy();
+  },
+);
+
+BrowserTestCase(
+  'Table should not show right shadow when table is scrollable and scrolled all the way to the right',
+  {},
+  async (client: any, testName: string) => {
+    const page = await goToEditorTestingWDExample(
+      client,
+      'editor-plugin-table',
+    );
+
+    await mountEditor(page, {
+      appearance: fullpage.appearance,
+      defaultValue: JSON.stringify(basicTable),
+      allowTables: {
+        advanced: true,
+      },
+    });
+
+    await page.waitForSelector('table');
+    await resizeColumn(page, { cellHandlePos: 2, resizeWidth: 1000 });
+    await page.evaluate(() => {
+      const tableWrapper =
+        document.querySelector<HTMLElement>('.pm-table-wrapper');
+      if (tableWrapper) {
+        tableWrapper.scrollLeft += 1000;
+      }
+      return tableWrapper;
+    });
+
+    expect(await checkShadows(page, 'right')).toBeFalsy();
+  },
+);
+
+BrowserTestCase(
+  'Table should show left shadow when table is scrollable and scrolled all the way to the right',
+  {},
+  async (client: any, testName: string) => {
+    const page = await goToEditorTestingWDExample(
+      client,
+      'editor-plugin-table',
+    );
+
+    await mountEditor(page, {
+      appearance: fullpage.appearance,
+      defaultValue: JSON.stringify(basicTable),
+      allowTables: {
+        advanced: true,
+      },
+    });
+
+    await page.waitForSelector('table');
+    await resizeColumn(page, { cellHandlePos: 2, resizeWidth: 1000 });
+    await page.evaluate(() => {
+      const tableWrapper =
+        document.querySelector<HTMLElement>('.pm-table-wrapper');
+      if (tableWrapper) {
+        tableWrapper.scrollLeft += 1000;
+      }
+      return tableWrapper;
+    });
+
+    expect(await checkShadows(page, 'left')).toBeTruthy();
+  },
+);

package/src/__tests__/integration/horizontal-scroll.ts

@@ -55,10 +55,9 @@ const assertTableDoesScroll = async (page: WebdriverPage) => {
   expect(tableScrollWidth).toBeGreaterThan(tableOffsetWidth);
 };
 
-// insertColumn helper doesn't work in Safari
 BrowserTestCase(
   'Table: Does not scroll when column is resized and a new column is inserted',
-  { skip: ['safari'] },
+  { skip: [] },
   async (client: any, testName: string) => {
     for (const screenWidth of screenWidths) {
       const page = await goToEditorTestingWDExample(
@@ -84,7 +83,6 @@ BrowserTestCase(
   },
 );
 
-// insertColumn helper doesn't work in Safari
 BrowserTestCase(
   'Table: Does not scroll when column is resized and breakout button is clicked 3x',
   { skip: ['safari'] },
@@ -281,10 +279,9 @@ BrowserTestCase(
   },
 );
 
-// insertColumn helper doesn't work in Safari
 BrowserTestCase(
   'Table: Scrolls when there are more columns added than can fit the current width',
-  { skip: ['safari'] },
+  { skip: [] },
   async (client: any, testName: string) => {
     for (const screenWidth of screenWidths) {
       const page = await goToEditorTestingWDExample(
@@ -315,10 +312,9 @@ BrowserTestCase(
   },
 );
 
-// insertColumn helper doesn't work in Safari
 BrowserTestCase(
   'Table: Does not scroll when nested in Bodied Macro, column is resized and breakout button is clicked',
-  { skip: ['safari'] },
+  { skip: [] },
   async (client: any, testName: string) => {
     for (const screenWidth of screenWidths) {
       const page = await goToEditorTestingWDExample(
@@ -451,10 +447,9 @@ BrowserTestCase(
   },
 );
 
-// insertColumn helper doesn't work in Safari
 BrowserTestCase(
   'Table: Does not scroll when nested in full-width layout, columns is resized and new column is inserted',
-  { skip: ['safari'] },
+  { skip: [] },
   async (client: any, testName: string) => {
     for (const screenWidth of screenWidths) {
       const page = await goToEditorTestingWDExample(