@atlaskit/editor-plugin-table 0.0.5 → 0.0.7

package/src/plugins/table/nodeviews/tableCell.tsx

@@ -11,6 +11,9 @@ import {
 } from '@atlaskit/adf-schema';
 import type { GetEditorFeatureFlags } from '@atlaskit/editor-common/types';
 
+const DEFAULT_COL_SPAN = 1;
+const DEFAULT_ROW_SPAN = 1;
+
 export default class TableCellNodeView implements NodeView {
   node: Node;
   dom: HTMLElement;
@@ -62,11 +65,9 @@ export default class TableCellNodeView implements NodeView {
 
     // need to rerender when colspan/rowspan in dom are different from the node attrs
     // this can happen when undoing merge cells
-    const defaultColspan = 1,
-      defaultRowspan = 1;
     if (
-      colspan !== (node.attrs.colspan || defaultColspan) ||
-      rowspan !== (node.attrs.rowspan || defaultRowspan)
+      colspan !== (node.attrs.colspan || DEFAULT_COL_SPAN) ||
+      rowspan !== (node.attrs.rowspan || DEFAULT_ROW_SPAN)
     ) {
       return false;
     }

package/src/plugins/table/pm-plugins/table-resizing/utils/column-state.ts

@@ -62,7 +62,7 @@ export const getCellsRefsInColumn = (
   return cells;
 };
 
-// calculates column withs based on `cells` DOM refs
+// calculates column widths based on `cells` DOM refs
 export const calculateColumnWidth = (
   cells: HTMLElement[],
   calculateColumnWidthCb: (

package/src/plugins/table/pm-plugins/table-resizing/utils/resize-logic.ts

@@ -8,8 +8,8 @@ export const growColumn = (
   amount: number,
   selectedColumns?: number[],
 ): ResizeState => {
-  // can't grow the last column
-  if (!state.cols[colIndex + 1]) {
+  // can't grow if columns don't exist or it's the last column
+  if (!state.cols[colIndex] || !state.cols[colIndex + 1]) {
     return state;
   }
   const res = moveSpaceFrom(state, colIndex + 1, colIndex, amount);
@@ -32,6 +32,10 @@ export const shrinkColumn = (
   amount: number,
   selectedColumns?: number[],
 ): ResizeState => {
+  // can't shrink if columns don't exist
+  if (!state.cols[colIndex] || !state.cols[colIndex + 1]) {
+    return state;
+  }
   // try to shrink dragging column by giving from the column to the right first
   const res = moveSpaceFrom(state, colIndex, colIndex + 1, -amount);
   let newState = res.state;

package/src/plugins/table/utils/column-controls.ts

@@ -144,7 +144,7 @@ const getRelativeDomCellWidths = ({
   // for cells in a table with unchanged column widths,
   // these are identified by the lack of colwidth data attribute,
   // return equally partitioned total cell width in DOM for each cell.
-  if (colspan <= 1 || !colwidth) {
+  if (colspan === 1 || !colwidth) {
     return new Array(colspan).fill(width / colspan);
   }
 

package/tmp/api-report-tmp.d.ts

@@ -0,0 +1,91 @@
+## API Report File for "@atlaskit/editor-plugin-table"
+
+> Do not edit this file. It is a report generated by [API Extractor](https://api-extractor.com/).
+
+```ts
+
+import type { EditorAnalyticsAPI } from '@atlaskit/editor-common/analytics';
+import type { EditorPlugin } from '@atlaskit/editor-common/types';
+import type { EditorSelectionAPI } from '@atlaskit/editor-common/selection';
+import type { GetEditorFeatureFlags } from '@atlaskit/editor-common/types';
+import { TableLayout } from '@atlaskit/adf-schema';
+
+// @public (undocumented)
+type PermittedLayoutsDescriptor = 'all' | TableLayout[];
+
+// @public (undocumented)
+interface PluginConfig {
+    // (undocumented)
+    advanced?: boolean;
+    // (undocumented)
+    allowAddColumnWithCustomStep?: boolean;
+    // (undocumented)
+    allowBackgroundColor?: boolean;
+    // (undocumented)
+    allowCellOptionsInFloatingToolbar?: boolean;
+    // (undocumented)
+    allowCollapse?: boolean;
+    // (undocumented)
+    allowColumnResizing?: boolean;
+    // (undocumented)
+    allowColumnSorting?: boolean;
+    // (undocumented)
+    allowControls?: boolean;
+    // (undocumented)
+    allowDistributeColumns?: boolean;
+    // (undocumented)
+    allowHeaderColumn?: boolean;
+    // (undocumented)
+    allowHeaderRow?: boolean;
+    // (undocumented)
+    allowMergeCells?: boolean;
+    // (undocumented)
+    allowNumberColumn?: boolean;
+    // (undocumented)
+    initialRenderOptimization?: boolean;
+    // (undocumented)
+    isHeaderRowRequired?: boolean;
+    // (undocumented)
+    mouseMoveOptimization?: boolean;
+    // (undocumented)
+    permittedLayouts?: PermittedLayoutsDescriptor;
+    // (undocumented)
+    stickToolbarToBottom?: boolean;
+    // (undocumented)
+    stickyHeaders?: boolean;
+    // (undocumented)
+    stickyHeadersOptimization?: boolean;
+    // (undocumented)
+    tableCellOptimization?: boolean;
+    // (undocumented)
+    tableOverflowShadowsOptimization?: boolean;
+    // (undocumented)
+    tableRenderOptimization?: boolean;
+}
+
+// @public (undocumented)
+interface TablePluginOptions {
+    // (undocumented)
+    allowContextualMenu?: boolean;
+    // (undocumented)
+    breakoutEnabled?: boolean;
+    // (undocumented)
+    editorAnalyticsAPI?: EditorAnalyticsAPI;
+    // (undocumented)
+    editorSelectionAPI?: EditorSelectionAPI;
+    // (undocumented)
+    fullWidthEnabled?: boolean;
+    // (undocumented)
+    getEditorFeatureFlags?: GetEditorFeatureFlags;
+    // (undocumented)
+    tableOptions: PluginConfig;
+    // (undocumented)
+    wasFullWidthEnabled?: boolean;
+}
+
+// @public (undocumented)
+export const tablesPlugin: (options?: TablePluginOptions | undefined) => EditorPlugin;
+
+// (No @packageDocumentation comment for this package)
+
+```