@atlaskit/editor-plugin-table 0.0.10 → 0.1.1

package/src/{plugins/table/__tests__ → __tests__}/integration/__fixtures__/resize-documents.ts

@@ -212,8 +212,7 @@ export const twoColFullWidthTableWithContent = {
                     },
                     {
                       type: 'text',
-                      text:
-                        '2. Paste a jira link in for the href and immediately close the bracket to complete the markdown',
+                      text: '2. Paste a jira link in for the href and immediately close the bracket to complete the markdown',
                     },
                   ],
                 },
@@ -229,8 +228,7 @@ export const twoColFullWidthTableWithContent = {
                     },
                     {
                       type: 'text',
-                      text:
-                        'markdown for URL works correctly? or smartcard overrides it?',
+                      text: 'markdown for URL works correctly? or smartcard overrides it?',
                     },
                   ],
                 },
@@ -246,8 +244,7 @@ export const twoColFullWidthTableWithContent = {
                     },
                     {
                       type: 'text',
-                      text:
-                        'Smartcard link for Jira is still being processed and is entered as the value for the markdown for the URL ',
+                      text: 'Smartcard link for Jira is still being processed and is entered as the value for the markdown for the URL ',
                     },
                     {
                       type: 'emoji',
@@ -262,8 +259,7 @@ export const twoColFullWidthTableWithContent = {
                     },
                     {
                       type: 'text',
-                      text:
-                        'URL ends up pointing to the confluence edit link but without a page ID so 404s',
+                      text: 'URL ends up pointing to the confluence edit link but without a page ID so 404s',
                     },
                   ],
                 },
@@ -302,8 +298,7 @@ export const twoColFullWidthTableWithContent = {
                   content: [
                     {
                       type: 'text',
-                      text:
-                        "Publishing somewhat big pages doesn't really provide any indication to the user that their page is actually being published and they're going to be navigated away",
+                      text: "Publishing somewhat big pages doesn't really provide any indication to the user that their page is actually being published and they're going to be navigated away",
                     },
                   ],
                 },

package/src/{plugins/table/__tests__ → __tests__}/integration/block-node-selection.ts

@@ -1,3 +1,4 @@
+export {};
 it.todo('TODO: ED-15801 - Fix smart link async rendering integration test');
 // import { runBlockNodeSelectionTestSuite } from '@atlaskit/editor-test-helpers/integration/selection';
 //

package/src/{plugins/table/__tests__ → __tests__}/integration/copy-button.ts

@@ -1,6 +1,6 @@
 //import { runBlockNodeSelectionTestSuite } from '@atlaskit/editor-test-helpers/integration/selection';
 // import { _getCopyButtonTestSuite } from '@atlaskit/editor-core/src/plugins/copy-button/__tests__/integration/_getCopyButtonTestSuite';
-
+export {};
 test.todo('TODO: ED-15706 We disabled the copy button');
 // _getCopyButtonTestSuite({
 //   nodeName: 'Table',

package/src/{plugins/table/__tests__ → __tests__}/integration/delete-columns.ts

@@ -7,12 +7,12 @@ import {
   fullpage,
 } from '@atlaskit/editor-test-helpers/integration/helpers';
 import { documentWithMergedCells } from './__fixtures__/merged-rows-and-cols-document';
-import { TableCssClassName as ClassName } from '@atlaskit/editor-core/src/plugins/table/types';
+import { TableCssClassName as ClassName } from '../../plugins/table/types';
 import {
   goToEditorTestingWDExample,
   mountEditor,
 } from '@atlaskit/editor-test-helpers/testing-example-page';
-import messages from '@atlaskit/editor-core/src/plugins/table/ui/messages';
+import messages from '../../plugins/table/ui/messages';
 
 BrowserTestCase(
   'Should delete merged columns from contextual menu and append missing cells to the table',

package/src/{plugins/table/__tests__ → __tests__}/integration/delete-last-column-in-full-width.ts

@@ -6,7 +6,7 @@ import {
   fullpage,
   quickInsert,
 } from '@atlaskit/editor-test-helpers/integration/helpers';
-import { TableCssClassName as ClassName } from '@atlaskit/editor-core/src/plugins/table/types';
+import { TableCssClassName as ClassName } from '../../plugins/table/types';
 import {
   goToEditorTestingWDExample,
   mountEditor,

package/src/{plugins/table/__tests__ → __tests__}/integration/delete-last-column-with-empty-action.ts

@@ -6,7 +6,7 @@ import {
   fullpage,
   quickInsert,
 } from '@atlaskit/editor-test-helpers/integration/helpers';
-import { TableCssClassName as ClassName } from '@atlaskit/editor-core/src/plugins/table/types';
+import { TableCssClassName as ClassName } from '../../plugins/table/types';
 import {
   goToEditorTestingWDExample,
   mountEditor,

package/src/{plugins/table/__tests__ → __tests__}/integration/delete-last-row-with-empty-action.ts

@@ -6,7 +6,7 @@ import {
   fullpage,
   quickInsert,
 } from '@atlaskit/editor-test-helpers/integration/helpers';
-import { TableCssClassName as ClassName } from '@atlaskit/editor-core/src/plugins/table/types';
+import { TableCssClassName as ClassName } from '../../plugins/table/types';
 import {
   goToEditorTestingWDExample,
   mountEditor,

package/src/{plugins/table/__tests__ → __tests__}/integration/delete-rows.ts

@@ -8,12 +8,12 @@ import {
 } from '@atlaskit/editor-test-helpers/integration/helpers';
 import { documentWithMergedCells } from './__fixtures__/merged-rows-and-cols-document';
 import { nestedInExtension } from './__fixtures__/nested-in-extension';
-import { TableCssClassName as ClassName } from '@atlaskit/editor-core/src/plugins/table/types';
+import { TableCssClassName as ClassName } from '../../plugins/table/types';
 import {
   goToEditorTestingWDExample,
   mountEditor,
 } from '@atlaskit/editor-test-helpers/testing-example-page';
-import messages from '@atlaskit/editor-core/src/plugins/table/ui/messages';
+import messages from '../../plugins/table/ui/messages';
 import { deleteRow } from '@atlaskit/editor-test-helpers/page-objects/table';
 
 BrowserTestCase(

package/src/{plugins/table/__tests__ → __tests__}/integration/insert-long-smart-link.ts

@@ -1,3 +1,4 @@
+export {};
 it.todo('TODO: ED-15801 - Fix smart link async rendering integration test');
 // import { BrowserTestCase } from '@atlaskit/webdriver-runner/runner';
 // import { copyToClipboard } from '@atlaskit/editor-test-helpers/integration/helpers';

package/src/{plugins/table/__tests__ → __tests__}/integration/resize.ts

@@ -27,7 +27,7 @@ import {
   tableForBulkResizeWithNumberCol,
 } from './__fixtures__/resize-documents';
 import { tableWithMinWidthColumnsDocument } from './__fixtures__/table-with-min-width-columns-document';
-import { pluginKey as tableResizingPluginKey } from '@atlaskit/editor-core/src/plugins/table/pm-plugins/table-resizing';
+import { pluginKey as tableResizingPluginKey } from '../../plugins/table/pm-plugins/table-resizing';
 
 import {
   goToEditorTestingWDExample,
@@ -185,8 +185,7 @@ BrowserTestCase(
     featureFlags: {},
   },
   {
-    test:
-      'Should stack columns to the right and go to overflow with overflowShadowsOptimisation',
+    test: 'Should stack columns to the right and go to overflow with overflowShadowsOptimisation',
     featureFlags: {
       tableOverflowShadowsOptimization: true,
     },

package/src/__tests__/integration/table-controls-selection.ts

@@ -0,0 +1,71 @@
+export {};
+test.todo('TODO [ED-15027]; restore unit');
+
+// //TODO: [ED-15027] remove and relocate this test once the behaviour has been corrected.\
+// import { BrowserTestCase } from '@atlaskit/webdriver-runner/runner';
+// import { BrowserObject } from '@atlaskit/webdriver-runner/wd-wrapper';
+// import {
+//   goToEditorTestingWDExample,
+//   mountEditor,
+// } from '../../../../__tests__/__helpers/testing-example-helpers';
+
+// import {
+//   fullpage,
+//   expectToMatchSelection,
+//   setProseMirrorTextSelection,
+// } from '../../../../__tests__/integration/_helpers';
+// import { WebDriverPage } from '../../../../__tests__/__helpers/page-objects/_types';
+// import adf from './__fixtures__/table-with-multiline-date.adf.json';
+
+// describe('table with multiline date', () => {
+//   const initEditor = async ({
+//     client,
+//     selection,
+//     adf,
+//   }: {
+//     client: BrowserObject;
+//     selection: { anchor: number; head: number };
+//     adf: string;
+//   }): Promise<WebDriverPage> => {
+//     const page = await goToEditorTestingWDExample(client);
+//     const props = {
+//       appearance: fullpage.appearance,
+//       defaultValue: adf,
+//       allowTextAlignment: true,
+//       allowTables: {
+//         advanced: true,
+//         allowColumnResizing: true,
+//       },
+//       allowDate: true,
+//     };
+
+//     await mountEditor(page, props, undefined, { clickInEditor: false });
+
+//     await page.waitForSelector('.inlineNodeView');
+
+//     await setProseMirrorTextSelection(page, selection);
+
+//     return page;
+//   };
+//   BrowserTestCase(
+//     'Does not select table corner controls when navigating up from a multiline node inside a table',
+//     {
+//       skip: ['firefox', 'safari'],
+//     },
+//     async (client: BrowserObject) => {
+//       const page = await initEditor({
+//         client,
+//         selection: { anchor: 27, head: 27 },
+//         adf,
+//       });
+
+//       await page.keys('ArrowUp');
+
+//       await expectToMatchSelection(page, {
+//         type: 'text',
+//         anchor: 27,
+//         head: 27,
+//       });
+//     },
+//   );
+// });

package/src/__tests__/unit/analytics.ts

@@ -1,5 +1,9 @@
 import { Rect } from '@atlaskit/editor-tables/table-map';
-import { createEditorFactory } from '@atlaskit/editor-test-helpers/create-editor';
+import {
+  createProsemirrorEditorFactory,
+  LightEditorPlugin,
+  Preset,
+} from '@atlaskit/editor-test-helpers/create-prosemirror-editor';
 import {
   doc,
   p,
@@ -14,7 +18,7 @@ import {
 import sendKeyToPm from '@atlaskit/editor-test-helpers/send-key-to-pm';
 import { B50 } from '@atlaskit/theme/colors';
 
-import { TablePluginState, PluginConfig } from '../../plugins/table/types';
+import { PluginConfig } from '../../plugins/table/types';
 import {
   deleteTableWithAnalytics,
   emptyMultipleCellsWithAnalytics,
@@ -37,11 +41,15 @@ import { pluginKey } from '../../plugins/table/pm-plugins/plugin-key';
 import { replaceSelectedTable } from '../../plugins/table/transforms';
 import type { EditorAnalyticsAPI } from '@atlaskit/editor-common/analytics';
 import tablePlugin from '../../plugins/table-plugin';
-
-const defaultTable = table()(
-  tr(thEmpty, thEmpty, thEmpty),
-  tr(tdEmpty, tdEmpty, tdEmpty),
-  tr(tdEmpty, tdEmpty, tdCursor),
+import typeAheadPlugin from '@atlaskit/editor-core/src/plugins/type-ahead';
+import quickInsertPlugin from '@atlaskit/editor-core/src/plugins/quick-insert';
+
+const defaultTableDoc = doc(
+  table()(
+    tr(thEmpty, thEmpty, thEmpty),
+    tr(tdEmpty, tdEmpty, tdEmpty),
+    tr(tdEmpty, tdEmpty, tdCursor),
+  ),
 );
 
 const secondRow: Rect = { left: 0, top: 1, bottom: 2, right: 3 };
@@ -57,7 +65,7 @@ describe('Table analytic events', () => {
     };
   });
 
-  const createEditor = createEditorFactory<TablePluginState>();
+  const createEditor = createProsemirrorEditorFactory();
 
   const editor = (doc: DocBuilder) => {
     const tableOptions = {
@@ -69,20 +77,13 @@ describe('Table analytic events', () => {
 
     const _editor = createEditor({
       doc,
-      editorProps: {
-        allowTables: false,
-        allowAnalyticsGASV3: true,
-        appearance: 'full-page',
-        quickInsert: true,
-        dangerouslyAppendPlugins: {
-          __plugins: [
-            tablePlugin({
-              tableOptions,
-              editorAnalyticsAPI: editorAnalyticsAPIFake,
-            }),
-          ],
-        },
-      },
+      preset: new Preset<LightEditorPlugin>()
+        .add(typeAheadPlugin)
+        .add(quickInsertPlugin)
+        .add([
+          tablePlugin,
+          { tableOptions, editorAnalyticsAPI: editorAnalyticsAPIFake },
+        ]),
       pluginKey,
     });
 
@@ -108,7 +109,7 @@ describe('Table analytic events', () => {
 
   describe('table deleted', () => {
     beforeEach(() => {
-      const { editorView } = editor(doc(defaultTable));
+      const { editorView } = editor(defaultTableDoc);
       deleteTableWithAnalytics(editorAnalyticsAPIFake)(
         editorView.state,
         editorView.dispatch,
@@ -239,9 +240,8 @@ describe('Table analytic events', () => {
       );
 
       mergeCellsWithAnalytics(editorAnalyticsAPIFake)(
-        editorView.state,
-        editorView.dispatch,
-      );
+        INPUT_METHOD.CONTEXT_MENU,
+      )(editorView.state, editorView.dispatch);
     });
 
     it('should fire v3 analytics', () => {
@@ -273,7 +273,7 @@ describe('Table analytic events', () => {
         ),
       );
 
-      splitCellWithAnalytics(editorAnalyticsAPIFake)(
+      splitCellWithAnalytics(editorAnalyticsAPIFake)(INPUT_METHOD.CONTEXT_MENU)(
         editorView.state,
         editorView.dispatch,
       );
@@ -308,11 +308,11 @@ describe('Table analytic events', () => {
         ),
       );
 
-      // eslint-disable-next-line @atlaskit/design-system/ensure-design-token-usage
-      setColorWithAnalytics(editorAnalyticsAPIFake)(B50)(
-        editorView.state,
-        editorView.dispatch,
-      );
+      setColorWithAnalytics(editorAnalyticsAPIFake)(
+        INPUT_METHOD.CONTEXT_MENU,
+        // eslint-disable-next-line @atlaskit/design-system/ensure-design-token-usage
+        B50,
+      )(editorView.state, editorView.dispatch);
     });
 
     it('should fire v3 analytics', () => {
@@ -335,7 +335,7 @@ describe('Table analytic events', () => {
 
   describe('header row toggled', () => {
     beforeEach(() => {
-      const { editorView } = editor(defaultTable);
+      const { editorView } = editor(defaultTableDoc);
       toggleHeaderRowWithAnalytics(editorAnalyticsAPIFake)(
         editorView.state,
         editorView.dispatch,
@@ -359,7 +359,7 @@ describe('Table analytic events', () => {
 
   describe('header column toggled', () => {
     beforeEach(() => {
-      const { editorView } = editor(defaultTable);
+      const { editorView } = editor(defaultTableDoc);
       toggleHeaderColumnWithAnalytics(editorAnalyticsAPIFake)(
         editorView.state,
         editorView.dispatch,
@@ -383,7 +383,7 @@ describe('Table analytic events', () => {
 
   describe('number column toggled', () => {
     beforeEach(() => {
-      const { editorView } = editor(defaultTable);
+      const { editorView } = editor(defaultTableDoc);
       toggleNumberColumnWithAnalytics(editorAnalyticsAPIFake)(
         editorView.state,
         editorView.dispatch,
@@ -408,7 +408,7 @@ describe('Table analytic events', () => {
   describe('layout changed', () => {
     describe('normal', () => {
       it('should fire v3 analytics', () => {
-        const { editorView } = editor(defaultTable);
+        const { editorView } = editor(defaultTableDoc);
         toggleTableLayoutWithAnalytics(editorAnalyticsAPIFake)(
           editorView.state,
           editorView.dispatch,
@@ -537,7 +537,7 @@ describe('Table analytic events', () => {
   describe('row added', () => {
     describe('context menu', () => {
       beforeEach(() => {
-        const { editorView } = editor(defaultTable);
+        const { editorView } = editor(defaultTableDoc);
         insertRowWithAnalytics(editorAnalyticsAPIFake)(
           INPUT_METHOD.CONTEXT_MENU,
           {
@@ -566,7 +566,7 @@ describe('Table analytic events', () => {
     describe('keyboard', () => {
       describe('Tab', () => {
         beforeEach(() => {
-          const { editorView } = editor(defaultTable);
+          const { editorView } = editor(defaultTableDoc);
           sendKeyToPm(editorView, 'Tab');
         });
 
@@ -623,7 +623,7 @@ describe('Table analytic events', () => {
       return { width: 500 };
     };
     beforeEach(() => {
-      const { editorView } = editor(defaultTable);
+      const { editorView } = editor(defaultTableDoc);
       insertColumnWithAnalytics(
         getEditorContainerWidth,
         editorAnalyticsAPIFake,
@@ -652,7 +652,7 @@ describe('Table analytic events', () => {
 
   describe('row deleted', () => {
     beforeEach(() => {
-      const { editorView } = editor(defaultTable);
+      const { editorView } = editor(defaultTableDoc);
       deleteRowsWithAnalytics(editorAnalyticsAPIFake)(
         INPUT_METHOD.CONTEXT_MENU,
         secondRow,
@@ -679,7 +679,7 @@ describe('Table analytic events', () => {
 
   describe('column deleted', () => {
     beforeEach(() => {
-      const { editorView } = editor(defaultTable);
+      const { editorView } = editor(defaultTableDoc);
       deleteColumnsWithAnalytics(editorAnalyticsAPIFake)(
         INPUT_METHOD.CONTEXT_MENU,
         secondColumn,

package/src/__tests__/unit/collab.ts

@@ -8,16 +8,22 @@ import {
   DocBuilder,
 } from '@atlaskit/editor-test-helpers/doc-builder';
 import { removeColumnAt } from '@atlaskit/editor-tables/utils';
-import { TablePluginState, PluginConfig } from '../../plugins/table/types';
+import { PluginConfig } from '../../plugins/table/types';
 
 import { setResizeHandlePos } from '../../plugins/table/pm-plugins/table-resizing/commands';
 import { pluginKey as tablePluginKey } from '../../plugins/table/pm-plugins/plugin-key';
-import { createEditorFactory } from '@atlaskit/editor-test-helpers/create-editor';
+import {
+  createProsemirrorEditorFactory,
+  LightEditorPlugin,
+  Preset,
+} from '@atlaskit/editor-test-helpers/create-prosemirror-editor';
 import tablePlugin from '../../plugins/table-plugin';
+import widthPlugin from '@atlaskit/editor-core/src/plugins/width';
+
 const TABLE_LOCAL_ID = 'test-table-local-id';
 
 describe('Tables with Collab editing', () => {
-  const createEditor = createEditorFactory<TablePluginState>();
+  const createEditor = createProsemirrorEditorFactory();
   const tableOptions = {
     allowNumberColumn: true,
     allowHeaderRow: true,
@@ -29,12 +35,9 @@ describe('Tables with Collab editing', () => {
   const editor = (doc: DocBuilder) => {
     return createEditor({
       doc,
-      editorProps: {
-        allowTables: false,
-        dangerouslyAppendPlugins: {
-          __plugins: [tablePlugin({ tableOptions })],
-        },
-      },
+      preset: new Preset<LightEditorPlugin>()
+        .add([tablePlugin, { tableOptions }])
+        .add(widthPlugin),
       pluginKey: tablePluginKey,
     });
   };

package/src/{plugins/table/__tests__ → __tests__}/unit/commands/go-to-next-cell.ts

@@ -16,10 +16,10 @@ import {
   DocBuilder,
 } from '@atlaskit/editor-test-helpers/doc-builder';
 import type { EditorAnalyticsAPI } from '@atlaskit/editor-common/analytics';
-import tablePlugin from '../../../index';
-import { pluginKey } from '../../../pm-plugins/plugin-key';
-import { TablePluginState } from '../../../types';
-import { goToNextCell } from '../../../commands/go-to-next-cell';
+import tablePlugin from '../../../plugins/table/index';
+import { pluginKey } from '../../../plugins/table/pm-plugins/plugin-key';
+import { TablePluginState } from '../../../plugins/table/types';
+import { goToNextCell } from '../../../plugins/table/commands/go-to-next-cell';
 
 const TABLE_LOCAL_ID = 'test-table-local-id';
 

package/src/{plugins/table/__tests__ → __tests__}/unit/commands/insert.ts

@@ -16,10 +16,10 @@ import {
 } from '@atlaskit/editor-test-helpers/doc-builder';
 import type { GetEditorContainerWidth } from '@atlaskit/editor-common/types';
 
-import tablePlugin from '../../../index';
-import { pluginKey } from '../../../pm-plugins/plugin-key';
-import { TablePluginState } from '../../../types';
-import { addColumnAt } from '../../../commands/insert';
+import tablePlugin from '../../../plugins/table/index';
+import { pluginKey } from '../../../plugins/table/pm-plugins/plugin-key';
+import { TablePluginState } from '../../../plugins/table/types';
+import { addColumnAt } from '../../../plugins/table/commands/insert';
 import widthPlugin from '@atlaskit/editor-core/src/plugins/width';
 
 const TABLE_LOCAL_ID = 'test-table-local-id';

package/src/{plugins/table/__tests__ → __tests__}/unit/commands/misc.ts

@@ -15,12 +15,18 @@ import {
   createProsemirrorEditorFactory,
 } from '@atlaskit/editor-test-helpers/create-prosemirror-editor';
 import panelPlugin from '@atlaskit/editor-core/src/plugins/panel';
-import { selectColumn, moveCursorBackward } from '../../../commands';
-import { getDecorations } from '../../../pm-plugins/decorations/plugin';
-import { getPluginState } from '../../../pm-plugins/plugin-factory';
-import { pluginKey } from '../../../pm-plugins/plugin-key';
-import { TableDecorations, TablePluginState } from '../../../types';
-import tablePlugin from '../../../';
+import {
+  selectColumn,
+  moveCursorBackward,
+} from '../../../plugins/table/commands';
+import { getDecorations } from '../../../plugins/table/pm-plugins/decorations/plugin';
+import { getPluginState } from '../../../plugins/table/pm-plugins/plugin-factory';
+import { pluginKey } from '../../../plugins/table/pm-plugins/plugin-key';
+import {
+  TableDecorations,
+  TablePluginState,
+} from '../../../plugins/table/types';
+import tablePlugin from '../../../plugins/table';
 
 describe('table plugin: commands', () => {
   const createEditor = createProsemirrorEditorFactory();