@atlaskit/editor-plugin-synced-block 5.3.37 → 5.4.1

package/CHANGELOG.md

@@ -1,5 +1,24 @@
 # @atlaskit/editor-plugin-synced-block
 
+## 5.4.1
+
+### Patch Changes
+
+- [`3b290b31e9ad1`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/3b290b31e9ad1) -
+  Update menu button text for sync blocks
+- Updated dependencies
+
+## 5.4.0
+
+### Minor Changes
+
+- [`e9b20ca59c789`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/e9b20ca59c789) -
+  EDITOR-5666 fix first node bodied synced block selection
+
+### Patch Changes
+
+- Updated dependencies
+
 ## 5.3.37
 
 ### Patch Changes

package/dist/cjs/pm-plugins/main.js

@@ -306,9 +306,20 @@ var createPlugin = exports.createPlugin = function createPlugin(options, pmPlugi
           selectionDecorationSet = currentPluginState.selectionDecorationSet,
           bodiedSyncBlockDeletionStatus = currentPluginState.bodiedSyncBlockDeletionStatus,
           retryCreationPosMap = currentPluginState.retryCreationPosMap;
-        var newDecorationSet = selectionDecorationSet.map(tr.mapping, tr.doc);
+        var newDecorationSet = (0, _platformFeatureFlags.fg)('platform_synced_block_patch_5') ? tr.docChanged ? selectionDecorationSet.map(tr.mapping, tr.doc) // only map if document changed
+        : selectionDecorationSet : selectionDecorationSet.map(tr.mapping, tr.doc);
         if (!tr.selection.eq(oldEditorState.selection)) {
           newDecorationSet = (0, _selectionDecorations.calculateDecorations)(tr.doc, tr.selection, tr.doc.type.schema);
+        } else if (tr.docChanged && (0, _platformFeatureFlags.fg)('platform_synced_block_patch_5')) {
+          var existingDecorationsLength = selectionDecorationSet.find().length;
+          var newDecorationsLength = newDecorationSet.find().length;
+
+          // Edge case: When document nodes are replaced, the mapping can lose decorations
+          // We rebuild decorations when the document changes but the selection hasn't.
+          // We can do this check because we only expect 1 decoration for the selection
+          if (existingDecorationsLength !== newDecorationsLength) {
+            newDecorationSet = (0, _selectionDecorations.calculateDecorations)(tr.doc, tr.selection, tr.doc.type.schema);
+          }
         }
         var newPosEntry = meta === null || meta === void 0 ? void 0 : meta.retryCreationPos;
         var newRetryCreationPosMap = mapRetryCreationPosMap(retryCreationPosMap, newPosEntry, tr.mapping.map.bind(tr.mapping));

package/dist/cjs/ui/CreateSyncedBlockDropdownItem.js

@@ -53,6 +53,11 @@ var CreateSyncedBlockDropdownItem = function CreateSyncedBlockDropdownItem(_ref)
   // Adds size="small" to icons for better visual consistency in block menu.
   // To clean up: remove conditional, keep only size="small" version.
   var iconSize = (0, _platformFeatureFlags.fg)('platform_editor_block_menu_v2_patch_3') ? 'small' : undefined;
+
+  // [FEATURE FLAG: platform_editor_block_menu_v2_patch_3]
+  // Changes wording from "Create synced block" to "Sync block" for conciseness.
+  // To clean up: remove conditional, keep only the syncBlock message.
+  var message = (0, _platformFeatureFlags.fg)('platform_editor_block_menu_v2_patch_3') ? _messages.blockMenuMessages.syncBlock : _messages.blockMenuMessages.createSyncedBlock;
   return /*#__PURE__*/_react.default.createElement(_editorToolbar.ToolbarDropdownItem, {
     elemBefore: /*#__PURE__*/_react.default.createElement(_editorToolbar.SyncBlocksIcon, {
       label: "",
@@ -64,7 +69,7 @@ var CreateSyncedBlockDropdownItem = function CreateSyncedBlockDropdownItem(_ref)
     elemAfter: /*#__PURE__*/_react.default.createElement(_lozenge.default, {
       appearance: "new"
     }, formatMessage(_messages.blockMenuMessages.newLozenge))
-  }, formatMessage(_messages.blockMenuMessages.createSyncedBlock));
+  }, formatMessage(message));
 };
 var CopySyncedBlockDropdownItem = function CopySyncedBlockDropdownItem(_ref2) {
   var api = _ref2.api;

package/dist/es2019/pm-plugins/main.js

@@ -270,9 +270,20 @@ export const createPlugin = (options, pmPluginFactoryParams, syncBlockStore, api
           bodiedSyncBlockDeletionStatus,
           retryCreationPosMap
         } = currentPluginState;
-        let newDecorationSet = selectionDecorationSet.map(tr.mapping, tr.doc);
+        let newDecorationSet = fg('platform_synced_block_patch_5') ? tr.docChanged ? selectionDecorationSet.map(tr.mapping, tr.doc) // only map if document changed
+        : selectionDecorationSet : selectionDecorationSet.map(tr.mapping, tr.doc);
         if (!tr.selection.eq(oldEditorState.selection)) {
           newDecorationSet = calculateDecorations(tr.doc, tr.selection, tr.doc.type.schema);
+        } else if (tr.docChanged && fg('platform_synced_block_patch_5')) {
+          const existingDecorationsLength = selectionDecorationSet.find().length;
+          const newDecorationsLength = newDecorationSet.find().length;
+
+          // Edge case: When document nodes are replaced, the mapping can lose decorations
+          // We rebuild decorations when the document changes but the selection hasn't.
+          // We can do this check because we only expect 1 decoration for the selection
+          if (existingDecorationsLength !== newDecorationsLength) {
+            newDecorationSet = calculateDecorations(tr.doc, tr.selection, tr.doc.type.schema);
+          }
         }
         const newPosEntry = meta === null || meta === void 0 ? void 0 : meta.retryCreationPos;
         const newRetryCreationPosMap = mapRetryCreationPosMap(retryCreationPosMap, newPosEntry, tr.mapping.map.bind(tr.mapping));

package/dist/es2019/ui/CreateSyncedBlockDropdownItem.js

@@ -45,6 +45,11 @@ const CreateSyncedBlockDropdownItem = ({
   // Adds size="small" to icons for better visual consistency in block menu.
   // To clean up: remove conditional, keep only size="small" version.
   const iconSize = fg('platform_editor_block_menu_v2_patch_3') ? 'small' : undefined;
+
+  // [FEATURE FLAG: platform_editor_block_menu_v2_patch_3]
+  // Changes wording from "Create synced block" to "Sync block" for conciseness.
+  // To clean up: remove conditional, keep only the syncBlock message.
+  const message = fg('platform_editor_block_menu_v2_patch_3') ? blockMenuMessages.syncBlock : blockMenuMessages.createSyncedBlock;
   return /*#__PURE__*/React.createElement(ToolbarDropdownItem, {
     elemBefore: /*#__PURE__*/React.createElement(SyncBlocksIcon, {
       label: "",
@@ -56,7 +61,7 @@ const CreateSyncedBlockDropdownItem = ({
     elemAfter: /*#__PURE__*/React.createElement(Lozenge, {
       appearance: "new"
     }, formatMessage(blockMenuMessages.newLozenge))
-  }, formatMessage(blockMenuMessages.createSyncedBlock));
+  }, formatMessage(message));
 };
 const CopySyncedBlockDropdownItem = ({
   api

package/dist/esm/pm-plugins/main.js

@@ -299,9 +299,20 @@ export var createPlugin = function createPlugin(options, pmPluginFactoryParams,
           selectionDecorationSet = currentPluginState.selectionDecorationSet,
           bodiedSyncBlockDeletionStatus = currentPluginState.bodiedSyncBlockDeletionStatus,
           retryCreationPosMap = currentPluginState.retryCreationPosMap;
-        var newDecorationSet = selectionDecorationSet.map(tr.mapping, tr.doc);
+        var newDecorationSet = fg('platform_synced_block_patch_5') ? tr.docChanged ? selectionDecorationSet.map(tr.mapping, tr.doc) // only map if document changed
+        : selectionDecorationSet : selectionDecorationSet.map(tr.mapping, tr.doc);
         if (!tr.selection.eq(oldEditorState.selection)) {
           newDecorationSet = calculateDecorations(tr.doc, tr.selection, tr.doc.type.schema);
+        } else if (tr.docChanged && fg('platform_synced_block_patch_5')) {
+          var existingDecorationsLength = selectionDecorationSet.find().length;
+          var newDecorationsLength = newDecorationSet.find().length;
+
+          // Edge case: When document nodes are replaced, the mapping can lose decorations
+          // We rebuild decorations when the document changes but the selection hasn't.
+          // We can do this check because we only expect 1 decoration for the selection
+          if (existingDecorationsLength !== newDecorationsLength) {
+            newDecorationSet = calculateDecorations(tr.doc, tr.selection, tr.doc.type.schema);
+          }
         }
         var newPosEntry = meta === null || meta === void 0 ? void 0 : meta.retryCreationPos;
         var newRetryCreationPosMap = mapRetryCreationPosMap(retryCreationPosMap, newPosEntry, tr.mapping.map.bind(tr.mapping));

package/dist/esm/ui/CreateSyncedBlockDropdownItem.js

@@ -44,6 +44,11 @@ var CreateSyncedBlockDropdownItem = function CreateSyncedBlockDropdownItem(_ref)
   // Adds size="small" to icons for better visual consistency in block menu.
   // To clean up: remove conditional, keep only size="small" version.
   var iconSize = fg('platform_editor_block_menu_v2_patch_3') ? 'small' : undefined;
+
+  // [FEATURE FLAG: platform_editor_block_menu_v2_patch_3]
+  // Changes wording from "Create synced block" to "Sync block" for conciseness.
+  // To clean up: remove conditional, keep only the syncBlock message.
+  var message = fg('platform_editor_block_menu_v2_patch_3') ? blockMenuMessages.syncBlock : blockMenuMessages.createSyncedBlock;
   return /*#__PURE__*/React.createElement(ToolbarDropdownItem, {
     elemBefore: /*#__PURE__*/React.createElement(SyncBlocksIcon, {
       label: "",
@@ -55,7 +60,7 @@ var CreateSyncedBlockDropdownItem = function CreateSyncedBlockDropdownItem(_ref)
     elemAfter: /*#__PURE__*/React.createElement(Lozenge, {
       appearance: "new"
     }, formatMessage(blockMenuMessages.newLozenge))
-  }, formatMessage(blockMenuMessages.createSyncedBlock));
+  }, formatMessage(message));
 };
 var CopySyncedBlockDropdownItem = function CopySyncedBlockDropdownItem(_ref2) {
   var api = _ref2.api;

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-plugin-synced-block",
-	"version": "5.3.37",
+	"version": "5.4.1",
 	"description": "SyncedBlock plugin for @atlaskit/editor-core",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",
@@ -61,7 +61,7 @@
 		"react-intl-next": "npm:react-intl@^5.18.1"
 	},
 	"peerDependencies": {
-		"@atlaskit/editor-common": "^111.21.0",
+		"@atlaskit/editor-common": "^111.23.0",
 		"react": "^18.2.0"
 	},
 	"devDependencies": {