@atlaskit/editor-plugin-synced-block 5.3.18 → 5.3.20

package/CHANGELOG.md

@@ -1,5 +1,19 @@
 # @atlaskit/editor-plugin-synced-block
 
+## 5.3.20
+
+### Patch Changes
+
+- [`fa62876ed1943`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/fa62876ed1943) -
+  EDITOR-5134 Clean up platform_synced_block_patch_1
+- Updated dependencies
+
+## 5.3.19
+
+### Patch Changes
+
+- Updated dependencies
+
 ## 5.3.18
 
 ### Patch Changes

package/dist/cjs/editor-commands/index.js

@@ -10,7 +10,6 @@ var _copyButton = require("@atlaskit/editor-common/copy-button");
 var _model = require("@atlaskit/editor-prosemirror/model");
 var _state = require("@atlaskit/editor-prosemirror/state");
 var _utils = require("@atlaskit/editor-prosemirror/utils");
-var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _main = require("../pm-plugins/main");
 var _utils2 = require("../pm-plugins/utils/utils");
 var _types = require("../types");
@@ -41,12 +40,6 @@ var createSyncedBlock = exports.createSyncedBlock = function createSyncedBlock(_
       });
       return false;
     }
-
-    // Save the new node with empty content to backend
-    // This is so that the node can be copied and referenced without the source being saved/published
-    if (!(0, _platformFeatureFlags.fg)('platform_synced_block_patch_1')) {
-      syncBlockStore.sourceManager.createBodiedSyncBlockNode(attrs, function () {});
-    }
     if (typeAheadInsert) {
       tr = typeAheadInsert(newBodiedSyncBlockNode);
     } else {
@@ -80,13 +73,6 @@ var createSyncedBlock = exports.createSyncedBlock = function createSyncedBlock(_
       });
       return false;
     }
-
-    // Save the new node with empty content to backend
-    // This is so that the node can be copied and referenced without the source being saved/published
-    if (!(0, _platformFeatureFlags.fg)('platform_synced_block_patch_1')) {
-      // Moved to appendTransaction
-      syncBlockStore.sourceManager.createBodiedSyncBlockNode(_attrs, function () {}, _newBodiedSyncBlockNode);
-    }
     tr.replaceWith(conversionInfo.from, conversionInfo.to, _newBodiedSyncBlockNode).scrollIntoView();
 
     // set selection to the start of the previous selection for the position taken up by the start of the new synced block
@@ -111,19 +97,17 @@ var copySyncedBlockReferenceToClipboard = exports.copySyncedBlockReferenceToClip
 var copySyncedBlockReferenceToClipboardInternal = function copySyncedBlockReferenceToClipboardInternal(schema, selection, syncBlockStore, inputMethod, api) {
   var syncBlockFindResult = (0, _utils2.findSyncBlockOrBodiedSyncBlock)(schema, selection);
   if (!syncBlockFindResult) {
-    if ((0, _platformFeatureFlags.fg)('platform_synced_block_patch_1')) {
-      var _api$analytics;
-      api === null || api === void 0 || (_api$analytics = api.analytics) === null || _api$analytics === void 0 || (_api$analytics = _api$analytics.actions) === null || _api$analytics === void 0 || _api$analytics.fireAnalyticsEvent({
-        eventType: _analytics.EVENT_TYPE.OPERATIONAL,
-        action: _analytics.ACTION.ERROR,
-        actionSubject: _analytics.ACTION_SUBJECT.SYNCED_BLOCK,
-        actionSubjectId: _analytics.ACTION_SUBJECT_ID.SYNCED_BLOCK_COPY,
-        attributes: {
-          error: 'No sync block found in selection',
-          inputMethod: inputMethod
-        }
-      });
-    }
+    var _api$analytics;
+    api === null || api === void 0 || (_api$analytics = api.analytics) === null || _api$analytics === void 0 || (_api$analytics = _api$analytics.actions) === null || _api$analytics === void 0 || _api$analytics.fireAnalyticsEvent({
+      eventType: _analytics.EVENT_TYPE.OPERATIONAL,
+      action: _analytics.ACTION.ERROR,
+      actionSubject: _analytics.ACTION_SUBJECT.SYNCED_BLOCK,
+      actionSubjectId: _analytics.ACTION_SUBJECT_ID.SYNCED_BLOCK_COPY,
+      attributes: {
+        error: 'No sync block found in selection',
+        inputMethod: inputMethod
+      }
+    });
     return false;
   }
   var isBodiedSyncBlock = (0, _utils2.isBodiedSyncBlockNode)(syncBlockFindResult.node, schema.nodes.bodiedSyncBlock);
@@ -136,39 +120,35 @@ var copySyncedBlockReferenceToClipboardInternal = function copySyncedBlockRefere
       resourceId: syncBlockStore.referenceManager.generateResourceIdForReference(syncBlockFindResult.node.attrs.resourceId)
     });
     if (!referenceSyncBlockNode) {
-      if ((0, _platformFeatureFlags.fg)('platform_synced_block_patch_1')) {
-        var _api$analytics2;
-        api === null || api === void 0 || (_api$analytics2 = api.analytics) === null || _api$analytics2 === void 0 || (_api$analytics2 = _api$analytics2.actions) === null || _api$analytics2 === void 0 || _api$analytics2.fireAnalyticsEvent({
-          eventType: _analytics.EVENT_TYPE.OPERATIONAL,
-          action: _analytics.ACTION.ERROR,
-          actionSubject: _analytics.ACTION_SUBJECT.SYNCED_BLOCK,
-          actionSubjectId: _analytics.ACTION_SUBJECT_ID.SYNCED_BLOCK_COPY,
-          attributes: {
-            error: 'Failed to create reference sync block node',
-            resourceId: syncBlockFindResult.node.attrs.resourceId,
-            inputMethod: inputMethod
-          }
-        });
-      }
-      return false;
-    }
-  } else {
-    referenceSyncBlockNode = syncBlockFindResult.node;
-  }
-  if (!referenceSyncBlockNode) {
-    if ((0, _platformFeatureFlags.fg)('platform_synced_block_patch_1')) {
-      var _api$analytics3;
-      api === null || api === void 0 || (_api$analytics3 = api.analytics) === null || _api$analytics3 === void 0 || (_api$analytics3 = _api$analytics3.actions) === null || _api$analytics3 === void 0 || _api$analytics3.fireAnalyticsEvent({
+      var _api$analytics2;
+      api === null || api === void 0 || (_api$analytics2 = api.analytics) === null || _api$analytics2 === void 0 || (_api$analytics2 = _api$analytics2.actions) === null || _api$analytics2 === void 0 || _api$analytics2.fireAnalyticsEvent({
         eventType: _analytics.EVENT_TYPE.OPERATIONAL,
         action: _analytics.ACTION.ERROR,
         actionSubject: _analytics.ACTION_SUBJECT.SYNCED_BLOCK,
         actionSubjectId: _analytics.ACTION_SUBJECT_ID.SYNCED_BLOCK_COPY,
         attributes: {
-          error: 'No reference sync block node available',
+          error: 'Failed to create reference sync block node',
+          resourceId: syncBlockFindResult.node.attrs.resourceId,
           inputMethod: inputMethod
         }
       });
+      return false;
     }
+  } else {
+    referenceSyncBlockNode = syncBlockFindResult.node;
+  }
+  if (!referenceSyncBlockNode) {
+    var _api$analytics3;
+    api === null || api === void 0 || (_api$analytics3 = api.analytics) === null || _api$analytics3 === void 0 || (_api$analytics3 = _api$analytics3.actions) === null || _api$analytics3 === void 0 || _api$analytics3.fireAnalyticsEvent({
+      eventType: _analytics.EVENT_TYPE.OPERATIONAL,
+      action: _analytics.ACTION.ERROR,
+      actionSubject: _analytics.ACTION_SUBJECT.SYNCED_BLOCK,
+      actionSubjectId: _analytics.ACTION_SUBJECT_ID.SYNCED_BLOCK_COPY,
+      attributes: {
+        error: 'No reference sync block node available',
+        inputMethod: inputMethod
+      }
+    });
     return false;
   }
   var domNode = (0, _copyButton.toDOM)(referenceSyncBlockNode, schema);
@@ -177,20 +157,18 @@ var copySyncedBlockReferenceToClipboardInternal = function copySyncedBlockRefere
   // Use setTimeout to dispatch transaction in next tick and avoid re-entrant dispatch
   setTimeout(function () {
     api === null || api === void 0 || api.core.actions.execute(function (_ref3) {
+      var _api$analytics4;
       var tr = _ref3.tr;
-      if ((0, _platformFeatureFlags.fg)('platform_synced_block_patch_1')) {
-        var _api$analytics4;
-        api === null || api === void 0 || (_api$analytics4 = api.analytics) === null || _api$analytics4 === void 0 || (_api$analytics4 = _api$analytics4.actions) === null || _api$analytics4 === void 0 || _api$analytics4.fireAnalyticsEvent({
-          eventType: _analytics.EVENT_TYPE.OPERATIONAL,
-          action: _analytics.ACTION.COPIED,
-          actionSubject: _analytics.ACTION_SUBJECT.SYNCED_BLOCK,
-          actionSubjectId: _analytics.ACTION_SUBJECT_ID.SYNCED_BLOCK_COPY,
-          attributes: {
-            resourceId: referenceSyncBlockNode.attrs.resourceId,
-            inputMethod: inputMethod
-          }
-        });
-      }
+      api === null || api === void 0 || (_api$analytics4 = api.analytics) === null || _api$analytics4 === void 0 || (_api$analytics4 = _api$analytics4.actions) === null || _api$analytics4 === void 0 || _api$analytics4.fireAnalyticsEvent({
+        eventType: _analytics.EVENT_TYPE.OPERATIONAL,
+        action: _analytics.ACTION.COPIED,
+        actionSubject: _analytics.ACTION_SUBJECT.SYNCED_BLOCK,
+        actionSubjectId: _analytics.ACTION_SUBJECT_ID.SYNCED_BLOCK_COPY,
+        attributes: {
+          resourceId: referenceSyncBlockNode.attrs.resourceId,
+          inputMethod: inputMethod
+        }
+      });
       return tr.setMeta(_main.syncedBlockPluginKey, {
         activeFlag: {
           id: _types.FLAG_ID.SYNC_BLOCK_COPIED
@@ -210,18 +188,16 @@ var editSyncedBlockSource = exports.editSyncedBlockSource = function editSyncedB
     }
     var syncBlockURL = syncBlockStore.referenceManager.getSyncBlockURL(resourceId);
     if (syncBlockURL) {
-      if ((0, _platformFeatureFlags.fg)('platform_synced_block_patch_1')) {
-        var _api$analytics5;
-        api === null || api === void 0 || (_api$analytics5 = api.analytics) === null || _api$analytics5 === void 0 || _api$analytics5.actions.fireAnalyticsEvent({
-          eventType: _analytics.EVENT_TYPE.OPERATIONAL,
-          action: _analytics.ACTION.SYNCED_BLOCK_EDIT_SOURCE,
-          actionSubject: _analytics.ACTION_SUBJECT.SYNCED_BLOCK,
-          actionSubjectId: _analytics.ACTION_SUBJECT_ID.SYNCED_BLOCK_SOURCE_URL,
-          attributes: {
-            resourceId: resourceId
-          }
-        });
-      }
+      var _api$analytics5;
+      api === null || api === void 0 || (_api$analytics5 = api.analytics) === null || _api$analytics5 === void 0 || _api$analytics5.actions.fireAnalyticsEvent({
+        eventType: _analytics.EVENT_TYPE.OPERATIONAL,
+        action: _analytics.ACTION.SYNCED_BLOCK_EDIT_SOURCE,
+        actionSubject: _analytics.ACTION_SUBJECT.SYNCED_BLOCK,
+        actionSubjectId: _analytics.ACTION_SUBJECT_ID.SYNCED_BLOCK_SOURCE_URL,
+        attributes: {
+          resourceId: resourceId
+        }
+      });
       window.open(syncBlockURL, '_blank');
     } else {
       var _api$analytics6;

package/dist/cjs/pm-plugins/main.js

@@ -16,7 +16,6 @@ var _editorPluginConnectivity = require("@atlaskit/editor-plugin-connectivity");
 var _state = require("@atlaskit/editor-prosemirror/state");
 var _view = require("@atlaskit/editor-prosemirror/view");
 var _editorSyncedBlockProvider = require("@atlaskit/editor-synced-block-provider");
-var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _bodiedLazySyncedBlock = require("../nodeviews/bodiedLazySyncedBlock");
 var _syncedBlock = require("../nodeviews/syncedBlock");
 var _types = require("../types");
@@ -141,11 +140,8 @@ var createPlugin = exports.createPlugin = function createPlugin(options, pmPlugi
         if (!tr.selection.eq(oldEditorState.selection)) {
           newDecorationSet = (0, _selectionDecorations.calculateDecorations)(tr.doc, tr.selection, tr.doc.type.schema);
         }
-        var newRetryCreationPosMap = retryCreationPosMap;
-        if ((0, _platformFeatureFlags.fg)('platform_synced_block_patch_1')) {
-          var newPosEntry = meta === null || meta === void 0 ? void 0 : meta.retryCreationPos;
-          newRetryCreationPosMap = mapRetryCreationPosMap(retryCreationPosMap, newPosEntry, tr.mapping.map.bind(tr.mapping));
-        }
+        var newPosEntry = meta === null || meta === void 0 ? void 0 : meta.retryCreationPos;
+        var newRetryCreationPosMap = mapRetryCreationPosMap(retryCreationPosMap, newPosEntry, tr.mapping.map.bind(tr.mapping));
         return {
           activeFlag: (_meta$activeFlag = meta === null || meta === void 0 ? void 0 : meta.activeFlag) !== null && _meta$activeFlag !== void 0 ? _meta$activeFlag : activeFlag,
           selectionDecorationSet: newDecorationSet,
@@ -201,7 +197,7 @@ var createPlugin = exports.createPlugin = function createPlugin(options, pmPlugi
               class: _syncBlock.SyncBlockStateCssClassName.viewModeClassName
             }));
           }
-          if (node.type.name === 'bodiedSyncBlock' && syncBlockStore.sourceManager.isPendingCreation(node.attrs.resourceId) && (0, _platformFeatureFlags.fg)('platform_synced_block_patch_1')) {
+          if (node.type.name === 'bodiedSyncBlock' && syncBlockStore.sourceManager.isPendingCreation(node.attrs.resourceId)) {
             loadingDecorations.push(_view.Decoration.node(pos, pos + node.nodeSize, {
               class: _syncBlock.SyncBlockStateCssClassName.creationLoadingClassName
             }));
@@ -268,12 +264,6 @@ var createPlugin = exports.createPlugin = function createPlugin(options, pmPlugi
       var _api$connectivity2;
       var isOffline = (0, _editorPluginConnectivity.isOfflineMode)(api === null || api === void 0 || (_api$connectivity2 = api.connectivity) === null || _api$connectivity2 === void 0 || (_api$connectivity2 = _api$connectivity2.sharedState.currentState()) === null || _api$connectivity2 === void 0 ? void 0 : _api$connectivity2.mode);
       var isConfirmedSyncBlockDeletion = Boolean(tr.getMeta('isConfirmedSyncBlockDeletion'));
-      var hasNoPendingRequest = (0, _platformFeatureFlags.fg)('platform_synced_block_patch_1') ? false :
-      // requireConfirmationBeforeDelete is always true, so this evaluates to false and hence redundant
-      !(syncBlockStore !== null && syncBlockStore !== void 0 && syncBlockStore.sourceManager.requireConfirmationBeforeDelete()) && !syncBlockStore.sourceManager.hasPendingCreation();
-      var isCommitsCreation = (0, _platformFeatureFlags.fg)('platform_synced_block_patch_1') ? false :
-      // For patch 1, we don't intercept the insert transaction, hence it's redundant
-      Boolean(tr.getMeta('isCommitSyncBlockCreation'));
 
       // Track newly added reference sync blocks before processing the transaction
       if (tr.docChanged && !tr.getMeta('isRemote')) {
@@ -294,7 +284,7 @@ var createPlugin = exports.createPlugin = function createPlugin(options, pmPlugi
       // or are from remote (collab) or already confirmed sync block deletion
       // We only care about local changes that change the document
       // and are not yet confirmed for sync block deletion
-      if (!tr.docChanged || hasNoPendingRequest || Boolean(tr.getMeta('isRemote')) || isCommitsCreation || !isOffline && isConfirmedSyncBlockDeletion) {
+      if (!tr.docChanged || Boolean(tr.getMeta('isRemote')) || !isOffline && isConfirmedSyncBlockDeletion) {
         return true;
       }
       var _trackSyncBlocks2 = (0, _trackSyncBlocks6.trackSyncBlocks)(syncBlockStore.sourceManager.isSourceBlock, tr, state),
@@ -343,22 +333,8 @@ var createPlugin = exports.createPlugin = function createPlugin(options, pmPlugi
             // After true is returned here and the node is created, we delete the node in the filterTransaction immediately, which cancels out the creation
             return true;
           }
-          if ((0, _platformFeatureFlags.fg)('platform_synced_block_patch_1')) {
-            (0, _handleBodiedSyncBlockCreation.handleBodiedSyncBlockCreation)(bodiedSyncBlockAdded, state, api);
-            return true;
-          } else {
-            // If there is bodiedSyncBlock node addition and it's waiting for the result of saving the node to backend (syncBlockStore.hasPendingCreation()),
-            // we need to intercept the transaction and save it in insert callback so that we only insert it to the document when backend call if backend call is successful
-            // The callback will be evoked by in SourceSyncBlockStoreManager.commitPendingCreation
-            syncBlockStore.sourceManager.registerCreationCallback(function () {
-              var _api$core;
-              api === null || api === void 0 || (_api$core = api.core) === null || _api$core === void 0 || _api$core.actions.execute(function () {
-                return tr.setMeta('isCommitSyncBlockCreation', true);
-              });
-              api === null || api === void 0 || api.core.actions.focus();
-            });
-            return false;
-          }
+          (0, _handleBodiedSyncBlockCreation.handleBodiedSyncBlockCreation)(bodiedSyncBlockAdded, state, api);
+          return true;
         }
       } else {
         var _trackSyncBlocks4 = (0, _trackSyncBlocks6.trackSyncBlocks)(function (node) {

package/dist/cjs/pm-plugins/menu-and-toolbar-experiences.js

@@ -11,7 +11,6 @@ var _analytics = require("@atlaskit/editor-common/analytics");
 var _experiences = require("@atlaskit/editor-common/experiences");
 var _safePlugin = require("@atlaskit/editor-common/safe-plugin");
 var _state = require("@atlaskit/editor-prosemirror/state");
-var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _types = require("../types");
 var TIMEOUT_DURATION = 30000;
 var pluginKey = new _state.PluginKey('syncedBlockMenuAndToolbarExperience');
@@ -61,44 +60,38 @@ var getMenuAndToolbarExperiencesPlugin = exports.getMenuAndToolbarExperiencesPlu
       durationMs: TIMEOUT_DURATION
     }), referenceSyncBlockRemovedFromDomCheck(refs)]
   });
-  var unsyncReferenceSyncedBlockExperience;
-  var unsyncSourceSyncedBlockExperience;
-  var deleteSourceSyncedBlockExperience;
-  var syncedLocationsExperience;
-  if ((0, _platformFeatureFlags.fg)('platform_synced_block_patch_1')) {
-    unsyncReferenceSyncedBlockExperience = new _experiences.Experience(_experiences.EXPERIENCE_ID.TOOLBAR_ACTION, {
-      action: _analytics.ACTION.REFERENCE_SYNCED_BLOCK_UNSYNC,
-      actionSubjectId: _analytics.ACTION_SUBJECT_ID.SYNCED_BLOCK_TOOLBAR,
-      dispatchAnalyticsEvent: dispatchAnalyticsEvent,
-      checks: [new _experiences.ExperienceCheckTimeout({
-        durationMs: TIMEOUT_DURATION
-      }), referenceSyncBlockRemovedFromDomCheck(refs)]
-    });
-    unsyncSourceSyncedBlockExperience = new _experiences.Experience(_experiences.EXPERIENCE_ID.TOOLBAR_ACTION, {
-      action: _analytics.ACTION.SYNCED_BLOCK_UNSYNC,
-      actionSubjectId: _analytics.ACTION_SUBJECT_ID.SYNCED_BLOCK_TOOLBAR,
-      dispatchAnalyticsEvent: dispatchAnalyticsEvent,
-      checks: [new _experiences.ExperienceCheckTimeout({
-        durationMs: TIMEOUT_DURATION
-      }), syncBlockDeleteConfirmationModalAddedCheck(refs)]
-    });
-    deleteSourceSyncedBlockExperience = new _experiences.Experience(_experiences.EXPERIENCE_ID.TOOLBAR_ACTION, {
-      action: _analytics.ACTION.SYNCED_BLOCK_DELETE,
-      actionSubjectId: _analytics.ACTION_SUBJECT_ID.SYNCED_BLOCK_TOOLBAR,
-      dispatchAnalyticsEvent: dispatchAnalyticsEvent,
-      checks: [new _experiences.ExperienceCheckTimeout({
-        durationMs: TIMEOUT_DURATION
-      }), syncBlockDeleteConfirmationModalAddedCheck(refs)]
-    });
-    syncedLocationsExperience = new _experiences.Experience(_experiences.EXPERIENCE_ID.TOOLBAR_ACTION, {
-      action: _analytics.ACTION.SYNCED_BLOCK_VIEW_SYNCED_LOCATIONS,
-      actionSubjectId: _analytics.ACTION_SUBJECT_ID.SYNCED_BLOCK_TOOLBAR,
-      dispatchAnalyticsEvent: dispatchAnalyticsEvent,
-      checks: [new _experiences.ExperienceCheckTimeout({
-        durationMs: TIMEOUT_DURATION
-      }), syncedLocationsDropdownOpenedCheck(refs)]
-    });
-  }
+  var unsyncReferenceSyncedBlockExperience = new _experiences.Experience(_experiences.EXPERIENCE_ID.TOOLBAR_ACTION, {
+    action: _analytics.ACTION.REFERENCE_SYNCED_BLOCK_UNSYNC,
+    actionSubjectId: _analytics.ACTION_SUBJECT_ID.SYNCED_BLOCK_TOOLBAR,
+    dispatchAnalyticsEvent: dispatchAnalyticsEvent,
+    checks: [new _experiences.ExperienceCheckTimeout({
+      durationMs: TIMEOUT_DURATION
+    }), referenceSyncBlockRemovedFromDomCheck(refs)]
+  });
+  var unsyncSourceSyncedBlockExperience = new _experiences.Experience(_experiences.EXPERIENCE_ID.TOOLBAR_ACTION, {
+    action: _analytics.ACTION.SYNCED_BLOCK_UNSYNC,
+    actionSubjectId: _analytics.ACTION_SUBJECT_ID.SYNCED_BLOCK_TOOLBAR,
+    dispatchAnalyticsEvent: dispatchAnalyticsEvent,
+    checks: [new _experiences.ExperienceCheckTimeout({
+      durationMs: TIMEOUT_DURATION
+    }), syncBlockDeleteConfirmationModalAddedCheck(refs)]
+  });
+  var deleteSourceSyncedBlockExperience = new _experiences.Experience(_experiences.EXPERIENCE_ID.TOOLBAR_ACTION, {
+    action: _analytics.ACTION.SYNCED_BLOCK_DELETE,
+    actionSubjectId: _analytics.ACTION_SUBJECT_ID.SYNCED_BLOCK_TOOLBAR,
+    dispatchAnalyticsEvent: dispatchAnalyticsEvent,
+    checks: [new _experiences.ExperienceCheckTimeout({
+      durationMs: TIMEOUT_DURATION
+    }), syncBlockDeleteConfirmationModalAddedCheck(refs)]
+  });
+  var syncedLocationsExperience = new _experiences.Experience(_experiences.EXPERIENCE_ID.TOOLBAR_ACTION, {
+    action: _analytics.ACTION.SYNCED_BLOCK_VIEW_SYNCED_LOCATIONS,
+    actionSubjectId: _analytics.ACTION_SUBJECT_ID.SYNCED_BLOCK_TOOLBAR,
+    dispatchAnalyticsEvent: dispatchAnalyticsEvent,
+    checks: [new _experiences.ExperienceCheckTimeout({
+      durationMs: TIMEOUT_DURATION
+    }), syncedLocationsDropdownOpenedCheck(refs)]
+  });
   var unbindClickListener = (0, _bindEventListener.bind)(document, {
     type: 'click',
     listener: function listener(event) {
@@ -162,7 +155,6 @@ var getMenuAndToolbarExperiencesPlugin = exports.getMenuAndToolbarExperiencesPlu
       editorViewEl = editorView.dom;
       return {
         destroy: function destroy() {
-          var _deleteSourceSyncedBl, _unsyncReferenceSynce, _unsyncSourceSyncedBl, _syncedLocationsExper;
           createSourcePrimaryToolbarExperience.abort({
             reason: 'editorDestroyed'
           });
@@ -175,16 +167,16 @@ var getMenuAndToolbarExperiencesPlugin = exports.getMenuAndToolbarExperiencesPlu
           deleteReferenceSyncedBlockExperience.abort({
             reason: 'editorDestroyed'
           });
-          (_deleteSourceSyncedBl = deleteSourceSyncedBlockExperience) === null || _deleteSourceSyncedBl === void 0 || _deleteSourceSyncedBl.abort({
+          deleteSourceSyncedBlockExperience === null || deleteSourceSyncedBlockExperience === void 0 || deleteSourceSyncedBlockExperience.abort({
             reason: 'editorDestroyed'
           });
-          (_unsyncReferenceSynce = unsyncReferenceSyncedBlockExperience) === null || _unsyncReferenceSynce === void 0 || _unsyncReferenceSynce.abort({
+          unsyncReferenceSyncedBlockExperience === null || unsyncReferenceSyncedBlockExperience === void 0 || unsyncReferenceSyncedBlockExperience.abort({
             reason: 'editorDestroyed'
           });
-          (_unsyncSourceSyncedBl = unsyncSourceSyncedBlockExperience) === null || _unsyncSourceSyncedBl === void 0 || _unsyncSourceSyncedBl.abort({
+          unsyncSourceSyncedBlockExperience === null || unsyncSourceSyncedBlockExperience === void 0 || unsyncSourceSyncedBlockExperience.abort({
             reason: 'editorDestroyed'
           });
-          (_syncedLocationsExper = syncedLocationsExperience) === null || _syncedLocationsExper === void 0 || _syncedLocationsExper.abort({
+          syncedLocationsExperience === null || syncedLocationsExperience === void 0 || syncedLocationsExperience.abort({
             reason: 'editorDestroyed'
           });
           unbindClickListener();

package/dist/cjs/ui/SyncedLocationDropdown.js

@@ -29,7 +29,6 @@ var _quotationMark = _interopRequireDefault(require("@atlaskit/icon/core/quotati
 var _statusError = _interopRequireDefault(require("@atlaskit/icon/core/status-error"));
 var _logo = require("@atlaskit/logo");
 var _lozenge = _interopRequireDefault(require("@atlaskit/lozenge"));
-var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _compiled = require("@atlaskit/primitives/compiled");
 var _spinner = _interopRequireDefault(require("@atlaskit/spinner"));
 var _tooltip = _interopRequireDefault(require("@atlaskit/tooltip"));
@@ -184,14 +183,14 @@ var SyncedLocationDropdown = exports.SyncedLocationDropdown = function SyncedLoc
       var isOpen = _ref5.isOpen;
       return setIsOpen(isOpen);
     },
-    testId: (0, _platformFeatureFlags.fg)('platform_synced_block_patch_1') ? 'synced-block-synced-locations-dropdown' : undefined,
+    testId: "synced-block-synced-locations-dropdown",
     trigger: function trigger(_ref6) {
       var triggerRef = _ref6.triggerRef,
         triggerProps = (0, _objectWithoutProperties2.default)(_ref6, _excluded);
       return /*#__PURE__*/React.createElement(_ui.FloatingToolbarButton, (0, _extends2.default)({
         ref: triggerRef,
         areAnyNewToolbarFlagsEnabled: true,
-        selected: (0, _platformFeatureFlags.fg)('platform_synced_block_patch_1') ? isOpen : undefined,
+        selected: isOpen,
         iconAfter: /*#__PURE__*/React.createElement(_chevronDown.default, {
           color: "currentColor",
           spacing: "spacious",
@@ -260,18 +259,16 @@ var DropdownContent = function DropdownContent(_ref7) {
     getReferenceData();
   }, [syncBlockStore, intl, isSource, localId, resourceId]);
   var handleLocationClick = function handleLocationClick() {
-    if ((0, _platformFeatureFlags.fg)('platform_synced_block_patch_1')) {
-      var _api$analytics;
-      api === null || api === void 0 || (_api$analytics = api.analytics) === null || _api$analytics === void 0 || (_api$analytics = _api$analytics.actions) === null || _api$analytics === void 0 || _api$analytics.fireAnalyticsEvent({
-        eventType: _analytics.EVENT_TYPE.OPERATIONAL,
-        action: _analytics.ACTION.CLICKED,
-        actionSubject: _analytics.ACTION_SUBJECT.SYNCED_BLOCK,
-        actionSubjectId: _analytics.ACTION_SUBJECT_ID.SYNCED_BLOCK_CLICK_SYNCED_LOCATION,
-        attributes: {
-          resourceId: resourceId
-        }
-      });
-    }
+    var _api$analytics;
+    api === null || api === void 0 || (_api$analytics = api.analytics) === null || _api$analytics === void 0 || (_api$analytics = _api$analytics.actions) === null || _api$analytics === void 0 || _api$analytics.fireAnalyticsEvent({
+      eventType: _analytics.EVENT_TYPE.OPERATIONAL,
+      action: _analytics.ACTION.CLICKED,
+      actionSubject: _analytics.ACTION_SUBJECT.SYNCED_BLOCK,
+      actionSubjectId: _analytics.ACTION_SUBJECT_ID.SYNCED_BLOCK_CLICK_SYNCED_LOCATION,
+      attributes: {
+        resourceId: resourceId
+      }
+    });
   };
   var content = function content() {
     switch (fetchStatus) {
@@ -333,7 +330,7 @@ var ErrorScreen = function ErrorScreen(_ref9) {
   var formatMessage = _ref9.formatMessage;
   return /*#__PURE__*/React.createElement(_compiled.Box, {
     xcss: styles.errorContainer,
-    testId: (0, _platformFeatureFlags.fg)('platform_synced_block_patch_1') ? 'synced-locations-dropdown-content-error' : undefined
+    testId: "synced-locations-dropdown-content-error"
   }, /*#__PURE__*/React.createElement(_compiled.Box, {
     xcss: styles.errorIcon
   }, /*#__PURE__*/React.createElement(_statusError.default, {
@@ -351,7 +348,7 @@ var NoResultScreen = function NoResultScreen(_ref0) {
   return /*#__PURE__*/React.createElement(_compiled.Stack, {
     xcss: styles.noResultsContainer,
     space: "space.100",
-    testId: (0, _platformFeatureFlags.fg)('platform_synced_block_patch_1') ? 'synced-locations-dropdown-content-no-results' : undefined
+    testId: "synced-locations-dropdown-content-no-results"
   }, /*#__PURE__*/React.createElement(_compiled.Text, {
     as: "p"
   }, formatMessage(_messages.syncBlockMessages.syncedLocationDropdownNoResults)), /*#__PURE__*/React.createElement(_compiled.Text, {

package/dist/cjs/ui/floating-toolbar.js

@@ -18,7 +18,6 @@ var _copy = _interopRequireDefault(require("@atlaskit/icon/core/copy"));
 var _delete = _interopRequireDefault(require("@atlaskit/icon/core/delete"));
 var _edit = _interopRequireDefault(require("@atlaskit/icon/core/edit"));
 var _linkBroken = _interopRequireDefault(require("@atlaskit/icon/core/link-broken"));
-var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _editorCommands = require("../editor-commands");
 var _utils2 = require("../pm-plugins/utils/utils");
 var _types = require("../types");
@@ -32,7 +31,7 @@ var getToolbarConfig = exports.getToolbarConfig = function getToolbarConfig(stat
   if (!syncBlockObject) {
     return;
   }
-  if (syncBlockStore.sourceManager.isPendingCreation(syncBlockObject.node.attrs.resourceId) && (0, _platformFeatureFlags.fg)('platform_synced_block_patch_1')) {
+  if (syncBlockStore.sourceManager.isPendingCreation(syncBlockObject.node.attrs.resourceId)) {
     return;
   }
   var syncBlockInstance = syncBlockStore.referenceManager.getFromCache(syncBlockObject.node.attrs.resourceId);
@@ -93,7 +92,7 @@ var getToolbarConfig = exports.getToolbarConfig = function getToolbarConfig(stat
             onClick: function onClick() {
               return (0, _editorCommands.unsync)(syncBlockStore, isBodiedSyncBlock, view);
             },
-            testId: (0, _platformFeatureFlags.fg)('platform_synced_block_patch_1') ? isBodiedSyncBlock ? _types.SYNCED_BLOCK_BUTTON_TEST_ID.syncedBlockToolbarSourceUnsync : _types.SYNCED_BLOCK_BUTTON_TEST_ID.syncedBlockToolbarReferenceUnsync : undefined
+            testId: isBodiedSyncBlock ? _types.SYNCED_BLOCK_BUTTON_TEST_ID.syncedBlockToolbarSourceUnsync : _types.SYNCED_BLOCK_BUTTON_TEST_ID.syncedBlockToolbarReferenceUnsync
           });
         }
       };
@@ -138,7 +137,7 @@ var getToolbarConfig = exports.getToolbarConfig = function getToolbarConfig(stat
         icon: /*#__PURE__*/_react.default.createElement(_delete.default, {
           label: ""
         }),
-        testId: (0, _platformFeatureFlags.fg)('platform_synced_block_patch_1') ? isBodiedSyncBlock ? _types.SYNCED_BLOCK_BUTTON_TEST_ID.syncedBlockToolbarSourceDelete : _types.SYNCED_BLOCK_BUTTON_TEST_ID.syncedBlockToolbarReferenceDelete : undefined
+        testId: isBodiedSyncBlock ? _types.SYNCED_BLOCK_BUTTON_TEST_ID.syncedBlockToolbarSourceDelete : _types.SYNCED_BLOCK_BUTTON_TEST_ID.syncedBlockToolbarReferenceDelete
       }, hoverDecorationProps(nodeType))]
     }];
     items.push.apply(items, overflowMenuConfig);