@atlaskit/editor-plugin-status 12.0.15 → 12.0.17

package/CHANGELOG.md

@@ -1,5 +1,23 @@
 # @atlaskit/editor-plugin-status
 
+## 12.0.17
+
+### Patch Changes
+
+- [`0f79b5238fada`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/0f79b5238fada) -
+  Cleaned up stale feature gate \_editor_a11y_aria_label_removal_popup (FFCLEANUP-90178). Removed
+  gate checks and always use the enabled path: nullish coalescing for popup ariaLabel, localized
+  labels for color picker and status picker popups. Replaced obsolete `[aria-label="Popup"]`
+  selectors with `[data-testid="popup-wrapper"]` in dependent tests and page-models. Guarded the
+  search-common ESLint test helper so it loads correctly outside Jest.
+- Updated dependencies
+
+## 12.0.16
+
+### Patch Changes
+
+- Updated dependencies
+
 ## 12.0.15
 
 ### Patch Changes

package/actions/package.json

@@ -6,12 +6,5 @@
   "sideEffects": [
     "*.compiled.css"
   ],
-  "types": "../dist/types/entry-points/actions.d.ts",
-  "typesVersions": {
-    ">=4.5 <5.9": {
-      "*": [
-        "../dist/types-ts4.5/entry-points/actions.d.ts"
-      ]
-    }
-  }
+  "types": "../dist/types/entry-points/actions.d.ts"
 }

package/dist/cjs/ui/statusPicker.js

@@ -342,7 +342,7 @@ var StatusPickerWithIntl = /*#__PURE__*/function (_React$Component) {
         return null;
       }
       return target && (0, _react2.jsx)(PopupWithListeners, {
-        ariaLabel: (0, _platformFeatureFlags.fg)('_editor_a11y_aria_label_removal_popup') ? intl.formatMessage(_messages.statusMessages.statusEditorLabel) : undefined,
+        ariaLabel: intl.formatMessage(_messages.statusMessages.statusEditorLabel),
         target: target
         // eslint-disable-next-line @atlassian/perf-linting/no-unstable-inline-props -- Ignored via go/ees017 (to be fixed)
         ,

package/dist/es2019/ui/statusPicker.js

@@ -316,7 +316,7 @@ class StatusPickerWithIntl extends React.Component {
       return null;
     }
     return target && jsx(PopupWithListeners, {
-      ariaLabel: fg('_editor_a11y_aria_label_removal_popup') ? intl.formatMessage(messages.statusEditorLabel) : undefined,
+      ariaLabel: intl.formatMessage(messages.statusEditorLabel),
       target: target
       // eslint-disable-next-line @atlassian/perf-linting/no-unstable-inline-props -- Ignored via go/ees017 (to be fixed)
       ,

package/dist/esm/ui/statusPicker.js

@@ -339,7 +339,7 @@ var StatusPickerWithIntl = /*#__PURE__*/function (_React$Component) {
         return null;
       }
       return target && jsx(PopupWithListeners, {
-        ariaLabel: fg('_editor_a11y_aria_label_removal_popup') ? intl.formatMessage(messages.statusEditorLabel) : undefined,
+        ariaLabel: intl.formatMessage(messages.statusEditorLabel),
         target: target
         // eslint-disable-next-line @atlassian/perf-linting/no-unstable-inline-props -- Ignored via go/ees017 (to be fixed)
         ,

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-plugin-status",
-	"version": "12.0.15",
+	"version": "12.0.17",
 	"description": "Status plugin for @atlaskit/editor-core",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",
@@ -38,14 +38,14 @@
 		"@atlaskit/icon": "^35.4.0",
 		"@atlaskit/platform-feature-flags": "^1.1.0",
 		"@atlaskit/status": "^4.1.0",
-		"@atlaskit/tmp-editor-statsig": "^102.0.0",
+		"@atlaskit/tmp-editor-statsig": "^103.0.0",
 		"@atlaskit/tokens": "^13.4.0",
 		"@atlaskit/visually-hidden": "^3.1.0",
 		"@babel/runtime": "^7.0.0",
 		"@emotion/react": "^11.7.1"
 	},
 	"peerDependencies": {
-		"@atlaskit/editor-common": "^115.15.0",
+		"@atlaskit/editor-common": "^115.16.0",
 		"react": "^18.2.0",
 		"react-dom": "^18.2.0",
 		"react-intl": "^5.25.1 || ^6.0.0 || ^7.0.0"
@@ -97,9 +97,6 @@
 		"platform-component-visual-refresh": {
 			"type": "boolean"
 		},
-		"_editor_a11y_aria_label_removal_popup": {
-			"type": "boolean"
-		},
 		"platform-lozenge-custom-letterspacing": {
 			"type": "boolean"
 		},

package/status-plugin/package.json

@@ -6,12 +6,5 @@
   "sideEffects": [
     "*.compiled.css"
   ],
-  "types": "../dist/types/entry-points/status-plugin.d.ts",
-  "typesVersions": {
-    ">=4.5 <5.9": {
-      "*": [
-        "../dist/types-ts4.5/entry-points/status-plugin.d.ts"
-      ]
-    }
-  }
+  "types": "../dist/types/entry-points/status-plugin.d.ts"
 }

package/status-plugin-type/package.json

@@ -6,12 +6,5 @@
   "sideEffects": [
     "*.compiled.css"
   ],
-  "types": "../dist/types/entry-points/status-plugin-type.d.ts",
-  "typesVersions": {
-    ">=4.5 <5.9": {
-      "*": [
-        "../dist/types-ts4.5/entry-points/status-plugin-type.d.ts"
-      ]
-    }
-  }
+  "types": "../dist/types/entry-points/status-plugin-type.d.ts"
 }

package/types/package.json

@@ -6,12 +6,5 @@
   "sideEffects": [
     "*.compiled.css"
   ],
-  "types": "../dist/types/entry-points/types.d.ts",
-  "typesVersions": {
-    ">=4.5 <5.9": {
-      "*": [
-        "../dist/types-ts4.5/entry-points/types.d.ts"
-      ]
-    }
-  }
+  "types": "../dist/types/entry-points/types.d.ts"
 }

package/dist/types-ts4.5/entry-points/actions.d.ts

@@ -1 +0,0 @@
-export type { UpdateStatus } from '../pm-plugins/actions';

package/dist/types-ts4.5/entry-points/status-plugin-type.d.ts

@@ -1 +0,0 @@
-export type { StatusPlugin, StatusPluginDependencies, StatusPluginActions, StatusPluginCommands, } from '../statusPluginType';

package/dist/types-ts4.5/entry-points/status-plugin.d.ts

@@ -1 +0,0 @@
-export { statusPlugin } from '../statusPlugin';

package/dist/types-ts4.5/entry-points/types.d.ts

@@ -1 +0,0 @@
-export type { StatusState, StatusType, StatusPluginOptions, ClosingPayload } from '../types/index';

package/dist/types-ts4.5/index.d.ts

@@ -1,4 +0,0 @@
-export { statusPlugin } from './statusPlugin';
-export type { StatusPlugin, StatusPluginDependencies, StatusPluginActions, StatusPluginCommands, } from './statusPluginType';
-export type { StatusState, StatusType, StatusPluginOptions, ClosingPayload } from './types';
-export type { UpdateStatus } from './pm-plugins/actions';

package/dist/types-ts4.5/nodeviews/StatusNodeView.d.ts

@@ -1,28 +0,0 @@
-import type { IntlShape } from 'react-intl';
-import type { Node as PMNode } from '@atlaskit/editor-prosemirror/model';
-import type { NodeView } from '@atlaskit/editor-prosemirror/view';
-/**
- *
- */
-export declare class StatusNodeView implements NodeView {
-    dom: Node;
-    domElement: HTMLElement | undefined;
-    private box;
-    private textContainer;
-    private node;
-    private intl;
-    /**
-     *
-     * @param node
-     * @param intl
-     * @example
-     */
-    constructor(node: PMNode, intl: IntlShape);
-    private setPlaceholder;
-    /**
-     *
-     * @param node
-     * @example
-     */
-    update(node: PMNode): boolean;
-}

package/dist/types-ts4.5/nodeviews/statusNodeSpec.d.ts

@@ -1,2 +0,0 @@
-import type { DOMOutputSpec, Node as PMNode } from '@atlaskit/editor-prosemirror/model';
-export declare const statusToDOM: (node: PMNode) => DOMOutputSpec;

package/dist/types-ts4.5/pm-plugins/actions.d.ts

@@ -1,20 +0,0 @@
-import type { EditorAnalyticsAPI } from '@atlaskit/editor-common/analytics';
-import { INPUT_METHOD } from '@atlaskit/editor-common/analytics';
-import type { Command, CommandDispatch, EditorCommand, TOOLBAR_MENU_TYPE } from '@atlaskit/editor-common/types';
-import { type Mark } from '@atlaskit/editor-prosemirror/model';
-import type { Node } from '@atlaskit/editor-prosemirror/model';
-import type { EditorState, Transaction } from '@atlaskit/editor-prosemirror/state';
-import type { EditorView } from '@atlaskit/editor-prosemirror/view';
-import type { ClosingPayload, StatusType } from '../types';
-export declare const DEFAULT_STATUS: StatusType;
-export declare const DEFAULT_STATUS_NEW: StatusType;
-export declare const verifyAndInsertStatus: (statusNode: Node, tr: Transaction, annotationMarks?: Mark[] | undefined) => Transaction;
-export declare const createStatus: (tr: Transaction) => Transaction;
-export declare const insertStatus: (editorAnalyticsAPI: EditorAnalyticsAPI | undefined) => (inputMethod?: INPUT_METHOD.INSERT_MENU | INPUT_METHOD.QUICK_INSERT | INPUT_METHOD.TOOLBAR) => EditorCommand;
-export declare const updateStatus: (status?: StatusType) => Command;
-export type UpdateStatus = (inputMethod: TOOLBAR_MENU_TYPE, status?: StatusType) => Command;
-export declare const updateStatusWithAnalytics: (editorAnalyticsAPI: EditorAnalyticsAPI | undefined) => (inputMethod: TOOLBAR_MENU_TYPE, status?: StatusType) => Command;
-export declare const setStatusPickerAt: (showStatusPickerAt: number | null) => (state: EditorState, dispatch: (tr: Transaction) => void) => boolean;
-export declare const removeStatus: (showStatusPickerAt: number) => EditorCommand;
-export declare const setFocusOnStatusInput: () => (state: EditorState, dispatch: CommandDispatch | undefined) => boolean;
-export declare const commitStatusPicker: (closingPayload?: ClosingPayload) => (editorView: EditorView) => void;

package/dist/types-ts4.5/pm-plugins/keymap.d.ts

@@ -1,3 +0,0 @@
-import type { SafePlugin } from '@atlaskit/editor-common/safe-plugin';
-export declare function keymapPlugin(): SafePlugin;
-export default keymapPlugin;

package/dist/types-ts4.5/pm-plugins/plugin-key.d.ts

@@ -1,3 +0,0 @@
-import { PluginKey } from '@atlaskit/editor-prosemirror/state';
-import type { StatusState } from '../types';
-export declare const pluginKey: PluginKey<StatusState>;

package/dist/types-ts4.5/pm-plugins/plugin.d.ts

@@ -1,5 +0,0 @@
-import { SafePlugin } from '@atlaskit/editor-common/safe-plugin';
-import type { PMPluginFactoryParams } from '@atlaskit/editor-common/types';
-import type { StatusPluginOptions } from '../types';
-declare const createPlugin: (pmPluginFactoryParams: PMPluginFactoryParams, options?: StatusPluginOptions) => SafePlugin;
-export default createPlugin;

package/dist/types-ts4.5/pm-plugins/utils.d.ts

@@ -1,5 +0,0 @@
-import type { Selection, Transaction } from '@atlaskit/editor-prosemirror/state';
-import type { StatusType } from '../types';
-export declare const mayGetStatusAtSelection: (selection: Selection) => StatusType | null;
-export declare const isEmptyStatus: (node: StatusType) => boolean;
-export declare const setNodeSelectionNearPos: (tr: Transaction, pos: number) => Transaction;

package/dist/types-ts4.5/statusPlugin.d.ts

@@ -1,2 +0,0 @@
-import type { StatusPlugin } from './statusPluginType';
-export declare const statusPlugin: StatusPlugin;

package/dist/types-ts4.5/statusPluginType.d.ts

@@ -1,44 +0,0 @@
-import type { INPUT_METHOD } from '@atlaskit/editor-common/analytics';
-import type { NextEditorPlugin, OptionalPlugin, Command } from '@atlaskit/editor-common/types';
-import type { AnalyticsPlugin } from '@atlaskit/editor-plugin-analytics';
-import type { commitStatusPicker, insertStatus, removeStatus, UpdateStatus } from './pm-plugins/actions';
-import type { StatusPluginOptions, StatusState } from './types';
-type DummyAnnotationPlugin = NextEditorPlugin<'annotation', {
-    actions: {
-        setInlineCommentDraftState: (isDraft: boolean, inputMethod: INPUT_METHOD) => Command;
-    };
-    sharedState: {
-        annotations: Record<string, boolean>;
-        bookmark: boolean;
-        isVisible: boolean;
-        mouseData: {
-            isSelecting: boolean;
-        };
-    };
-}>;
-type DummyEditorViewModePlugin = NextEditorPlugin<'editorViewMode', {
-    sharedState: {
-        mode: 'view' | 'edit';
-    };
-}>;
-export type StatusPluginDependencies = [
-    OptionalPlugin<AnalyticsPlugin>,
-    OptionalPlugin<DummyAnnotationPlugin>,
-    OptionalPlugin<DummyEditorViewModePlugin>
-];
-export type StatusPluginActions = {
-    commitStatusPicker: typeof commitStatusPicker;
-    updateStatus: UpdateStatus;
-};
-export type StatusPluginCommands = {
-    insertStatus: ReturnType<typeof insertStatus>;
-    removeStatus: typeof removeStatus;
-};
-export type StatusPlugin = NextEditorPlugin<'status', {
-    actions: StatusPluginActions;
-    commands: StatusPluginCommands;
-    dependencies: StatusPluginDependencies;
-    pluginConfiguration: StatusPluginOptions | undefined;
-    sharedState: StatusState | undefined;
-}>;
-export {};

package/dist/types-ts4.5/types/index.d.ts

@@ -1,20 +0,0 @@
-import type { Color as ColorType } from '@atlaskit/status/element';
-import type { closingMethods } from '../ui/statusPicker';
-export type StatusType = {
-    color: ColorType;
-    localId?: string;
-    style?: string;
-    text: string;
-};
-export type StatusState = {
-    focusStatusInput?: boolean;
-    isNew: boolean;
-    showStatusPickerAt: number | null;
-};
-export interface StatusPluginOptions {
-    allowZeroWidthSpaceAfter?: boolean;
-    menuDisabled: boolean;
-}
-export type ClosingPayload = {
-    closingMethod: closingMethods;
-};

package/dist/types-ts4.5/ui/ContentComponent.d.ts

@@ -1,15 +0,0 @@
-import React from 'react';
-import type { ExtractInjectionAPI } from '@atlaskit/editor-common/types';
-import type { DomAtPos } from '@atlaskit/editor-prosemirror/utils';
-import type { EditorView } from '@atlaskit/editor-prosemirror/view';
-import type { StatusPlugin } from '../statusPluginType';
-interface ContentComponentProps {
-    api: ExtractInjectionAPI<StatusPlugin> | undefined;
-    domAtPos: DomAtPos;
-    editorView: EditorView;
-    popupsBoundariesElement?: HTMLElement;
-    popupsMountPoint?: HTMLElement;
-    popupsScrollableElement?: HTMLElement;
-}
-export declare function ContentComponent({ api, popupsMountPoint, popupsBoundariesElement, popupsScrollableElement, editorView, domAtPos, }: ContentComponentProps): React.JSX.Element | null;
-export {};

package/dist/types-ts4.5/ui/analytics.d.ts

@@ -1,4 +0,0 @@
-import type { AnalyticsEventPayload, CreateUIAnalyticsEvent } from '@atlaskit/analytics-next';
-export declare const FABRIC_CHANNEL = "fabric-elements";
-export declare const createStatusAnalyticsAndFire: (createAnalyticsEvent?: CreateUIAnalyticsEvent) => (payload: AnalyticsEventPayload) => void;
-export declare const analyticsState: (isNew: boolean | undefined) => "new" | "update";

package/dist/types-ts4.5/ui/statusPicker.d.ts

@@ -1,49 +0,0 @@
-import React from 'react';
-import { type WithIntlProps, type WrappedComponentProps } from 'react-intl';
-import type { CreateUIAnalyticsEvent, WithAnalyticsEventsProps } from '@atlaskit/analytics-next';
-import type { ExtractInjectionAPI } from '@atlaskit/editor-common/types';
-import type { EditorView } from '@atlaskit/editor-prosemirror/view';
-import type { ColorType as Color } from '@atlaskit/status/picker';
-import type { StatusPlugin } from '../statusPluginType';
-import type { ClosingPayload, StatusType } from '../types';
-export declare enum InputMethod {
-    blur = "blur",
-    escKey = "escKey",
-    enterKey = "enterKey"
-}
-export declare enum closingMethods {
-    ArrowLeft = "arrowLeft",
-    ArrowRight = "arrowRight"
-}
-export interface Props {
-    api?: ExtractInjectionAPI<StatusPlugin>;
-    boundariesElement?: HTMLElement;
-    closeStatusPicker: (closingPayload?: ClosingPayload) => void;
-    createAnalyticsEvent?: CreateUIAnalyticsEvent;
-    defaultColor?: Color;
-    defaultLocalId?: string;
-    defaultText?: string;
-    editorView: EditorView;
-    focusStatusInput?: boolean;
-    intl: WrappedComponentProps['intl'];
-    isNew?: boolean;
-    mountTo?: HTMLElement;
-    onEnter: (status: StatusType) => void;
-    onSelect: (status: StatusType) => void;
-    onTextChanged: (status: StatusType, isNew: boolean) => void;
-    scrollableElement?: HTMLElement;
-    target: HTMLElement | null;
-}
-export interface State {
-    color: Color;
-    isNew?: boolean;
-    localId?: string;
-    text: string;
-}
-export declare const StatusPickerWithoutAnalytcs: React.FC<WithIntlProps<Props>> & {
-    WrappedComponent: React.ComponentType<Props>;
-};
-declare const _default_1: React.ForwardRefExoticComponent<Omit<Omit<Props, 'intl'> & {
-    forwardedRef?: React.Ref<any>;
-}, keyof WithAnalyticsEventsProps> & React.RefAttributes<any>>;
-export default _default_1;