@atlaskit/editor-plugin-show-diff 13.1.1 → 13.1.2

package/CHANGELOG.md

@@ -1,5 +1,22 @@
 # @atlaskit/editor-plugin-show-diff
 
+## 13.1.2
+
+### Patch Changes
+
+- [`f8a30b9c66bf8`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/f8a30b9c66bf8) -
+  Replace each hardcoded colour in the show-diff deleted-node selectors with
+  `var(--diff-delete-*, <the same token as before>)`, in both `smartCardStyles.ts` and its inlined
+  duplicate in `EditorContentContainer-compiled.tsx`.
+
+  No visual change: nothing sets these variables yet, so every declaration resolves to its current
+  value. All `-traditional` selectors are retained and opacity is untouched.
+
+  Groundwork for EDITOR-8551, ahead of the gated change that lets a colour scheme drive these
+  selectors.
+
+- Updated dependencies
+
 ## 13.1.1
 
 ### Patch Changes

package/dist/cjs/pm-plugins/decorations/colorSchemes/factory.js

@@ -902,11 +902,17 @@ function buildAtomicInlineChangedCSSVariables(colors) {
   });
 }
 
-/** Deleted node wrapper variables, all three states. Read by the smartCardStyles selectors. */
+/**
+ * Deleted-node wrapper variables, one per visual role in editor-core's `showDiffDeletedNodeStyles`:
+ * resting ring, `-outline-new` ring, `-active` ring, and the blockquote/embedCard strike colour.
+ *
+ * Not yet called — those selectors carry `var(…, <today's token>)` fallbacks until
+ * `wrapBlockNodeView` emits these under the refactor gate. No opacity variable: that opacity is
+ * driven by `platform_editor_enghealth_a11y_jan_fixes`, not by the scheme.
+ */
 function buildDeletedNodeCSSVariables(colors) {
   return (0, _lazyNodeView.convertToInlineCss)({
     '--diff-delete-color': borderAccent(colors.deleteColor),
-    '--diff-delete-color-default': borderAccent(colors.deleteActiveColor),
     '--diff-delete-color-new': bgSubtlest(colors.deleteColor),
     '--diff-delete-color-active': bgSubtlerPressed(colors.deleteActiveColor),
     '--diff-delete-text-decoration-color': borderAccent(colors.deleteColor)

package/dist/es2019/pm-plugins/decorations/colorSchemes/factory.js

@@ -837,11 +837,17 @@ export function buildAtomicInlineChangedCSSVariables(colors) {
   });
 }
 
-/** Deleted node wrapper variables, all three states. Read by the smartCardStyles selectors. */
+/**
+ * Deleted-node wrapper variables, one per visual role in editor-core's `showDiffDeletedNodeStyles`:
+ * resting ring, `-outline-new` ring, `-active` ring, and the blockquote/embedCard strike colour.
+ *
+ * Not yet called — those selectors carry `var(…, <today's token>)` fallbacks until
+ * `wrapBlockNodeView` emits these under the refactor gate. No opacity variable: that opacity is
+ * driven by `platform_editor_enghealth_a11y_jan_fixes`, not by the scheme.
+ */
 export function buildDeletedNodeCSSVariables(colors) {
   return convertToInlineCss({
     '--diff-delete-color': borderAccent(colors.deleteColor),
-    '--diff-delete-color-default': borderAccent(colors.deleteActiveColor),
     '--diff-delete-color-new': bgSubtlest(colors.deleteColor),
     '--diff-delete-color-active': bgSubtlerPressed(colors.deleteActiveColor),
     '--diff-delete-text-decoration-color': borderAccent(colors.deleteColor)

package/dist/esm/pm-plugins/decorations/colorSchemes/factory.js

@@ -835,11 +835,17 @@ export function buildAtomicInlineChangedCSSVariables(colors) {
   });
 }
 
-/** Deleted node wrapper variables, all three states. Read by the smartCardStyles selectors. */
+/**
+ * Deleted-node wrapper variables, one per visual role in editor-core's `showDiffDeletedNodeStyles`:
+ * resting ring, `-outline-new` ring, `-active` ring, and the blockquote/embedCard strike colour.
+ *
+ * Not yet called — those selectors carry `var(…, <today's token>)` fallbacks until
+ * `wrapBlockNodeView` emits these under the refactor gate. No opacity variable: that opacity is
+ * driven by `platform_editor_enghealth_a11y_jan_fixes`, not by the scheme.
+ */
 export function buildDeletedNodeCSSVariables(colors) {
   return convertToInlineCss({
     '--diff-delete-color': borderAccent(colors.deleteColor),
-    '--diff-delete-color-default': borderAccent(colors.deleteActiveColor),
     '--diff-delete-color-new': bgSubtlest(colors.deleteColor),
     '--diff-delete-color-active': bgSubtlerPressed(colors.deleteActiveColor),
     '--diff-delete-text-decoration-color': borderAccent(colors.deleteColor)

package/dist/types/pm-plugins/decorations/colorSchemes/factory.d.ts

@@ -169,5 +169,12 @@ export declare function buildDeletedWrappedBlockOutline(colors: DiffColorScheme,
  * inline it beats the stylesheet's fallback, making the plugin the only source of the colour.
  */
 export declare function buildAtomicInlineChangedCSSVariables(colors: DiffColorScheme): string;
-/** Deleted node wrapper variables, all three states. Read by the smartCardStyles selectors. */
+/**
+ * Deleted-node wrapper variables, one per visual role in editor-core's `showDiffDeletedNodeStyles`:
+ * resting ring, `-outline-new` ring, `-active` ring, and the blockquote/embedCard strike colour.
+ *
+ * Not yet called — those selectors carry `var(…, <today's token>)` fallbacks until
+ * `wrapBlockNodeView` emits these under the refactor gate. No opacity variable: that opacity is
+ * driven by `platform_editor_enghealth_a11y_jan_fixes`, not by the scheme.
+ */
 export declare function buildDeletedNodeCSSVariables(colors: DiffColorScheme): string;

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-plugin-show-diff",
-	"version": "13.1.1",
+	"version": "13.1.2",
 	"description": "ShowDiff plugin for @atlaskit/editor-core",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",
@@ -40,11 +40,11 @@
 		"@atlaskit/adf-utils": "^20.7.0",
 		"@atlaskit/button": "^25.1.0",
 		"@atlaskit/css": "^1.0.0",
-		"@atlaskit/dropdown-menu": "^18.0.0",
+		"@atlaskit/dropdown-menu": "^18.1.0",
 		"@atlaskit/editor-core": "^224.2.0",
 		"@atlaskit/editor-json-transformer": "^9.4.0",
 		"@atlaskit/form": "^17.0.0",
-		"@atlaskit/primitives": "^22.2.0",
+		"@atlaskit/primitives": "^22.3.0",
 		"@atlaskit/section-message": "^10.0.0",
 		"@atlaskit/textarea": "^10.0.0",
 		"@atlassian/confluence-presets": "workspace:^",
@@ -54,7 +54,7 @@
 		"react-intl": "^7.0.0"
 	},
 	"peerDependencies": {
-		"@atlaskit/editor-common": "^119.9.0",
+		"@atlaskit/editor-common": "^119.10.0",
 		"react": "^18.2.0 || ^19.2.0"
 	},
 	"techstack": {