@atlaskit/editor-plugin-selection 30.0.8 → 30.0.9

package/CHANGELOG.md

@@ -1,5 +1,14 @@
 # @atlaskit/editor-plugin-selection
 
+## 30.0.9
+
+### Patch Changes
+
+- [`cbe7f7f57f1c6`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/cbe7f7f57f1c6) -
+  EDITOR-10030: Behind the `platform_editor_improve_inp_batch_2` experiment, the gap cursor click
+  handler checks for ignored clicks before calling `posAtCoords`, so ignored clicks no longer force
+  a synchronous layout.
+
 ## 30.0.8
 
 ### Patch Changes

package/dist/cjs/pm-plugins/gap-cursor-main.js

@@ -12,6 +12,7 @@ var _state = require("@atlaskit/editor-prosemirror/state");
 var _utils = require("@atlaskit/editor-prosemirror/utils");
 var _view2 = require("@atlaskit/editor-prosemirror/view");
 var _cellSelection = require("@atlaskit/editor-tables/cell-selection");
+var _isExperimentEnabled = require("@atlaskit/platform-feature-experiments/is-experiment-enabled");
 var _types = require("../types");
 var _gapCursorPluginKey = require("./gap-cursor-plugin-key");
 var _actions2 = require("./gap-cursor/actions");
@@ -100,11 +101,21 @@ var plugin = new _safePlugin.SafePlugin({
     },
     handleClick: function handleClick(view, nodePos, event) {
       var _$pos$parent;
+      var target = event.target instanceof HTMLElement ? event.target : null;
+      // Check the experiment first so the control group runs isIgnoredClick once, after
+      // posAtCoords, exactly as before.
+      var checkIgnoredClickFirst = (0, _isExperimentEnabled.isExperimentEnabled)('platform_editor_improve_inp_batch_2');
+      if (checkIgnoredClickFirst && target && (0, _utils2.isIgnoredClick)(target)) {
+        return false;
+      }
+
+      // posAtCoords reads layout (elementFromPoint, caret position and client rects), so only
+      // call it once nothing cheaper can rule the click out.
       var posAtCoords = view.posAtCoords({
         left: event.clientX,
         top: event.clientY
       });
-      if (!posAtCoords || (0, _utils2.isIgnoredClick)(event.target instanceof HTMLElement ? event.target : null)) {
+      if (!posAtCoords || !checkIgnoredClickFirst && (0, _utils2.isIgnoredClick)(target)) {
         return false;
       }
       var isInsideTheTarget = posAtCoords.pos === posAtCoords.inside;

package/dist/es2019/pm-plugins/gap-cursor-main.js

@@ -6,6 +6,7 @@ import { NodeSelection } from '@atlaskit/editor-prosemirror/state';
 import { findPositionOfNodeBefore } from '@atlaskit/editor-prosemirror/utils';
 import { Decoration, DecorationSet } from '@atlaskit/editor-prosemirror/view';
 import { CellSelection } from '@atlaskit/editor-tables/cell-selection';
+import { isExperimentEnabled } from '@atlaskit/platform-feature-experiments/is-experiment-enabled';
 import { selectionPluginKey } from '../types';
 import { gapCursorPluginKey } from './gap-cursor-plugin-key';
 import { deleteNode } from './gap-cursor/actions';
@@ -97,11 +98,21 @@ const plugin = new SafePlugin({
     },
     handleClick(view, nodePos, event) {
       var _$pos$parent;
+      const target = event.target instanceof HTMLElement ? event.target : null;
+      // Check the experiment first so the control group runs isIgnoredClick once, after
+      // posAtCoords, exactly as before.
+      const checkIgnoredClickFirst = isExperimentEnabled('platform_editor_improve_inp_batch_2');
+      if (checkIgnoredClickFirst && target && isIgnoredClick(target)) {
+        return false;
+      }
+
+      // posAtCoords reads layout (elementFromPoint, caret position and client rects), so only
+      // call it once nothing cheaper can rule the click out.
       const posAtCoords = view.posAtCoords({
         left: event.clientX,
         top: event.clientY
       });
-      if (!posAtCoords || isIgnoredClick(event.target instanceof HTMLElement ? event.target : null)) {
+      if (!posAtCoords || !checkIgnoredClickFirst && isIgnoredClick(target)) {
         return false;
       }
       const isInsideTheTarget = posAtCoords.pos === posAtCoords.inside;

package/dist/esm/pm-plugins/gap-cursor-main.js

@@ -6,6 +6,7 @@ import { NodeSelection } from '@atlaskit/editor-prosemirror/state';
 import { findPositionOfNodeBefore } from '@atlaskit/editor-prosemirror/utils';
 import { Decoration, DecorationSet } from '@atlaskit/editor-prosemirror/view';
 import { CellSelection } from '@atlaskit/editor-tables/cell-selection';
+import { isExperimentEnabled } from '@atlaskit/platform-feature-experiments/is-experiment-enabled';
 import { selectionPluginKey } from '../types';
 import { gapCursorPluginKey } from './gap-cursor-plugin-key';
 import { deleteNode } from './gap-cursor/actions';
@@ -94,11 +95,21 @@ var plugin = new SafePlugin({
     },
     handleClick: function handleClick(view, nodePos, event) {
       var _$pos$parent;
+      var target = event.target instanceof HTMLElement ? event.target : null;
+      // Check the experiment first so the control group runs isIgnoredClick once, after
+      // posAtCoords, exactly as before.
+      var checkIgnoredClickFirst = isExperimentEnabled('platform_editor_improve_inp_batch_2');
+      if (checkIgnoredClickFirst && target && isIgnoredClick(target)) {
+        return false;
+      }
+
+      // posAtCoords reads layout (elementFromPoint, caret position and client rects), so only
+      // call it once nothing cheaper can rule the click out.
       var posAtCoords = view.posAtCoords({
         left: event.clientX,
         top: event.clientY
       });
-      if (!posAtCoords || isIgnoredClick(event.target instanceof HTMLElement ? event.target : null)) {
+      if (!posAtCoords || !checkIgnoredClickFirst && isIgnoredClick(target)) {
         return false;
       }
       var isInsideTheTarget = posAtCoords.pos === posAtCoords.inside;

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-plugin-selection",
-	"version": "30.0.8",
+	"version": "30.0.9",
 	"description": "Selection plugin for @atlaskit/editor-core",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -25,17 +25,18 @@
 		"@atlaskit/editor-prosemirror": "^9.0.0",
 		"@atlaskit/editor-shared-styles": "^5.0.0",
 		"@atlaskit/editor-tables": "^3.2.0",
+		"@atlaskit/platform-feature-experiments": "^0.3.0",
 		"@atlaskit/primitives": "^22.6.0",
 		"@atlaskit/tmp-editor-statsig": "^253.0.0",
 		"@atlaskit/tokens": "^20.9.0",
 		"@babel/runtime": "^7.0.0"
 	},
 	"peerDependencies": {
-		"@atlaskit/editor-common": "^134.5.0",
+		"@atlaskit/editor-common": "^134.6.0",
 		"react": "^18.2.0 || ^19.2.0"
 	},
 	"devDependencies": {
-		"@atlaskit/editor-common": "^134.5.0",
+		"@atlaskit/editor-common": "^134.6.0",
 		"react": "^19.2.0"
 	}
 }