@atlaskit/editor-plugin-selection 2.1.3 → 2.1.4

package/CHANGELOG.md

@@ -1,5 +1,14 @@
 # @atlaskit/editor-plugin-selection
 
+## 2.1.4
+
+### Patch Changes
+
+- [#132086](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/pull-requests/132086)
+  [`0c61b5cc7a789`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/0c61b5cc7a789) -
+  [ux] ED-27255 Fix bug which prevented the gap cursor from appearing sometimes when a table is
+  nested in another table, layout or expand
+
 ## 2.1.3
 
 ### Patch Changes

package/dist/cjs/pm-plugins/gap-cursor/utils/place-gap-cursor.js

@@ -7,6 +7,7 @@ Object.defineProperty(exports, "__esModule", {
 exports.toDOM = void 0;
 var _toArray2 = _interopRequireDefault(require("@babel/runtime/helpers/toArray"));
 var _selection = require("@atlaskit/editor-common/selection");
+var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _utils = require("../utils");
 /**
  * We have a couple of nodes that require us to compute style
@@ -90,7 +91,10 @@ var toDOM = exports.toDOM = function toDOM(view, getPos) {
     if (nodeStart !== 0 || layoutMode || (node === null || node === void 0 ? void 0 : node.type.name) === 'table') {
       gapCursor.style.marginTop = style.getPropertyValue('margin-top');
     }
-    if (layoutMode) {
+
+    // Tables nested inside other elements such as layouts, expands and other tables do not have fixed width
+    var isNestedTable = (0, _platformFeatureFlags.fg)('platform_editor_nested_tables_gap_cursor') ? (node === null || node === void 0 ? void 0 : node.type.name) === 'table' && selection.$to.depth > 0 : false;
+    if (layoutMode && !isNestedTable) {
       gapCursor.setAttribute('layout', layoutMode);
       var breakoutModeStyle = (0, _utils.getComputedStyleForLayoutMode)(dom, node, style);
       gapCursor.style.width = "".concat(measureWidth(breakoutModeStyle), "px");

package/dist/es2019/pm-plugins/gap-cursor/utils/place-gap-cursor.js

@@ -1,4 +1,5 @@
 import { Side } from '@atlaskit/editor-common/selection';
+import { fg } from '@atlaskit/platform-feature-flags';
 import { getComputedStyleForLayoutMode, getLayoutModeFromTargetNode, isLeftCursor } from '../utils';
 
 /**
@@ -81,7 +82,10 @@ export const toDOM = (view, getPos) => {
     if (nodeStart !== 0 || layoutMode || (node === null || node === void 0 ? void 0 : node.type.name) === 'table') {
       gapCursor.style.marginTop = style.getPropertyValue('margin-top');
     }
-    if (layoutMode) {
+
+    // Tables nested inside other elements such as layouts, expands and other tables do not have fixed width
+    const isNestedTable = fg('platform_editor_nested_tables_gap_cursor') ? (node === null || node === void 0 ? void 0 : node.type.name) === 'table' && selection.$to.depth > 0 : false;
+    if (layoutMode && !isNestedTable) {
       gapCursor.setAttribute('layout', layoutMode);
       const breakoutModeStyle = getComputedStyleForLayoutMode(dom, node, style);
       gapCursor.style.width = `${measureWidth(breakoutModeStyle)}px`;

package/dist/esm/pm-plugins/gap-cursor/utils/place-gap-cursor.js

@@ -1,5 +1,6 @@
 import _toArray from "@babel/runtime/helpers/toArray";
 import { Side } from '@atlaskit/editor-common/selection';
+import { fg } from '@atlaskit/platform-feature-flags';
 import { getComputedStyleForLayoutMode, getLayoutModeFromTargetNode, isLeftCursor } from '../utils';
 
 /**
@@ -84,7 +85,10 @@ export var toDOM = function toDOM(view, getPos) {
     if (nodeStart !== 0 || layoutMode || (node === null || node === void 0 ? void 0 : node.type.name) === 'table') {
       gapCursor.style.marginTop = style.getPropertyValue('margin-top');
     }
-    if (layoutMode) {
+
+    // Tables nested inside other elements such as layouts, expands and other tables do not have fixed width
+    var isNestedTable = fg('platform_editor_nested_tables_gap_cursor') ? (node === null || node === void 0 ? void 0 : node.type.name) === 'table' && selection.$to.depth > 0 : false;
+    if (layoutMode && !isNestedTable) {
       gapCursor.setAttribute('layout', layoutMode);
       var breakoutModeStyle = getComputedStyleForLayoutMode(dom, node, style);
       gapCursor.style.width = "".concat(measureWidth(breakoutModeStyle), "px");

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-plugin-selection",
-	"version": "2.1.3",
+	"version": "2.1.4",
 	"description": "Selection plugin for @atlaskit/editor-core",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -92,6 +92,9 @@
 		},
 		"platform_editor_lcm_inline_node_selection_fix": {
 			"type": "boolean"
+		},
+		"platform_editor_nested_tables_gap_cursor": {
+			"type": "boolean"
 		}
 	}
 }