@atlaskit/editor-plugin-selection 2.0.3 → 2.0.5

package/CHANGELOG.md

@@ -1,5 +1,19 @@
 # @atlaskit/editor-plugin-selection
 
+## 2.0.5
+
+### Patch Changes
+
+- Updated dependencies
+
+## 2.0.4
+
+### Patch Changes
+
+- [#120517](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/pull-requests/120517)
+  [`cfcd496e4d6f2`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/cfcd496e4d6f2) -
+  [ED-26790] Fix selecting an Emoji or Mention Selects All LCMs
+
 ## 2.0.3
 
 ### Patch Changes

package/dist/cjs/pm-plugins/auto-expand-selection-range-on-inline-node-main.js

@@ -6,6 +6,7 @@ Object.defineProperty(exports, "__esModule", {
 exports.createAutoExpandSelectionRangeOnInlineNodePlugin = void 0;
 var _safePlugin = require("@atlaskit/editor-common/safe-plugin");
 var _state = require("@atlaskit/editor-prosemirror/state");
+var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _experiments = require("@atlaskit/tmp-editor-statsig/experiments");
 var _autoExpandSelectionRangeOnInlineNodeKey = require("./auto-expand-selection-range-on-inline-node-key");
 var createAutoExpandSelectionRangeOnInlineNodePlugin = exports.createAutoExpandSelectionRangeOnInlineNodePlugin = function createAutoExpandSelectionRangeOnInlineNodePlugin() {
@@ -23,10 +24,21 @@ var createAutoExpandSelectionRangeOnInlineNodePlugin = exports.createAutoExpandS
           // Ignored via go/ees005
           // eslint-disable-next-line @atlaskit/editor/no-as-casting
           var mouseUpElement = event.target;
-
-          // terminate early if mouse down and mouse up elements are the same -> e.g a click event
-          if (mouseDownElement === mouseUpElement) {
-            return;
+          if ((0, _platformFeatureFlags.fg)('platform_editor_lcm_inline_node_selection_fix')) {
+            // terminate early if mouse down and mouse up elements are the same -> e.g a click event
+            // or mouse down doesn't trigger
+            if (!mouseDownElement || mouseDownElement === mouseUpElement) {
+              mouseDownElement = null;
+              return;
+            }
+            // reset mouse down element after mouse up event
+            // so that we can detect the next mouse down event is triggered right after mouse up event or not
+            mouseDownElement = null;
+          } else {
+            // terminate early if mouse down and mouse up elements are the same -> e.g a click event
+            if (mouseDownElement === mouseUpElement) {
+              return;
+            }
           }
 
           // terminate early if mouse up event is not fired on inline node

package/dist/es2019/pm-plugins/auto-expand-selection-range-on-inline-node-main.js

@@ -1,5 +1,6 @@
 import { SafePlugin } from '@atlaskit/editor-common/safe-plugin';
 import { TextSelection } from '@atlaskit/editor-prosemirror/state';
+import { fg } from '@atlaskit/platform-feature-flags';
 import { editorExperiment } from '@atlaskit/tmp-editor-statsig/experiments';
 import { autoExpandSelectionRangeOnInlineNodePluginKey } from './auto-expand-selection-range-on-inline-node-key';
 export const createAutoExpandSelectionRangeOnInlineNodePlugin = () => {
@@ -17,10 +18,21 @@ export const createAutoExpandSelectionRangeOnInlineNodePlugin = () => {
           // Ignored via go/ees005
           // eslint-disable-next-line @atlaskit/editor/no-as-casting
           const mouseUpElement = event.target;
-
-          // terminate early if mouse down and mouse up elements are the same -> e.g a click event
-          if (mouseDownElement === mouseUpElement) {
-            return;
+          if (fg('platform_editor_lcm_inline_node_selection_fix')) {
+            // terminate early if mouse down and mouse up elements are the same -> e.g a click event
+            // or mouse down doesn't trigger
+            if (!mouseDownElement || mouseDownElement === mouseUpElement) {
+              mouseDownElement = null;
+              return;
+            }
+            // reset mouse down element after mouse up event
+            // so that we can detect the next mouse down event is triggered right after mouse up event or not
+            mouseDownElement = null;
+          } else {
+            // terminate early if mouse down and mouse up elements are the same -> e.g a click event
+            if (mouseDownElement === mouseUpElement) {
+              return;
+            }
           }
 
           // terminate early if mouse up event is not fired on inline node

package/dist/esm/pm-plugins/auto-expand-selection-range-on-inline-node-main.js

@@ -1,5 +1,6 @@
 import { SafePlugin } from '@atlaskit/editor-common/safe-plugin';
 import { TextSelection } from '@atlaskit/editor-prosemirror/state';
+import { fg } from '@atlaskit/platform-feature-flags';
 import { editorExperiment } from '@atlaskit/tmp-editor-statsig/experiments';
 import { autoExpandSelectionRangeOnInlineNodePluginKey } from './auto-expand-selection-range-on-inline-node-key';
 export var createAutoExpandSelectionRangeOnInlineNodePlugin = function createAutoExpandSelectionRangeOnInlineNodePlugin() {
@@ -17,10 +18,21 @@ export var createAutoExpandSelectionRangeOnInlineNodePlugin = function createAut
           // Ignored via go/ees005
           // eslint-disable-next-line @atlaskit/editor/no-as-casting
           var mouseUpElement = event.target;
-
-          // terminate early if mouse down and mouse up elements are the same -> e.g a click event
-          if (mouseDownElement === mouseUpElement) {
-            return;
+          if (fg('platform_editor_lcm_inline_node_selection_fix')) {
+            // terminate early if mouse down and mouse up elements are the same -> e.g a click event
+            // or mouse down doesn't trigger
+            if (!mouseDownElement || mouseDownElement === mouseUpElement) {
+              mouseDownElement = null;
+              return;
+            }
+            // reset mouse down element after mouse up event
+            // so that we can detect the next mouse down event is triggered right after mouse up event or not
+            mouseDownElement = null;
+          } else {
+            // terminate early if mouse down and mouse up elements are the same -> e.g a click event
+            if (mouseDownElement === mouseUpElement) {
+              return;
+            }
           }
 
           // terminate early if mouse up event is not fired on inline node

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-plugin-selection",
-	"version": "2.0.3",
+	"version": "2.0.5",
 	"description": "Selection plugin for @atlaskit/editor-core",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -20,13 +20,13 @@
 		"runReact18": true
 	},
 	"dependencies": {
-		"@atlaskit/editor-common": "^100.2.0",
+		"@atlaskit/editor-common": "^100.5.0",
 		"@atlaskit/editor-prosemirror": "7.0.0",
 		"@atlaskit/editor-shared-styles": "^3.4.0",
 		"@atlaskit/editor-tables": "^2.9.0",
 		"@atlaskit/platform-feature-flags": "^1.1.0",
-		"@atlaskit/tmp-editor-statsig": "3.3.0",
-		"@atlaskit/tokens": "^4.2.0",
+		"@atlaskit/tmp-editor-statsig": "3.4.0",
+		"@atlaskit/tokens": "^4.3.0",
 		"@babel/runtime": "^7.0.0"
 	},
 	"peerDependencies": {
@@ -89,6 +89,9 @@
 		},
 		"editor_auto_expand_selection_on_inline_node": {
 			"type": "boolean"
+		},
+		"platform_editor_lcm_inline_node_selection_fix": {
+			"type": "boolean"
 		}
 	}
 }