@atlaskit/editor-plugin-selection 1.5.1 → 1.5.3

package/CHANGELOG.md

@@ -1,5 +1,25 @@
 # @atlaskit/editor-plugin-selection
 
+## 1.5.3
+
+### Patch Changes
+
+- [#159308](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/159308)
+  [`14ef6f05d711c`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/14ef6f05d711c) -
+  [ED-24690] Replace LD FF with Statsig platform-editor-single-player-expand
+- Updated dependencies
+
+## 1.5.2
+
+### Patch Changes
+
+- [#155735](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/155735)
+  [`14108e8c08732`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/14108e8c08732) -
+  Stop firing `document selected` event
+- [#155735](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/155735)
+  [`1beeeda29023a`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/1beeeda29023a) -
+  Upgrades editor packages to react 18
+
 ## 1.5.1
 
 ### Patch Changes

package/dist/cjs/pm-plugins/events/keydown.js

@@ -21,7 +21,7 @@ var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var isCollapsedExpand = function isCollapsedExpand(node, _ref) {
   var __livePage = _ref.__livePage;
   var currentExpandedState;
-  if (__livePage && (0, _platformFeatureFlags.getBooleanFF)('platform.editor.single-player-expand')) {
+  if (__livePage && (0, _platformFeatureFlags.fg)('platform-editor-single-player-expand')) {
     currentExpandedState = node ? !_expand.expandedState.get(node) : undefined;
   } else if (__livePage) {
     currentExpandedState = node === null || node === void 0 ? void 0 : node.attrs.__expanded;

package/dist/cjs/pm-plugins/selection-main.js

@@ -23,32 +23,6 @@ var createPlugin = exports.createPlugin = function createPlugin(dispatch, dispat
   return new _safePlugin.SafePlugin({
     key: _types.selectionPluginKey,
     state: (0, _pluginFactory.createPluginState)(dispatch, getInitialState),
-    view: function view() {
-      return {
-        update: function update(editorView, oldEditorState) {
-          var state = editorView.state;
-          if (!(0, _utils.shouldRecalcDecorations)({
-            oldEditorState: oldEditorState,
-            newEditorState: state
-          })) {
-            return;
-          }
-          var analyticsPayload = (0, _utils.getNodeSelectionAnalyticsPayload)(state.selection) || (0, _utils.getAllSelectionAnalyticsPayload)(state.selection) ||
-          // We handle all range/cell selections except click and drag here, which is
-          // handled in mouseup handler below
-          !editorView.mouseDown && ((0, _utils.getRangeSelectionAnalyticsPayload)(state.selection, state.doc) || (0, _utils.getCellSelectionAnalyticsPayload)(state));
-
-          // We have to use dispatchAnalyticsEvent over any of the analytics plugin helpers
-          // as there were several issues caused by the fact that adding analytics through
-          // the plugin adds a new step to the transaction
-          // This causes prosemirror to run through some different code paths, eg. attempting
-          // to map selection
-          if (analyticsPayload) {
-            dispatchAnalyticsEvent(analyticsPayload);
-          }
-        }
-      };
-    },
     appendTransaction: function appendTransaction(_transactions, oldEditorState, newEditorState) {
       if (!(0, _utils.shouldRecalcDecorations)({
         oldEditorState: oldEditorState,
@@ -86,20 +60,7 @@ var createPlugin = exports.createPlugin = function createPlugin(dispatch, dispat
       handleDOMEvents: {
         keydown: (0, _keydown.createOnKeydown)({
           __livePage: options.__livePage
-        }),
-        // We only want to fire analytics for a click and drag range/cell selection when
-        // the user has finished, otherwise we will get an event almost every time they move
-        // their mouse which is too much
-        mouseup: function mouseup(editorView, event) {
-          var mouseEvent = event;
-          if (!mouseEvent.shiftKey) {
-            var analyticsPayload = (0, _utils.getRangeSelectionAnalyticsPayload)(editorView.state.selection, editorView.state.doc) || (0, _utils.getCellSelectionAnalyticsPayload)(editorView.state);
-            if (analyticsPayload) {
-              dispatchAnalyticsEvent(analyticsPayload);
-            }
-          }
-          return false;
-        }
+        })
       }
     }
   });

package/dist/cjs/utils.js

@@ -9,34 +9,7 @@ Object.defineProperty(exports, "createSelectionClickHandler", {
     return _selection.createSelectionClickHandler;
   }
 });
-exports.findSelectableContainerParent = exports.findSelectableContainerBefore = exports.findSelectableContainerAfter = exports.findLastChildNodeToSelect = exports.findFirstChildNodeToSelect = void 0;
-Object.defineProperty(exports, "getAllSelectionAnalyticsPayload", {
-  enumerable: true,
-  get: function get() {
-    return _selection.getAllSelectionAnalyticsPayload;
-  }
-});
-Object.defineProperty(exports, "getCellSelectionAnalyticsPayload", {
-  enumerable: true,
-  get: function get() {
-    return _selection.getCellSelectionAnalyticsPayload;
-  }
-});
-exports.getDecorations = void 0;
-Object.defineProperty(exports, "getNodeSelectionAnalyticsPayload", {
-  enumerable: true,
-  get: function get() {
-    return _selection.getNodeSelectionAnalyticsPayload;
-  }
-});
-exports.getNodesToDecorateFromSelection = void 0;
-Object.defineProperty(exports, "getRangeSelectionAnalyticsPayload", {
-  enumerable: true,
-  get: function get() {
-    return _selection.getRangeSelectionAnalyticsPayload;
-  }
-});
-exports.isSelectionAtStartOfParentNode = exports.isSelectionAtEndOfParentNode = exports.isSelectableContainerNode = exports.isSelectableChildNode = void 0;
+exports.isSelectionAtStartOfParentNode = exports.isSelectionAtEndOfParentNode = exports.isSelectableContainerNode = exports.isSelectableChildNode = exports.getNodesToDecorateFromSelection = exports.getDecorations = exports.findSelectableContainerParent = exports.findSelectableContainerBefore = exports.findSelectableContainerAfter = exports.findLastChildNodeToSelect = exports.findFirstChildNodeToSelect = void 0;
 exports.shouldRecalcDecorations = shouldRecalcDecorations;
 var _selection = require("@atlaskit/editor-common/selection");
 var _utils = require("@atlaskit/editor-common/utils");

package/dist/es2019/pm-plugins/events/keydown.js

@@ -1,6 +1,6 @@
 import { expandedState } from '@atlaskit/editor-common/expand';
 import { TextSelection } from '@atlaskit/editor-prosemirror/state';
-import { getBooleanFF } from '@atlaskit/platform-feature-flags';
+import { fg } from '@atlaskit/platform-feature-flags';
 
 /*
  * The way expand was built, no browser recognize selection on it.
@@ -17,7 +17,7 @@ const isCollapsedExpand = (node, {
   __livePage
 }) => {
   let currentExpandedState;
-  if (__livePage && getBooleanFF('platform.editor.single-player-expand')) {
+  if (__livePage && fg('platform-editor-single-player-expand')) {
     currentExpandedState = node ? !expandedState.get(node) : undefined;
   } else if (__livePage) {
     currentExpandedState = node === null || node === void 0 ? void 0 : node.attrs.__expanded;

package/dist/es2019/pm-plugins/selection-main.js

@@ -3,7 +3,7 @@ import { NodeSelection, TextSelection } from '@atlaskit/editor-prosemirror/state
 import { SelectionActionTypes } from '../actions';
 import { createPluginState, getPluginState } from '../plugin-factory';
 import { selectionPluginKey } from '../types';
-import { getAllSelectionAnalyticsPayload, getCellSelectionAnalyticsPayload, getDecorations, getNodeSelectionAnalyticsPayload, getRangeSelectionAnalyticsPayload, shouldRecalcDecorations } from '../utils';
+import { getDecorations, shouldRecalcDecorations } from '../utils';
 import { onCreateSelectionBetween } from './events/create-selection-between';
 import { createOnKeydown } from './events/keydown';
 export const getInitialState = state => ({
@@ -14,32 +14,6 @@ export const createPlugin = (dispatch, dispatchAnalyticsEvent, options = {}) =>
   return new SafePlugin({
     key: selectionPluginKey,
     state: createPluginState(dispatch, getInitialState),
-    view: () => ({
-      update: (editorView, oldEditorState) => {
-        const {
-          state
-        } = editorView;
-        if (!shouldRecalcDecorations({
-          oldEditorState,
-          newEditorState: state
-        })) {
-          return;
-        }
-        const analyticsPayload = getNodeSelectionAnalyticsPayload(state.selection) || getAllSelectionAnalyticsPayload(state.selection) ||
-        // We handle all range/cell selections except click and drag here, which is
-        // handled in mouseup handler below
-        !editorView.mouseDown && (getRangeSelectionAnalyticsPayload(state.selection, state.doc) || getCellSelectionAnalyticsPayload(state));
-
-        // We have to use dispatchAnalyticsEvent over any of the analytics plugin helpers
-        // as there were several issues caused by the fact that adding analytics through
-        // the plugin adds a new step to the transaction
-        // This causes prosemirror to run through some different code paths, eg. attempting
-        // to map selection
-        if (analyticsPayload) {
-          dispatchAnalyticsEvent(analyticsPayload);
-        }
-      }
-    }),
     appendTransaction(_transactions, oldEditorState, newEditorState) {
       if (!shouldRecalcDecorations({
         oldEditorState,
@@ -79,20 +53,7 @@ export const createPlugin = (dispatch, dispatchAnalyticsEvent, options = {}) =>
       handleDOMEvents: {
         keydown: createOnKeydown({
           __livePage: options.__livePage
-        }),
-        // We only want to fire analytics for a click and drag range/cell selection when
-        // the user has finished, otherwise we will get an event almost every time they move
-        // their mouse which is too much
-        mouseup: (editorView, event) => {
-          const mouseEvent = event;
-          if (!mouseEvent.shiftKey) {
-            const analyticsPayload = getRangeSelectionAnalyticsPayload(editorView.state.selection, editorView.state.doc) || getCellSelectionAnalyticsPayload(editorView.state);
-            if (analyticsPayload) {
-              dispatchAnalyticsEvent(analyticsPayload);
-            }
-          }
-          return false;
-        }
+        })
       }
     }
   });

package/dist/es2019/utils.js

@@ -1,4 +1,4 @@
-import { createSelectionClickHandler, getAllSelectionAnalyticsPayload, getCellSelectionAnalyticsPayload, getNodeSelectionAnalyticsPayload, getRangeSelectionAnalyticsPayload, isIgnored as isIgnoredByGapCursor, isSelectionAtStartOfNode } from '@atlaskit/editor-common/selection';
+import { createSelectionClickHandler, isIgnored as isIgnoredByGapCursor, isSelectionAtStartOfNode } from '@atlaskit/editor-common/selection';
 import { isEmptyParagraph } from '@atlaskit/editor-common/utils';
 import { AllSelection, NodeSelection, Selection, TextSelection } from '@atlaskit/editor-prosemirror/state';
 import { findParentNode, flatten } from '@atlaskit/editor-prosemirror/utils';
@@ -240,4 +240,4 @@ export const isSelectionAtEndOfParentNode = ($pos, selection) => {
   const $after = $pos.doc.resolve($pos.after());
   return $after.parent.content.size === $after.parentOffset;
 };
-export { getNodeSelectionAnalyticsPayload, getAllSelectionAnalyticsPayload, getRangeSelectionAnalyticsPayload, getCellSelectionAnalyticsPayload, createSelectionClickHandler };
+export { createSelectionClickHandler };

package/dist/esm/pm-plugins/events/keydown.js

@@ -1,6 +1,6 @@
 import { expandedState } from '@atlaskit/editor-common/expand';
 import { TextSelection } from '@atlaskit/editor-prosemirror/state';
-import { getBooleanFF } from '@atlaskit/platform-feature-flags';
+import { fg } from '@atlaskit/platform-feature-flags';
 
 /*
  * The way expand was built, no browser recognize selection on it.
@@ -16,7 +16,7 @@ import { getBooleanFF } from '@atlaskit/platform-feature-flags';
 var isCollapsedExpand = function isCollapsedExpand(node, _ref) {
   var __livePage = _ref.__livePage;
   var currentExpandedState;
-  if (__livePage && getBooleanFF('platform.editor.single-player-expand')) {
+  if (__livePage && fg('platform-editor-single-player-expand')) {
     currentExpandedState = node ? !expandedState.get(node) : undefined;
   } else if (__livePage) {
     currentExpandedState = node === null || node === void 0 ? void 0 : node.attrs.__expanded;

package/dist/esm/pm-plugins/selection-main.js

@@ -3,7 +3,7 @@ import { NodeSelection, TextSelection } from '@atlaskit/editor-prosemirror/state
 import { SelectionActionTypes } from '../actions';
 import { createPluginState, getPluginState } from '../plugin-factory';
 import { selectionPluginKey } from '../types';
-import { getAllSelectionAnalyticsPayload, getCellSelectionAnalyticsPayload, getDecorations, getNodeSelectionAnalyticsPayload, getRangeSelectionAnalyticsPayload, shouldRecalcDecorations } from '../utils';
+import { getDecorations, shouldRecalcDecorations } from '../utils';
 import { onCreateSelectionBetween } from './events/create-selection-between';
 import { createOnKeydown } from './events/keydown';
 export var getInitialState = function getInitialState(state) {
@@ -17,32 +17,6 @@ export var createPlugin = function createPlugin(dispatch, dispatchAnalyticsEvent
   return new SafePlugin({
     key: selectionPluginKey,
     state: createPluginState(dispatch, getInitialState),
-    view: function view() {
-      return {
-        update: function update(editorView, oldEditorState) {
-          var state = editorView.state;
-          if (!shouldRecalcDecorations({
-            oldEditorState: oldEditorState,
-            newEditorState: state
-          })) {
-            return;
-          }
-          var analyticsPayload = getNodeSelectionAnalyticsPayload(state.selection) || getAllSelectionAnalyticsPayload(state.selection) ||
-          // We handle all range/cell selections except click and drag here, which is
-          // handled in mouseup handler below
-          !editorView.mouseDown && (getRangeSelectionAnalyticsPayload(state.selection, state.doc) || getCellSelectionAnalyticsPayload(state));
-
-          // We have to use dispatchAnalyticsEvent over any of the analytics plugin helpers
-          // as there were several issues caused by the fact that adding analytics through
-          // the plugin adds a new step to the transaction
-          // This causes prosemirror to run through some different code paths, eg. attempting
-          // to map selection
-          if (analyticsPayload) {
-            dispatchAnalyticsEvent(analyticsPayload);
-          }
-        }
-      };
-    },
     appendTransaction: function appendTransaction(_transactions, oldEditorState, newEditorState) {
       if (!shouldRecalcDecorations({
         oldEditorState: oldEditorState,
@@ -80,20 +54,7 @@ export var createPlugin = function createPlugin(dispatch, dispatchAnalyticsEvent
       handleDOMEvents: {
         keydown: createOnKeydown({
           __livePage: options.__livePage
-        }),
-        // We only want to fire analytics for a click and drag range/cell selection when
-        // the user has finished, otherwise we will get an event almost every time they move
-        // their mouse which is too much
-        mouseup: function mouseup(editorView, event) {
-          var mouseEvent = event;
-          if (!mouseEvent.shiftKey) {
-            var analyticsPayload = getRangeSelectionAnalyticsPayload(editorView.state.selection, editorView.state.doc) || getCellSelectionAnalyticsPayload(editorView.state);
-            if (analyticsPayload) {
-              dispatchAnalyticsEvent(analyticsPayload);
-            }
-          }
-          return false;
-        }
+        })
       }
     }
   });

package/dist/esm/utils.js

@@ -1,4 +1,4 @@
-import { createSelectionClickHandler, getAllSelectionAnalyticsPayload, getCellSelectionAnalyticsPayload, getNodeSelectionAnalyticsPayload, getRangeSelectionAnalyticsPayload, isIgnored as isIgnoredByGapCursor, isSelectionAtStartOfNode } from '@atlaskit/editor-common/selection';
+import { createSelectionClickHandler, isIgnored as isIgnoredByGapCursor, isSelectionAtStartOfNode } from '@atlaskit/editor-common/selection';
 import { isEmptyParagraph } from '@atlaskit/editor-common/utils';
 import { AllSelection, NodeSelection, Selection, TextSelection } from '@atlaskit/editor-prosemirror/state';
 import { findParentNode, flatten } from '@atlaskit/editor-prosemirror/utils';
@@ -246,4 +246,4 @@ export var isSelectionAtEndOfParentNode = function isSelectionAtEndOfParentNode(
   var $after = $pos.doc.resolve($pos.after());
   return $after.parent.content.size === $after.parentOffset;
 };
-export { getNodeSelectionAnalyticsPayload, getAllSelectionAnalyticsPayload, getRangeSelectionAnalyticsPayload, getCellSelectionAnalyticsPayload, createSelectionClickHandler };
+export { createSelectionClickHandler };

package/dist/types/utils.d.ts

@@ -1,4 +1,4 @@
-import { createSelectionClickHandler, getAllSelectionAnalyticsPayload, getCellSelectionAnalyticsPayload, getNodeSelectionAnalyticsPayload, getRangeSelectionAnalyticsPayload } from '@atlaskit/editor-common/selection';
+import { createSelectionClickHandler } from '@atlaskit/editor-common/selection';
 import type { Node as PmNode, ResolvedPos } from '@atlaskit/editor-prosemirror/model';
 import type { EditorState, ReadonlyTransaction, Transaction } from '@atlaskit/editor-prosemirror/state';
 import { Selection } from '@atlaskit/editor-prosemirror/state';
@@ -55,4 +55,4 @@ export declare const findFirstChildNodeToSelect: (parent: PmNode) => NodeWithPos
 export declare const findLastChildNodeToSelect: (parent: PmNode) => NodeWithPos | undefined;
 export declare const isSelectionAtStartOfParentNode: ($pos: ResolvedPos, selection: Selection) => boolean;
 export declare const isSelectionAtEndOfParentNode: ($pos: ResolvedPos, selection: Selection) => boolean;
-export { getNodeSelectionAnalyticsPayload, getAllSelectionAnalyticsPayload, getRangeSelectionAnalyticsPayload, getCellSelectionAnalyticsPayload, createSelectionClickHandler, };
+export { createSelectionClickHandler };

package/dist/types-ts4.5/utils.d.ts

@@ -1,4 +1,4 @@
-import { createSelectionClickHandler, getAllSelectionAnalyticsPayload, getCellSelectionAnalyticsPayload, getNodeSelectionAnalyticsPayload, getRangeSelectionAnalyticsPayload } from '@atlaskit/editor-common/selection';
+import { createSelectionClickHandler } from '@atlaskit/editor-common/selection';
 import type { Node as PmNode, ResolvedPos } from '@atlaskit/editor-prosemirror/model';
 import type { EditorState, ReadonlyTransaction, Transaction } from '@atlaskit/editor-prosemirror/state';
 import { Selection } from '@atlaskit/editor-prosemirror/state';
@@ -55,4 +55,4 @@ export declare const findFirstChildNodeToSelect: (parent: PmNode) => NodeWithPos
 export declare const findLastChildNodeToSelect: (parent: PmNode) => NodeWithPos | undefined;
 export declare const isSelectionAtStartOfParentNode: ($pos: ResolvedPos, selection: Selection) => boolean;
 export declare const isSelectionAtEndOfParentNode: ($pos: ResolvedPos, selection: Selection) => boolean;
-export { getNodeSelectionAnalyticsPayload, getAllSelectionAnalyticsPayload, getRangeSelectionAnalyticsPayload, getCellSelectionAnalyticsPayload, createSelectionClickHandler, };
+export { createSelectionClickHandler };

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-plugin-selection",
-	"version": "1.5.1",
+	"version": "1.5.3",
 	"description": "Selection plugin for @atlaskit/editor-core",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -17,15 +17,15 @@
 	"atlassian": {
 		"team": "Editor: Lego",
 		"singleton": true,
-		"runReact18": false
+		"runReact18": true
 	},
 	"dependencies": {
-		"@atlaskit/editor-common": "^94.0.0",
+		"@atlaskit/editor-common": "^94.11.0",
 		"@atlaskit/editor-prosemirror": "6.0.0",
-		"@atlaskit/editor-shared-styles": "^3.0.0",
+		"@atlaskit/editor-shared-styles": "^3.2.0",
 		"@atlaskit/editor-tables": "^2.8.0",
 		"@atlaskit/platform-feature-flags": "^0.3.0",
-		"@atlaskit/tokens": "^2.0.0",
+		"@atlaskit/tokens": "^2.1.0",
 		"@babel/runtime": "^7.0.0"
 	},
 	"peerDependencies": {
@@ -77,7 +77,7 @@
 		}
 	},
 	"platform-feature-flags": {
-		"platform.editor.single-player-expand": {
+		"platform-editor-single-player-expand": {
 			"type": "boolean"
 		},
 		"platform_editor_mark_boundary_cursor": {