@atlaskit/editor-plugin-selection-extension 2.4.5 → 2.4.6

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # @atlaskit/editor-plugin-selection-extension
 
+## 2.4.6
+
+### Patch Changes
+
+- [#175281](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/pull-requests/175281)
+  [`f720d2c80d128`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/f720d2c80d128) -
+  [ux] Fix inconsistent references in getSelection to state that could cause unhandled exceptions
+
 ## 2.4.5
 
 ### Patch Changes

package/dist/cjs/selectionExtensionPlugin.js

@@ -9,6 +9,7 @@ var _toConsumableArray2 = _interopRequireDefault(require("@babel/runtime/helpers
 var _react = _interopRequireDefault(require("react"));
 var _messages = require("@atlaskit/editor-common/messages");
 var _safePlugin = require("@atlaskit/editor-common/safe-plugin");
+var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _main = require("./pm-plugins/main");
 var _SelectionExtensionComponentWrapper = require("./ui/extension/SelectionExtensionComponentWrapper");
 var _getBoundingBoxFromSelection = require("./ui/getBoundingBoxFromSelection");
@@ -109,7 +110,8 @@ var selectionExtensionPlugin = exports.selectionExtensionPlugin = function selec
           var currentSelection = view.state.selection;
           var from = currentSelection.from,
             to = currentSelection.to;
-          var text = state.doc.textBetween(from, to, '\n');
+          var currentState = (0, _platformFeatureFlags.fg)('platform_editor_fix_get_selection_state_mismatch') ? view.state : state;
+          var text = currentState.doc.textBetween(from, to, '\n');
           var coords = (0, _getBoundingBoxFromSelection.getBoundingBoxFromSelection)(view, from, to);
           return {
             text: text,

package/dist/es2019/selectionExtensionPlugin.js

@@ -1,6 +1,7 @@
 import React from 'react';
 import { selectionExtensionMessages } from '@atlaskit/editor-common/messages';
 import { SafePlugin } from '@atlaskit/editor-common/safe-plugin';
+import { fg } from '@atlaskit/platform-feature-flags';
 import { createPlugin, selectionExtensionPluginKey } from './pm-plugins/main';
 import { SelectionExtensionComponentWrapper } from './ui/extension/SelectionExtensionComponentWrapper';
 import { getBoundingBoxFromSelection } from './ui/getBoundingBoxFromSelection';
@@ -107,7 +108,8 @@ export const selectionExtensionPlugin = ({
             from,
             to
           } = currentSelection;
-          const text = state.doc.textBetween(from, to, '\n');
+          const currentState = fg('platform_editor_fix_get_selection_state_mismatch') ? view.state : state;
+          const text = currentState.doc.textBetween(from, to, '\n');
           const coords = getBoundingBoxFromSelection(view, from, to);
           return {
             text,

package/dist/esm/selectionExtensionPlugin.js

@@ -2,6 +2,7 @@ import _toConsumableArray from "@babel/runtime/helpers/toConsumableArray";
 import React from 'react';
 import { selectionExtensionMessages } from '@atlaskit/editor-common/messages';
 import { SafePlugin } from '@atlaskit/editor-common/safe-plugin';
+import { fg } from '@atlaskit/platform-feature-flags';
 import { createPlugin, selectionExtensionPluginKey } from './pm-plugins/main';
 import { SelectionExtensionComponentWrapper } from './ui/extension/SelectionExtensionComponentWrapper';
 import { getBoundingBoxFromSelection } from './ui/getBoundingBoxFromSelection';
@@ -102,7 +103,8 @@ export var selectionExtensionPlugin = function selectionExtensionPlugin(_ref) {
           var currentSelection = view.state.selection;
           var from = currentSelection.from,
             to = currentSelection.to;
-          var text = state.doc.textBetween(from, to, '\n');
+          var currentState = fg('platform_editor_fix_get_selection_state_mismatch') ? view.state : state;
+          var text = currentState.doc.textBetween(from, to, '\n');
           var coords = getBoundingBoxFromSelection(view, from, to);
           return {
             text: text,

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-plugin-selection-extension",
-	"version": "2.4.5",
+	"version": "2.4.6",
 	"description": "editor-plugin-selection-extension plugin for @atlaskit/editor-core",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",
@@ -36,12 +36,12 @@
 		".": "./src/index.ts"
 	},
 	"dependencies": {
-		"@atlaskit/editor-common": "^107.0.0",
+		"@atlaskit/editor-common": "^107.2.0",
 		"@atlaskit/editor-plugin-analytics": "^2.3.0",
 		"@atlaskit/editor-plugin-editor-viewmode": "^4.0.0",
 		"@atlaskit/editor-plugin-selection-toolbar": "^3.7.0",
 		"@atlaskit/editor-prosemirror": "7.0.0",
-		"@atlaskit/icon": "^27.0.0",
+		"@atlaskit/icon": "^27.1.0",
 		"@atlaskit/platform-feature-flags": "^1.1.0",
 		"@atlaskit/primitives": "^14.9.0",
 		"@atlaskit/tmp-editor-statsig": "^8.0.0",
@@ -99,5 +99,10 @@
 				"import-no-extraneous-disable-for-examples-and-docs"
 			]
 		}
+	},
+	"platform-feature-flags": {
+		"platform_editor_fix_get_selection_state_mismatch": {
+			"type": "boolean"
+		}
 	}
 }