@atlaskit/editor-plugin-quick-insert 19.0.3 → 19.0.5

package/CHANGELOG.md

@@ -1,5 +1,22 @@
 # @atlaskit/editor-plugin-quick-insert
 
+## 19.0.5
+
+### Patch Changes
+
+- [`89497a944a054`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/89497a944a054) -
+  Keep the block control Quick Insert button available after editor appearance changes behind
+  `platform_editor_block_control_migration`.
+- Updated dependencies
+
+## 19.0.4
+
+### Patch Changes
+
+- [`50f3c586dbc63`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/50f3c586dbc63) -
+  Clean up feature gate `platform_editor_fix_space_triggering_ai`
+- Updated dependencies
+
 ## 19.0.3
 
 ### Patch Changes

package/dist/cjs/quickInsertPlugin.js

@@ -155,7 +155,7 @@ var quickInsertPlugin = exports.quickInsertPlugin = function quickInsertPlugin(_
             dispatchAnalyticsEvent = _ref6.dispatchAnalyticsEvent;
           return quickInsertPluginFactory((0, _isExperimentEnabled.isExperimentEnabled)('platform_editor_slash_command') ? (defaultItems || []).filter(function (item) {
             return item !== undefined;
-          }) : defaultItems, providerFactory, getIntl, dispatch, dispatchAnalyticsEvent, options === null || options === void 0 ? void 0 : options.emptyStateHandler, onInsert, options === null || options === void 0 ? void 0 : options.itemFilter, api);
+          }) : defaultItems, providerFactory, getIntl, dispatch, dispatchAnalyticsEvent, refs, options === null || options === void 0 ? void 0 : options.emptyStateHandler, onInsert, options === null || options === void 0 ? void 0 : options.itemFilter, api);
         }
       }, {
         name: 'quickInsertOpenExperience',
@@ -177,7 +177,11 @@ var quickInsertPlugin = exports.quickInsertPlugin = function quickInsertPlugin(_
       var editorView = _ref7.editorView,
         popupsMountPoint = _ref7.popupsMountPoint,
         wrapperElement = _ref7.wrapperElement;
-      refs.editorView = editorView || undefined;
+      // using contentComponent to set editorView can cause it to become stale when editor is reconfigured
+      // (e.g. page appearance change)
+      if (!(0, _isExperimentEnabled.isExperimentEnabled)('platform_editor_block_control_migration')) {
+        refs.editorView = editorView || undefined;
+      }
       refs.popupsMountPoint = popupsMountPoint || undefined;
       refs.wrapperElement = wrapperElement || undefined;
       if (!editorView || (0, _coreUtils.isSSR)()) {
@@ -342,10 +346,10 @@ var setProviderState = function setProviderState(providerState) {
     return true;
   };
 };
-function quickInsertPluginFactory(defaultItems, providerFactory, getIntl, dispatch, dispatchAnalyticsEvent, emptyStateHandler) {
-  var onInsert = arguments.length > 6 && arguments[6] !== undefined ? arguments[6] : function () {};
-  var itemFilter = arguments.length > 7 ? arguments[7] : undefined;
-  var api = arguments.length > 8 ? arguments[8] : undefined;
+function quickInsertPluginFactory(defaultItems, providerFactory, getIntl, dispatch, dispatchAnalyticsEvent, refs, emptyStateHandler) {
+  var onInsert = arguments.length > 7 && arguments[7] !== undefined ? arguments[7] : function () {};
+  var itemFilter = arguments.length > 8 ? arguments[8] : undefined;
+  var api = arguments.length > 9 ? arguments[9] : undefined;
   return new _safePlugin.SafePlugin({
     key: _pluginKey.pluginKey,
     state: {
@@ -379,6 +383,9 @@ function quickInsertPluginFactory(defaultItems, providerFactory, getIntl, dispat
       }
     },
     view: function view(editorView) {
+      if ((0, _isExperimentEnabled.isExperimentEnabled)('platform_editor_block_control_migration')) {
+        refs.editorView = editorView;
+      }
       var quickInsertItemsAnalyticsScheduler;
       var isDestroyed = false;
       var providerHandler = /*#__PURE__*/function () {
@@ -457,6 +464,9 @@ function quickInsertPluginFactory(defaultItems, providerFactory, getIntl, dispat
       return {
         destroy: function destroy() {
           var _quickInsertItemsAnal;
+          if ((0, _isExperimentEnabled.isExperimentEnabled)('platform_editor_block_control_migration') && refs.editorView === editorView) {
+            refs.editorView = undefined;
+          }
           isDestroyed = true;
           (_quickInsertItemsAnal = quickInsertItemsAnalyticsScheduler) === null || _quickInsertItemsAnal === void 0 || _quickInsertItemsAnal.destroy();
           providerFactory.unsubscribe('quickInsertProvider', providerHandler);

package/dist/cjs/ui/search.js

@@ -9,7 +9,6 @@ var _toConsumableArray2 = _interopRequireDefault(require("@babel/runtime/helpers
 var _quickInsert = require("@atlaskit/editor-common/quick-insert");
 var _getActiveQuickInsertCategories = require("@atlaskit/editor-common/quick-insert/get-active-quick-insert-categories");
 var _utils = require("@atlaskit/editor-common/utils");
-var _fg = require("@atlaskit/platform-feature-flags/fg");
 var isRegisteredLayoutQuickInsertItem = function isRegisteredLayoutQuickInsertItem(item) {
   var _item$keywords, _item$keywords2;
   return Boolean(item.id && item.id !== 'layout' && ((_item$keywords = item.keywords) === null || _item$keywords === void 0 ? void 0 : _item$keywords.includes('layout')) && ((_item$keywords2 = item.keywords) === null || _item$keywords2 === void 0 ? void 0 : _item$keywords2.includes('column')));
@@ -74,7 +73,7 @@ var getQuickInsertSuggestions = exports.getQuickInsertSuggestions = function get
       return item.featured;
     });
   }
-  return (0, _quickInsert.find)(((0, _fg.fg)('platform_editor_fix_space_triggering_ai') ? query === null || query === void 0 ? void 0 : query.trimEnd() : query) || '', category === 'all' || !category ? items : items.filter(function (item) {
+  return (0, _quickInsert.find)((query === null || query === void 0 ? void 0 : query.trimEnd()) || '', category === 'all' || !category ? items : items.filter(function (item) {
     return (0, _getActiveQuickInsertCategories.getActiveQuickInsertCategories)(item.category, item.categories).includes(category);
   }), prioritySortingFn);
 };

package/dist/es2019/quickInsertPlugin.js

@@ -137,7 +137,7 @@ export const quickInsertPlugin = ({
           getIntl,
           dispatch,
           dispatchAnalyticsEvent
-        }) => quickInsertPluginFactory(isExperimentEnabled('platform_editor_slash_command') ? (defaultItems || []).filter(item => item !== undefined) : defaultItems, providerFactory, getIntl, dispatch, dispatchAnalyticsEvent, options === null || options === void 0 ? void 0 : options.emptyStateHandler, onInsert, options === null || options === void 0 ? void 0 : options.itemFilter, api)
+        }) => quickInsertPluginFactory(isExperimentEnabled('platform_editor_slash_command') ? (defaultItems || []).filter(item => item !== undefined) : defaultItems, providerFactory, getIntl, dispatch, dispatchAnalyticsEvent, refs, options === null || options === void 0 ? void 0 : options.emptyStateHandler, onInsert, options === null || options === void 0 ? void 0 : options.itemFilter, api)
       }, {
         name: 'quickInsertOpenExperience',
         plugin: () => getQuickInsertOpenExperiencePlugin({
@@ -157,7 +157,11 @@ export const quickInsertPlugin = ({
       popupsMountPoint,
       wrapperElement
     }) {
-      refs.editorView = editorView || undefined;
+      // using contentComponent to set editorView can cause it to become stale when editor is reconfigured
+      // (e.g. page appearance change)
+      if (!isExperimentEnabled('platform_editor_block_control_migration')) {
+        refs.editorView = editorView || undefined;
+      }
       refs.popupsMountPoint = popupsMountPoint || undefined;
       refs.wrapperElement = wrapperElement || undefined;
       if (!editorView || isSSR()) {
@@ -304,7 +308,7 @@ const setProviderState = providerState => (state, dispatch) => {
   }
   return true;
 };
-function quickInsertPluginFactory(defaultItems, providerFactory, getIntl, dispatch, dispatchAnalyticsEvent, emptyStateHandler, onInsert = () => {}, itemFilter, api) {
+function quickInsertPluginFactory(defaultItems, providerFactory, getIntl, dispatch, dispatchAnalyticsEvent, refs, emptyStateHandler, onInsert = () => {}, itemFilter, api) {
   return new SafePlugin({
     key: pluginKey,
     state: {
@@ -339,6 +343,9 @@ function quickInsertPluginFactory(defaultItems, providerFactory, getIntl, dispat
       }
     },
     view(editorView) {
+      if (isExperimentEnabled('platform_editor_block_control_migration')) {
+        refs.editorView = editorView;
+      }
       let quickInsertItemsAnalyticsScheduler;
       let isDestroyed = false;
       const providerHandler = async (_name, providerPromise) => {
@@ -377,6 +384,9 @@ function quickInsertPluginFactory(defaultItems, providerFactory, getIntl, dispat
       return {
         destroy() {
           var _quickInsertItemsAnal;
+          if (isExperimentEnabled('platform_editor_block_control_migration') && refs.editorView === editorView) {
+            refs.editorView = undefined;
+          }
           isDestroyed = true;
           (_quickInsertItemsAnal = quickInsertItemsAnalyticsScheduler) === null || _quickInsertItemsAnal === void 0 ? void 0 : _quickInsertItemsAnal.destroy();
           providerFactory.unsubscribe('quickInsertProvider', providerHandler);

package/dist/es2019/ui/search.js

@@ -1,7 +1,6 @@
 import { find } from '@atlaskit/editor-common/quick-insert';
 import { getActiveQuickInsertCategories } from '@atlaskit/editor-common/quick-insert/get-active-quick-insert-categories';
 import { dedupe } from '@atlaskit/editor-common/utils';
-import { fg } from '@atlaskit/platform-feature-flags/fg';
 const isRegisteredLayoutQuickInsertItem = item => {
   var _item$keywords, _item$keywords2;
   return Boolean(item.id && item.id !== 'layout' && ((_item$keywords = item.keywords) === null || _item$keywords === void 0 ? void 0 : _item$keywords.includes('layout')) && ((_item$keywords2 = item.keywords) === null || _item$keywords2 === void 0 ? void 0 : _item$keywords2.includes('column')));
@@ -56,5 +55,5 @@ export const getQuickInsertSuggestions = (searchOptions, lazyDefaultItems = () =
   if (featuredItems) {
     return items.filter(item => item.featured);
   }
-  return find((fg('platform_editor_fix_space_triggering_ai') ? query === null || query === void 0 ? void 0 : query.trimEnd() : query) || '', category === 'all' || !category ? items : items.filter(item => getActiveQuickInsertCategories(item.category, item.categories).includes(category)), prioritySortingFn);
+  return find((query === null || query === void 0 ? void 0 : query.trimEnd()) || '', category === 'all' || !category ? items : items.filter(item => getActiveQuickInsertCategories(item.category, item.categories).includes(category)), prioritySortingFn);
 };

package/dist/esm/quickInsertPlugin.js

@@ -148,7 +148,7 @@ export var quickInsertPlugin = function quickInsertPlugin(_ref) {
             dispatchAnalyticsEvent = _ref6.dispatchAnalyticsEvent;
           return quickInsertPluginFactory(isExperimentEnabled('platform_editor_slash_command') ? (defaultItems || []).filter(function (item) {
             return item !== undefined;
-          }) : defaultItems, providerFactory, getIntl, dispatch, dispatchAnalyticsEvent, options === null || options === void 0 ? void 0 : options.emptyStateHandler, onInsert, options === null || options === void 0 ? void 0 : options.itemFilter, api);
+          }) : defaultItems, providerFactory, getIntl, dispatch, dispatchAnalyticsEvent, refs, options === null || options === void 0 ? void 0 : options.emptyStateHandler, onInsert, options === null || options === void 0 ? void 0 : options.itemFilter, api);
         }
       }, {
         name: 'quickInsertOpenExperience',
@@ -170,7 +170,11 @@ export var quickInsertPlugin = function quickInsertPlugin(_ref) {
       var editorView = _ref7.editorView,
         popupsMountPoint = _ref7.popupsMountPoint,
         wrapperElement = _ref7.wrapperElement;
-      refs.editorView = editorView || undefined;
+      // using contentComponent to set editorView can cause it to become stale when editor is reconfigured
+      // (e.g. page appearance change)
+      if (!isExperimentEnabled('platform_editor_block_control_migration')) {
+        refs.editorView = editorView || undefined;
+      }
       refs.popupsMountPoint = popupsMountPoint || undefined;
       refs.wrapperElement = wrapperElement || undefined;
       if (!editorView || isSSR()) {
@@ -335,10 +339,10 @@ var setProviderState = function setProviderState(providerState) {
     return true;
   };
 };
-function quickInsertPluginFactory(defaultItems, providerFactory, getIntl, dispatch, dispatchAnalyticsEvent, emptyStateHandler) {
-  var onInsert = arguments.length > 6 && arguments[6] !== undefined ? arguments[6] : function () {};
-  var itemFilter = arguments.length > 7 ? arguments[7] : undefined;
-  var api = arguments.length > 8 ? arguments[8] : undefined;
+function quickInsertPluginFactory(defaultItems, providerFactory, getIntl, dispatch, dispatchAnalyticsEvent, refs, emptyStateHandler) {
+  var onInsert = arguments.length > 7 && arguments[7] !== undefined ? arguments[7] : function () {};
+  var itemFilter = arguments.length > 8 ? arguments[8] : undefined;
+  var api = arguments.length > 9 ? arguments[9] : undefined;
   return new SafePlugin({
     key: pluginKey,
     state: {
@@ -372,6 +376,9 @@ function quickInsertPluginFactory(defaultItems, providerFactory, getIntl, dispat
       }
     },
     view: function view(editorView) {
+      if (isExperimentEnabled('platform_editor_block_control_migration')) {
+        refs.editorView = editorView;
+      }
       var quickInsertItemsAnalyticsScheduler;
       var isDestroyed = false;
       var providerHandler = /*#__PURE__*/function () {
@@ -450,6 +457,9 @@ function quickInsertPluginFactory(defaultItems, providerFactory, getIntl, dispat
       return {
         destroy: function destroy() {
           var _quickInsertItemsAnal;
+          if (isExperimentEnabled('platform_editor_block_control_migration') && refs.editorView === editorView) {
+            refs.editorView = undefined;
+          }
           isDestroyed = true;
           (_quickInsertItemsAnal = quickInsertItemsAnalyticsScheduler) === null || _quickInsertItemsAnal === void 0 || _quickInsertItemsAnal.destroy();
           providerFactory.unsubscribe('quickInsertProvider', providerHandler);

package/dist/esm/ui/search.js

@@ -2,7 +2,6 @@ import _toConsumableArray from "@babel/runtime/helpers/toConsumableArray";
 import { find } from '@atlaskit/editor-common/quick-insert';
 import { getActiveQuickInsertCategories } from '@atlaskit/editor-common/quick-insert/get-active-quick-insert-categories';
 import { dedupe } from '@atlaskit/editor-common/utils';
-import { fg } from '@atlaskit/platform-feature-flags/fg';
 var isRegisteredLayoutQuickInsertItem = function isRegisteredLayoutQuickInsertItem(item) {
   var _item$keywords, _item$keywords2;
   return Boolean(item.id && item.id !== 'layout' && ((_item$keywords = item.keywords) === null || _item$keywords === void 0 ? void 0 : _item$keywords.includes('layout')) && ((_item$keywords2 = item.keywords) === null || _item$keywords2 === void 0 ? void 0 : _item$keywords2.includes('column')));
@@ -67,7 +66,7 @@ export var getQuickInsertSuggestions = function getQuickInsertSuggestions(search
       return item.featured;
     });
   }
-  return find((fg('platform_editor_fix_space_triggering_ai') ? query === null || query === void 0 ? void 0 : query.trimEnd() : query) || '', category === 'all' || !category ? items : items.filter(function (item) {
+  return find((query === null || query === void 0 ? void 0 : query.trimEnd()) || '', category === 'all' || !category ? items : items.filter(function (item) {
     return getActiveQuickInsertCategories(item.category, item.categories).includes(category);
   }), prioritySortingFn);
 };

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-plugin-quick-insert",
-	"version": "19.0.3",
+	"version": "19.0.5",
 	"description": "Quick insert plugin for @atlaskit/editor-core",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",
@@ -51,7 +51,7 @@
 		"@emotion/react": "^11.7.1"
 	},
 	"peerDependencies": {
-		"@atlaskit/editor-common": "^123.3.0",
+		"@atlaskit/editor-common": "^123.4.0",
 		"react": "^18.2.0 || ^19.2.0",
 		"react-dom": "^18.2.0 || ^19.2.0",
 		"react-intl": "^5.25.1 || ^6.0.0 || ^7.0.0"
@@ -68,9 +68,6 @@
 		"platform_editor_ease_of_use_metrics": {
 			"type": "boolean"
 		},
-		"platform_editor_fix_space_triggering_ai": {
-			"type": "boolean"
-		},
 		"platform_dst_modal-dialog-use-modal-title": {
 			"type": "boolean",
 			"referenceOnly": true