@atlaskit/editor-plugin-paste-options-toolbar 9.1.7 → 9.1.8

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # @atlaskit/editor-plugin-paste-options-toolbar
 
+## 9.1.8
+
+### Patch Changes
+
+- [`fb9bbd5719238`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/fb9bbd5719238) -
+  EDITOR-6193 Correcting `visibleAiActions` attribute of paste actions menu which was not being
+  populated.
+
 ## 9.1.7
 
 ### Patch Changes

package/dist/cjs/ui/on-paste-actions-menu/PasteActionsMenu.js

@@ -225,7 +225,7 @@ function onPositionCalculated(editorView, pasteStartPos, pasteEndPos, targetElem
   };
 }
 var PasteActionsMenu = exports.PasteActionsMenu = function PasteActionsMenu(_ref) {
-  var _api$analytics, _api$uiControlRegistr, _api$uiControlRegistr2, _api$uiControlRegistr3, _api$uiControlRegistr4;
+  var _api$analytics, _api$uiControlRegistr, _api$uiControlRegistr2;
   var api = _ref.api,
     editorView = _ref.editorView,
     mountTo = _ref.mountTo,
@@ -279,22 +279,6 @@ var PasteActionsMenu = exports.PasteActionsMenu = function PasteActionsMenu(_ref
     isToolbarShown = _useSharedPluginState2.showToolbar,
     pasteStartPos = _useSharedPluginState2.pasteStartPos,
     pasteEndPos = _useSharedPluginState2.pasteEndPos;
-  var aiSurfaceComponents = (_api$uiControlRegistr = api === null || api === void 0 || (_api$uiControlRegistr2 = api.uiControlRegistry) === null || _api$uiControlRegistr2 === void 0 ? void 0 : _api$uiControlRegistr2.actions.getComponents('ai-paste-menu')) !== null && _api$uiControlRegistr !== void 0 ? _api$uiControlRegistr : [];
-  var visibleAiActionKeys = (0, _hasVisibleButton.getVisibleKeys)(aiSurfaceComponents, ['button', 'menu-item']);
-  (0, _react.useEffect)(function () {
-    if (!prevShowToolbarRef.current && isToolbarShown) {
-      editorAnalyticsAPI === null || editorAnalyticsAPI === void 0 || editorAnalyticsAPI.fireAnalyticsEvent({
-        action: _analytics.ACTION.OPENED,
-        actionSubject: _analytics.ACTION_SUBJECT.PASTE_ACTIONS_MENU,
-        eventType: _analytics.EVENT_TYPE.UI,
-        attributes: {
-          visibleAiActions: visibleAiActionKeys
-        }
-      });
-    }
-    prevShowToolbarRef.current = isToolbarShown;
-    // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [isToolbarShown, editorAnalyticsAPI]);
   var preventEditorFocusLoss = (0, _react.useCallback)(function (e) {
     e.preventDefault();
   }, []);
@@ -326,22 +310,38 @@ var PasteActionsMenu = exports.PasteActionsMenu = function PasteActionsMenu(_ref
   // onPositionCalculated with fresh viewport coordinates.
   var overflowScrollParent = isToolbarShown ? (0, _ui.findOverflowScrollParent)(editorView.dom) : false;
   var effectiveScrollableElement = overflowScrollParent || scrollableElement;
-  var pasteMenuComponents = (_api$uiControlRegistr3 = api === null || api === void 0 || (_api$uiControlRegistr4 = api.uiControlRegistry) === null || _api$uiControlRegistr4 === void 0 ? void 0 : _api$uiControlRegistr4.actions.getComponents(_toolbar.PASTE_MENU.key)) !== null && _api$uiControlRegistr3 !== void 0 ? _api$uiControlRegistr3 : [];
+  var pasteMenuComponents = (_api$uiControlRegistr = api === null || api === void 0 || (_api$uiControlRegistr2 = api.uiControlRegistry) === null || _api$uiControlRegistr2 === void 0 ? void 0 : _api$uiControlRegistr2.actions.getComponents(_toolbar.PASTE_MENU.key)) !== null && _api$uiControlRegistr !== void 0 ? _api$uiControlRegistr : [];
   var anyComponentVisible = (0, _hasVisibleButton.hasVisibleButton)(pasteMenuComponents);
 
-  // Two positioning modes:
-  // 1. Inline: no AI actions visible — menu appears to the right of the cursor,
-  //    vertically centered with the text line.
-  // 2. Block-anchored: AI actions are visible — menu appears at the right edge
-  //    of the content block, aligned with paste start.
-  var hasVisibleAiActions = (0, _hasVisibleButton.getVisibleKeys)(
   // eslint-disable-next-line @atlassian/perf-linting/no-expensive-computations-in-render -- pasteMenuComponents changes by reference each render; filter is small (< 10 items)
-  pasteMenuComponents.filter(function (c) {
+  var aiMenuItems = pasteMenuComponents.filter(function (c) {
     var _c$parents;
     return c.type === 'menu-item' && ((_c$parents = c.parents) === null || _c$parents === void 0 ? void 0 : _c$parents.some(function (p) {
       return p.key === _toolbar.AI_PASTE_MENU_SECTION.key;
     }));
-  }), ['menu-item']).length > 0;
+  });
+  var visibleAiActionKeys = (0, _hasVisibleButton.getVisibleKeys)(aiMenuItems, ['menu-item']);
+
+  // Two positioning modes:
+  // 1. Inline: no AI actions visible — menu appears to the right of the cursor,
+  //    vertically centered with the text line.
+  // 2. Block-anchored: AI actions are visible — menu appears at the right edge
+  //    of the content block, aligned with paste start.
+  var hasVisibleAiActions = visibleAiActionKeys.length > 0;
+  (0, _react.useEffect)(function () {
+    if (!prevShowToolbarRef.current && isToolbarShown) {
+      editorAnalyticsAPI === null || editorAnalyticsAPI === void 0 || editorAnalyticsAPI.fireAnalyticsEvent({
+        action: _analytics.ACTION.OPENED,
+        actionSubject: _analytics.ACTION_SUBJECT.PASTE_ACTIONS_MENU,
+        eventType: _analytics.EVENT_TYPE.UI,
+        attributes: {
+          visibleAiActions: visibleAiActionKeys
+        }
+      });
+    }
+    prevShowToolbarRef.current = isToolbarShown;
+    // eslint-disable-next-line react-hooks/exhaustive-deps
+  }, [isToolbarShown, editorAnalyticsAPI]);
   var useInlinePosition = !hasVisibleAiActions;
   if (!isToolbarShown) {
     return null;

package/dist/es2019/ui/on-paste-actions-menu/PasteActionsMenu.js

@@ -215,7 +215,7 @@ export const PasteActionsMenu = ({
   boundariesElement,
   scrollableElement
 }) => {
-  var _api$analytics, _api$uiControlRegistr, _api$uiControlRegistr2, _api$uiControlRegistr3, _api$uiControlRegistr4;
+  var _api$analytics, _api$uiControlRegistr, _api$uiControlRegistr2;
   const editorAnalyticsAPI = api === null || api === void 0 ? void 0 : (_api$analytics = api.analytics) === null || _api$analytics === void 0 ? void 0 : _api$analytics.actions;
   const {
     lastContentPasted
@@ -266,22 +266,6 @@ export const PasteActionsMenu = ({
       pasteEndPos: (_pluginState$pasteEnd = pluginState === null || pluginState === void 0 ? void 0 : pluginState.pasteEndPos) !== null && _pluginState$pasteEnd !== void 0 ? _pluginState$pasteEnd : 0
     };
   });
-  const aiSurfaceComponents = (_api$uiControlRegistr = api === null || api === void 0 ? void 0 : (_api$uiControlRegistr2 = api.uiControlRegistry) === null || _api$uiControlRegistr2 === void 0 ? void 0 : _api$uiControlRegistr2.actions.getComponents('ai-paste-menu')) !== null && _api$uiControlRegistr !== void 0 ? _api$uiControlRegistr : [];
-  const visibleAiActionKeys = getVisibleKeys(aiSurfaceComponents, ['button', 'menu-item']);
-  useEffect(() => {
-    if (!prevShowToolbarRef.current && isToolbarShown) {
-      editorAnalyticsAPI === null || editorAnalyticsAPI === void 0 ? void 0 : editorAnalyticsAPI.fireAnalyticsEvent({
-        action: ACTION.OPENED,
-        actionSubject: ACTION_SUBJECT.PASTE_ACTIONS_MENU,
-        eventType: EVENT_TYPE.UI,
-        attributes: {
-          visibleAiActions: visibleAiActionKeys
-        }
-      });
-    }
-    prevShowToolbarRef.current = isToolbarShown;
-    // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [isToolbarShown, editorAnalyticsAPI]);
   const preventEditorFocusLoss = useCallback(e => {
     e.preventDefault();
   }, []);
@@ -313,20 +297,36 @@ export const PasteActionsMenu = ({
   // onPositionCalculated with fresh viewport coordinates.
   const overflowScrollParent = isToolbarShown ? findOverflowScrollParent(editorView.dom) : false;
   const effectiveScrollableElement = overflowScrollParent || scrollableElement;
-  const pasteMenuComponents = (_api$uiControlRegistr3 = api === null || api === void 0 ? void 0 : (_api$uiControlRegistr4 = api.uiControlRegistry) === null || _api$uiControlRegistr4 === void 0 ? void 0 : _api$uiControlRegistr4.actions.getComponents(PASTE_MENU.key)) !== null && _api$uiControlRegistr3 !== void 0 ? _api$uiControlRegistr3 : [];
+  const pasteMenuComponents = (_api$uiControlRegistr = api === null || api === void 0 ? void 0 : (_api$uiControlRegistr2 = api.uiControlRegistry) === null || _api$uiControlRegistr2 === void 0 ? void 0 : _api$uiControlRegistr2.actions.getComponents(PASTE_MENU.key)) !== null && _api$uiControlRegistr !== void 0 ? _api$uiControlRegistr : [];
   const anyComponentVisible = hasVisibleButton(pasteMenuComponents);
 
+  // eslint-disable-next-line @atlassian/perf-linting/no-expensive-computations-in-render -- pasteMenuComponents changes by reference each render; filter is small (< 10 items)
+  const aiMenuItems = pasteMenuComponents.filter(c => {
+    var _c$parents;
+    return c.type === 'menu-item' && ((_c$parents = c.parents) === null || _c$parents === void 0 ? void 0 : _c$parents.some(p => p.key === AI_PASTE_MENU_SECTION.key));
+  });
+  const visibleAiActionKeys = getVisibleKeys(aiMenuItems, ['menu-item']);
+
   // Two positioning modes:
   // 1. Inline: no AI actions visible — menu appears to the right of the cursor,
   //    vertically centered with the text line.
   // 2. Block-anchored: AI actions are visible — menu appears at the right edge
   //    of the content block, aligned with paste start.
-  const hasVisibleAiActions = getVisibleKeys(
-  // eslint-disable-next-line @atlassian/perf-linting/no-expensive-computations-in-render -- pasteMenuComponents changes by reference each render; filter is small (< 10 items)
-  pasteMenuComponents.filter(c => {
-    var _c$parents;
-    return c.type === 'menu-item' && ((_c$parents = c.parents) === null || _c$parents === void 0 ? void 0 : _c$parents.some(p => p.key === AI_PASTE_MENU_SECTION.key));
-  }), ['menu-item']).length > 0;
+  const hasVisibleAiActions = visibleAiActionKeys.length > 0;
+  useEffect(() => {
+    if (!prevShowToolbarRef.current && isToolbarShown) {
+      editorAnalyticsAPI === null || editorAnalyticsAPI === void 0 ? void 0 : editorAnalyticsAPI.fireAnalyticsEvent({
+        action: ACTION.OPENED,
+        actionSubject: ACTION_SUBJECT.PASTE_ACTIONS_MENU,
+        eventType: EVENT_TYPE.UI,
+        attributes: {
+          visibleAiActions: visibleAiActionKeys
+        }
+      });
+    }
+    prevShowToolbarRef.current = isToolbarShown;
+    // eslint-disable-next-line react-hooks/exhaustive-deps
+  }, [isToolbarShown, editorAnalyticsAPI]);
   const useInlinePosition = !hasVisibleAiActions;
   if (!isToolbarShown) {
     return null;

package/dist/esm/ui/on-paste-actions-menu/PasteActionsMenu.js

@@ -210,7 +210,7 @@ export function onPositionCalculated(editorView, pasteStartPos, pasteEndPos, tar
   };
 }
 export var PasteActionsMenu = function PasteActionsMenu(_ref) {
-  var _api$analytics, _api$uiControlRegistr, _api$uiControlRegistr2, _api$uiControlRegistr3, _api$uiControlRegistr4;
+  var _api$analytics, _api$uiControlRegistr, _api$uiControlRegistr2;
   var api = _ref.api,
     editorView = _ref.editorView,
     mountTo = _ref.mountTo,
@@ -264,22 +264,6 @@ export var PasteActionsMenu = function PasteActionsMenu(_ref) {
     isToolbarShown = _useSharedPluginState2.showToolbar,
     pasteStartPos = _useSharedPluginState2.pasteStartPos,
     pasteEndPos = _useSharedPluginState2.pasteEndPos;
-  var aiSurfaceComponents = (_api$uiControlRegistr = api === null || api === void 0 || (_api$uiControlRegistr2 = api.uiControlRegistry) === null || _api$uiControlRegistr2 === void 0 ? void 0 : _api$uiControlRegistr2.actions.getComponents('ai-paste-menu')) !== null && _api$uiControlRegistr !== void 0 ? _api$uiControlRegistr : [];
-  var visibleAiActionKeys = getVisibleKeys(aiSurfaceComponents, ['button', 'menu-item']);
-  useEffect(function () {
-    if (!prevShowToolbarRef.current && isToolbarShown) {
-      editorAnalyticsAPI === null || editorAnalyticsAPI === void 0 || editorAnalyticsAPI.fireAnalyticsEvent({
-        action: ACTION.OPENED,
-        actionSubject: ACTION_SUBJECT.PASTE_ACTIONS_MENU,
-        eventType: EVENT_TYPE.UI,
-        attributes: {
-          visibleAiActions: visibleAiActionKeys
-        }
-      });
-    }
-    prevShowToolbarRef.current = isToolbarShown;
-    // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [isToolbarShown, editorAnalyticsAPI]);
   var preventEditorFocusLoss = useCallback(function (e) {
     e.preventDefault();
   }, []);
@@ -311,22 +295,38 @@ export var PasteActionsMenu = function PasteActionsMenu(_ref) {
   // onPositionCalculated with fresh viewport coordinates.
   var overflowScrollParent = isToolbarShown ? findOverflowScrollParent(editorView.dom) : false;
   var effectiveScrollableElement = overflowScrollParent || scrollableElement;
-  var pasteMenuComponents = (_api$uiControlRegistr3 = api === null || api === void 0 || (_api$uiControlRegistr4 = api.uiControlRegistry) === null || _api$uiControlRegistr4 === void 0 ? void 0 : _api$uiControlRegistr4.actions.getComponents(PASTE_MENU.key)) !== null && _api$uiControlRegistr3 !== void 0 ? _api$uiControlRegistr3 : [];
+  var pasteMenuComponents = (_api$uiControlRegistr = api === null || api === void 0 || (_api$uiControlRegistr2 = api.uiControlRegistry) === null || _api$uiControlRegistr2 === void 0 ? void 0 : _api$uiControlRegistr2.actions.getComponents(PASTE_MENU.key)) !== null && _api$uiControlRegistr !== void 0 ? _api$uiControlRegistr : [];
   var anyComponentVisible = hasVisibleButton(pasteMenuComponents);
 
-  // Two positioning modes:
-  // 1. Inline: no AI actions visible — menu appears to the right of the cursor,
-  //    vertically centered with the text line.
-  // 2. Block-anchored: AI actions are visible — menu appears at the right edge
-  //    of the content block, aligned with paste start.
-  var hasVisibleAiActions = getVisibleKeys(
   // eslint-disable-next-line @atlassian/perf-linting/no-expensive-computations-in-render -- pasteMenuComponents changes by reference each render; filter is small (< 10 items)
-  pasteMenuComponents.filter(function (c) {
+  var aiMenuItems = pasteMenuComponents.filter(function (c) {
     var _c$parents;
     return c.type === 'menu-item' && ((_c$parents = c.parents) === null || _c$parents === void 0 ? void 0 : _c$parents.some(function (p) {
       return p.key === AI_PASTE_MENU_SECTION.key;
     }));
-  }), ['menu-item']).length > 0;
+  });
+  var visibleAiActionKeys = getVisibleKeys(aiMenuItems, ['menu-item']);
+
+  // Two positioning modes:
+  // 1. Inline: no AI actions visible — menu appears to the right of the cursor,
+  //    vertically centered with the text line.
+  // 2. Block-anchored: AI actions are visible — menu appears at the right edge
+  //    of the content block, aligned with paste start.
+  var hasVisibleAiActions = visibleAiActionKeys.length > 0;
+  useEffect(function () {
+    if (!prevShowToolbarRef.current && isToolbarShown) {
+      editorAnalyticsAPI === null || editorAnalyticsAPI === void 0 || editorAnalyticsAPI.fireAnalyticsEvent({
+        action: ACTION.OPENED,
+        actionSubject: ACTION_SUBJECT.PASTE_ACTIONS_MENU,
+        eventType: EVENT_TYPE.UI,
+        attributes: {
+          visibleAiActions: visibleAiActionKeys
+        }
+      });
+    }
+    prevShowToolbarRef.current = isToolbarShown;
+    // eslint-disable-next-line react-hooks/exhaustive-deps
+  }, [isToolbarShown, editorAnalyticsAPI]);
   var useInlinePosition = !hasVisibleAiActions;
   if (!isToolbarShown) {
     return null;

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-plugin-paste-options-toolbar",
-	"version": "9.1.7",
+	"version": "9.1.8",
 	"description": "Paste options toolbar for @atlaskit/editor-core",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",
@@ -42,14 +42,14 @@
 		"@atlaskit/icon": "^33.1.0",
 		"@atlaskit/platform-feature-flags": "^1.1.0",
 		"@atlaskit/primitives": "^18.1.0",
-		"@atlaskit/tokens": "^11.3.0",
+		"@atlaskit/tokens": "^11.4.0",
 		"@babel/runtime": "^7.0.0",
 		"@compiled/react": "^0.20.0",
 		"@emotion/react": "^11.7.1",
 		"react-intl-next": "npm:react-intl@^5.18.1"
 	},
 	"peerDependencies": {
-		"@atlaskit/editor-common": "^112.11.0",
+		"@atlaskit/editor-common": "^112.12.0",
 		"react": "^18.2.0",
 		"react-dom": "^18.2.0"
 	},