@atlaskit/editor-plugin-paste-options-toolbar 9.1.1 → 9.1.2

package/CHANGELOG.md

@@ -1,5 +1,15 @@
 # @atlaskit/editor-plugin-paste-options-toolbar
 
+## 9.1.2
+
+### Patch Changes
+
+- [`0386f83e8c2b8`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/0386f83e8c2b8) -
+  Fix paste actions menu dismissing when pressing modifier keys (Ctrl, Shift, Alt, Meta/Cmd).
+  Modifier-only key presses no longer hide the toolbar, gated behind
+  platform_editor_paste_actions_keypress_fix feature flag.
+- Updated dependencies
+
 ## 9.1.1
 
 ### Patch Changes

package/dist/cjs/pm-plugins/main.js

@@ -7,10 +7,17 @@ exports.createPlugin = createPlugin;
 var _safePlugin = require("@atlaskit/editor-common/safe-plugin");
 var _model = require("@atlaskit/editor-prosemirror/model");
 var _view2 = require("@atlaskit/editor-prosemirror/view");
+var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _commands = require("../editor-commands/commands");
 var _types = require("../types/types");
 var _constants = require("./constants");
 var _pluginFactory = require("./plugin-factory");
+var MODIFIER_KEYS = new Set(['Shift', 'Control', 'Alt', 'Meta',
+// Cmd on Mac, Win on Windows
+'CapsLock', 'NumLock', 'ScrollLock', 'Fn', 'FnLock']);
+function isModifierKey(event) {
+  return MODIFIER_KEYS.has(event.key);
+}
 function createPlugin(dispatch, options) {
   return new _safePlugin.SafePlugin({
     key: _types.pasteOptionsPluginKey,
@@ -46,7 +53,11 @@ function createPlugin(dispatch, options) {
         // Hide toolbar when clicked anywhere within the editor, tr.getMeta('pointer') does not work if clicked on the same line after pasting so relying on mousedown event
         mousedown: _commands.checkAndHideToolbar
       },
-      handleKeyDown: function handleKeyDown(view) {
+      handleKeyDown: function handleKeyDown(view, event) {
+        // Don't hide toolbar when pressing modifier keys alone (Ctrl, Shift, Alt, Meta/Cmd)
+        if (isModifierKey(event) && (0, _platformFeatureFlags.fg)('platform_editor_paste_actions_keypress_fix')) {
+          return false;
+        }
         (0, _commands.checkAndHideToolbar)(view);
         return false;
       },

package/dist/es2019/pm-plugins/main.js

@@ -1,10 +1,17 @@
 import { SafePlugin } from '@atlaskit/editor-common/safe-plugin';
 import { Slice } from '@atlaskit/editor-prosemirror/model';
 import { Decoration, DecorationSet } from '@atlaskit/editor-prosemirror/view';
+import { fg } from '@atlaskit/platform-feature-flags';
 import { checkAndHideToolbar } from '../editor-commands/commands';
 import { pasteOptionsPluginKey, ToolbarDropdownOption } from '../types/types';
 import { PASTE_HIGHLIGHT_DECORATION_KEY, TEXT_HIGHLIGHT_CLASS } from './constants';
 import { createPluginState } from './plugin-factory';
+const MODIFIER_KEYS = new Set(['Shift', 'Control', 'Alt', 'Meta',
+// Cmd on Mac, Win on Windows
+'CapsLock', 'NumLock', 'ScrollLock', 'Fn', 'FnLock']);
+function isModifierKey(event) {
+  return MODIFIER_KEYS.has(event.key);
+}
 export function createPlugin(dispatch, options) {
   return new SafePlugin({
     key: pasteOptionsPluginKey,
@@ -40,7 +47,11 @@ export function createPlugin(dispatch, options) {
         // Hide toolbar when clicked anywhere within the editor, tr.getMeta('pointer') does not work if clicked on the same line after pasting so relying on mousedown event
         mousedown: checkAndHideToolbar
       },
-      handleKeyDown: view => {
+      handleKeyDown: (view, event) => {
+        // Don't hide toolbar when pressing modifier keys alone (Ctrl, Shift, Alt, Meta/Cmd)
+        if (isModifierKey(event) && fg('platform_editor_paste_actions_keypress_fix')) {
+          return false;
+        }
         checkAndHideToolbar(view);
         return false;
       },

package/dist/esm/pm-plugins/main.js

@@ -1,10 +1,17 @@
 import { SafePlugin } from '@atlaskit/editor-common/safe-plugin';
 import { Slice } from '@atlaskit/editor-prosemirror/model';
 import { Decoration, DecorationSet } from '@atlaskit/editor-prosemirror/view';
+import { fg } from '@atlaskit/platform-feature-flags';
 import { checkAndHideToolbar } from '../editor-commands/commands';
 import { pasteOptionsPluginKey, ToolbarDropdownOption } from '../types/types';
 import { PASTE_HIGHLIGHT_DECORATION_KEY, TEXT_HIGHLIGHT_CLASS } from './constants';
 import { createPluginState } from './plugin-factory';
+var MODIFIER_KEYS = new Set(['Shift', 'Control', 'Alt', 'Meta',
+// Cmd on Mac, Win on Windows
+'CapsLock', 'NumLock', 'ScrollLock', 'Fn', 'FnLock']);
+function isModifierKey(event) {
+  return MODIFIER_KEYS.has(event.key);
+}
 export function createPlugin(dispatch, options) {
   return new SafePlugin({
     key: pasteOptionsPluginKey,
@@ -40,7 +47,11 @@ export function createPlugin(dispatch, options) {
         // Hide toolbar when clicked anywhere within the editor, tr.getMeta('pointer') does not work if clicked on the same line after pasting so relying on mousedown event
         mousedown: checkAndHideToolbar
       },
-      handleKeyDown: function handleKeyDown(view) {
+      handleKeyDown: function handleKeyDown(view, event) {
+        // Don't hide toolbar when pressing modifier keys alone (Ctrl, Shift, Alt, Meta/Cmd)
+        if (isModifierKey(event) && fg('platform_editor_paste_actions_keypress_fix')) {
+          return false;
+        }
         checkAndHideToolbar(view);
         return false;
       },

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-plugin-paste-options-toolbar",
-	"version": "9.1.1",
+	"version": "9.1.2",
 	"description": "Paste options toolbar for @atlaskit/editor-core",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",
@@ -56,6 +56,11 @@
 		"@testing-library/react": "^16.3.0",
 		"wait-for-expect": "^1.2.0"
 	},
+	"platform-feature-flags": {
+		"platform_editor_paste_actions_keypress_fix": {
+			"type": "boolean"
+		}
+	},
 	"techstack": {
 		"@atlassian/frontend": {
 			"code-structure": [