@atlaskit/editor-plugin-panel 1.1.1 → 1.1.3

package/CHANGELOG.md

@@ -1,5 +1,21 @@
 # @atlaskit/editor-plugin-panel
 
+## 1.1.3
+
+### Patch Changes
+
+- [#94717](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/94717) [`40f38eb0a512`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/40f38eb0a512) - Cleaning up feature flag for inserting nodes in ordered list.
+
+  Fix bugs for incorrect ordered list order with action & improve selection behaviour on insert
+
+- Updated dependencies
+
+## 1.1.2
+
+### Patch Changes
+
+- [#93748](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/93748) [`16e695c28843`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/16e695c28843) - ED-22891: Fixed selection weirdness when panel has no icon
+
 ## 1.1.1
 
 ### Patch Changes

package/dist/cjs/nodeviews/panel.js

@@ -79,6 +79,9 @@ var PanelNodeView = /*#__PURE__*/function () {
     key: "ignoreMutation",
     value: function ignoreMutation(mutation) {
       // ignore mutation if it caused by the icon.
+      if (!this.icon) {
+        return false;
+      }
       var isIcon = mutation.target === this.icon || mutation.target.parentNode === this.icon;
       // ignore mutation if it caused by the lazy load emoji inside icon.
       var isInsideIcon = this.icon.contains(mutation.target);

package/dist/cjs/plugin.js

@@ -10,7 +10,6 @@ var _adfSchema = require("@atlaskit/adf-schema");
 var _analytics = require("@atlaskit/editor-common/analytics");
 var _messages = require("@atlaskit/editor-common/messages");
 var _quickInsert = require("@atlaskit/editor-common/quick-insert");
-var _utils = require("@atlaskit/editor-common/utils");
 var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _colors = require("@atlaskit/theme/colors");
 var _actions = require("./actions");
@@ -205,11 +204,7 @@ function createPanelAction(_ref4) {
   if (!node) {
     return false;
   }
-  var tr = state.selection.empty && (0, _platformFeatureFlags.getBooleanFF)('platform.editor.ordered-list-inserting-nodes_bh0vo') ? insert(node) : (0, _utils.createWrapSelectionTransaction)({
-    state: state,
-    type: state.schema.nodes.panel,
-    nodeAttributes: attributes
-  });
+  var tr = state.selection.empty && insert(node);
   if (tr) {
     var _api$analytics2;
     api === null || api === void 0 || (_api$analytics2 = api.analytics) === null || _api$analytics2 === void 0 || _api$analytics2.actions.attachAnalyticsEvent({

package/dist/es2019/nodeviews/panel.js

@@ -71,6 +71,9 @@ class PanelNodeView {
   }
   ignoreMutation(mutation) {
     // ignore mutation if it caused by the icon.
+    if (!this.icon) {
+      return false;
+    }
     const isIcon = mutation.target === this.icon || mutation.target.parentNode === this.icon;
     // ignore mutation if it caused by the lazy load emoji inside icon.
     const isInsideIcon = this.icon.contains(mutation.target);

package/dist/es2019/plugin.js

@@ -3,7 +3,6 @@ import { extendedPanel, panel, PanelType } from '@atlaskit/adf-schema';
 import { ACTION, ACTION_SUBJECT, ACTION_SUBJECT_ID, EVENT_TYPE, INPUT_METHOD } from '@atlaskit/editor-common/analytics';
 import { blockTypeMessages } from '@atlaskit/editor-common/messages';
 import { IconCustomPanel, IconPanel, IconPanelError, IconPanelNote, IconPanelSuccess, IconPanelWarning } from '@atlaskit/editor-common/quick-insert';
-import { createWrapSelectionTransaction } from '@atlaskit/editor-common/utils';
 import { getBooleanFF } from '@atlaskit/platform-feature-flags';
 import { T50 } from '@atlaskit/theme/colors';
 import { insertPanelWithAnalytics } from './actions';
@@ -183,11 +182,7 @@ function createPanelAction({
   if (!node) {
     return false;
   }
-  const tr = state.selection.empty && getBooleanFF('platform.editor.ordered-list-inserting-nodes_bh0vo') ? insert(node) : createWrapSelectionTransaction({
-    state,
-    type: state.schema.nodes.panel,
-    nodeAttributes: attributes
-  });
+  const tr = state.selection.empty && insert(node);
   if (tr) {
     var _api$analytics2;
     api === null || api === void 0 ? void 0 : (_api$analytics2 = api.analytics) === null || _api$analytics2 === void 0 ? void 0 : _api$analytics2.actions.attachAnalyticsEvent({

package/dist/esm/nodeviews/panel.js

@@ -72,6 +72,9 @@ var PanelNodeView = /*#__PURE__*/function () {
     key: "ignoreMutation",
     value: function ignoreMutation(mutation) {
       // ignore mutation if it caused by the icon.
+      if (!this.icon) {
+        return false;
+      }
       var isIcon = mutation.target === this.icon || mutation.target.parentNode === this.icon;
       // ignore mutation if it caused by the lazy load emoji inside icon.
       var isInsideIcon = this.icon.contains(mutation.target);

package/dist/esm/plugin.js

@@ -3,7 +3,6 @@ import { extendedPanel, panel, PanelType } from '@atlaskit/adf-schema';
 import { ACTION, ACTION_SUBJECT, ACTION_SUBJECT_ID, EVENT_TYPE, INPUT_METHOD } from '@atlaskit/editor-common/analytics';
 import { blockTypeMessages } from '@atlaskit/editor-common/messages';
 import { IconCustomPanel, IconPanel, IconPanelError, IconPanelNote, IconPanelSuccess, IconPanelWarning } from '@atlaskit/editor-common/quick-insert';
-import { createWrapSelectionTransaction } from '@atlaskit/editor-common/utils';
 import { getBooleanFF } from '@atlaskit/platform-feature-flags';
 import { T50 } from '@atlaskit/theme/colors';
 import { insertPanelWithAnalytics } from './actions';
@@ -198,11 +197,7 @@ function createPanelAction(_ref4) {
   if (!node) {
     return false;
   }
-  var tr = state.selection.empty && getBooleanFF('platform.editor.ordered-list-inserting-nodes_bh0vo') ? insert(node) : createWrapSelectionTransaction({
-    state: state,
-    type: state.schema.nodes.panel,
-    nodeAttributes: attributes
-  });
+  var tr = state.selection.empty && insert(node);
   if (tr) {
     var _api$analytics2;
     api === null || api === void 0 || (_api$analytics2 = api.analytics) === null || _api$analytics2 === void 0 || _api$analytics2.actions.attachAnalyticsEvent({

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaskit/editor-plugin-panel",
-  "version": "1.1.1",
+  "version": "1.1.3",
   "description": "Panel plugin for @atlaskit/editor-core.",
   "author": "Atlassian Pty Ltd",
   "license": "Apache-2.0",
@@ -34,12 +34,12 @@
   },
   "dependencies": {
     "@atlaskit/adf-schema": "^35.10.0",
-    "@atlaskit/editor-common": "^78.31.0",
+    "@atlaskit/editor-common": "^78.34.0",
     "@atlaskit/editor-palette": "1.5.3",
     "@atlaskit/editor-plugin-analytics": "^1.1.0",
     "@atlaskit/editor-plugin-decorations": "^1.1.0",
     "@atlaskit/editor-prosemirror": "4.0.0",
-    "@atlaskit/editor-shared-styles": "^2.9.0",
+    "@atlaskit/editor-shared-styles": "^2.10.0",
     "@atlaskit/emoji": "^67.6.0",
     "@atlaskit/icon": "^22.1.0",
     "@atlaskit/platform-feature-flags": "^0.2.0",
@@ -93,9 +93,6 @@
   },
   "prettier": "@atlassian/atlassian-frontend-prettier-config-1.0.0",
   "platform-feature-flags": {
-    "platform.editor.ordered-list-inserting-nodes_bh0vo": {
-      "type": "boolean"
-    },
     "platform.editor.allow-extended-panel": {
       "type": "boolean"
     },