@atlaskit/editor-plugin-media 9.5.4 → 9.5.5

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # @atlaskit/editor-plugin-media
 
+## 9.5.5
+
+### Patch Changes
+
+- [`231bc5802c7de`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/231bc5802c7de) -
+  fix stale node position issue in media single
+- Updated dependencies
+
 ## 9.5.4
 
 ### Patch Changes

package/dist/cjs/ui/ResizableMediaSingle/ResizableMediaSingleNext.js

@@ -38,6 +38,16 @@ function _interopRequireWildcard(e, t) { if ("function" == typeof WeakMap) var r
 // eslint-disable-next-line @atlaskit/ui-styling-standard/use-compiled -- Ignored via go/DSP-18766
 
 var resizerNextTestId = exports.resizerNextTestId = 'mediaSingle.resizerNext.testid';
+var getNodePosition = function getNodePosition(getPos) {
+  if (typeof getPos !== 'function') {
+    return null;
+  }
+  var pos = getPos();
+  if (Number.isNaN(pos) || typeof pos !== 'number') {
+    return null;
+  }
+  return pos;
+};
 var calcPxHeight = function calcPxHeight(props) {
   var newWidth = props.newWidth,
     previousWidth = props.previousWidth,
@@ -204,15 +214,10 @@ var ResizableMediaSingleNextFunctional = exports.ResizableMediaSingleNextFunctio
     _useState0 = (0, _slicedToArray2.default)(_useState9, 2),
     hasResized = _useState0[0],
     setHasResized = _useState0[1];
-  var nodePosition = (0, _react.useMemo)(function () {
-    if (typeof getPos !== 'function') {
-      return null;
-    }
-    var pos = getPos();
-    if (Number.isNaN(pos) || typeof pos !== 'number') {
-      return null;
-    }
-    return pos;
+  var nodePosition = (0, _expValEquals.expValEquals)('platform_editor_media_vc_fixes', 'isEnabled', true) ? getNodePosition(getPos) :
+  // eslint-disable-next-line react-hooks/rules-of-hooks
+  (0, _react.useMemo)(function () {
+    return getNodePosition(getPos);
   }, [getPos]);
   var isNestedNode = (0, _react.useMemo)(function () {
     if (nodePosition === null) {

package/dist/es2019/ui/ResizableMediaSingle/ResizableMediaSingleNext.js

@@ -26,6 +26,16 @@ import { checkMediaType } from '../../pm-plugins/utils/check-media-type';
 import { ResizableMediaMigrationNotification } from './ResizableMediaMigrationNotification';
 import { wrapperStyle } from './styled';
 export const resizerNextTestId = 'mediaSingle.resizerNext.testid';
+const getNodePosition = getPos => {
+  if (typeof getPos !== 'function') {
+    return null;
+  }
+  const pos = getPos();
+  if (Number.isNaN(pos) || typeof pos !== 'number') {
+    return null;
+  }
+  return pos;
+};
 const calcPxHeight = props => {
   const {
     newWidth,
@@ -181,16 +191,9 @@ export const ResizableMediaSingleNextFunctional = props => {
   const [isResizing, setIsResizing] = useState(false);
   const [isVideoFile, setIsVideoFile] = useState(!fg('platform_editor_media_video_check_fix_new'));
   const [hasResized, setHasResized] = useState(false);
-  const nodePosition = useMemo(() => {
-    if (typeof getPos !== 'function') {
-      return null;
-    }
-    const pos = getPos();
-    if (Number.isNaN(pos) || typeof pos !== 'number') {
-      return null;
-    }
-    return pos;
-  }, [getPos]);
+  const nodePosition = expValEquals('platform_editor_media_vc_fixes', 'isEnabled', true) ? getNodePosition(getPos) :
+  // eslint-disable-next-line react-hooks/rules-of-hooks
+  useMemo(() => getNodePosition(getPos), [getPos]);
   const isNestedNode = useMemo(() => {
     if (nodePosition === null) {
       return false;

package/dist/esm/ui/ResizableMediaSingle/ResizableMediaSingleNext.js

@@ -28,6 +28,16 @@ import { checkMediaType } from '../../pm-plugins/utils/check-media-type';
 import { ResizableMediaMigrationNotification } from './ResizableMediaMigrationNotification';
 import { wrapperStyle } from './styled';
 export var resizerNextTestId = 'mediaSingle.resizerNext.testid';
+var getNodePosition = function getNodePosition(getPos) {
+  if (typeof getPos !== 'function') {
+    return null;
+  }
+  var pos = getPos();
+  if (Number.isNaN(pos) || typeof pos !== 'number') {
+    return null;
+  }
+  return pos;
+};
 var calcPxHeight = function calcPxHeight(props) {
   var newWidth = props.newWidth,
     previousWidth = props.previousWidth,
@@ -194,15 +204,10 @@ export var ResizableMediaSingleNextFunctional = function ResizableMediaSingleNex
     _useState0 = _slicedToArray(_useState9, 2),
     hasResized = _useState0[0],
     setHasResized = _useState0[1];
-  var nodePosition = useMemo(function () {
-    if (typeof getPos !== 'function') {
-      return null;
-    }
-    var pos = getPos();
-    if (Number.isNaN(pos) || typeof pos !== 'number') {
-      return null;
-    }
-    return pos;
+  var nodePosition = expValEquals('platform_editor_media_vc_fixes', 'isEnabled', true) ? getNodePosition(getPos) :
+  // eslint-disable-next-line react-hooks/rules-of-hooks
+  useMemo(function () {
+    return getNodePosition(getPos);
   }, [getPos]);
   var isNestedNode = useMemo(function () {
     if (nodePosition === null) {

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-plugin-media",
-	"version": "9.5.4",
+	"version": "9.5.5",
 	"description": "Media plugin for @atlaskit/editor-core",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",
@@ -58,7 +58,7 @@
 		"@atlaskit/media-client": "^35.8.0",
 		"@atlaskit/media-client-react": "^4.2.0",
 		"@atlaskit/media-common": "^12.4.0",
-		"@atlaskit/media-filmstrip": "^51.1.0",
+		"@atlaskit/media-filmstrip": "^51.2.0",
 		"@atlaskit/media-picker": "^70.1.0",
 		"@atlaskit/media-ui": "^28.7.0",
 		"@atlaskit/media-viewer": "^52.8.0",
@@ -66,7 +66,7 @@
 		"@atlaskit/primitives": "^18.0.0",
 		"@atlaskit/textfield": "^8.2.0",
 		"@atlaskit/theme": "^21.0.0",
-		"@atlaskit/tmp-editor-statsig": "^29.0.0",
+		"@atlaskit/tmp-editor-statsig": "^29.4.0",
 		"@atlaskit/tokens": "^11.0.0",
 		"@atlaskit/tooltip": "^20.14.0",
 		"@babel/runtime": "^7.0.0",
@@ -78,7 +78,7 @@
 		"uuid": "^3.1.0"
 	},
 	"peerDependencies": {
-		"@atlaskit/editor-common": "^111.16.0",
+		"@atlaskit/editor-common": "^111.18.0",
 		"@atlaskit/media-core": "^37.0.0",
 		"react": "^18.2.0",
 		"react-dom": "^18.2.0",
@@ -130,9 +130,6 @@
 		"platform_editor_typography_ugc": {
 			"type": "boolean"
 		},
-		"platform-visual-refresh-icons": {
-			"type": "boolean"
-		},
 		"platform_editor_introduce_insert_media_command": {
 			"type": "boolean"
 		},