@atlaskit/editor-plugin-media 5.1.4 → 5.1.5

package/CHANGELOG.md

@@ -1,5 +1,14 @@
 # @atlaskit/editor-plugin-media
 
+## 5.1.5
+
+### Patch Changes
+
+- [#184968](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/pull-requests/184968)
+  [`a52007f9eed36`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/a52007f9eed36) -
+  Introduce a performance experiment to avoid running media floating toolbar code unless selected.
+- Updated dependencies
+
 ## 5.1.4
 
 ### Patch Changes

package/dist/cjs/ui/toolbar/index.js

@@ -29,6 +29,7 @@ var _smartLinkCard = _interopRequireDefault(require("@atlaskit/icon/core/smart-l
 var _mediaFilmstrip = require("@atlaskit/media-filmstrip");
 var _mediaUi = require("@atlaskit/media-ui");
 var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
+var _expValEquals = require("@atlaskit/tmp-editor-statsig/exp-val-equals");
 var _experiments = require("@atlaskit/tmp-editor-statsig/experiments");
 var _styles = require("../../nodeviews/styles");
 var _altText = require("../../pm-plugins/alt-text");
@@ -685,6 +686,12 @@ var getMediaTypeMessage = function getMediaTypeMessage(selectedNodeTypeSingle) {
   return mediaType ? mediaTypeMessages[mediaType] : _mediaUi.messages.file_unknown_is_selected;
 };
 var overflowDropdwonBtnTriggerTestId = exports.overflowDropdwonBtnTriggerTestId = 'media-overflow-dropdown-trigger';
+var isMediaSelection = function isMediaSelection(selection, nodeType) {
+  if (selection instanceof _state2.NodeSelection) {
+    return nodeType.includes(selection.node.type);
+  }
+  return false;
+};
 var floatingToolbar = exports.floatingToolbar = function floatingToolbar(state, intl) {
   var _pluginInjectionApi$d3, _pluginInjectionApi$d4;
   var options = arguments.length > 2 && arguments[2] !== undefined ? arguments[2] : {};
@@ -715,6 +722,11 @@ var floatingToolbar = exports.floatingToolbar = function floatingToolbar(state,
   }
   var nodeType = allowMediaInline ? [mediaInline, mediaSingle, media] : [mediaSingle];
   var isSelectedNodeMediaSingle = state.selection instanceof _state2.NodeSelection && state.selection.node.type === mediaSingle;
+  if ((0, _expValEquals.expValEquals)('platform_editor_media_floating_toolbar_early_exit', 'isEnabled', true)) {
+    if (!isMediaSelection(state.selection, nodeType)) {
+      return;
+    }
+  }
   var baseToolbar = {
     title: 'Media floating controls',
     nodeType: nodeType,

package/dist/es2019/ui/toolbar/index.js

@@ -19,6 +19,7 @@ import SmartLinkCardIcon from '@atlaskit/icon/core/smart-link-card';
 import { mediaFilmstripItemDOMSelector } from '@atlaskit/media-filmstrip';
 import { messages } from '@atlaskit/media-ui';
 import { fg } from '@atlaskit/platform-feature-flags';
+import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 import { editorExperiment } from '@atlaskit/tmp-editor-statsig/experiments';
 import { MediaSingleNodeSelector } from '../../nodeviews/styles';
 import { getPluginState as getMediaAltTextPluginState } from '../../pm-plugins/alt-text';
@@ -681,6 +682,12 @@ const getMediaTypeMessage = selectedNodeTypeSingle => {
   return mediaType ? mediaTypeMessages[mediaType] : messages.file_unknown_is_selected;
 };
 export const overflowDropdwonBtnTriggerTestId = 'media-overflow-dropdown-trigger';
+const isMediaSelection = (selection, nodeType) => {
+  if (selection instanceof NodeSelection) {
+    return nodeType.includes(selection.node.type);
+  }
+  return false;
+};
 export const floatingToolbar = (state, intl, options = {}, pluginInjectionApi) => {
   var _pluginInjectionApi$d3, _pluginInjectionApi$d4;
   const {
@@ -715,6 +722,11 @@ export const floatingToolbar = (state, intl, options = {}, pluginInjectionApi) =
   }
   const nodeType = allowMediaInline ? [mediaInline, mediaSingle, media] : [mediaSingle];
   const isSelectedNodeMediaSingle = state.selection instanceof NodeSelection && state.selection.node.type === mediaSingle;
+  if (expValEquals('platform_editor_media_floating_toolbar_early_exit', 'isEnabled', true)) {
+    if (!isMediaSelection(state.selection, nodeType)) {
+      return;
+    }
+  }
   const baseToolbar = {
     title: 'Media floating controls',
     nodeType,

package/dist/esm/ui/toolbar/index.js

@@ -23,6 +23,7 @@ import SmartLinkCardIcon from '@atlaskit/icon/core/smart-link-card';
 import { mediaFilmstripItemDOMSelector } from '@atlaskit/media-filmstrip';
 import { messages } from '@atlaskit/media-ui';
 import { fg } from '@atlaskit/platform-feature-flags';
+import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 import { editorExperiment } from '@atlaskit/tmp-editor-statsig/experiments';
 import { MediaSingleNodeSelector } from '../../nodeviews/styles';
 import { getPluginState as getMediaAltTextPluginState } from '../../pm-plugins/alt-text';
@@ -676,6 +677,12 @@ var getMediaTypeMessage = function getMediaTypeMessage(selectedNodeTypeSingle) {
   return mediaType ? mediaTypeMessages[mediaType] : messages.file_unknown_is_selected;
 };
 export var overflowDropdwonBtnTriggerTestId = 'media-overflow-dropdown-trigger';
+var isMediaSelection = function isMediaSelection(selection, nodeType) {
+  if (selection instanceof NodeSelection) {
+    return nodeType.includes(selection.node.type);
+  }
+  return false;
+};
 export var floatingToolbar = function floatingToolbar(state, intl) {
   var _pluginInjectionApi$d3, _pluginInjectionApi$d4;
   var options = arguments.length > 2 && arguments[2] !== undefined ? arguments[2] : {};
@@ -706,6 +713,11 @@ export var floatingToolbar = function floatingToolbar(state, intl) {
   }
   var nodeType = allowMediaInline ? [mediaInline, mediaSingle, media] : [mediaSingle];
   var isSelectedNodeMediaSingle = state.selection instanceof NodeSelection && state.selection.node.type === mediaSingle;
+  if (expValEquals('platform_editor_media_floating_toolbar_early_exit', 'isEnabled', true)) {
+    if (!isMediaSelection(state.selection, nodeType)) {
+      return;
+    }
+  }
   var baseToolbar = {
     title: 'Media floating controls',
     nodeType: nodeType,

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-plugin-media",
-	"version": "5.1.4",
+	"version": "5.1.5",
 	"description": "Media plugin for @atlaskit/editor-core",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",
@@ -33,7 +33,7 @@
 		"./types": "./src/types/index.ts"
 	},
 	"dependencies": {
-		"@atlaskit/adf-schema": "^47.6.0",
+		"@atlaskit/adf-schema": "^49.0.5",
 		"@atlaskit/analytics-namespaced-context": "^7.0.0",
 		"@atlaskit/analytics-next": "^11.1.0",
 		"@atlaskit/button": "^23.2.0",
@@ -69,8 +69,8 @@
 		"@atlaskit/primitives": "^14.10.0",
 		"@atlaskit/textfield": "^8.0.0",
 		"@atlaskit/theme": "^19.0.0",
-		"@atlaskit/tmp-editor-statsig": "^9.2.0",
-		"@atlaskit/tokens": "^5.4.0",
+		"@atlaskit/tmp-editor-statsig": "^9.5.0",
+		"@atlaskit/tokens": "^5.5.0",
 		"@atlaskit/tooltip": "^20.3.0",
 		"@babel/runtime": "^7.0.0",
 		"@emotion/react": "^11.7.1",