@atlaskit/editor-plugin-media 10.0.8 → 10.0.10

package/CHANGELOG.md

@@ -1,5 +1,19 @@
 # @atlaskit/editor-plugin-media
 
+## 10.0.10
+
+### Patch Changes
+
+- [`46ff42199054d`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/46ff42199054d) -
+  Cleans up experiment platform_editor_eslint_suppression_fix
+- Updated dependencies
+
+## 10.0.9
+
+### Patch Changes
+
+- Updated dependencies
+
 ## 10.0.8
 
 ### Patch Changes

package/dist/cjs/nodeviews/mediaSingleNext.js

@@ -448,9 +448,6 @@ var MediaSingleNodeNext = exports.MediaSingleNodeNext = function MediaSingleNode
     (_captionPlaceHolderRe = captionPlaceHolderRef.current) === null || _captionPlaceHolderRe === void 0 || _captionPlaceHolderRe.click();
   }, [mediaSingleWrapperRef, captionPlaceHolderRef]);
   var onMediaSingleKeyDown = _react.default.useCallback(function (event) {
-    if (!(0, _expValEquals.expValEquals)('platform_editor_eslint_suppression_fix', 'isEnabled', true)) {
-      return;
-    }
     if (mediaSingleWrapperRef.current !== event.target) {
       return;
     }
@@ -479,7 +476,7 @@ var MediaSingleNodeNext = exports.MediaSingleNodeNext = function MediaSingleNode
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-classname-prop -- Ignored via go/DSP-18766
     ,
     className: _styles.MediaSingleNodeSelector,
-    onClick: notIos && (0, _expValEquals.expValEquals)('platform_editor_eslint_suppression_fix', 'isEnabled', true) ? undefined : onMediaSingleClicked,
+    onClick: notIos ? undefined : onMediaSingleClicked,
     onKeyDown: notIos ? undefined : onMediaSingleKeyDown
   }, (0, _react2.jsx)(_mediaSingle.MediaBadges, {
     mediaElement: currentMediaElement(),

package/dist/cjs/ui/ImageBorder/index.js

@@ -144,9 +144,9 @@ var ImageBorder = function ImageBorder(_ref) {
       type: "button",
       "aria-label": formatMessage(_media.imageBorderMessages.borderColorDropdownAriaLabel),
       "data-testid": "image-border-dropdown-button-color",
-      css: (0, _expValEquals.expValEquals)('platform_editor_fix_media_toolbar_border_dropdown', 'isEnabled', true, false) ? dropdownOptionButtonNew
+      css: (0, _expValEquals.expValEquals)('platform_editor_fix_media_toolbar_border_dropdown', 'isEnabled', true, false) ? dropdownOptionButtonNew :
       // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values, @atlaskit/design-system/consistent-css-prop-usage -- Ignored via go/DSP-18766
-      : _styles2.dropdownOptionButton,
+      _styles2.dropdownOptionButton,
       "aria-expanded": isColorSubmenuOpen,
       onKeyDown: function onKeyDown(e) {
         return handleTriggerByKeyboard(e, function () {
@@ -210,9 +210,9 @@ var ImageBorder = function ImageBorder(_ref) {
       type: "button",
       "aria-label": formatMessage(_media.imageBorderMessages.borderSizeDropdownAriaLabel),
       "data-testid": "image-border-dropdown-button-size",
-      css: (0, _expValEquals.expValEquals)('platform_editor_fix_media_toolbar_border_dropdown', 'isEnabled', true, false) ? dropdownOptionButtonNew
+      css: (0, _expValEquals.expValEquals)('platform_editor_fix_media_toolbar_border_dropdown', 'isEnabled', true, false) ? dropdownOptionButtonNew :
       // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values, @atlaskit/design-system/consistent-css-prop-usage -- Ignored via go/DSP-18766
-      : _styles2.dropdownOptionButton,
+      _styles2.dropdownOptionButton,
       "aria-expanded": isSizeSubmenuOpen,
       ref: dropDownSizeOptionButton,
       onKeyDown: function onKeyDown(e) {
@@ -357,11 +357,7 @@ var ImageBorder = function ImageBorder(_ref) {
     forcePlacement: true,
     stick: true
   }, (0, _react2.jsx)("div", {
-    onMouseLeave: (0, _expValEquals.expValEquals)('platform_editor_eslint_suppression_fix', 'isEnabled', true) ? undefined : function () {
-      setIsColorSubmenuOpen(false);
-      setIsSizeSubmenuOpen(false);
-    }
-    /* eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values, @atlaskit/design-system/consistent-css-prop-usage -- Ignored via go/DSP-18766 */,
+    /* eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values, @atlaskit/design-system/consistent-css-prop-usage -- Ignored via go/DSP-18766 */
     css: _styles2.dropdownWrapper
   }, (0, _react2.jsx)(_uiMenu.DropdownMenu
   //This needs be removed when the a11y is completely handled

package/dist/cjs/ui/MediaViewer/MediaViewerContainer.js

@@ -9,7 +9,6 @@ exports.MediaViewerContainer = void 0;
 var _slicedToArray2 = _interopRequireDefault(require("@babel/runtime/helpers/slicedToArray"));
 var _react = _interopRequireWildcard(require("react"));
 var _react2 = require("@emotion/react");
-var _expValEquals = require("@atlaskit/tmp-editor-statsig/exp-val-equals");
 var _experiments = require("@atlaskit/tmp-editor-statsig/experiments");
 var _isType = require("../../pm-plugins/utils/is-type");
 var _utils = require("../../ui/toolbar/utils");
@@ -54,22 +53,16 @@ var MediaViewerContainer = exports.MediaViewerContainer = function MediaViewerCo
   };
   var isVideoMedia = (0, _isType.isVideo)((_mediaNode$firstChild = mediaNode.firstChild) === null || _mediaNode$firstChild === void 0 ? void 0 : _mediaNode$firstChild.attrs.__fileMimeType);
   var shouldShowViewer = isEditorViewMode && showViewer && selectedNodeAttrs && mediaClientConfig && !isVideoMedia && (0, _experiments.editorExperiment)('platform_editor_controls', 'control');
-  return (0, _react2.jsx)(_react.Fragment, null, isEditorViewMode ? (0, _react2.jsx)(_react.Fragment, null, isInline ?
-  // remove eslint disable when platform_editor_eslint_suppression_fix has been cleaned up
-  // eslint-disable-next-line @atlassian/a11y/click-events-have-key-events, @atlassian/a11y/interactive-element-not-keyboard-focusable, @atlassian/a11y/no-static-element-interactions
-  (0, _react2.jsx)("span", {
+  return (0, _react2.jsx)(_react.Fragment, null, isEditorViewMode ? (0, _react2.jsx)(_react.Fragment, null, isInline ? (0, _react2.jsx)("span", {
     onClick: showMediaViewer,
     css: interactiveStyles,
     "data-testid": mediaViewerContainerTestID,
-    role: (0, _expValEquals.expValEquals)('platform_editor_eslint_suppression_fix', 'isEnabled', true) ? 'none' : undefined
-  }, children) :
-  // remove eslint disable when platform_editor_eslint_suppression_fix has been cleaned up
-  // eslint-disable-next-line @atlassian/a11y/click-events-have-key-events, @atlassian/a11y/interactive-element-not-keyboard-focusable, @atlassian/a11y/no-static-element-interactions
-  (0, _react2.jsx)("div", {
+    role: "none"
+  }, children) : (0, _react2.jsx)("div", {
     onClick: showMediaViewer,
     css: interactiveStyles,
     "data-testid": mediaViewerContainerTestID,
-    role: (0, _expValEquals.expValEquals)('platform_editor_eslint_suppression_fix', 'isEnabled', true) ? 'none' : undefined
+    role: "none"
   }, children), shouldShowViewer && (0, _react2.jsx)(_PortalWrapper.RenderMediaViewer, {
     selectedNodeAttrs: selectedNodeAttrs,
     mediaClientConfig: mediaClientConfig,

package/dist/es2019/nodeviews/mediaSingleNext.js

@@ -408,9 +408,6 @@ export const MediaSingleNodeNext = mediaSingleNodeNextProps => {
     (_captionPlaceHolderRe = captionPlaceHolderRef.current) === null || _captionPlaceHolderRe === void 0 ? void 0 : _captionPlaceHolderRe.click();
   }, [mediaSingleWrapperRef, captionPlaceHolderRef]);
   const onMediaSingleKeyDown = React.useCallback(event => {
-    if (!expValEquals('platform_editor_eslint_suppression_fix', 'isEnabled', true)) {
-      return;
-    }
     if (mediaSingleWrapperRef.current !== event.target) {
       return;
     }
@@ -439,7 +436,7 @@ export const MediaSingleNodeNext = mediaSingleNodeNextProps => {
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-classname-prop -- Ignored via go/DSP-18766
     ,
     className: MediaSingleNodeSelector,
-    onClick: notIos && expValEquals('platform_editor_eslint_suppression_fix', 'isEnabled', true) ? undefined : onMediaSingleClicked,
+    onClick: notIos ? undefined : onMediaSingleClicked,
     onKeyDown: notIos ? undefined : onMediaSingleKeyDown
   }, jsx(MediaBadges, {
     mediaElement: currentMediaElement(),

package/dist/es2019/ui/ImageBorder/index.js

@@ -126,9 +126,9 @@ const ImageBorder = ({
       type: "button",
       "aria-label": formatMessage(messages.borderColorDropdownAriaLabel),
       "data-testid": "image-border-dropdown-button-color",
-      css: expValEquals('platform_editor_fix_media_toolbar_border_dropdown', 'isEnabled', true, false) ? dropdownOptionButtonNew
+      css: expValEquals('platform_editor_fix_media_toolbar_border_dropdown', 'isEnabled', true, false) ? dropdownOptionButtonNew :
       // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values, @atlaskit/design-system/consistent-css-prop-usage -- Ignored via go/DSP-18766
-      : dropdownOptionButton,
+      dropdownOptionButton,
       "aria-expanded": isColorSubmenuOpen,
       onKeyDown: e => handleTriggerByKeyboard(e, () => setIsColorSubmenuOpen(!isColorSubmenuOpen))
     }, jsx(Text, null, formatMessage(messages.borderColor)), jsx("div", {
@@ -188,9 +188,9 @@ const ImageBorder = ({
       type: "button",
       "aria-label": formatMessage(messages.borderSizeDropdownAriaLabel),
       "data-testid": "image-border-dropdown-button-size",
-      css: expValEquals('platform_editor_fix_media_toolbar_border_dropdown', 'isEnabled', true, false) ? dropdownOptionButtonNew
+      css: expValEquals('platform_editor_fix_media_toolbar_border_dropdown', 'isEnabled', true, false) ? dropdownOptionButtonNew :
       // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values, @atlaskit/design-system/consistent-css-prop-usage -- Ignored via go/DSP-18766
-      : dropdownOptionButton,
+      dropdownOptionButton,
       "aria-expanded": isSizeSubmenuOpen,
       ref: dropDownSizeOptionButton,
       onKeyDown: e => handleTriggerByKeyboard(e, () => setIsSizeSubmenuOpen(!isSizeSubmenuOpen))
@@ -328,11 +328,7 @@ const ImageBorder = ({
     forcePlacement: true,
     stick: true
   }, jsx("div", {
-    onMouseLeave: expValEquals('platform_editor_eslint_suppression_fix', 'isEnabled', true) ? undefined : () => {
-      setIsColorSubmenuOpen(false);
-      setIsSizeSubmenuOpen(false);
-    }
-    /* eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values, @atlaskit/design-system/consistent-css-prop-usage -- Ignored via go/DSP-18766 */,
+    /* eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values, @atlaskit/design-system/consistent-css-prop-usage -- Ignored via go/DSP-18766 */
     css: dropdownWrapper
   }, jsx(DropdownMenu
   //This needs be removed when the a11y is completely handled

package/dist/es2019/ui/MediaViewer/MediaViewerContainer.js

@@ -6,7 +6,6 @@ import React, { Fragment, useEffect, useState } from 'react';
 
 // eslint-disable-next-line @atlaskit/ui-styling-standard/use-compiled, @typescript-eslint/consistent-type-imports
 import { css, jsx } from '@emotion/react';
-import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 import { editorExperiment } from '@atlaskit/tmp-editor-statsig/experiments';
 import { isVideo } from '../../pm-plugins/utils/is-type';
 import { getSelectedNearestMediaContainerNodeAttrsFunction } from '../../ui/toolbar/utils';
@@ -38,22 +37,16 @@ export const MediaViewerContainer = ({
   };
   const isVideoMedia = isVideo((_mediaNode$firstChild = mediaNode.firstChild) === null || _mediaNode$firstChild === void 0 ? void 0 : _mediaNode$firstChild.attrs.__fileMimeType);
   const shouldShowViewer = isEditorViewMode && showViewer && selectedNodeAttrs && mediaClientConfig && !isVideoMedia && editorExperiment('platform_editor_controls', 'control');
-  return jsx(Fragment, null, isEditorViewMode ? jsx(Fragment, null, isInline ?
-  // remove eslint disable when platform_editor_eslint_suppression_fix has been cleaned up
-  // eslint-disable-next-line @atlassian/a11y/click-events-have-key-events, @atlassian/a11y/interactive-element-not-keyboard-focusable, @atlassian/a11y/no-static-element-interactions
-  jsx("span", {
+  return jsx(Fragment, null, isEditorViewMode ? jsx(Fragment, null, isInline ? jsx("span", {
     onClick: showMediaViewer,
     css: interactiveStyles,
     "data-testid": mediaViewerContainerTestID,
-    role: expValEquals('platform_editor_eslint_suppression_fix', 'isEnabled', true) ? 'none' : undefined
-  }, children) :
-  // remove eslint disable when platform_editor_eslint_suppression_fix has been cleaned up
-  // eslint-disable-next-line @atlassian/a11y/click-events-have-key-events, @atlassian/a11y/interactive-element-not-keyboard-focusable, @atlassian/a11y/no-static-element-interactions
-  jsx("div", {
+    role: "none"
+  }, children) : jsx("div", {
     onClick: showMediaViewer,
     css: interactiveStyles,
     "data-testid": mediaViewerContainerTestID,
-    role: expValEquals('platform_editor_eslint_suppression_fix', 'isEnabled', true) ? 'none' : undefined
+    role: "none"
   }, children), shouldShowViewer && jsx(RenderMediaViewer, {
     selectedNodeAttrs: selectedNodeAttrs,
     mediaClientConfig: mediaClientConfig,

package/dist/esm/nodeviews/mediaSingleNext.js

@@ -442,9 +442,6 @@ export var MediaSingleNodeNext = function MediaSingleNodeNext(mediaSingleNodeNex
     (_captionPlaceHolderRe = captionPlaceHolderRef.current) === null || _captionPlaceHolderRe === void 0 || _captionPlaceHolderRe.click();
   }, [mediaSingleWrapperRef, captionPlaceHolderRef]);
   var onMediaSingleKeyDown = React.useCallback(function (event) {
-    if (!expValEquals('platform_editor_eslint_suppression_fix', 'isEnabled', true)) {
-      return;
-    }
     if (mediaSingleWrapperRef.current !== event.target) {
       return;
     }
@@ -473,7 +470,7 @@ export var MediaSingleNodeNext = function MediaSingleNodeNext(mediaSingleNodeNex
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-classname-prop -- Ignored via go/DSP-18766
     ,
     className: MediaSingleNodeSelector,
-    onClick: notIos && expValEquals('platform_editor_eslint_suppression_fix', 'isEnabled', true) ? undefined : onMediaSingleClicked,
+    onClick: notIos ? undefined : onMediaSingleClicked,
     onKeyDown: notIos ? undefined : onMediaSingleKeyDown
   }, jsx(MediaBadges, {
     mediaElement: currentMediaElement(),

package/dist/esm/ui/ImageBorder/index.js

@@ -136,9 +136,9 @@ var ImageBorder = function ImageBorder(_ref) {
       type: "button",
       "aria-label": formatMessage(messages.borderColorDropdownAriaLabel),
       "data-testid": "image-border-dropdown-button-color",
-      css: expValEquals('platform_editor_fix_media_toolbar_border_dropdown', 'isEnabled', true, false) ? dropdownOptionButtonNew
+      css: expValEquals('platform_editor_fix_media_toolbar_border_dropdown', 'isEnabled', true, false) ? dropdownOptionButtonNew :
       // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values, @atlaskit/design-system/consistent-css-prop-usage -- Ignored via go/DSP-18766
-      : dropdownOptionButton,
+      dropdownOptionButton,
       "aria-expanded": isColorSubmenuOpen,
       onKeyDown: function onKeyDown(e) {
         return handleTriggerByKeyboard(e, function () {
@@ -202,9 +202,9 @@ var ImageBorder = function ImageBorder(_ref) {
       type: "button",
       "aria-label": formatMessage(messages.borderSizeDropdownAriaLabel),
       "data-testid": "image-border-dropdown-button-size",
-      css: expValEquals('platform_editor_fix_media_toolbar_border_dropdown', 'isEnabled', true, false) ? dropdownOptionButtonNew
+      css: expValEquals('platform_editor_fix_media_toolbar_border_dropdown', 'isEnabled', true, false) ? dropdownOptionButtonNew :
       // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values, @atlaskit/design-system/consistent-css-prop-usage -- Ignored via go/DSP-18766
-      : dropdownOptionButton,
+      dropdownOptionButton,
       "aria-expanded": isSizeSubmenuOpen,
       ref: dropDownSizeOptionButton,
       onKeyDown: function onKeyDown(e) {
@@ -349,11 +349,7 @@ var ImageBorder = function ImageBorder(_ref) {
     forcePlacement: true,
     stick: true
   }, jsx("div", {
-    onMouseLeave: expValEquals('platform_editor_eslint_suppression_fix', 'isEnabled', true) ? undefined : function () {
-      setIsColorSubmenuOpen(false);
-      setIsSizeSubmenuOpen(false);
-    }
-    /* eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values, @atlaskit/design-system/consistent-css-prop-usage -- Ignored via go/DSP-18766 */,
+    /* eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values, @atlaskit/design-system/consistent-css-prop-usage -- Ignored via go/DSP-18766 */
     css: dropdownWrapper
   }, jsx(DropdownMenu
   //This needs be removed when the a11y is completely handled

package/dist/esm/ui/MediaViewer/MediaViewerContainer.js

@@ -7,7 +7,6 @@ import React, { Fragment, useEffect, useState } from 'react';
 
 // eslint-disable-next-line @atlaskit/ui-styling-standard/use-compiled, @typescript-eslint/consistent-type-imports
 import { css, jsx } from '@emotion/react';
-import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 import { editorExperiment } from '@atlaskit/tmp-editor-statsig/experiments';
 import { isVideo } from '../../pm-plugins/utils/is-type';
 import { getSelectedNearestMediaContainerNodeAttrsFunction } from '../../ui/toolbar/utils';
@@ -44,22 +43,16 @@ export var MediaViewerContainer = function MediaViewerContainer(_ref) {
   };
   var isVideoMedia = isVideo((_mediaNode$firstChild = mediaNode.firstChild) === null || _mediaNode$firstChild === void 0 ? void 0 : _mediaNode$firstChild.attrs.__fileMimeType);
   var shouldShowViewer = isEditorViewMode && showViewer && selectedNodeAttrs && mediaClientConfig && !isVideoMedia && editorExperiment('platform_editor_controls', 'control');
-  return jsx(Fragment, null, isEditorViewMode ? jsx(Fragment, null, isInline ?
-  // remove eslint disable when platform_editor_eslint_suppression_fix has been cleaned up
-  // eslint-disable-next-line @atlassian/a11y/click-events-have-key-events, @atlassian/a11y/interactive-element-not-keyboard-focusable, @atlassian/a11y/no-static-element-interactions
-  jsx("span", {
+  return jsx(Fragment, null, isEditorViewMode ? jsx(Fragment, null, isInline ? jsx("span", {
     onClick: showMediaViewer,
     css: interactiveStyles,
     "data-testid": mediaViewerContainerTestID,
-    role: expValEquals('platform_editor_eslint_suppression_fix', 'isEnabled', true) ? 'none' : undefined
-  }, children) :
-  // remove eslint disable when platform_editor_eslint_suppression_fix has been cleaned up
-  // eslint-disable-next-line @atlassian/a11y/click-events-have-key-events, @atlassian/a11y/interactive-element-not-keyboard-focusable, @atlassian/a11y/no-static-element-interactions
-  jsx("div", {
+    role: "none"
+  }, children) : jsx("div", {
     onClick: showMediaViewer,
     css: interactiveStyles,
     "data-testid": mediaViewerContainerTestID,
-    role: expValEquals('platform_editor_eslint_suppression_fix', 'isEnabled', true) ? 'none' : undefined
+    role: "none"
   }, children), shouldShowViewer && jsx(RenderMediaViewer, {
     selectedNodeAttrs: selectedNodeAttrs,
     mediaClientConfig: mediaClientConfig,

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-plugin-media",
-	"version": "10.0.8",
+	"version": "10.0.10",
 	"description": "Media plugin for @atlaskit/editor-core",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",
@@ -66,7 +66,7 @@
 		"@atlaskit/primitives": "^18.0.0",
 		"@atlaskit/textfield": "^8.2.0",
 		"@atlaskit/theme": "^22.0.0",
-		"@atlaskit/tmp-editor-statsig": "^40.6.0",
+		"@atlaskit/tmp-editor-statsig": "^42.0.0",
 		"@atlaskit/tokens": "^11.1.0",
 		"@atlaskit/tooltip": "^21.0.0",
 		"@babel/runtime": "^7.0.0",
@@ -78,7 +78,7 @@
 		"uuid": "^3.1.0"
 	},
 	"peerDependencies": {
-		"@atlaskit/editor-common": "^112.6.0",
+		"@atlaskit/editor-common": "^112.7.0",
 		"@atlaskit/media-core": "^37.0.0",
 		"react": "^18.2.0",
 		"react-dom": "^18.2.0",