@atlaskit/editor-plugin-media 1.37.2 → 1.37.3

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # @atlaskit/editor-plugin-media
 
+## 1.37.3
+
+### Patch Changes
+
+- [#156556](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/156556)
+  [`fa4db989cfa70`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/fa4db989cfa70) -
+  [HOT-112603] Reduce memory leak footage by using WeakRef to store HTML element
+
 ## 1.37.2
 
 ### Patch Changes

package/dist/cjs/pm-plugins/main.js

@@ -740,7 +740,6 @@ var getMediaPluginState = exports.getMediaPluginState = function getMediaPluginS
 };
 var createPlugin = exports.createPlugin = function createPlugin(_schema, options, getIntl, pluginInjectionApi, dispatch, mediaOptions, newInsertionBehaviour) {
   var intl = getIntl();
-  var dropPlaceholder = createDropPlaceholder(intl, mediaOptions && mediaOptions.allowDropzoneDropLine);
   return new _safePlugin.SafePlugin({
     state: {
       init: function init(_config, state) {
@@ -882,8 +881,15 @@ var createPlugin = exports.createPlugin = function createPlugin(_schema, options
         if (pos === null || pos === undefined) {
           return _view2.DecorationSet.create(state.doc, mediaNodes);
         }
-        var dropPlaceholders = [_view2.Decoration.widget(pos, dropPlaceholder, {
-          key: 'drop-placeholder'
+        var dropPlaceholders = [_view2.Decoration.widget(pos, function () {
+          return createDropPlaceholder(intl, mediaOptions && mediaOptions.allowDropzoneDropLine);
+        }, {
+          key: 'drop-placeholder',
+          destroy: function destroy(elem) {
+            if (elem instanceof HTMLElement) {
+              _reactDom.default.unmountComponentAtNode(elem);
+            }
+          }
         })].concat(mediaNodes);
         return _view2.DecorationSet.create(state.doc, dropPlaceholders);
       },

package/dist/es2019/pm-plugins/main.js

@@ -625,7 +625,6 @@ export class MediaPluginStateImplementation {
 export const getMediaPluginState = state => stateKey.getState(state);
 export const createPlugin = (_schema, options, getIntl, pluginInjectionApi, dispatch, mediaOptions, newInsertionBehaviour) => {
   const intl = getIntl();
-  const dropPlaceholder = createDropPlaceholder(intl, mediaOptions && mediaOptions.allowDropzoneDropLine);
   return new SafePlugin({
     state: {
       init(_config, state) {
@@ -764,8 +763,15 @@ export const createPlugin = (_schema, options, getIntl, pluginInjectionApi, disp
         if (pos === null || pos === undefined) {
           return DecorationSet.create(state.doc, mediaNodes);
         }
-        const dropPlaceholders = [Decoration.widget(pos, dropPlaceholder, {
-          key: 'drop-placeholder'
+        const dropPlaceholders = [Decoration.widget(pos, () => {
+          return createDropPlaceholder(intl, mediaOptions && mediaOptions.allowDropzoneDropLine);
+        }, {
+          key: 'drop-placeholder',
+          destroy: elem => {
+            if (elem instanceof HTMLElement) {
+              ReactDOM.unmountComponentAtNode(elem);
+            }
+          }
         }), ...mediaNodes];
         return DecorationSet.create(state.doc, dropPlaceholders);
       },

package/dist/esm/pm-plugins/main.js

@@ -725,7 +725,6 @@ export var getMediaPluginState = function getMediaPluginState(state) {
 };
 export var createPlugin = function createPlugin(_schema, options, getIntl, pluginInjectionApi, dispatch, mediaOptions, newInsertionBehaviour) {
   var intl = getIntl();
-  var dropPlaceholder = createDropPlaceholder(intl, mediaOptions && mediaOptions.allowDropzoneDropLine);
   return new SafePlugin({
     state: {
       init: function init(_config, state) {
@@ -867,8 +866,15 @@ export var createPlugin = function createPlugin(_schema, options, getIntl, plugi
         if (pos === null || pos === undefined) {
           return DecorationSet.create(state.doc, mediaNodes);
         }
-        var dropPlaceholders = [Decoration.widget(pos, dropPlaceholder, {
-          key: 'drop-placeholder'
+        var dropPlaceholders = [Decoration.widget(pos, function () {
+          return createDropPlaceholder(intl, mediaOptions && mediaOptions.allowDropzoneDropLine);
+        }, {
+          key: 'drop-placeholder',
+          destroy: function destroy(elem) {
+            if (elem instanceof HTMLElement) {
+              ReactDOM.unmountComponentAtNode(elem);
+            }
+          }
         })].concat(mediaNodes);
         return DecorationSet.create(state.doc, dropPlaceholders);
       },

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-plugin-media",
-	"version": "1.37.2",
+	"version": "1.37.3",
 	"description": "Media plugin for @atlaskit/editor-core",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",
@@ -36,7 +36,7 @@
 		"@atlaskit/analytics-namespaced-context": "^6.12.0",
 		"@atlaskit/analytics-next": "^10.1.0",
 		"@atlaskit/button": "^20.3.0",
-		"@atlaskit/editor-common": "^94.2.0",
+		"@atlaskit/editor-common": "^94.3.0",
 		"@atlaskit/editor-palette": "1.6.2",
 		"@atlaskit/editor-plugin-analytics": "^1.10.0",
 		"@atlaskit/editor-plugin-annotation": "1.21.3",
@@ -57,7 +57,7 @@
 		"@atlaskit/media-card": "^78.8.0",
 		"@atlaskit/media-client": "^28.0.0",
 		"@atlaskit/media-client-react": "^2.2.0",
-		"@atlaskit/media-common": "^11.6.0",
+		"@atlaskit/media-common": "^11.7.0",
 		"@atlaskit/media-filmstrip": "^47.4.0",
 		"@atlaskit/media-picker": "^66.7.0",
 		"@atlaskit/media-ui": "^25.16.0",
@@ -66,7 +66,7 @@
 		"@atlaskit/primitives": "^12.2.0",
 		"@atlaskit/textfield": "^6.5.0",
 		"@atlaskit/theme": "^14.0.0",
-		"@atlaskit/tmp-editor-statsig": "^2.8.0",
+		"@atlaskit/tmp-editor-statsig": "^2.9.0",
 		"@atlaskit/tokens": "^2.0.0",
 		"@atlaskit/tooltip": "^18.8.0",
 		"@babel/runtime": "^7.0.0",