@atlaskit/editor-plugin-media 1.31.6 → 1.31.7

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/CHANGELOG.md CHANGED
@@ -1,5 +1,14 @@
1
1
  # @atlaskit/editor-plugin-media
2
2
 
3
+ ## 1.31.7
4
+
5
+ ### Patch Changes
6
+
7
+ - [#140707](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/140707)
8
+ [`972fb840acf35`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/972fb840acf35) -
9
+ Switch from fg to experiment for media-from-url
10
+ - Updated dependencies
11
+
3
12
  ## 1.31.6
4
13
 
5
14
  ### Patch Changes
@@ -30,6 +30,7 @@ var _utils2 = require("@atlaskit/editor-prosemirror/utils");
30
30
  var _cellSelection = require("@atlaskit/editor-tables/cell-selection");
31
31
  var _mediaClient = require("@atlaskit/media-client");
32
32
  var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
33
+ var _experiments = require("@atlaskit/tmp-editor-statsig/experiments");
33
34
  var _captions = require("../commands/captions");
34
35
  var _main = require("../pm-plugins/main");
35
36
  var _CaptionPlaceholder = _interopRequireDefault(require("../ui/CaptionPlaceholder"));
@@ -466,7 +467,7 @@ var MediaSingleNode = exports.default = /*#__PURE__*/function (_Component) {
466
467
  ,
467
468
  className: _styles.MediaSingleNodeSelector,
468
469
  onClick: this.onMediaSingleClicked
469
- }, (0, _platformFeatureFlags.fg)('platform_editor_insert_media_plugin_phase_one') && (0, _react2.jsx)(_mediaSingle.MediaBadges, {
470
+ }, (0, _experiments.editorExperiment)('add-media-from-url', true) && (0, _react2.jsx)(_mediaSingle.MediaBadges, {
470
471
  mediaElement: currentMediaElement(),
471
472
  mediaHeight: height,
472
473
  mediaWidth: width,
@@ -483,7 +484,7 @@ var MediaSingleNode = exports.default = /*#__PURE__*/function (_Component) {
483
484
  isDrafting: isCurrentNodeDrafting,
484
485
  badgeSize: badgeSize
485
486
  }));
486
- }), !(0, _platformFeatureFlags.fg)('platform_editor_insert_media_plugin_phase_one') && commentsOnMedia && (0, _react2.jsx)(_CommentBadge.CommentBadge, {
487
+ }), !(0, _experiments.editorExperiment)('add-media-from-url', true) && commentsOnMedia && (0, _react2.jsx)(_CommentBadge.CommentBadge, {
487
488
  commentsOnMediaBugFixEnabled: mediaOptions === null || mediaOptions === void 0 || (_mediaOptions$getEdit2 = mediaOptions.getEditorFeatureFlags) === null || _mediaOptions$getEdit2 === void 0 || (_mediaOptions$getEdit2 = _mediaOptions$getEdit2.call(mediaOptions)) === null || _mediaOptions$getEdit2 === void 0 ? void 0 : _mediaOptions$getEdit2.commentsOnMediaBugFix,
488
489
  view: view,
489
490
  api: pluginInjectionApi,
@@ -32,6 +32,7 @@ var _utils2 = require("@atlaskit/editor-prosemirror/utils");
32
32
  var _view2 = require("@atlaskit/editor-prosemirror/view");
33
33
  var _cellSelection = require("@atlaskit/editor-tables/cell-selection");
34
34
  var _mediaCommon = require("@atlaskit/media-common");
35
+ var _experiments = require("@atlaskit/tmp-editor-statsig/experiments");
35
36
  var _helpers = _interopRequireWildcard(require("../commands/helpers"));
36
37
  var helpers = _helpers;
37
38
  var _pickerFacade = _interopRequireDefault(require("../picker-facade"));
@@ -211,6 +212,9 @@ var MediaPluginStateImplementation = exports.MediaPluginStateImplementation = /*
211
212
  });
212
213
  (0, _defineProperty2.default)(this, "showMediaPicker", function () {
213
214
  if (_this.openMediaPickerBrowser) {
215
+ (0, _experiments.editorExperiment)('add-media-from-url', false, {
216
+ exposure: true
217
+ });
214
218
  return _this.openMediaPickerBrowser();
215
219
  }
216
220
  _this.onPopupToggleCallback(true);
@@ -87,7 +87,7 @@ var CommentBadge = exports.CommentBadge = (0, _reactIntlNext.injectIntl)(Comment
87
87
  /**
88
88
  * Remove CommentBadgeWrapper component above
89
89
  * and rename CommentBadgeNextWrapper to CommentBadgeWrapper
90
- * when clean up platform_editor_insert_media_plugin_phase_one feature flag
90
+ * when clean up platform_editor_add_media_from_url feature flag
91
91
  */
92
92
 
93
93
  var CommentBadgeNextWrapper = exports.CommentBadgeNextWrapper = function CommentBadgeNextWrapper(_ref2) {
@@ -16,6 +16,7 @@ var _model = require("@atlaskit/editor-prosemirror/model");
16
16
  var _state = require("@atlaskit/editor-prosemirror/state");
17
17
  var _utils2 = require("@atlaskit/editor-prosemirror/utils");
18
18
  var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
19
+ var _experiments = require("@atlaskit/tmp-editor-statsig/experiments");
19
20
  var _mediaCommon = require("../utils/media-common");
20
21
  var _analytics2 = require("./analytics");
21
22
  var _isType = require("./is-type");
@@ -94,7 +95,7 @@ var insertMediaAsMediaSingle = exports.insertMediaAsMediaSingle = function inser
94
95
  return false;
95
96
  }
96
97
  var resizeExperience = (0, _platformFeatureFlags.fg)('platform.editor.media.extended-resize-experience');
97
- var insertMediaPopup = (0, _platformFeatureFlags.fg)('platform_editor_insert_media_plugin_phase_one');
98
+ var insertMediaPopup = (0, _experiments.editorExperiment)('add-media-from-url', true);
98
99
  var mediaSingleAttrs = resizeExperience && insertMediaPopup ? {
99
100
  widthType: 'pixel',
100
101
  width: (0, _mediaSingle.getMediaSingleInitialWidth)((_node$attrs$width = node.attrs.width) !== null && _node$attrs$width !== void 0 ? _node$attrs$width : _mediaSingle.DEFAULT_IMAGE_WIDTH),
@@ -11,8 +11,7 @@ import React, { Component, Fragment, useMemo } from 'react';
11
11
  // eslint-disable-next-line @atlaskit/ui-styling-standard/use-compiled -- Ignored via go/DSP-18766
12
12
  import { css, jsx } from '@emotion/react';
13
13
  import { useSharedPluginState } from '@atlaskit/editor-common/hooks';
14
- import { calcMediaSinglePixelWidth, DEFAULT_IMAGE_HEIGHT, DEFAULT_IMAGE_WIDTH, getMaxWidthForNestedNode, MEDIA_SINGLE_GUTTER_SIZE } from '@atlaskit/editor-common/media-single';
15
- import { ExternalImageBadge, MediaBadges } from '@atlaskit/editor-common/media-single';
14
+ import { calcMediaSinglePixelWidth, DEFAULT_IMAGE_HEIGHT, DEFAULT_IMAGE_WIDTH, ExternalImageBadge, getMaxWidthForNestedNode, MEDIA_SINGLE_GUTTER_SIZE, MediaBadges } from '@atlaskit/editor-common/media-single';
16
15
  import { WithProviders } from '@atlaskit/editor-common/provider-factory';
17
16
  import ReactNodeView from '@atlaskit/editor-common/react-node-view';
18
17
  import { MediaSingle } from '@atlaskit/editor-common/ui';
@@ -22,6 +21,7 @@ import { findParentNodeOfTypeClosestToPos } from '@atlaskit/editor-prosemirror/u
22
21
  import { CellSelection } from '@atlaskit/editor-tables/cell-selection';
23
22
  import { getAttrsFromUrl } from '@atlaskit/media-client';
24
23
  import { fg } from '@atlaskit/platform-feature-flags';
24
+ import { editorExperiment } from '@atlaskit/tmp-editor-statsig/experiments';
25
25
  import { insertAndSelectCaptionFromMediaSinglePos } from '../commands/captions';
26
26
  import { MEDIA_CONTENT_WRAP_CLASS_NAME } from '../pm-plugins/main';
27
27
  import CaptionPlaceholder from '../ui/CaptionPlaceholder';
@@ -384,7 +384,7 @@ export default class MediaSingleNode extends Component {
384
384
  ,
385
385
  className: MediaSingleNodeSelector,
386
386
  onClick: this.onMediaSingleClicked
387
- }, fg('platform_editor_insert_media_plugin_phase_one') && jsx(MediaBadges, {
387
+ }, editorExperiment('add-media-from-url', true) && jsx(MediaBadges, {
388
388
  mediaElement: currentMediaElement(),
389
389
  mediaHeight: height,
390
390
  mediaWidth: width,
@@ -400,7 +400,7 @@ export default class MediaSingleNode extends Component {
400
400
  getPos: getPos,
401
401
  isDrafting: isCurrentNodeDrafting,
402
402
  badgeSize: badgeSize
403
- }))), !fg('platform_editor_insert_media_plugin_phase_one') && commentsOnMedia && jsx(CommentBadge, {
403
+ }))), !editorExperiment('add-media-from-url', true) && commentsOnMedia && jsx(CommentBadge, {
404
404
  commentsOnMediaBugFixEnabled: mediaOptions === null || mediaOptions === void 0 ? void 0 : (_mediaOptions$getEdit2 = mediaOptions.getEditorFeatureFlags) === null || _mediaOptions$getEdit2 === void 0 ? void 0 : (_mediaOptions$getEdit3 = _mediaOptions$getEdit2.call(mediaOptions)) === null || _mediaOptions$getEdit3 === void 0 ? void 0 : _mediaOptions$getEdit3.commentsOnMediaBugFix,
405
405
  view: view,
406
406
  api: pluginInjectionApi,
@@ -14,6 +14,7 @@ import { findDomRefAtPos, findParentNodeOfType, findSelectedNodeOfType, isNodeSe
14
14
  import { Decoration, DecorationSet } from '@atlaskit/editor-prosemirror/view';
15
15
  import { CellSelection } from '@atlaskit/editor-tables/cell-selection';
16
16
  import { getMediaFeatureFlag } from '@atlaskit/media-common';
17
+ import { editorExperiment } from '@atlaskit/tmp-editor-statsig/experiments';
17
18
  import * as helpers from '../commands/helpers';
18
19
  import { updateMediaNodeAttrs } from '../commands/helpers';
19
20
  import PickerFacade from '../picker-facade';
@@ -181,6 +182,9 @@ export class MediaPluginStateImplementation {
181
182
  });
182
183
  _defineProperty(this, "showMediaPicker", () => {
183
184
  if (this.openMediaPickerBrowser) {
185
+ editorExperiment('add-media-from-url', false, {
186
+ exposure: true
187
+ });
184
188
  return this.openMediaPickerBrowser();
185
189
  }
186
190
  this.onPopupToggleCallback(true);
@@ -76,7 +76,7 @@ export const CommentBadge = injectIntl(CommentBadgeWrapper);
76
76
  /**
77
77
  * Remove CommentBadgeWrapper component above
78
78
  * and rename CommentBadgeNextWrapper to CommentBadgeWrapper
79
- * when clean up platform_editor_insert_media_plugin_phase_one feature flag
79
+ * when clean up platform_editor_add_media_from_url feature flag
80
80
  */
81
81
 
82
82
  export const CommentBadgeNextWrapper = ({
@@ -8,6 +8,7 @@ import { Fragment, Slice } from '@atlaskit/editor-prosemirror/model';
8
8
  import { TextSelection } from '@atlaskit/editor-prosemirror/state';
9
9
  import { safeInsert as pmSafeInsert, removeSelectedNode } from '@atlaskit/editor-prosemirror/utils';
10
10
  import { fg } from '@atlaskit/platform-feature-flags';
11
+ import { editorExperiment } from '@atlaskit/tmp-editor-statsig/experiments';
11
12
  import { copyOptionalAttrsFromMediaState } from '../utils/media-common';
12
13
  import { findChangeFromLocation, getChangeMediaAnalytics } from './analytics';
13
14
  import { isImage } from './is-type';
@@ -85,7 +86,7 @@ export const insertMediaAsMediaSingle = (view, node, inputMethod, editorAnalytic
85
86
  return false;
86
87
  }
87
88
  const resizeExperience = fg('platform.editor.media.extended-resize-experience');
88
- const insertMediaPopup = fg('platform_editor_insert_media_plugin_phase_one');
89
+ const insertMediaPopup = editorExperiment('add-media-from-url', true);
89
90
  const mediaSingleAttrs = resizeExperience && insertMediaPopup ? {
90
91
  widthType: 'pixel',
91
92
  width: getMediaSingleInitialWidth((_node$attrs$width = node.attrs.width) !== null && _node$attrs$width !== void 0 ? _node$attrs$width : DEFAULT_IMAGE_WIDTH),
@@ -24,8 +24,7 @@ import React, { Component, Fragment, useMemo } from 'react';
24
24
  // eslint-disable-next-line @atlaskit/ui-styling-standard/use-compiled -- Ignored via go/DSP-18766
25
25
  import { css, jsx } from '@emotion/react';
26
26
  import { useSharedPluginState } from '@atlaskit/editor-common/hooks';
27
- import { calcMediaSinglePixelWidth, DEFAULT_IMAGE_HEIGHT, DEFAULT_IMAGE_WIDTH, getMaxWidthForNestedNode, MEDIA_SINGLE_GUTTER_SIZE } from '@atlaskit/editor-common/media-single';
28
- import { ExternalImageBadge, MediaBadges } from '@atlaskit/editor-common/media-single';
27
+ import { calcMediaSinglePixelWidth, DEFAULT_IMAGE_HEIGHT, DEFAULT_IMAGE_WIDTH, ExternalImageBadge, getMaxWidthForNestedNode, MEDIA_SINGLE_GUTTER_SIZE, MediaBadges } from '@atlaskit/editor-common/media-single';
29
28
  import { WithProviders } from '@atlaskit/editor-common/provider-factory';
30
29
  import ReactNodeView from '@atlaskit/editor-common/react-node-view';
31
30
  import { MediaSingle } from '@atlaskit/editor-common/ui';
@@ -35,6 +34,7 @@ import { findParentNodeOfTypeClosestToPos } from '@atlaskit/editor-prosemirror/u
35
34
  import { CellSelection } from '@atlaskit/editor-tables/cell-selection';
36
35
  import { getAttrsFromUrl } from '@atlaskit/media-client';
37
36
  import { fg } from '@atlaskit/platform-feature-flags';
37
+ import { editorExperiment } from '@atlaskit/tmp-editor-statsig/experiments';
38
38
  import { insertAndSelectCaptionFromMediaSinglePos } from '../commands/captions';
39
39
  import { MEDIA_CONTENT_WRAP_CLASS_NAME } from '../pm-plugins/main';
40
40
  import CaptionPlaceholder from '../ui/CaptionPlaceholder';
@@ -461,7 +461,7 @@ var MediaSingleNode = /*#__PURE__*/function (_Component) {
461
461
  ,
462
462
  className: MediaSingleNodeSelector,
463
463
  onClick: this.onMediaSingleClicked
464
- }, fg('platform_editor_insert_media_plugin_phase_one') && jsx(MediaBadges, {
464
+ }, editorExperiment('add-media-from-url', true) && jsx(MediaBadges, {
465
465
  mediaElement: currentMediaElement(),
466
466
  mediaHeight: height,
467
467
  mediaWidth: width,
@@ -478,7 +478,7 @@ var MediaSingleNode = /*#__PURE__*/function (_Component) {
478
478
  isDrafting: isCurrentNodeDrafting,
479
479
  badgeSize: badgeSize
480
480
  }));
481
- }), !fg('platform_editor_insert_media_plugin_phase_one') && commentsOnMedia && jsx(CommentBadge, {
481
+ }), !editorExperiment('add-media-from-url', true) && commentsOnMedia && jsx(CommentBadge, {
482
482
  commentsOnMediaBugFixEnabled: mediaOptions === null || mediaOptions === void 0 || (_mediaOptions$getEdit2 = mediaOptions.getEditorFeatureFlags) === null || _mediaOptions$getEdit2 === void 0 || (_mediaOptions$getEdit2 = _mediaOptions$getEdit2.call(mediaOptions)) === null || _mediaOptions$getEdit2 === void 0 ? void 0 : _mediaOptions$getEdit2.commentsOnMediaBugFix,
483
483
  view: view,
484
484
  api: pluginInjectionApi,
@@ -23,6 +23,7 @@ import { findDomRefAtPos, findParentNodeOfType, findSelectedNodeOfType, isNodeSe
23
23
  import { Decoration, DecorationSet } from '@atlaskit/editor-prosemirror/view';
24
24
  import { CellSelection } from '@atlaskit/editor-tables/cell-selection';
25
25
  import { getMediaFeatureFlag } from '@atlaskit/media-common';
26
+ import { editorExperiment } from '@atlaskit/tmp-editor-statsig/experiments';
26
27
  import * as helpers from '../commands/helpers';
27
28
  import { updateMediaNodeAttrs } from '../commands/helpers';
28
29
  import PickerFacade from '../picker-facade';
@@ -196,6 +197,9 @@ export var MediaPluginStateImplementation = /*#__PURE__*/function () {
196
197
  });
197
198
  _defineProperty(this, "showMediaPicker", function () {
198
199
  if (_this.openMediaPickerBrowser) {
200
+ editorExperiment('add-media-from-url', false, {
201
+ exposure: true
202
+ });
199
203
  return _this.openMediaPickerBrowser();
200
204
  }
201
205
  _this.onPopupToggleCallback(true);
@@ -77,7 +77,7 @@ export var CommentBadge = injectIntl(CommentBadgeWrapper);
77
77
  /**
78
78
  * Remove CommentBadgeWrapper component above
79
79
  * and rename CommentBadgeNextWrapper to CommentBadgeWrapper
80
- * when clean up platform_editor_insert_media_plugin_phase_one feature flag
80
+ * when clean up platform_editor_add_media_from_url feature flag
81
81
  */
82
82
 
83
83
  export var CommentBadgeNextWrapper = function CommentBadgeNextWrapper(_ref2) {
@@ -11,6 +11,7 @@ import { Fragment, Slice } from '@atlaskit/editor-prosemirror/model';
11
11
  import { TextSelection } from '@atlaskit/editor-prosemirror/state';
12
12
  import { safeInsert as pmSafeInsert, removeSelectedNode } from '@atlaskit/editor-prosemirror/utils';
13
13
  import { fg } from '@atlaskit/platform-feature-flags';
14
+ import { editorExperiment } from '@atlaskit/tmp-editor-statsig/experiments';
14
15
  import { copyOptionalAttrsFromMediaState } from '../utils/media-common';
15
16
  import { findChangeFromLocation, getChangeMediaAnalytics } from './analytics';
16
17
  import { isImage } from './is-type';
@@ -87,7 +88,7 @@ export var insertMediaAsMediaSingle = function insertMediaAsMediaSingle(view, no
87
88
  return false;
88
89
  }
89
90
  var resizeExperience = fg('platform.editor.media.extended-resize-experience');
90
- var insertMediaPopup = fg('platform_editor_insert_media_plugin_phase_one');
91
+ var insertMediaPopup = editorExperiment('add-media-from-url', true);
91
92
  var mediaSingleAttrs = resizeExperience && insertMediaPopup ? {
92
93
  widthType: 'pixel',
93
94
  width: getMediaSingleInitialWidth((_node$attrs$width = node.attrs.width) !== null && _node$attrs$width !== void 0 ? _node$attrs$width : DEFAULT_IMAGE_WIDTH),
@@ -22,7 +22,7 @@ export declare const CommentBadge: React.FC<import("react-intl-next").WithIntlPr
22
22
  /**
23
23
  * Remove CommentBadgeWrapper component above
24
24
  * and rename CommentBadgeNextWrapper to CommentBadgeWrapper
25
- * when clean up platform_editor_insert_media_plugin_phase_one feature flag
25
+ * when clean up platform_editor_add_media_from_url feature flag
26
26
  */
27
27
  type CommentBadgeNextWrapperProps = {
28
28
  mediaSingleElement?: HTMLElement | null;
@@ -22,7 +22,7 @@ export declare const CommentBadge: React.FC<import("react-intl-next").WithIntlPr
22
22
  /**
23
23
  * Remove CommentBadgeWrapper component above
24
24
  * and rename CommentBadgeNextWrapper to CommentBadgeWrapper
25
- * when clean up platform_editor_insert_media_plugin_phase_one feature flag
25
+ * when clean up platform_editor_add_media_from_url feature flag
26
26
  */
27
27
  type CommentBadgeNextWrapperProps = {
28
28
  mediaSingleElement?: HTMLElement | null;
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@atlaskit/editor-plugin-media",
3
- "version": "1.31.6",
3
+ "version": "1.31.7",
4
4
  "description": "Media plugin for @atlaskit/editor-core",
5
5
  "author": "Atlassian Pty Ltd",
6
6
  "license": "Apache-2.0",
@@ -36,7 +36,7 @@
36
36
  "@atlaskit/analytics-namespaced-context": "^6.12.0",
37
37
  "@atlaskit/analytics-next": "^10.1.0",
38
38
  "@atlaskit/button": "^20.1.0",
39
- "@atlaskit/editor-common": "^89.1.0",
39
+ "@atlaskit/editor-common": "^89.2.0",
40
40
  "@atlaskit/editor-palette": "1.6.0",
41
41
  "@atlaskit/editor-plugin-analytics": "^1.8.0",
42
42
  "@atlaskit/editor-plugin-annotation": "1.19.6",
@@ -53,7 +53,7 @@
53
53
  "@atlaskit/editor-shared-styles": "^2.13.0",
54
54
  "@atlaskit/editor-tables": "^2.8.0",
55
55
  "@atlaskit/form": "^10.5.0",
56
- "@atlaskit/icon": "^22.17.0",
56
+ "@atlaskit/icon": "^22.18.0",
57
57
  "@atlaskit/media-card": "^78.3.0",
58
58
  "@atlaskit/media-client": "^28.0.0",
59
59
  "@atlaskit/media-client-react": "^2.2.0",
@@ -67,7 +67,7 @@
67
67
  "@atlaskit/textfield": "^6.5.0",
68
68
  "@atlaskit/theme": "^13.0.0",
69
69
  "@atlaskit/tmp-editor-statsig": "^2.1.8",
70
- "@atlaskit/tokens": "^1.59.0",
70
+ "@atlaskit/tokens": "^1.60.0",
71
71
  "@atlaskit/tooltip": "^18.7.0",
72
72
  "@babel/runtime": "^7.0.0",
73
73
  "@emotion/react": "^11.7.1",
@@ -144,9 +144,6 @@
144
144
  "platform-editor-a11y-image-border-options-dropdown": {
145
145
  "type": "boolean"
146
146
  },
147
- "platform_editor_insert_media_plugin_phase_one": {
148
- "type": "boolean"
149
- },
150
147
  "platform_editor_media_batch_updates": {
151
148
  "type": "boolean"
152
149
  }