@atlaskit/editor-plugin-media 0.10.1 → 0.10.3

package/CHANGELOG.md

@@ -1,5 +1,18 @@
 # @atlaskit/editor-plugin-media
 
+## 0.10.3
+
+### Patch Changes
+
+- [#65846](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/65846) [`aa24d3f38df0`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/aa24d3f38df0) - Updated analytics for border mark
+- Updated dependencies
+
+## 0.10.2
+
+### Patch Changes
+
+- [#65194](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/65194) [`b17492206adc`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/b17492206adc) - ED-21544 able to insert inline image in panel with empty paragraph.
+
 ## 0.10.1
 
 ### Patch Changes

package/dist/cjs/toolbar/commands.js

@@ -12,18 +12,25 @@ var _state = require("@atlaskit/editor-prosemirror/state");
 var _utils = require("@atlaskit/editor-prosemirror/utils");
 var _analytics2 = require("../utils/analytics");
 var _currentMediaNode = require("../utils/current-media-node");
+var _mediaCommon = require("../utils/media-common");
 var _mediaSingle = require("../utils/media-single");
 var _utils2 = require("./utils");
 function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
 function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { (0, _defineProperty2.default)(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; }
 var DEFAULT_BORDER_COLOR = exports.DEFAULT_BORDER_COLOR = '#091e4224';
 var DEFAULT_BORDER_SIZE = exports.DEFAULT_BORDER_SIZE = 2;
+var getNodeType = function getNodeType(state) {
+  var _state$schema$nodes = state.schema.nodes,
+    mediaSingle = _state$schema$nodes.mediaSingle,
+    mediaInline = _state$schema$nodes.mediaInline;
+  return (0, _mediaCommon.isSelectionMediaSingleNode)(state) ? mediaSingle.name : mediaInline.name;
+};
 var changeInlineToMediaCard = exports.changeInlineToMediaCard = function changeInlineToMediaCard(editorAnalyticsAPI) {
   return function (state, dispatch) {
-    var _state$schema$nodes = state.schema.nodes,
-      media = _state$schema$nodes.media,
-      mediaInline = _state$schema$nodes.mediaInline,
-      mediaGroup = _state$schema$nodes.mediaGroup;
+    var _state$schema$nodes2 = state.schema.nodes,
+      media = _state$schema$nodes2.media,
+      mediaInline = _state$schema$nodes2.mediaInline,
+      mediaGroup = _state$schema$nodes2.mediaGroup;
     var selectedNode = state.selection instanceof _state.NodeSelection && state.selection.node.type === mediaInline && state.selection.node;
     if (!selectedNode) {
       return false;
@@ -59,10 +66,10 @@ var changeInlineToMediaCard = exports.changeInlineToMediaCard = function changeI
 };
 var changeMediaCardToInline = exports.changeMediaCardToInline = function changeMediaCardToInline(editorAnalyticsAPI) {
   return function (state, dispatch) {
-    var _state$schema$nodes2 = state.schema.nodes,
-      media = _state$schema$nodes2.media,
-      mediaInline = _state$schema$nodes2.mediaInline,
-      paragraph = _state$schema$nodes2.paragraph;
+    var _state$schema$nodes3 = state.schema.nodes,
+      media = _state$schema$nodes3.media,
+      mediaInline = _state$schema$nodes3.mediaInline,
+      paragraph = _state$schema$nodes3.paragraph;
     var selectedNode = state.selection instanceof _state.NodeSelection && state.selection.node;
 
     // @ts-ignore - [unblock prosemirror bump] redundant check comparing boolean to media
@@ -141,6 +148,7 @@ var toggleBorderMark = exports.toggleBorderMark = function toggleBorderMark(edit
       }
     }
     if (dispatch) {
+      var type = getNodeType(state);
       if (borderMark !== null && borderMark !== void 0 && borderMark.attrs) {
         editorAnalyticsAPI === null || editorAnalyticsAPI === void 0 || editorAnalyticsAPI.attachAnalyticsEvent({
           action: _analytics.ACTION.DELETED,
@@ -148,8 +156,10 @@ var toggleBorderMark = exports.toggleBorderMark = function toggleBorderMark(edit
           actionSubjectId: _analytics.ACTION_SUBJECT_ID.BORDER,
           eventType: _analytics.EVENT_TYPE.TRACK,
           attributes: {
+            type: type,
             previousColor: borderMark.attrs.color,
-            previousSize: borderMark.attrs.size
+            previousSize: borderMark.attrs.size,
+            mediaType: node.attrs.type
           }
         })(tr);
       } else {
@@ -159,8 +169,10 @@ var toggleBorderMark = exports.toggleBorderMark = function toggleBorderMark(edit
           actionSubjectId: _analytics.ACTION_SUBJECT_ID.BORDER,
           eventType: _analytics.EVENT_TYPE.TRACK,
           attributes: {
+            type: type,
             color: DEFAULT_BORDER_COLOR,
-            size: DEFAULT_BORDER_SIZE
+            size: DEFAULT_BORDER_SIZE,
+            mediaType: node.attrs.type
           }
         })(tr);
       }
@@ -204,6 +216,8 @@ var setBorderMark = exports.setBorderMark = function setBorderMark(editorAnalyti
           actionSubjectId: _analytics.ACTION_SUBJECT_ID.BORDER,
           eventType: _analytics.EVENT_TYPE.TRACK,
           attributes: {
+            type: getNodeType(state),
+            mediaType: node.attrs.type,
             previousColor: borderMark === null || borderMark === void 0 ? void 0 : borderMark.color,
             previousSize: borderMark === null || borderMark === void 0 ? void 0 : borderMark.size,
             newColor: color,
@@ -252,9 +266,9 @@ var updateMediaSingleWidth = exports.updateMediaSingleWidth = function updateMed
 var changeMediaSingleToMediaInline = exports.changeMediaSingleToMediaInline = function changeMediaSingleToMediaInline(editorAnalyticsAPI) {
   return function (state, dispatch) {
     var selectedNodeWithPos = (0, _utils2.getSelectedMediaSingle)(state);
-    var _state$schema$nodes3 = state.schema.nodes,
-      mediaInline = _state$schema$nodes3.mediaInline,
-      paragraph = _state$schema$nodes3.paragraph;
+    var _state$schema$nodes4 = state.schema.nodes,
+      mediaInline = _state$schema$nodes4.mediaInline,
+      paragraph = _state$schema$nodes4.paragraph;
     if (!selectedNodeWithPos) {
       return false;
     }

package/dist/cjs/utils/media-files.js

@@ -12,6 +12,7 @@ var _model = require("@atlaskit/editor-prosemirror/model");
 var _utils2 = require("@atlaskit/editor-prosemirror/utils");
 var _isType = require("./is-type");
 var _mediaCommon = require("./media-common");
+var _mediaInline2 = require("./media-inline");
 var canInsertMediaInline = exports.canInsertMediaInline = function canInsertMediaInline(state) {
   var node = state.schema.nodes.mediaInline.create({});
   return (0, _utils2.canInsert)(state.selection.$to, _model.Fragment.from(node));
@@ -116,8 +117,8 @@ var insertMediaInlineNode = exports.insertMediaInlineNode = function insertMedia
     var space = state.schema.text(' ');
     var pos = state.selection.$to.pos;
 
-    // If the selection is inside an empty list item set pos inside paragraph
-    if ((0, _utils.isInListItem)(state) && (0, _mediaCommon.isInsidePotentialEmptyParagraph)(state)) {
+    // If the selection is inside an empty list item or panel set pos inside paragraph
+    if ((0, _mediaInline2.isInSupportedInlineImageParent)(state) && (0, _mediaCommon.isInsidePotentialEmptyParagraph)(state)) {
       pos = pos + 1;
     }
     var content = _model.Fragment.from([mediaInlineNode, space]);

package/dist/cjs/utils/media-inline.js

@@ -3,16 +3,20 @@
 Object.defineProperty(exports, "__esModule", {
   value: true
 });
-exports.getMediaNodeInsertionType = void 0;
+exports.isInSupportedInlineImageParent = exports.getMediaNodeInsertionType = void 0;
 var _utils = require("@atlaskit/editor-common/utils");
+var _utils2 = require("@atlaskit/editor-prosemirror/utils");
 var _mediaCommon = require("@atlaskit/media-common");
 var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _mediaFiles = require("../utils/media-files");
 var _mediaSingle = require("../utils/media-single");
 var _isType = require("./is-type");
 var _mediaCommon2 = require("./media-common");
+var isInSupportedInlineImageParent = exports.isInSupportedInlineImageParent = function isInSupportedInlineImageParent(state) {
+  return (0, _utils2.hasParentNodeOfType)([state.schema.nodes.listItem, state.schema.nodes.panel])(state.selection);
+};
 var getMediaNodeInsertionType = exports.getMediaNodeInsertionType = function getMediaNodeInsertionType(state, mediaFeatureFlags, fileMimeType) {
-  var canInsertInlineNode = (0, _mediaCommon.getMediaFeatureFlag)('mediaInline', mediaFeatureFlags) && !(0, _utils.isInEmptyLine)(state) && (!(0, _mediaCommon2.isInsidePotentialEmptyParagraph)(state) || (0, _utils.isInListItem)(state)) && (0, _mediaFiles.canInsertMediaInline)(state);
+  var canInsertInlineNode = (0, _mediaCommon.getMediaFeatureFlag)('mediaInline', mediaFeatureFlags) && !(0, _utils.isInEmptyLine)(state) && (!(0, _mediaCommon2.isInsidePotentialEmptyParagraph)(state) || isInSupportedInlineImageParent(state)) && (0, _mediaFiles.canInsertMediaInline)(state);
   if ((0, _platformFeatureFlags.getBooleanFF)('platform.editor.media.inline-image.base-support')) {
     if (canInsertInlineNode && !(0, _isType.isVideo)(fileMimeType)) {
       return 'inline';

package/dist/es2019/toolbar/commands.js

@@ -4,10 +4,18 @@ import { NodeSelection, TextSelection } from '@atlaskit/editor-prosemirror/state
 import { isNodeSelection, removeSelectedNode, safeInsert } from '@atlaskit/editor-prosemirror/utils';
 import { findChangeFromLocation, getChangeMediaAnalytics, getMediaInputResizeAnalyticsEvent } from '../utils/analytics';
 import { currentMediaInlineNodeWithPos, currentMediaNodeWithPos } from '../utils/current-media-node';
+import { isSelectionMediaSingleNode } from '../utils/media-common';
 import { changeFromMediaInlineToMediaSingleNode } from '../utils/media-single';
 import { getSelectedMediaSingle, removeMediaGroupNode } from './utils';
 export const DEFAULT_BORDER_COLOR = '#091e4224';
 export const DEFAULT_BORDER_SIZE = 2;
+const getNodeType = state => {
+  const {
+    mediaSingle,
+    mediaInline
+  } = state.schema.nodes;
+  return isSelectionMediaSingleNode(state) ? mediaSingle.name : mediaInline.name;
+};
 export const changeInlineToMediaCard = editorAnalyticsAPI => (state, dispatch) => {
   const {
     media,
@@ -127,6 +135,7 @@ export const toggleBorderMark = editorAnalyticsAPI => (state, dispatch) => {
     }
   }
   if (dispatch) {
+    const type = getNodeType(state);
     if (borderMark !== null && borderMark !== void 0 && borderMark.attrs) {
       editorAnalyticsAPI === null || editorAnalyticsAPI === void 0 ? void 0 : editorAnalyticsAPI.attachAnalyticsEvent({
         action: ACTION.DELETED,
@@ -134,8 +143,10 @@ export const toggleBorderMark = editorAnalyticsAPI => (state, dispatch) => {
         actionSubjectId: ACTION_SUBJECT_ID.BORDER,
         eventType: EVENT_TYPE.TRACK,
         attributes: {
+          type,
           previousColor: borderMark.attrs.color,
-          previousSize: borderMark.attrs.size
+          previousSize: borderMark.attrs.size,
+          mediaType: node.attrs.type
         }
       })(tr);
     } else {
@@ -145,8 +156,10 @@ export const toggleBorderMark = editorAnalyticsAPI => (state, dispatch) => {
         actionSubjectId: ACTION_SUBJECT_ID.BORDER,
         eventType: EVENT_TYPE.TRACK,
         attributes: {
+          type,
           color: DEFAULT_BORDER_COLOR,
-          size: DEFAULT_BORDER_SIZE
+          size: DEFAULT_BORDER_SIZE,
+          mediaType: node.attrs.type
         }
       })(tr);
     }
@@ -185,6 +198,8 @@ export const setBorderMark = editorAnalyticsAPI => attrs => (state, dispatch) =>
       actionSubjectId: ACTION_SUBJECT_ID.BORDER,
       eventType: EVENT_TYPE.TRACK,
       attributes: {
+        type: getNodeType(state),
+        mediaType: node.attrs.type,
         previousColor: borderMark === null || borderMark === void 0 ? void 0 : borderMark.color,
         previousSize: borderMark === null || borderMark === void 0 ? void 0 : borderMark.size,
         newColor: color,

package/dist/es2019/utils/media-files.js

@@ -6,6 +6,7 @@ import { Fragment } from '@atlaskit/editor-prosemirror/model';
 import { canInsert, hasParentNode, safeInsert } from '@atlaskit/editor-prosemirror/utils';
 import { isImage } from './is-type';
 import { copyOptionalAttrsFromMediaState, isInsidePotentialEmptyParagraph, isSelectionNonMediaBlockNode, posOfMediaGroupNearby, posOfParentMediaGroup, posOfPrecedingMediaGroup } from './media-common';
+import { isInSupportedInlineImageParent } from './media-inline';
 export const canInsertMediaInline = state => {
   const node = state.schema.nodes.mediaInline.create({});
   return canInsert(state.selection.$to, Fragment.from(node));
@@ -125,8 +126,8 @@ export const insertMediaInlineNode = editorAnalyticsAPI => (view, mediaState, co
   const space = state.schema.text(' ');
   let pos = state.selection.$to.pos;
 
-  // If the selection is inside an empty list item set pos inside paragraph
-  if (isInListItem(state) && isInsidePotentialEmptyParagraph(state)) {
+  // If the selection is inside an empty list item or panel set pos inside paragraph
+  if (isInSupportedInlineImageParent(state) && isInsidePotentialEmptyParagraph(state)) {
     pos = pos + 1;
   }
   let content = Fragment.from([mediaInlineNode, space]);

package/dist/es2019/utils/media-inline.js

@@ -1,12 +1,16 @@
-import { isInEmptyLine, isInListItem } from '@atlaskit/editor-common/utils';
+import { isInEmptyLine } from '@atlaskit/editor-common/utils';
+import { hasParentNodeOfType } from '@atlaskit/editor-prosemirror/utils';
 import { getMediaFeatureFlag } from '@atlaskit/media-common';
 import { getBooleanFF } from '@atlaskit/platform-feature-flags';
 import { canInsertMediaInline } from '../utils/media-files';
 import { isMediaSingle } from '../utils/media-single';
 import { isVideo } from './is-type';
 import { isInsidePotentialEmptyParagraph } from './media-common';
+export const isInSupportedInlineImageParent = state => {
+  return hasParentNodeOfType([state.schema.nodes.listItem, state.schema.nodes.panel])(state.selection);
+};
 export const getMediaNodeInsertionType = (state, mediaFeatureFlags, fileMimeType) => {
-  const canInsertInlineNode = getMediaFeatureFlag('mediaInline', mediaFeatureFlags) && !isInEmptyLine(state) && (!isInsidePotentialEmptyParagraph(state) || isInListItem(state)) && canInsertMediaInline(state);
+  const canInsertInlineNode = getMediaFeatureFlag('mediaInline', mediaFeatureFlags) && !isInEmptyLine(state) && (!isInsidePotentialEmptyParagraph(state) || isInSupportedInlineImageParent(state)) && canInsertMediaInline(state);
   if (getBooleanFF('platform.editor.media.inline-image.base-support')) {
     if (canInsertInlineNode && !isVideo(fileMimeType)) {
       return 'inline';

package/dist/esm/toolbar/commands.js

@@ -7,16 +7,23 @@ import { NodeSelection, TextSelection } from '@atlaskit/editor-prosemirror/state
 import { isNodeSelection, removeSelectedNode, safeInsert } from '@atlaskit/editor-prosemirror/utils';
 import { findChangeFromLocation, getChangeMediaAnalytics, getMediaInputResizeAnalyticsEvent } from '../utils/analytics';
 import { currentMediaInlineNodeWithPos, currentMediaNodeWithPos } from '../utils/current-media-node';
+import { isSelectionMediaSingleNode } from '../utils/media-common';
 import { changeFromMediaInlineToMediaSingleNode } from '../utils/media-single';
 import { getSelectedMediaSingle, removeMediaGroupNode } from './utils';
 export var DEFAULT_BORDER_COLOR = '#091e4224';
 export var DEFAULT_BORDER_SIZE = 2;
+var getNodeType = function getNodeType(state) {
+  var _state$schema$nodes = state.schema.nodes,
+    mediaSingle = _state$schema$nodes.mediaSingle,
+    mediaInline = _state$schema$nodes.mediaInline;
+  return isSelectionMediaSingleNode(state) ? mediaSingle.name : mediaInline.name;
+};
 export var changeInlineToMediaCard = function changeInlineToMediaCard(editorAnalyticsAPI) {
   return function (state, dispatch) {
-    var _state$schema$nodes = state.schema.nodes,
-      media = _state$schema$nodes.media,
-      mediaInline = _state$schema$nodes.mediaInline,
-      mediaGroup = _state$schema$nodes.mediaGroup;
+    var _state$schema$nodes2 = state.schema.nodes,
+      media = _state$schema$nodes2.media,
+      mediaInline = _state$schema$nodes2.mediaInline,
+      mediaGroup = _state$schema$nodes2.mediaGroup;
     var selectedNode = state.selection instanceof NodeSelection && state.selection.node.type === mediaInline && state.selection.node;
     if (!selectedNode) {
       return false;
@@ -52,10 +59,10 @@ export var changeInlineToMediaCard = function changeInlineToMediaCard(editorAnal
 };
 export var changeMediaCardToInline = function changeMediaCardToInline(editorAnalyticsAPI) {
   return function (state, dispatch) {
-    var _state$schema$nodes2 = state.schema.nodes,
-      media = _state$schema$nodes2.media,
-      mediaInline = _state$schema$nodes2.mediaInline,
-      paragraph = _state$schema$nodes2.paragraph;
+    var _state$schema$nodes3 = state.schema.nodes,
+      media = _state$schema$nodes3.media,
+      mediaInline = _state$schema$nodes3.mediaInline,
+      paragraph = _state$schema$nodes3.paragraph;
     var selectedNode = state.selection instanceof NodeSelection && state.selection.node;
 
     // @ts-ignore - [unblock prosemirror bump] redundant check comparing boolean to media
@@ -134,6 +141,7 @@ export var toggleBorderMark = function toggleBorderMark(editorAnalyticsAPI) {
       }
     }
     if (dispatch) {
+      var type = getNodeType(state);
       if (borderMark !== null && borderMark !== void 0 && borderMark.attrs) {
         editorAnalyticsAPI === null || editorAnalyticsAPI === void 0 || editorAnalyticsAPI.attachAnalyticsEvent({
           action: ACTION.DELETED,
@@ -141,8 +149,10 @@ export var toggleBorderMark = function toggleBorderMark(editorAnalyticsAPI) {
           actionSubjectId: ACTION_SUBJECT_ID.BORDER,
           eventType: EVENT_TYPE.TRACK,
           attributes: {
+            type: type,
             previousColor: borderMark.attrs.color,
-            previousSize: borderMark.attrs.size
+            previousSize: borderMark.attrs.size,
+            mediaType: node.attrs.type
           }
         })(tr);
       } else {
@@ -152,8 +162,10 @@ export var toggleBorderMark = function toggleBorderMark(editorAnalyticsAPI) {
           actionSubjectId: ACTION_SUBJECT_ID.BORDER,
           eventType: EVENT_TYPE.TRACK,
           attributes: {
+            type: type,
             color: DEFAULT_BORDER_COLOR,
-            size: DEFAULT_BORDER_SIZE
+            size: DEFAULT_BORDER_SIZE,
+            mediaType: node.attrs.type
           }
         })(tr);
       }
@@ -197,6 +209,8 @@ export var setBorderMark = function setBorderMark(editorAnalyticsAPI) {
           actionSubjectId: ACTION_SUBJECT_ID.BORDER,
           eventType: EVENT_TYPE.TRACK,
           attributes: {
+            type: getNodeType(state),
+            mediaType: node.attrs.type,
             previousColor: borderMark === null || borderMark === void 0 ? void 0 : borderMark.color,
             previousSize: borderMark === null || borderMark === void 0 ? void 0 : borderMark.size,
             newColor: color,
@@ -245,9 +259,9 @@ export var updateMediaSingleWidth = function updateMediaSingleWidth(editorAnalyt
 export var changeMediaSingleToMediaInline = function changeMediaSingleToMediaInline(editorAnalyticsAPI) {
   return function (state, dispatch) {
     var selectedNodeWithPos = getSelectedMediaSingle(state);
-    var _state$schema$nodes3 = state.schema.nodes,
-      mediaInline = _state$schema$nodes3.mediaInline,
-      paragraph = _state$schema$nodes3.paragraph;
+    var _state$schema$nodes4 = state.schema.nodes,
+      mediaInline = _state$schema$nodes4.mediaInline,
+      paragraph = _state$schema$nodes4.paragraph;
     if (!selectedNodeWithPos) {
       return false;
     }

package/dist/esm/utils/media-files.js

@@ -6,6 +6,7 @@ import { Fragment } from '@atlaskit/editor-prosemirror/model';
 import { canInsert, hasParentNode, safeInsert } from '@atlaskit/editor-prosemirror/utils';
 import { isImage } from './is-type';
 import { copyOptionalAttrsFromMediaState, isInsidePotentialEmptyParagraph, isSelectionNonMediaBlockNode, posOfMediaGroupNearby, posOfParentMediaGroup, posOfPrecedingMediaGroup } from './media-common';
+import { isInSupportedInlineImageParent } from './media-inline';
 export var canInsertMediaInline = function canInsertMediaInline(state) {
   var node = state.schema.nodes.mediaInline.create({});
   return canInsert(state.selection.$to, Fragment.from(node));
@@ -110,8 +111,8 @@ export var insertMediaInlineNode = function insertMediaInlineNode(editorAnalytic
     var space = state.schema.text(' ');
     var pos = state.selection.$to.pos;
 
-    // If the selection is inside an empty list item set pos inside paragraph
-    if (isInListItem(state) && isInsidePotentialEmptyParagraph(state)) {
+    // If the selection is inside an empty list item or panel set pos inside paragraph
+    if (isInSupportedInlineImageParent(state) && isInsidePotentialEmptyParagraph(state)) {
       pos = pos + 1;
     }
     var content = Fragment.from([mediaInlineNode, space]);

package/dist/esm/utils/media-inline.js

@@ -1,12 +1,16 @@
-import { isInEmptyLine, isInListItem } from '@atlaskit/editor-common/utils';
+import { isInEmptyLine } from '@atlaskit/editor-common/utils';
+import { hasParentNodeOfType } from '@atlaskit/editor-prosemirror/utils';
 import { getMediaFeatureFlag } from '@atlaskit/media-common';
 import { getBooleanFF } from '@atlaskit/platform-feature-flags';
 import { canInsertMediaInline } from '../utils/media-files';
 import { isMediaSingle } from '../utils/media-single';
 import { isVideo } from './is-type';
 import { isInsidePotentialEmptyParagraph } from './media-common';
+export var isInSupportedInlineImageParent = function isInSupportedInlineImageParent(state) {
+  return hasParentNodeOfType([state.schema.nodes.listItem, state.schema.nodes.panel])(state.selection);
+};
 export var getMediaNodeInsertionType = function getMediaNodeInsertionType(state, mediaFeatureFlags, fileMimeType) {
-  var canInsertInlineNode = getMediaFeatureFlag('mediaInline', mediaFeatureFlags) && !isInEmptyLine(state) && (!isInsidePotentialEmptyParagraph(state) || isInListItem(state)) && canInsertMediaInline(state);
+  var canInsertInlineNode = getMediaFeatureFlag('mediaInline', mediaFeatureFlags) && !isInEmptyLine(state) && (!isInsidePotentialEmptyParagraph(state) || isInSupportedInlineImageParent(state)) && canInsertMediaInline(state);
   if (getBooleanFF('platform.editor.media.inline-image.base-support')) {
     if (canInsertInlineNode && !isVideo(fileMimeType)) {
       return 'inline';

package/dist/types/utils/media-inline.d.ts

@@ -1,4 +1,5 @@
 import type { EditorState } from '@atlaskit/editor-prosemirror/state';
 import type { MediaFeatureFlags } from '@atlaskit/media-common';
 export type MediaNodeType = 'inline' | 'block' | 'group';
+export declare const isInSupportedInlineImageParent: (state: EditorState) => boolean;
 export declare const getMediaNodeInsertionType: (state: EditorState, mediaFeatureFlags?: MediaFeatureFlags, fileMimeType?: string) => MediaNodeType;

package/dist/types-ts4.5/utils/media-inline.d.ts

@@ -1,4 +1,5 @@
 import type { EditorState } from '@atlaskit/editor-prosemirror/state';
 import type { MediaFeatureFlags } from '@atlaskit/media-common';
 export type MediaNodeType = 'inline' | 'block' | 'group';
+export declare const isInSupportedInlineImageParent: (state: EditorState) => boolean;
 export declare const getMediaNodeInsertionType: (state: EditorState, mediaFeatureFlags?: MediaFeatureFlags, fileMimeType?: string) => MediaNodeType;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaskit/editor-plugin-media",
-  "version": "0.10.1",
+  "version": "0.10.3",
   "description": "Media plugin for @atlaskit/editor-core",
   "author": "Atlassian Pty Ltd",
   "license": "Apache-2.0",
@@ -34,10 +34,10 @@
   },
   "dependencies": {
     "@atlaskit/adf-schema": "^35.3.0",
-    "@atlaskit/analytics-namespaced-context": "^6.8.0",
+    "@atlaskit/analytics-namespaced-context": "^6.9.0",
     "@atlaskit/analytics-next": "^9.1.0",
     "@atlaskit/button": "^17.2.0",
-    "@atlaskit/editor-common": "^76.35.0",
+    "@atlaskit/editor-common": "^76.36.0",
     "@atlaskit/editor-palette": "1.5.2",
     "@atlaskit/editor-plugin-analytics": "^0.4.0",
     "@atlaskit/editor-plugin-decorations": "^0.2.0",