@atlaskit/editor-plugin-local-id 4.2.7 → 4.3.1

package/CHANGELOG.md

@@ -1,5 +1,20 @@
 # @atlaskit/editor-plugin-local-id
 
+## 4.3.1
+
+### Patch Changes
+
+- [`65e23b9169d24`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/65e23b9169d24) -
+  Do not pre-load local ids with collab
+- Updated dependencies
+
+## 4.3.0
+
+### Minor Changes
+
+- [`8557b67bb48de`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/8557b67bb48de) -
+  Set isDirty to true for dirty transaction
+
 ## 4.2.7
 
 ### Patch Changes

package/afm-cc/tsconfig.json

@@ -4,7 +4,8 @@
 		"target": "es5",
 		"outDir": "../../../../../confluence/tsDist/@atlaskit__editor-plugin-local-id",
 		"rootDir": "../",
-		"composite": true
+		"composite": true,
+		"noCheck": true
 	},
 	"include": [
 		"../src/**/*.ts",

package/afm-jira/tsconfig.json

@@ -4,7 +4,8 @@
 		"target": "es5",
 		"outDir": "../../../../../jira/tsDist/@atlaskit__editor-plugin-local-id/app",
 		"rootDir": "../",
-		"composite": true
+		"composite": true,
+		"noCheck": true
 	},
 	"include": [
 		"../src/**/*.ts",

package/afm-products/tsconfig.json

@@ -4,7 +4,8 @@
 		"target": "es5",
 		"outDir": "../../../../../tsDist/@atlaskit__editor-plugin-local-id/app",
 		"rootDir": "../",
-		"composite": true
+		"composite": true,
+		"noCheck": true
 	},
 	"include": [
 		"../src/**/*.ts",

package/dist/cjs/pm-plugins/main.js

@@ -8,6 +8,7 @@ exports.localIdPluginKey = exports.createPlugin = exports.batchAddLocalIdToNodes
 var _slicedToArray2 = _interopRequireDefault(require("@babel/runtime/helpers/slicedToArray"));
 var _adfSchema = require("@atlaskit/adf-schema");
 var _steps = require("@atlaskit/adf-schema/steps");
+var _collab = require("@atlaskit/editor-common/collab");
 var _safePlugin = require("@atlaskit/editor-common/safe-plugin");
 var _utils = require("@atlaskit/editor-common/utils");
 var _state = require("@atlaskit/editor-prosemirror/state");
@@ -44,6 +45,13 @@ var createPlugin = exports.createPlugin = function createPlugin(api) {
        * to nodes that don't have them. It's designed to run only once per
        * editor instance to avoid performance issues.
        */
+      // @ts-expect-error - This is an experiment to see if we can improve performance - if successful
+      // we will add the plugin as a dependency
+      if (api !== null && api !== void 0 && api.collabEdit && (0, _platformFeatureFlags.fg)('platform_editor_ai_aifc_avoid_initial_localId')) {
+        return {
+          update: function update() {}
+        };
+      }
       requestIdleCallbackWithFallback(function () {
         var tr = editorView.state.tr;
         var localIdWasAdded = false;
@@ -71,10 +79,12 @@ var createPlugin = exports.createPlugin = function createPlugin(api) {
         if ((0, _platformFeatureFlags.fg)('platform_editor_localid_improvements')) {
           if (nodesToUpdate.size > 0) {
             batchAddLocalIdToNodes(nodesToUpdate, tr);
+            (0, _collab.tintDirtyTransaction)(tr);
             editorView.dispatch(tr);
           }
         } else if (localIdWasAdded) {
           tr.setMeta('addToHistory', false);
+          (0, _collab.tintDirtyTransaction)(tr);
           editorView.dispatch(tr);
         }
       });
@@ -150,7 +160,7 @@ var createPlugin = exports.createPlugin = function createPlugin(api) {
         });
       });
       if (addedNodes.size > 0 && (0, _platformFeatureFlags.fg)('platform_editor_use_localid_dedupe')) {
-        newState.doc.descendants(function (node, pos) {
+        newState.doc.descendants(function (node) {
           if (addedNodes.has(node)) {
             return true;
           }

package/dist/es2019/pm-plugins/main.js

@@ -1,5 +1,6 @@
 import { uuid } from '@atlaskit/adf-schema';
 import { BatchAttrsStep } from '@atlaskit/adf-schema/steps';
+import { tintDirtyTransaction } from '@atlaskit/editor-common/collab';
 import { SafePlugin } from '@atlaskit/editor-common/safe-plugin';
 import { stepHasSlice } from '@atlaskit/editor-common/utils';
 import { PluginKey } from '@atlaskit/editor-prosemirror/state';
@@ -33,6 +34,13 @@ export const createPlugin = api => {
        * to nodes that don't have them. It's designed to run only once per
        * editor instance to avoid performance issues.
        */
+      // @ts-expect-error - This is an experiment to see if we can improve performance - if successful
+      // we will add the plugin as a dependency
+      if (api !== null && api !== void 0 && api.collabEdit && fg('platform_editor_ai_aifc_avoid_initial_localId')) {
+        return {
+          update: () => {}
+        };
+      }
       requestIdleCallbackWithFallback(() => {
         const tr = editorView.state.tr;
         let localIdWasAdded = false;
@@ -61,10 +69,12 @@ export const createPlugin = api => {
         if (fg('platform_editor_localid_improvements')) {
           if (nodesToUpdate.size > 0) {
             batchAddLocalIdToNodes(nodesToUpdate, tr);
+            tintDirtyTransaction(tr);
             editorView.dispatch(tr);
           }
         } else if (localIdWasAdded) {
           tr.setMeta('addToHistory', false);
+          tintDirtyTransaction(tr);
           editorView.dispatch(tr);
         }
       });
@@ -141,7 +151,7 @@ export const createPlugin = api => {
         });
       });
       if (addedNodes.size > 0 && fg('platform_editor_use_localid_dedupe')) {
-        newState.doc.descendants((node, pos) => {
+        newState.doc.descendants(node => {
           if (addedNodes.has(node)) {
             return true;
           }

package/dist/esm/pm-plugins/main.js

@@ -4,6 +4,7 @@ function _unsupportedIterableToArray(r, a) { if (r) { if ("string" == typeof r)
 function _arrayLikeToArray(r, a) { (null == a || a > r.length) && (a = r.length); for (var e = 0, n = Array(a); e < a; e++) n[e] = r[e]; return n; }
 import { uuid } from '@atlaskit/adf-schema';
 import { BatchAttrsStep } from '@atlaskit/adf-schema/steps';
+import { tintDirtyTransaction } from '@atlaskit/editor-common/collab';
 import { SafePlugin } from '@atlaskit/editor-common/safe-plugin';
 import { stepHasSlice } from '@atlaskit/editor-common/utils';
 import { PluginKey } from '@atlaskit/editor-prosemirror/state';
@@ -37,6 +38,13 @@ export var createPlugin = function createPlugin(api) {
        * to nodes that don't have them. It's designed to run only once per
        * editor instance to avoid performance issues.
        */
+      // @ts-expect-error - This is an experiment to see if we can improve performance - if successful
+      // we will add the plugin as a dependency
+      if (api !== null && api !== void 0 && api.collabEdit && fg('platform_editor_ai_aifc_avoid_initial_localId')) {
+        return {
+          update: function update() {}
+        };
+      }
       requestIdleCallbackWithFallback(function () {
         var tr = editorView.state.tr;
         var localIdWasAdded = false;
@@ -64,10 +72,12 @@ export var createPlugin = function createPlugin(api) {
         if (fg('platform_editor_localid_improvements')) {
           if (nodesToUpdate.size > 0) {
             batchAddLocalIdToNodes(nodesToUpdate, tr);
+            tintDirtyTransaction(tr);
             editorView.dispatch(tr);
           }
         } else if (localIdWasAdded) {
           tr.setMeta('addToHistory', false);
+          tintDirtyTransaction(tr);
           editorView.dispatch(tr);
         }
       });
@@ -143,7 +153,7 @@ export var createPlugin = function createPlugin(api) {
         });
       });
       if (addedNodes.size > 0 && fg('platform_editor_use_localid_dedupe')) {
-        newState.doc.descendants(function (node, pos) {
+        newState.doc.descendants(function (node) {
           if (addedNodes.has(node)) {
             return true;
           }

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-plugin-local-id",
-	"version": "4.2.7",
+	"version": "4.3.1",
 	"description": "LocalId plugin for @atlaskit/editor-core",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",
@@ -35,7 +35,7 @@
 		"raf-schd": "^4.0.3"
 	},
 	"peerDependencies": {
-		"@atlaskit/editor-common": "^110.38.0",
+		"@atlaskit/editor-common": "^110.41.0",
 		"react": "^18.2.0"
 	},
 	"devDependencies": {
@@ -84,6 +84,9 @@
 		"platform_editor_ai_local_id_short": {
 			"type": "boolean"
 		},
+		"platform_editor_ai_aifc_avoid_initial_localId": {
+			"type": "boolean"
+		},
 		"platform_editor_localid_improvements": {
 			"type": "boolean"
 		}