@atlaskit/editor-plugin-local-id 12.0.3 → 12.0.4

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # @atlaskit/editor-plugin-local-id
 
+## 12.0.4
+
+### Patch Changes
+
+- [`dc25bddeafe4d`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/dc25bddeafe4d) -
+  Clean up experiment `platform_editor_ai_tablecell_localids`
+- Updated dependencies
+
 ## 12.0.3
 
 ### Patch Changes

package/dist/cjs/pm-plugins/main.js

@@ -96,10 +96,8 @@ var createPlugin = exports.createPlugin = function createPlugin(api) {
       var addedNodes = new Set();
       // A single PMNode reference can appear at multiple positions in the doc (e.g.
       // `createTable` from `prosemirror-utils` reuses cell node objects across
-      // non-header rows), so the new code path tracks every position per node identity.
-      // The legacy path retains the single-position-per-node map for compatibility.
+      // non-header rows), so we track every position per node identity.
       var positionsByNode = new Map();
-      var addedNodePos = new Map();
       var localIds = new Set();
       var nodesToUpdate = new Map(); // position -> localId
 
@@ -150,7 +148,7 @@ var createPlugin = exports.createPlugin = function createPlugin(api) {
           step.getMap().forEach(function (oldStart, oldEnd, newStart, newEnd) {
             // Scan the changed range to find all nodes
             tr.doc.nodesBetween(newStart, Math.min(newEnd, tr.doc.content.size), function (node, pos) {
-              var _node$type$spec$attrs2;
+              var _node$type$spec$attrs2, _positionsByNode$get;
               if (ignoredNodeTypes.includes(node.type.name) || !((_node$type$spec$attrs2 = node.type.spec.attrs) !== null && _node$type$spec$attrs2 !== void 0 && _node$type$spec$attrs2.localId)) {
                 return true;
               }
@@ -158,14 +156,9 @@ var createPlugin = exports.createPlugin = function createPlugin(api) {
 
               // Always add to addedNodes for duplicate prevention
               addedNodes.add(node);
-              if ((0, _expValEquals.expValEquals)('platform_editor_ai_tablecell_localids', 'isEnabled', true)) {
-                var _positionsByNode$get;
-                var positions = (_positionsByNode$get = positionsByNode.get(node)) !== null && _positionsByNode$get !== void 0 ? _positionsByNode$get : new Set();
-                positions.add(pos);
-                positionsByNode.set(node, positions);
-              } else {
-                addedNodePos.set(node, pos);
-              }
+              var positions = (_positionsByNode$get = positionsByNode.get(node)) !== null && _positionsByNode$get !== void 0 ? _positionsByNode$get : new Set();
+              positions.add(pos);
+              positionsByNode.set(node, positions);
               return true;
             });
           });
@@ -187,91 +180,65 @@ var createPlugin = exports.createPlugin = function createPlugin(api) {
         hasInitializedExistingUUIDs = true;
         // Also ensure the added have no duplicates
         var seenIds = new Set();
-        if ((0, _expValEquals.expValEquals)('platform_editor_ai_tablecell_localids', 'isEnabled', true)) {
-          var _iterator = _createForOfIteratorHelper(addedNodes),
-            _step;
-          try {
-            for (_iterator.s(); !(_step = _iterator.n()).done;) {
-              var node = _step.value;
-              var positions = positionsByNode.get(node);
-              if (!positions || positions.size === 0) {
-                continue;
-              }
-              var existingId = node.attrs.localId;
-              var needsNewIds = !existingId || localIds.has(existingId) || seenIds.has(existingId);
-              if (needsNewIds) {
-                // No usable localId: assign a fresh unique one to every position.
-                var _iterator2 = _createForOfIteratorHelper(positions),
-                  _step2;
-                try {
-                  for (_iterator2.s(); !(_step2 = _iterator2.n()).done;) {
-                    var pos = _step2.value;
-                    var newId = generateUUID();
-                    nodesToUpdate.set(pos, newId);
-                    seenIds.add(newId);
-                    modified = true;
-                  }
-                } catch (err) {
-                  _iterator2.e(err);
-                } finally {
-                  _iterator2.f();
-                }
-              } else if (positions.size > 1) {
-                // Shared node reference: keep the existing id at the first position,
-                // assign fresh ones to the rest so they don't share the same localId.
-                seenIds.add(existingId);
-                var _Array$from = Array.from(positions),
-                  _Array$from2 = (0, _toArray2.default)(_Array$from),
-                  _first = _Array$from2[0],
-                  rest = _arrayLikeToArray(_Array$from2).slice(1);
-                var _iterator3 = _createForOfIteratorHelper(rest),
-                  _step3;
-                try {
-                  for (_iterator3.s(); !(_step3 = _iterator3.n()).done;) {
-                    var _pos = _step3.value;
-                    var _newId = generateUUID();
-                    nodesToUpdate.set(_pos, _newId);
-                    seenIds.add(_newId);
-                    modified = true;
-                  }
-                } catch (err) {
-                  _iterator3.e(err);
-                } finally {
-                  _iterator3.f();
-                }
-              } else if (existingId) {
-                seenIds.add(existingId);
-              }
+        var _iterator = _createForOfIteratorHelper(addedNodes),
+          _step;
+        try {
+          for (_iterator.s(); !(_step = _iterator.n()).done;) {
+            var node = _step.value;
+            var positions = positionsByNode.get(node);
+            if (!positions || positions.size === 0) {
+              continue;
             }
-          } catch (err) {
-            _iterator.e(err);
-          } finally {
-            _iterator.f();
-          }
-        } else {
-          var _iterator4 = _createForOfIteratorHelper(addedNodes),
-            _step4;
-          try {
-            for (_iterator4.s(); !(_step4 = _iterator4.n()).done;) {
-              var _node = _step4.value;
-              if (!_node.attrs.localId || localIds.has(_node.attrs.localId) || seenIds.has(_node.attrs.localId)) {
-                var _pos2 = addedNodePos.get(_node);
-                if (_pos2 !== undefined) {
-                  var _newId2 = generateUUID();
-                  nodesToUpdate.set(_pos2, _newId2);
-                  seenIds.add(_newId2);
+            var existingId = node.attrs.localId;
+            var needsNewIds = !existingId || localIds.has(existingId) || seenIds.has(existingId);
+            if (needsNewIds) {
+              // No usable localId: assign a fresh unique one to every position.
+              var _iterator2 = _createForOfIteratorHelper(positions),
+                _step2;
+              try {
+                for (_iterator2.s(); !(_step2 = _iterator2.n()).done;) {
+                  var pos = _step2.value;
+                  var newId = generateUUID();
+                  nodesToUpdate.set(pos, newId);
+                  seenIds.add(newId);
                   modified = true;
                 }
+              } catch (err) {
+                _iterator2.e(err);
+              } finally {
+                _iterator2.f();
               }
-              if (_node.attrs.localId) {
-                seenIds.add(_node.attrs.localId);
+            } else if (positions.size > 1) {
+              // Shared node reference: keep the existing id at the first position,
+              // assign fresh ones to the rest so they don't share the same localId.
+              seenIds.add(existingId);
+              var _Array$from = Array.from(positions),
+                _Array$from2 = (0, _toArray2.default)(_Array$from),
+                _first = _Array$from2[0],
+                rest = _arrayLikeToArray(_Array$from2).slice(1);
+              var _iterator3 = _createForOfIteratorHelper(rest),
+                _step3;
+              try {
+                for (_iterator3.s(); !(_step3 = _iterator3.n()).done;) {
+                  var _pos = _step3.value;
+                  var _newId = generateUUID();
+                  nodesToUpdate.set(_pos, _newId);
+                  seenIds.add(_newId);
+                  modified = true;
+                }
+              } catch (err) {
+                _iterator3.e(err);
+              } finally {
+                _iterator3.f();
               }
+            } else if (existingId) {
+              seenIds.add(existingId);
             }
-          } catch (err) {
-            _iterator4.e(err);
-          } finally {
-            _iterator4.f();
           }
+        } catch (err) {
+          _iterator.e(err);
+        } finally {
+          _iterator.f();
         }
       }
       // Apply local ID updates based on the improvements feature flag:

package/dist/es2019/pm-plugins/main.js

@@ -86,10 +86,8 @@ export const createPlugin = api => {
       const addedNodes = new Set();
       // A single PMNode reference can appear at multiple positions in the doc (e.g.
       // `createTable` from `prosemirror-utils` reuses cell node objects across
-      // non-header rows), so the new code path tracks every position per node identity.
-      // The legacy path retains the single-position-per-node map for compatibility.
+      // non-header rows), so we track every position per node identity.
       const positionsByNode = new Map();
-      const addedNodePos = new Map();
       const localIds = new Set();
       const nodesToUpdate = new Map(); // position -> localId
 
@@ -138,7 +136,7 @@ export const createPlugin = api => {
           step.getMap().forEach((oldStart, oldEnd, newStart, newEnd) => {
             // Scan the changed range to find all nodes
             tr.doc.nodesBetween(newStart, Math.min(newEnd, tr.doc.content.size), (node, pos) => {
-              var _node$type$spec$attrs2;
+              var _node$type$spec$attrs2, _positionsByNode$get;
               if (ignoredNodeTypes.includes(node.type.name) || !((_node$type$spec$attrs2 = node.type.spec.attrs) !== null && _node$type$spec$attrs2 !== void 0 && _node$type$spec$attrs2.localId)) {
                 return true;
               }
@@ -146,14 +144,9 @@ export const createPlugin = api => {
 
               // Always add to addedNodes for duplicate prevention
               addedNodes.add(node);
-              if (expValEquals('platform_editor_ai_tablecell_localids', 'isEnabled', true)) {
-                var _positionsByNode$get;
-                const positions = (_positionsByNode$get = positionsByNode.get(node)) !== null && _positionsByNode$get !== void 0 ? _positionsByNode$get : new Set();
-                positions.add(pos);
-                positionsByNode.set(node, positions);
-              } else {
-                addedNodePos.set(node, pos);
-              }
+              const positions = (_positionsByNode$get = positionsByNode.get(node)) !== null && _positionsByNode$get !== void 0 ? _positionsByNode$get : new Set();
+              positions.add(pos);
+              positionsByNode.set(node, positions);
               return true;
             });
           });
@@ -175,51 +168,34 @@ export const createPlugin = api => {
         hasInitializedExistingUUIDs = true;
         // Also ensure the added have no duplicates
         const seenIds = new Set();
-        if (expValEquals('platform_editor_ai_tablecell_localids', 'isEnabled', true)) {
-          for (const node of addedNodes) {
-            const positions = positionsByNode.get(node);
-            if (!positions || positions.size === 0) {
-              continue;
-            }
-            const existingId = node.attrs.localId;
-            const needsNewIds = !existingId || localIds.has(existingId) || seenIds.has(existingId);
-            if (needsNewIds) {
-              // No usable localId: assign a fresh unique one to every position.
-              for (const pos of positions) {
-                const newId = generateUUID();
-                nodesToUpdate.set(pos, newId);
-                seenIds.add(newId);
-                modified = true;
-              }
-            } else if (positions.size > 1) {
-              // Shared node reference: keep the existing id at the first position,
-              // assign fresh ones to the rest so they don't share the same localId.
-              seenIds.add(existingId);
-              const [_first, ...rest] = Array.from(positions);
-              for (const pos of rest) {
-                const newId = generateUUID();
-                nodesToUpdate.set(pos, newId);
-                seenIds.add(newId);
-                modified = true;
-              }
-            } else if (existingId) {
-              seenIds.add(existingId);
-            }
+        for (const node of addedNodes) {
+          const positions = positionsByNode.get(node);
+          if (!positions || positions.size === 0) {
+            continue;
           }
-        } else {
-          for (const node of addedNodes) {
-            if (!node.attrs.localId || localIds.has(node.attrs.localId) || seenIds.has(node.attrs.localId)) {
-              const pos = addedNodePos.get(node);
-              if (pos !== undefined) {
-                const newId = generateUUID();
-                nodesToUpdate.set(pos, newId);
-                seenIds.add(newId);
-                modified = true;
-              }
+          const existingId = node.attrs.localId;
+          const needsNewIds = !existingId || localIds.has(existingId) || seenIds.has(existingId);
+          if (needsNewIds) {
+            // No usable localId: assign a fresh unique one to every position.
+            for (const pos of positions) {
+              const newId = generateUUID();
+              nodesToUpdate.set(pos, newId);
+              seenIds.add(newId);
+              modified = true;
             }
-            if (node.attrs.localId) {
-              seenIds.add(node.attrs.localId);
+          } else if (positions.size > 1) {
+            // Shared node reference: keep the existing id at the first position,
+            // assign fresh ones to the rest so they don't share the same localId.
+            seenIds.add(existingId);
+            const [_first, ...rest] = Array.from(positions);
+            for (const pos of rest) {
+              const newId = generateUUID();
+              nodesToUpdate.set(pos, newId);
+              seenIds.add(newId);
+              modified = true;
             }
+          } else if (existingId) {
+            seenIds.add(existingId);
           }
         }
       }

package/dist/esm/pm-plugins/main.js

@@ -89,10 +89,8 @@ export var createPlugin = function createPlugin(api) {
       var addedNodes = new Set();
       // A single PMNode reference can appear at multiple positions in the doc (e.g.
       // `createTable` from `prosemirror-utils` reuses cell node objects across
-      // non-header rows), so the new code path tracks every position per node identity.
-      // The legacy path retains the single-position-per-node map for compatibility.
+      // non-header rows), so we track every position per node identity.
       var positionsByNode = new Map();
-      var addedNodePos = new Map();
       var localIds = new Set();
       var nodesToUpdate = new Map(); // position -> localId
 
@@ -143,7 +141,7 @@ export var createPlugin = function createPlugin(api) {
           step.getMap().forEach(function (oldStart, oldEnd, newStart, newEnd) {
             // Scan the changed range to find all nodes
             tr.doc.nodesBetween(newStart, Math.min(newEnd, tr.doc.content.size), function (node, pos) {
-              var _node$type$spec$attrs2;
+              var _node$type$spec$attrs2, _positionsByNode$get;
               if (ignoredNodeTypes.includes(node.type.name) || !((_node$type$spec$attrs2 = node.type.spec.attrs) !== null && _node$type$spec$attrs2 !== void 0 && _node$type$spec$attrs2.localId)) {
                 return true;
               }
@@ -151,14 +149,9 @@ export var createPlugin = function createPlugin(api) {
 
               // Always add to addedNodes for duplicate prevention
               addedNodes.add(node);
-              if (expValEquals('platform_editor_ai_tablecell_localids', 'isEnabled', true)) {
-                var _positionsByNode$get;
-                var positions = (_positionsByNode$get = positionsByNode.get(node)) !== null && _positionsByNode$get !== void 0 ? _positionsByNode$get : new Set();
-                positions.add(pos);
-                positionsByNode.set(node, positions);
-              } else {
-                addedNodePos.set(node, pos);
-              }
+              var positions = (_positionsByNode$get = positionsByNode.get(node)) !== null && _positionsByNode$get !== void 0 ? _positionsByNode$get : new Set();
+              positions.add(pos);
+              positionsByNode.set(node, positions);
               return true;
             });
           });
@@ -180,91 +173,65 @@ export var createPlugin = function createPlugin(api) {
         hasInitializedExistingUUIDs = true;
         // Also ensure the added have no duplicates
         var seenIds = new Set();
-        if (expValEquals('platform_editor_ai_tablecell_localids', 'isEnabled', true)) {
-          var _iterator = _createForOfIteratorHelper(addedNodes),
-            _step;
-          try {
-            for (_iterator.s(); !(_step = _iterator.n()).done;) {
-              var node = _step.value;
-              var positions = positionsByNode.get(node);
-              if (!positions || positions.size === 0) {
-                continue;
-              }
-              var existingId = node.attrs.localId;
-              var needsNewIds = !existingId || localIds.has(existingId) || seenIds.has(existingId);
-              if (needsNewIds) {
-                // No usable localId: assign a fresh unique one to every position.
-                var _iterator2 = _createForOfIteratorHelper(positions),
-                  _step2;
-                try {
-                  for (_iterator2.s(); !(_step2 = _iterator2.n()).done;) {
-                    var pos = _step2.value;
-                    var newId = generateUUID();
-                    nodesToUpdate.set(pos, newId);
-                    seenIds.add(newId);
-                    modified = true;
-                  }
-                } catch (err) {
-                  _iterator2.e(err);
-                } finally {
-                  _iterator2.f();
-                }
-              } else if (positions.size > 1) {
-                // Shared node reference: keep the existing id at the first position,
-                // assign fresh ones to the rest so they don't share the same localId.
-                seenIds.add(existingId);
-                var _Array$from = Array.from(positions),
-                  _Array$from2 = _toArray(_Array$from),
-                  _first = _Array$from2[0],
-                  rest = _arrayLikeToArray(_Array$from2).slice(1);
-                var _iterator3 = _createForOfIteratorHelper(rest),
-                  _step3;
-                try {
-                  for (_iterator3.s(); !(_step3 = _iterator3.n()).done;) {
-                    var _pos = _step3.value;
-                    var _newId = generateUUID();
-                    nodesToUpdate.set(_pos, _newId);
-                    seenIds.add(_newId);
-                    modified = true;
-                  }
-                } catch (err) {
-                  _iterator3.e(err);
-                } finally {
-                  _iterator3.f();
-                }
-              } else if (existingId) {
-                seenIds.add(existingId);
-              }
+        var _iterator = _createForOfIteratorHelper(addedNodes),
+          _step;
+        try {
+          for (_iterator.s(); !(_step = _iterator.n()).done;) {
+            var node = _step.value;
+            var positions = positionsByNode.get(node);
+            if (!positions || positions.size === 0) {
+              continue;
             }
-          } catch (err) {
-            _iterator.e(err);
-          } finally {
-            _iterator.f();
-          }
-        } else {
-          var _iterator4 = _createForOfIteratorHelper(addedNodes),
-            _step4;
-          try {
-            for (_iterator4.s(); !(_step4 = _iterator4.n()).done;) {
-              var _node = _step4.value;
-              if (!_node.attrs.localId || localIds.has(_node.attrs.localId) || seenIds.has(_node.attrs.localId)) {
-                var _pos2 = addedNodePos.get(_node);
-                if (_pos2 !== undefined) {
-                  var _newId2 = generateUUID();
-                  nodesToUpdate.set(_pos2, _newId2);
-                  seenIds.add(_newId2);
+            var existingId = node.attrs.localId;
+            var needsNewIds = !existingId || localIds.has(existingId) || seenIds.has(existingId);
+            if (needsNewIds) {
+              // No usable localId: assign a fresh unique one to every position.
+              var _iterator2 = _createForOfIteratorHelper(positions),
+                _step2;
+              try {
+                for (_iterator2.s(); !(_step2 = _iterator2.n()).done;) {
+                  var pos = _step2.value;
+                  var newId = generateUUID();
+                  nodesToUpdate.set(pos, newId);
+                  seenIds.add(newId);
                   modified = true;
                 }
+              } catch (err) {
+                _iterator2.e(err);
+              } finally {
+                _iterator2.f();
               }
-              if (_node.attrs.localId) {
-                seenIds.add(_node.attrs.localId);
+            } else if (positions.size > 1) {
+              // Shared node reference: keep the existing id at the first position,
+              // assign fresh ones to the rest so they don't share the same localId.
+              seenIds.add(existingId);
+              var _Array$from = Array.from(positions),
+                _Array$from2 = _toArray(_Array$from),
+                _first = _Array$from2[0],
+                rest = _arrayLikeToArray(_Array$from2).slice(1);
+              var _iterator3 = _createForOfIteratorHelper(rest),
+                _step3;
+              try {
+                for (_iterator3.s(); !(_step3 = _iterator3.n()).done;) {
+                  var _pos = _step3.value;
+                  var _newId = generateUUID();
+                  nodesToUpdate.set(_pos, _newId);
+                  seenIds.add(_newId);
+                  modified = true;
+                }
+              } catch (err) {
+                _iterator3.e(err);
+              } finally {
+                _iterator3.f();
               }
+            } else if (existingId) {
+              seenIds.add(existingId);
             }
-          } catch (err) {
-            _iterator4.e(err);
-          } finally {
-            _iterator4.f();
           }
+        } catch (err) {
+          _iterator.e(err);
+        } finally {
+          _iterator.f();
         }
       }
       // Apply local ID updates based on the improvements feature flag:

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-plugin-local-id",
-	"version": "12.0.3",
+	"version": "12.0.4",
 	"description": "LocalId plugin for @atlaskit/editor-core",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",
@@ -20,18 +20,18 @@
 	"sideEffects": false,
 	"atlaskit:src": "src/index.ts",
 	"dependencies": {
-		"@atlaskit/adf-schema": "^56.6.0",
+		"@atlaskit/adf-schema": "^56.7.0",
 		"@atlaskit/editor-plugin-collab-edit": "^15.0.0",
 		"@atlaskit/editor-plugin-composition": "^13.0.0",
 		"@atlaskit/editor-plugin-limited-mode": "^11.0.0",
 		"@atlaskit/editor-prosemirror": "^8.0.0",
 		"@atlaskit/platform-feature-flags": "^2.1.0",
-		"@atlaskit/tmp-editor-statsig": "^145.0.0",
+		"@atlaskit/tmp-editor-statsig": "^146.0.0",
 		"@babel/runtime": "^7.0.0",
 		"raf-schd": "^4.0.3"
 	},
 	"peerDependencies": {
-		"@atlaskit/editor-common": "^118.2.0",
+		"@atlaskit/editor-common": "^118.4.0",
 		"react": "^18.2.0 || ^19.2.0"
 	},
 	"devDependencies": {