@atlaskit/editor-plugin-list 4.1.2 → 4.1.3

package/CHANGELOG.md

@@ -1,5 +1,14 @@
 # @atlaskit/editor-plugin-list
 
+## 4.1.3
+
+### Patch Changes
+
+- [#124104](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/pull-requests/124104)
+  [`a48ac34f66f25`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/a48ac34f66f25) -
+  [ux] ED-26942 Modified editor-plugin-list backspace keymap handler to prevent it from deleting
+  extensions
+
 ## 4.1.2
 
 ### Patch Changes

package/dist/cjs/pm-plugins/commands/index.js

@@ -16,6 +16,7 @@ var _commands2 = require("@atlaskit/editor-prosemirror/commands");
 var _model = require("@atlaskit/editor-prosemirror/model");
 var _state = require("@atlaskit/editor-prosemirror/state");
 var _utils2 = require("@atlaskit/editor-prosemirror/utils");
+var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _conversions = require("../actions/conversions");
 var _wrapAndJoinLists = require("../actions/wrap-and-join-lists");
 var _transforms = require("../transforms");
@@ -254,10 +255,12 @@ var deletePreviousEmptyListItem = function deletePreviousEmptyListItem(state, di
   if (!$cut || !$cut.nodeBefore || !($cut.nodeBefore.type === listItem)) {
     return false;
   }
+  var nodeBeforeIsExtension =
+  // eslint-disable-next-line @atlaskit/platform/no-preconditioning
+  (0, _platformFeatureFlags.fg)('platform_editor_nbm_backspace_fixes') && $cut.nodeBefore.firstChild && $cut.nodeBefore.firstChild.type.name === 'extension';
   var previousListItemEmpty =
   // Ignored via go/ees005
-  // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
-  $cut.nodeBefore.childCount === 1 && $cut.nodeBefore.firstChild.nodeSize <= 2;
+  $cut.nodeBefore.childCount === 1 && $cut.nodeBefore.firstChild && $cut.nodeBefore.firstChild.nodeSize <= 2 && !nodeBeforeIsExtension;
   if (previousListItemEmpty) {
     var tr = state.tr;
     if (dispatch) {

package/dist/es2019/pm-plugins/commands/index.js

@@ -8,6 +8,7 @@ import { chainCommands } from '@atlaskit/editor-prosemirror/commands';
 import { Fragment, Slice } from '@atlaskit/editor-prosemirror/model';
 import { NodeSelection, TextSelection } from '@atlaskit/editor-prosemirror/state';
 import { findPositionOfNodeBefore, hasParentNodeOfType } from '@atlaskit/editor-prosemirror/utils';
+import { fg } from '@atlaskit/platform-feature-flags';
 import { convertListType } from '../actions/conversions';
 import { wrapInListAndJoin } from '../actions/wrap-and-join-lists';
 import { liftFollowingList, liftNodeSelectionList, liftTextSelectionList } from '../transforms';
@@ -241,10 +242,12 @@ const deletePreviousEmptyListItem = (state, dispatch) => {
   if (!$cut || !$cut.nodeBefore || !($cut.nodeBefore.type === listItem)) {
     return false;
   }
+  const nodeBeforeIsExtension =
+  // eslint-disable-next-line @atlaskit/platform/no-preconditioning
+  fg('platform_editor_nbm_backspace_fixes') && $cut.nodeBefore.firstChild && $cut.nodeBefore.firstChild.type.name === 'extension';
   const previousListItemEmpty =
   // Ignored via go/ees005
-  // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
-  $cut.nodeBefore.childCount === 1 && $cut.nodeBefore.firstChild.nodeSize <= 2;
+  $cut.nodeBefore.childCount === 1 && $cut.nodeBefore.firstChild && $cut.nodeBefore.firstChild.nodeSize <= 2 && !nodeBeforeIsExtension;
   if (previousListItemEmpty) {
     const {
       tr

package/dist/esm/pm-plugins/commands/index.js

@@ -11,6 +11,7 @@ import { chainCommands } from '@atlaskit/editor-prosemirror/commands';
 import { Fragment, Slice } from '@atlaskit/editor-prosemirror/model';
 import { NodeSelection, TextSelection } from '@atlaskit/editor-prosemirror/state';
 import { findPositionOfNodeBefore, hasParentNodeOfType } from '@atlaskit/editor-prosemirror/utils';
+import { fg } from '@atlaskit/platform-feature-flags';
 import { convertListType } from '../actions/conversions';
 import { wrapInListAndJoin } from '../actions/wrap-and-join-lists';
 import { liftFollowingList, liftNodeSelectionList, liftTextSelectionList } from '../transforms';
@@ -247,10 +248,12 @@ var deletePreviousEmptyListItem = function deletePreviousEmptyListItem(state, di
   if (!$cut || !$cut.nodeBefore || !($cut.nodeBefore.type === listItem)) {
     return false;
   }
+  var nodeBeforeIsExtension =
+  // eslint-disable-next-line @atlaskit/platform/no-preconditioning
+  fg('platform_editor_nbm_backspace_fixes') && $cut.nodeBefore.firstChild && $cut.nodeBefore.firstChild.type.name === 'extension';
   var previousListItemEmpty =
   // Ignored via go/ees005
-  // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
-  $cut.nodeBefore.childCount === 1 && $cut.nodeBefore.firstChild.nodeSize <= 2;
+  $cut.nodeBefore.childCount === 1 && $cut.nodeBefore.firstChild && $cut.nodeBefore.firstChild.nodeSize <= 2 && !nodeBeforeIsExtension;
   if (previousListItemEmpty) {
     var tr = state.tr;
     if (dispatch) {

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-plugin-list",
-	"version": "4.1.2",
+	"version": "4.1.3",
 	"description": "List plugin for @atlaskit/editor-core",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",
@@ -32,10 +32,11 @@
 	},
 	"dependencies": {
 		"@atlaskit/adf-schema": "^47.6.0",
-		"@atlaskit/editor-common": "^102.0.0",
+		"@atlaskit/editor-common": "^102.1.0",
 		"@atlaskit/editor-plugin-analytics": "^2.1.0",
 		"@atlaskit/editor-plugin-feature-flags": "^1.3.0",
 		"@atlaskit/editor-prosemirror": "7.0.0",
+		"@atlaskit/platform-feature-flags": "^1.1.0",
 		"@atlaskit/prosemirror-input-rules": "^3.3.0",
 		"@atlaskit/tmp-editor-statsig": "^3.4.0",
 		"@babel/runtime": "^7.0.0"
@@ -82,6 +83,11 @@
 			]
 		}
 	},
+	"platform-feature-flags": {
+		"platform_editor_nbm_backspace_fixes": {
+			"type": "boolean"
+		}
+	},
 	"stricter": {
 		"no-unused-dependencies": {
 			"checkDevDependencies": true